chorus-codes 0.8.40 → 0.8.42

package/.next/trace-build

@@ -1 +1 @@
-[{"name":"run-webpack","duration":10616055,"timestamp":7591428153347,"id":14,"parentId":1,"tags":{},"startTime":1778982798579,"traceId":"f9ba0ee77fc34f5f"},{"name":"run-typescript","duration":5913143,"timestamp":7591438772500,"id":2118,"parentId":1,"tags":{},"startTime":1778982809199,"traceId":"f9ba0ee77fc34f5f"},{"name":"static-check","duration":423410,"timestamp":7591444733460,"id":2121,"parentId":1,"tags":{},"startTime":1778982815159,"traceId":"f9ba0ee77fc34f5f"},{"name":"static-generation","duration":1168776,"timestamp":7591445596866,"id":2161,"parentId":1,"tags":{},"startTime":1778982816023,"traceId":"f9ba0ee77fc34f5f"},{"name":"collect-build-traces","duration":6134038,"timestamp":7591445157333,"id":2158,"parentId":1,"tags":{},"startTime":1778982815583,"traceId":"f9ba0ee77fc34f5f"},{"name":"telemetry-flush","duration":33,"timestamp":7591451293114,"id":2170,"parentId":1,"tags":{},"startTime":1778982821719,"traceId":"f9ba0ee77fc34f5f"},{"name":"next-build","duration":23227142,"timestamp":7591428066015,"id":1,"tags":{"buildMode":"default","version":"16.2.4","bundler":"webpack","has-custom-webpack-config":"false","use-build-worker":"true"},"startTime":1778982798492,"traceId":"f9ba0ee77fc34f5f"}]
+[{"name":"run-webpack","duration":10400394,"timestamp":7785070234903,"id":14,"parentId":1,"tags":{},"startTime":1779176440661,"traceId":"96c0634f7218b45d"},{"name":"run-typescript","duration":5817929,"timestamp":7785080638605,"id":2118,"parentId":1,"tags":{},"startTime":1779176451065,"traceId":"96c0634f7218b45d"},{"name":"static-check","duration":399936,"timestamp":7785086503435,"id":2121,"parentId":1,"tags":{},"startTime":1779176456929,"traceId":"96c0634f7218b45d"},{"name":"static-generation","duration":1292404,"timestamp":7785087076198,"id":2161,"parentId":1,"tags":{},"startTime":1779176457502,"traceId":"96c0634f7218b45d"},{"name":"collect-build-traces","duration":6348634,"timestamp":7785086903776,"id":2158,"parentId":1,"tags":{},"startTime":1779176457330,"traceId":"96c0634f7218b45d"},{"name":"telemetry-flush","duration":30,"timestamp":7785093254055,"id":2170,"parentId":1,"tags":{},"startTime":1779176463680,"traceId":"96c0634f7218b45d"},{"name":"next-build","duration":23101152,"timestamp":7785070152943,"id":1,"tags":{"buildMode":"default","version":"16.2.4","bundler":"webpack","has-custom-webpack-config":"false","use-build-worker":"true"},"startTime":1779176440579,"traceId":"96c0634f7218b45d"}]

package/dist/daemon/runner/verdict.js

@@ -25,21 +25,46 @@ function verdictFromReviewerText(content) {
     // `do not approve` / `cannot approve`. Both spellings are common in real
     // reviews. The optional `['’]?t` segment catches both straight (') and
     // typographic (’) apostrophes — LLMs emit the latter often.
-    const negatives = /\b(request changes|requesting changes|disagree|reject(?:ed|ing)?|blocker|(?:do not|don['’]?t) (?:approve|merge)|(?:cannot|can['’]?t) (?:approve|merge)|nack)\b/;
+    //
+    // Issue #52 expansions (the original list missed real-world rejections
+    // that happened to end with a polite "I'd approve once …" kicker):
+    //   - request(?:s|ed|ing)? changes   — covers requests/requested/requesting
+    //   - not (?:approved|ready|merging|ok|acceptable|good to (?:merge|ship))
+    //   - approve (?:after|once|when|conditional(?:ly)?|if|provided|assuming)
+    //   - conditional(?:ly)? approve
+    //     — both forms reframe conditional approvals as negative, since
+    //       the reviewer is explicitly NOT approving the current diff.
+    //   - would(?:\s+not|n['’]?t) approve
+    //
+    // Round-1 self-review (3 convergent dissenters) flagged candidate
+    // patterns `changes (?:are )?(?:needed|required|requested)` and
+    // `needs (?:work|changes|fixes)` as too ambiguous — both match in
+    // clean-approval contexts like "no changes needed, LGTM" or "the
+    // changes requested by the reviewer are fine". They're dropped from
+    // the negatives list; the remaining patterns still catch all three
+    // concrete leak cases in brianmarr's report (case 2a is caught by
+    // `approve after`, case 2 family by `not ready`).
+    const negatives = /\b(request(?:s|ed|ing)? changes|not (?:approved|ready|merging|ok|acceptable|good to (?:merge|ship))|approve (?:after|once|when|conditional(?:ly)?|if|provided|assuming)|conditional(?:ly)? approve|would(?:\s+not|n['’]?t) approve|disagree|reject(?:ed|ing)?|blocker|(?:do not|don['’]?t) (?:approve|merge)|(?:cannot|can['’]?t) (?:approve|merge)|nack)\b/;
     const positives = /\b(approve(?:d|s)?|lgtm|looks good to me|no concerns|ship it|ack)\b/;
-    // Check verdict keywords FIRST — a terse but explicit reply like
-    // "approve ## DONE" (15 chars after sentinel strip) is unambiguous and
-    // shouldn't be filtered out by the length floor. Tail wins over whole
-    // so an analytical review mentioning "good practice" mid-paragraph
-    // doesn't get auto-approved without an explicit verdict at the end.
+    const whole = stripped.toLowerCase();
     const tail = stripped.slice(-400).toLowerCase();
-    if (negatives.test(tail))
+    // Negatives win globally. Issue #52: previously the function returned
+    // TRUE when the tail contained a positive token even if the body of
+    // the answer carried an explicit rejection. Real reviewers routinely
+    // write "Request changes. … [substantive critique] … Happy to approve
+    // once these are addressed." — that's a rejection, not an approval.
+    // Scan the entire stripped answer for negatives first; only fall
+    // through to positives once we've confirmed there's no rejection
+    // anywhere in the text.
+    if (negatives.test(whole))
         return false;
+    // Positives prefer the tail so an analytical review mentioning
+    // "good practice" mid-paragraph doesn't get auto-approved without an
+    // explicit verdict at the end. Whole-text fallback catches the case
+    // where the verdict lives mid-body and the tail is padded with
+    // closing matter (test: "falls back to whole-text scan").
     if (positives.test(tail))
         return true;
-    const whole = stripped.toLowerCase();
-    if (negatives.test(whole))
-        return false;
     if (positives.test(whole))
         return true;
     // No verdict keyword anywhere — return null (ambiguous). The 20-char

package/dist/daemon/runner/verdict.js.map

@@ -1 +1 @@
-{"version":3,"file":"verdict.js","sourceRoot":"","sources":["../../../src/daemon/runner/verdict.ts"],"names":[],"mappings":";;AAiBA,0DA+BC;AAhDD;;;;;;;;;;;;;;;;GAgBG;AACH,SAAgB,uBAAuB,CAAC,OAAe;IACrD,MAAM,QAAQ,GAAG,OAAO,CAAC,OAAO,CAAC,gBAAgB,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;IAE9D,oEAAoE;IACpE,yEAAyE;IACzE,yEAAyE;IACzE,uEAAuE;IACvE,4DAA4D;IAC5D,MAAM,SAAS,GACb,gKAAgK,CAAC;IACnK,MAAM,SAAS,GACb,qEAAqE,CAAC;IAExE,iEAAiE;IACjE,uEAAuE;IACvE,sEAAsE;IACtE,mEAAmE;IACnE,oEAAoE;IACpE,MAAM,IAAI,GAAG,QAAQ,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,CAAC,WAAW,EAAE,CAAC;IAChD,IAAI,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,KAAK,CAAC;IACvC,IAAI,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAC;IAEtC,MAAM,KAAK,GAAG,QAAQ,CAAC,WAAW,EAAE,CAAC;IACrC,IAAI,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IACxC,IAAI,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IAEvC,qEAAqE;IACrE,qEAAqE;IACrE,uEAAuE;IACvE,wDAAwD;IACxD,OAAO,IAAI,CAAC;AACd,CAAC"}
+{"version":3,"file":"verdict.js","sourceRoot":"","sources":["../../../src/daemon/runner/verdict.ts"],"names":[],"mappings":";;AAiBA,0DA0DC;AA3ED;;;;;;;;;;;;;;;;GAgBG;AACH,SAAgB,uBAAuB,CAAC,OAAe;IACrD,MAAM,QAAQ,GAAG,OAAO,CAAC,OAAO,CAAC,gBAAgB,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;IAE9D,oEAAoE;IACpE,yEAAyE;IACzE,yEAAyE;IACzE,uEAAuE;IACvE,4DAA4D;IAC5D,EAAE;IACF,uEAAuE;IACvE,mEAAmE;IACnE,4EAA4E;IAC5E,0EAA0E;IAC1E,0EAA0E;IAC1E,iCAAiC;IACjC,oEAAoE;IACpE,mEAAmE;IACnE,sCAAsC;IACtC,EAAE;IACF,kEAAkE;IAClE,gEAAgE;IAChE,kEAAkE;IAClE,iEAAiE;IACjE,oEAAoE;IACpE,mEAAmE;IACnE,kEAAkE;IAClE,kDAAkD;IAClD,MAAM,SAAS,GACb,6VAA6V,CAAC;IAChW,MAAM,SAAS,GACb,qEAAqE,CAAC;IAExE,MAAM,KAAK,GAAG,QAAQ,CAAC,WAAW,EAAE,CAAC;IACrC,MAAM,IAAI,GAAG,QAAQ,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,CAAC,WAAW,EAAE,CAAC;IAEhD,sEAAsE;IACtE,oEAAoE;IACpE,qEAAqE;IACrE,sEAAsE;IACtE,oEAAoE;IACpE,iEAAiE;IACjE,iEAAiE;IACjE,wBAAwB;IACxB,IAAI,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IAExC,+DAA+D;IAC/D,qEAAqE;IACrE,oEAAoE;IACpE,+DAA+D;IAC/D,0DAA0D;IAC1D,IAAI,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAC;IACtC,IAAI,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IAEvC,qEAAqE;IACrE,qEAAqE;IACrE,uEAAuE;IACvE,wDAAwD;IACxD,OAAO,IAAI,CAAC;AACd,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "chorus-codes",
-  "version": "0.8.40",
+  "version": "0.8.42",
   "description": "Driver-agnostic multi-LLM peer review for code decisions. Bring your own CLI; Chorus convenes 2-4 other LLMs to review the work before you ship.",
   "license": "Apache-2.0",
   "author": "99x Agency",