chorus-codes 0.8.25 → 0.8.27

package/dist/daemon/runner/fallback-registry.js

@@ -0,0 +1,110 @@
+"use strict";
+/**
+ * Per-chat/round in-flight (lineage, model) registry — prevents two
+ * reviewer slots from independently picking the SAME template fallback
+ * target when their primaries fail in parallel.
+ *
+ * Why this exists:
+ *   `buildSlotFallbackChain` dedups at chain-construction time against
+ *   every active slot's PRIMARY model, but the template-level fallback
+ *   list is shared across all slots. Two slots both compute the same
+ *   tail (e.g. `anthropic/claude-sonnet-4-6`) and, when both primaries
+ *   fail simultaneously, both dispatch to it in parallel — wasted cost,
+ *   broken lineage diversity (the whole point of multi-LLM peer review).
+ *   Real example 2026-05-08: a gemini slot AND an opencode/kimi slot
+ *   both fell back to claude-sonnet-4-6 on the same run.
+ *
+ * Semantics:
+ *   - `tryClaim(chatId, round, lineage, model)` — true on first claim,
+ *     false if another slot in the same chat/round is already running
+ *     this exact (lineage, model). Idempotent guard, never throws.
+ *   - `release(...)` — called by the same slot when its attempt
+ *     finishes (success, null, throw — all paths). Other slots can now
+ *     claim. Idempotent.
+ *   - `resetRound(chatId, round)` — drops all claims for a chat/round.
+ *     Called from runner on phase_done so a multi-round chat starts
+ *     each round with a clean registry.
+ *
+ * Why per-round, not per-chat:
+ *   Round 2 reviewers are a fresh fan-out; their fallback targets
+ *   should be claimable independently of round 1's already-completed
+ *   reviewers. Round-scoped also means the registry self-clears on
+ *   normal chat termination — no leak risk in long-running daemons.
+ *
+ * Why this is module-level state, not per-runner:
+ *   The runner instantiates a fresh closure per chat, but the registry
+ *   needs to outlive a single attempt() call across all slots in the
+ *   same phase. Module state with chat-scoped keys is the smallest
+ *   surface that gives the right reach. Same daemon-wide pattern as
+ *   `cli-semaphore.ts`.
+ *
+ * Testing seam:
+ *   `_testing.reset()` clears all state between vitest cases. Without
+ *   this, claims from a prior test leak across the whole worker and
+ *   later cases see false from `tryClaim` for unrelated targets.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports._testing = void 0;
+exports.tryClaim = tryClaim;
+exports.release = release;
+exports.resetRound = resetRound;
+exports.snapshot = snapshot;
+const inFlight = new Map();
+function roundKey(chatId, round) {
+    return `${chatId}:${round}`;
+}
+function entryKey(lineage, model) {
+    // `(default)` is the canonical placeholder when a slot has no
+    // declared model — buildSlotFallbackChain emits one such entry per
+    // models-less slot. Two slots both falling through to the lineage
+    // default would still collide; this key lets us catch that.
+    return `${lineage}:${model ?? '(default)'}`;
+}
+function tryClaim(chatId, round, lineage, model) {
+    const k = roundKey(chatId, round);
+    let set = inFlight.get(k);
+    if (!set) {
+        set = new Set();
+        inFlight.set(k, set);
+    }
+    const tag = entryKey(lineage, model);
+    if (set.has(tag))
+        return false;
+    set.add(tag);
+    return true;
+}
+function release(chatId, round, lineage, model) {
+    const k = roundKey(chatId, round);
+    const set = inFlight.get(k);
+    if (!set)
+        return;
+    set.delete(entryKey(lineage, model));
+    // Opportunistically drop the empty-Set parent entry so a long-running
+    // daemon processing thousands of chats doesn't accumulate one entry
+    // per terminated round. Cheap (one Map.delete per fully-released
+    // round); without this, ~50 bytes leak per chat × N chats over the
+    // process lifetime. Caught on chorus self-review of this PR.
+    if (set.size === 0)
+        inFlight.delete(k);
+}
+function resetRound(chatId, round) {
+    inFlight.delete(roundKey(chatId, round));
+}
+/**
+ * Diagnostic snapshot — currently in-flight tags grouped by chat/round.
+ * Useful when debugging "why did slot B skip this entry?" — pair with
+ * the [reviewer] daemon log line.
+ */
+function snapshot() {
+    const out = {};
+    for (const [k, set] of inFlight.entries()) {
+        out[k] = [...set];
+    }
+    return out;
+}
+exports._testing = {
+    reset: () => {
+        inFlight.clear();
+    },
+};
+//# sourceMappingURL=fallback-registry.js.map

package/dist/daemon/runner/fallback-registry.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"fallback-registry.js","sourceRoot":"","sources":["../../../src/daemon/runner/fallback-registry.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA2CG;;;AAgBH,4BAgBC;AAED,0BAgBC;AAED,gCAEC;AAOD,4BAMC;AAjED,MAAM,QAAQ,GAA6B,IAAI,GAAG,EAAE,CAAC;AAErD,SAAS,QAAQ,CAAC,MAAc,EAAE,KAAa;IAC7C,OAAO,GAAG,MAAM,IAAI,KAAK,EAAE,CAAC;AAC9B,CAAC;AAED,SAAS,QAAQ,CAAC,OAAe,EAAE,KAAyB;IAC1D,8DAA8D;IAC9D,mEAAmE;IACnE,kEAAkE;IAClE,4DAA4D;IAC5D,OAAO,GAAG,OAAO,IAAI,KAAK,IAAI,WAAW,EAAE,CAAC;AAC9C,CAAC;AAED,SAAgB,QAAQ,CACtB,MAAc,EACd,KAAa,EACb,OAAe,EACf,KAAyB;IAEzB,MAAM,CAAC,GAAG,QAAQ,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC;IAClC,IAAI,GAAG,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;IAC1B,IAAI,CAAC,GAAG,EAAE,CAAC;QACT,GAAG,GAAG,IAAI,GAAG,EAAE,CAAC;QAChB,QAAQ,CAAC,GAAG,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;IACvB,CAAC;IACD,MAAM,GAAG,GAAG,QAAQ,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;IACrC,IAAI,GAAG,CAAC,GAAG,CAAC,GAAG,CAAC;QAAE,OAAO,KAAK,CAAC;IAC/B,GAAG,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;IACb,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAgB,OAAO,CACrB,MAAc,EACd,KAAa,EACb,OAAe,EACf,KAAyB;IAEzB,MAAM,CAAC,GAAG,QAAQ,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC;IAClC,MAAM,GAAG,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;IAC5B,IAAI,CAAC,GAAG;QAAE,OAAO;IACjB,GAAG,CAAC,MAAM,CAAC,QAAQ,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC;IACrC,sEAAsE;IACtE,oEAAoE;IACpE,iEAAiE;IACjE,mEAAmE;IACnE,6DAA6D;IAC7D,IAAI,GAAG,CAAC,IAAI,KAAK,CAAC;QAAE,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;AACzC,CAAC;AAED,SAAgB,UAAU,CAAC,MAAc,EAAE,KAAa;IACtD,QAAQ,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC,CAAC;AAC3C,CAAC;AAED;;;;GAIG;AACH,SAAgB,QAAQ;IACtB,MAAM,GAAG,GAA6B,EAAE,CAAC;IACzC,KAAK,MAAM,CAAC,CAAC,EAAE,GAAG,CAAC,IAAI,QAAQ,CAAC,OAAO,EAAE,EAAE,CAAC;QAC1C,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,GAAG,GAAG,CAAC,CAAC;IACpB,CAAC;IACD,OAAO,GAAG,CAAC;AACb,CAAC;AAEY,QAAA,QAAQ,GAAG;IACtB,KAAK,EAAE,GAAS,EAAE;QAChB,QAAQ,CAAC,KAAK,EAAE,CAAC;IACnB,CAAC;CACF,CAAC"}