chia-agent 13.2.0 → 14.0.0-beta.0

package/config/index.js

@@ -43,7 +43,7 @@ function getConfig(configFilePath) {
 exports.getConfig = getConfig;
 function buildConfigObj(config, currentPath = [], product = {}) {
     for (const propName in config) {
-        if (!config.hasOwnProperty(propName)) {
+        if (!Object.prototype.hasOwnProperty.call(config, propName)) {
             continue;
         }
         const value = config[propName];

package/daemon/index.js

@@ -119,7 +119,6 @@ class Daemon {
                     reject("Not connected");
                     return;
                 }
-                let timer = null;
                 const message = this.createMessageTemplate(command, destination, data || {});
                 const reqId = message.request_id;
                 this._responseQueue[reqId] = resolve;
@@ -262,7 +261,7 @@ class Daemon {
         }
         this._messageEventListeners.forEach(l => l(event));
         for (const o in this._messageListeners) {
-            if (!this._messageListeners.hasOwnProperty(o)) {
+            if (!Object.prototype.hasOwnProperty.call(this._messageListeners, o)) {
                 continue;
             }
             const listeners = this._messageListeners[o];
@@ -283,7 +282,7 @@ class Daemon {
         this._subscriptions = [];
         this._closeEventListeners.forEach(l => l(event));
         this.clearAllEventListeners();
-        logger_1.getLogger().info(`Closed ws connection`);
+        logger_1.getLogger().info("Closed ws connection");
         if (this._onClosePromise) {
             this._onClosePromise();
             this._onClosePromise = undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "chia-agent",
-  "version": "13.2.0",
+  "version": "14.0.0-beta.0",
   "author": "ChiaMineJP <admin@chiamine.jp>",
   "description": "chia rpc/websocket client library",
   "license": "MIT",

package/rpc/index.d.ts

@@ -32,10 +32,6 @@ export declare type TRPCAgentProps = {
     configPath?: string;
     skip_hostname_verification?: boolean;
 };
-export declare type ErrorResponse = {
-    error: string;
-    success: false;
-};
 export declare class RPCAgent {
     protected _protocol: "http" | "https";
     protected _hostname: string;
@@ -52,7 +48,7 @@ export declare class RPCAgent {
         clientKey: Buffer;
         caCert: Buffer;
     };
-    sendMessage<M extends unknown>(destination: string, command: string, data?: Record<string, unknown>): Promise<M | ErrorResponse>;
+    sendMessage<M extends unknown>(destination: string, command: string, data?: Record<string, unknown>): Promise<M>;
     request<R>(method: string, path: string, data?: any): Promise<R>;
 }
 export declare type TRPCAgent = InstanceType<typeof RPCAgent>;

package/rpc/index.js

@@ -198,7 +198,7 @@ class RPCAgent {
                         }
                         p += "?";
                         for (const key in data) {
-                            if (data.hasOwnProperty(key)) {
+                            if (Object.prototype.hasOwnProperty.call(data, key)) {
                                 p += `${key}=${data[key]}`;
                             }
                         }
@@ -228,7 +228,21 @@ class RPCAgent {
                     res.on("end", () => {
                         try {
                             if (chunks.length > 0) {
-                                const d = JSONbig.parse(Buffer.concat(chunks).toString());
+                                const entireChunks = Buffer.concat(chunks);
+                                const serializedData = entireChunks.toString();
+                                const d = JSONbig.parse(serializedData);
+                                if (typeof d !== "object" || !d) {
+                                    logger_1.getLogger().error(`Response is expected to be an object but received: ${serializedData}`);
+                                    return reject(new Error(`Unexpected response format: ${serializedData}`));
+                                }
+                                else if (!Object.prototype.hasOwnProperty.call(d, "success")) {
+                                    logger_1.getLogger().error("Response has no 'success' property");
+                                    return reject(new Error(`Response has no 'success' property: ${serializedData}`));
+                                }
+                                if (!d.success) {
+                                    logger_1.getLogger().error(`API failure: ${d.error}`);
+                                    return reject(d);
+                                }
                                 return resolve(d);
                             }
                             // RPC Server should return response like