chati-dev 4.3.1 → 4.4.0

package/src/orchestrator/session-manager.js

@@ -6,11 +6,24 @@
  */
 
 import yaml from 'js-yaml';
-import { existsSync, readFileSync, writeFileSync, mkdirSync } from 'fs';
+import { existsSync, readFileSync, writeFileSync, renameSync, mkdirSync } from 'fs';
 import { join, dirname } from 'path';
 
 const SESSION_FILE = '.chati/session.yaml';
 
+/**
+ * Atomic write helper. Writes `content` to a sibling `.tmp` file and then
+ * renames it into place. If the process is killed mid-write the original
+ * remains intact. Same-FS rename on POSIX is atomic; on Windows it's
+ * best-effort. Mirrors the pattern used by `chati.dev/hooks/prism-engine.js`
+ * `writeBackSession` to keep both hook and CLI write paths consistent.
+ */
+function writeFileAtomic(path, content, encoding = 'utf-8') {
+  const tmp = `${path}.tmp`;
+  writeFileSync(tmp, content, encoding);
+  renameSync(tmp, path);
+}
+
 /**
  * Default session template.
  */
@@ -26,6 +39,12 @@ const DEFAULT_SESSION = {
   started_at: null,
   current_agent: '',
   pipeline_position: 0,
+  // execution_mode is a string enum ('interactive' | 'autonomous') per
+  // session.schema.json. Article XVIII deprecation (2026-04-18) collapsed
+  // the old 4-value execution_profile enum into this binary form. Per-
+  // transition metadata (setAt, reason) lives in mode_transitions[] below,
+  // not on this field. mode-manager.js was historically reading it as an
+  // object — that path was normalized to read the string in 2026-05.
   execution_mode: 'interactive',
   user_level: 'auto',
   user_level_confidence: 0.0,
@@ -135,7 +154,7 @@ export function initSession(projectDir, options = {}) {
       noRefs: true,
     });
 
-    writeFileSync(sessionPath, yamlContent, 'utf-8');
+    writeFileAtomic(sessionPath, yamlContent);
 
     return {
       created: true,
@@ -216,6 +235,14 @@ export function migrateSession(session) {
     };
   }
 
+  // Defensive seed: ensure execution_mode is always present after migration.
+  // An unrecognized execution_profile (e.g. a hand-edited 'custom') or no
+  // profile at all used to leave the field absent, so validateSession could
+  // not catch it and every subsequent load re-migrated the same session. The
+  // profile mapping below can still promote this to 'autonomous'. Guarded so
+  // an existing 'autonomous' value is preserved.
+  if (!session.execution_mode) session.execution_mode = 'interactive';
+
   // Article XVIII deprecation (2026-04-18): collapse execution_profile into
   // execution_mode per the migration table. Runs LAST so it overrides any
   // default seeded above. See constitution Article XVIII for rationale.
@@ -232,6 +259,20 @@ export function migrateSession(session) {
     delete session.profile_transitions;
   }
 
+  // execution_mode normalization (2026-05): the schema declares this field
+  // as a string enum ('interactive' | 'autonomous'), and all CLI/dashboard/
+  // hook consumers treat it as a string. Earlier `setExecutionMode` writes
+  // accidentally produced an object shape `{ mode, setAt, reason }` that
+  // only `mode-manager.js#getCurrentMode` understood. Sessions that ran
+  // through that path stored the object form; flatten them back to a string
+  // here so subsequent reads from cli.js / dashboard / templates work.
+  // Per-transition metadata lives in mode_transitions[] (already present).
+  if (session.execution_mode && typeof session.execution_mode === 'object' && !Array.isArray(session.execution_mode)) {
+    const inner = session.execution_mode.mode;
+    const map = { 'human-in-the-loop': 'interactive', interactive: 'interactive', autonomous: 'autonomous' };
+    session.execution_mode = map[inner] || 'interactive';
+  }
+
   return { migrated: true, fromVersion, toVersion: CURRENT_SCHEMA_VERSION };
 }
 
@@ -260,9 +301,16 @@ export function loadSession(projectDir) {
     if (migration.migrated) {
       try {
         const yamlContent = yaml.dump(session, { lineWidth: -1, noRefs: true });
-        writeFileSync(sessionPath, yamlContent, 'utf-8');
-      } catch { /* expected: operation may fail gracefully */
-        // Migration write failed — continue with migrated in-memory session
+        writeFileAtomic(sessionPath, yamlContent);
+      } catch (writeErr) {
+        // Migration write-back failed (read-only filesystem, EACCES). The
+        // session continues with the migrated in-memory copy, but disk stays
+        // on the old schema and re-migrates on every load. Surface it so the
+        // user can fix the cause (make .chati/ writable) instead of it failing
+        // silently. The production path (writable FS) never reaches here.
+        process.stderr.write(
+          `[chati] warning: session migrated in memory but could not be written back to ${sessionPath} (${writeErr.code || writeErr.message}); it will re-migrate on every load until the directory is writable\n`
+        );
       }
     }
 
@@ -329,7 +377,7 @@ export function updateSession(projectDir, updates) {
       noRefs: true,
     });
 
-    writeFileSync(sessionPath, yamlContent, 'utf-8');
+    writeFileAtomic(sessionPath, yamlContent);
 
     return {
       saved: true,
@@ -392,7 +440,7 @@ function writeSessionToDisk(projectDir, session) {
   const sessionPath = join(projectDir, SESSION_FILE);
   try {
     const yamlContent = yaml.dump(session, { lineWidth: -1, noRefs: true });
-    writeFileSync(sessionPath, yamlContent, 'utf-8');
+    writeFileAtomic(sessionPath, yamlContent);
     return { saved: true, session };
   } catch (err) {
     return { saved: false, error: `Failed to write session: ${err.message}` };
@@ -875,7 +923,7 @@ export function validateSession(projectDir) {
   const session = loadResult.session;
 
   // Validate required fields
-  const requiredFields = ['schema_version', 'version', 'mode', 'language', 'project_type', 'agents'];
+  const requiredFields = ['schema_version', 'version', 'mode', 'execution_mode', 'language', 'project_type', 'agents'];
   for (const field of requiredFields) {
     if (!session[field]) {
       return {

package/src/telemetry/sender.js

@@ -5,30 +5,19 @@
  * Fire-and-forget: never blocks the user workflow, fails silently.
  */
 
-import { existsSync, readFileSync } from 'fs';
-import { join } from 'path';
-import { homedir } from 'os';
-
 // ---------------------------------------------------------------------------
 // Default Endpoint
 // ---------------------------------------------------------------------------
 
 export const DEFAULT_ENDPOINT = 'https://chati.dev/api/telemetry';
 
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-function readGlobalLicenseKey() {
-  try {
-    const p = join(homedir(), '.chati-dev', 'license.yaml');
-    if (!existsSync(p)) return null;
-    const content = readFileSync(p, 'utf-8');
-    const match = content.match(/^key:\s*(.+)$/m);
-    const key = match?.[1]?.trim();
-    return key && key !== 'null' ? key : null;
-  } catch { return null; }
-}
+// Note: the prior implementation read the local license key from
+// `~/.chati-dev/license.yaml` and shipped it inside every telemetry POST as
+// `license_key`. That sent a paying user's credential to the analytics
+// endpoint on every install/pipeline event — outside the per-event PII
+// scrubber. Removed (2026-05). Server-side attribution should be derived
+// from the validated license session correlated to `anonymousId`, never from
+// the raw key over the wire.
 
 // ---------------------------------------------------------------------------
 // Sender
@@ -50,7 +39,6 @@ export async function sendEvents(events, config) {
 
   const payload = {
     anonymousId: config.anonymousId,
-    license_key: readGlobalLicenseKey(),
     project_name: config.projectName ?? null,
     chatiVersion: config.version || 'unknown',
     nodeVersion: process.version,

package/src/terminal/run-team.js

@@ -21,7 +21,7 @@ import { fileURLToPath } from 'url';
 import { existsSync, readFileSync } from 'fs';
 import { join } from 'path';
 import { buildAgentPrompt } from './prompt-builder.js';
-import { spawnParallelGroup, spawnTerminal } from './spawner.js';
+import { spawnParallelGroup } from './spawner.js';
 import { TerminalMonitor } from './monitor.js';
 import { collectResults, mergeHandoffs, buildConsolidatedHandoff } from './collector.js';
 import { parseAgentOutput } from './handoff-parser.js';
@@ -107,7 +107,7 @@ async function main() {
   const taskListPath = join(teamDir, 'tasks.yaml');
 
   // Load session state (minimal parse)
-  let sessionState = {};
+  const sessionState = {};
   try {
     const sessionPath = join(projectDir, '.chati', 'session.yaml');
     if (existsSync(sessionPath)) {
@@ -166,7 +166,7 @@ async function main() {
 
   // Spawn team members
   let group;
-  let fallbackUsed = false;
+  const fallbackUsed = false;
   const echoEvents = [];
 
   try {

package/src/upgrade/tracked-files-detector.js

@@ -41,6 +41,11 @@ function isGitRepo(targetDir) {
  * Detect which framework-owned paths are currently tracked by git.
  * Does NOT modify git state — read-only operation.
  *
+ * Runs a single `git ls-files -z -- <pattern1> <pattern2> …` invocation and
+ * partitions the result locally. The prior implementation spawned one
+ * `git ls-files` per pattern (19 processes per call) which added several
+ * hundred ms of overhead on a slow disk during every upgrade check.
+ *
  * @param {string} targetDir - absolute path to the project root
  * @returns {string[]} array of tracked framework file paths (relative to targetDir)
  */
@@ -49,28 +54,41 @@ export function detectTrackedFrameworkFiles(targetDir) {
     return [];
   }
 
-  const tracked = [];
+  let stdout;
+  try {
+    // -z: NUL-separated output (safe for paths with spaces/newlines).
+    // Pass all patterns as positional args after `--` so they're treated as
+    // pathspecs, not options. Quoting is handled by execFile-style argv if
+    // available; we use execSync with a builtin pattern array escape.
+    const args = FRAMEWORK_PATTERNS.map(p => JSON.stringify(p)).join(' ');
+    stdout = execSync(`git ls-files -z -- ${args}`, {
+      cwd: targetDir,
+      stdio: ['ignore', 'pipe', 'ignore'],
+      timeout: 5000,
+    }).toString();
+  } catch {
+    // git ls-files failed entirely (not a repo, repo corrupt, etc.) → none tracked
+    return [];
+  }
 
-  for (const pattern of FRAMEWORK_PATTERNS) {
-    try {
-      const result = execSync(`git ls-files -- "${pattern}"`, {
-        cwd: targetDir,
-        stdio: ['ignore', 'pipe', 'ignore'],
-        timeout: 5000,
-      })
-        .toString()
-        .trim();
+  if (!stdout) return [];
 
-      if (result.length > 0) {
-        tracked.push(pattern);
+  // Split on NUL. For each tracked path returned by git, find which of our
+  // FRAMEWORK_PATTERNS it belongs under (directory prefixes use trailing
+  // slash; exact-file patterns match equality).
+  const trackedPaths = stdout.split('\0').filter(Boolean);
+  const tracked = new Set();
+  for (const path of trackedPaths) {
+    for (const pattern of FRAMEWORK_PATTERNS) {
+      if (pattern.endsWith('/')) {
+        if (path.startsWith(pattern)) { tracked.add(pattern); break; }
+      } else if (path === pattern) {
+        tracked.add(pattern); break;
       }
-    } catch {
-      // git ls-files failure means path is not tracked — skip
     }
   }
 
-  // Deduplicate in case patterns overlap
-  return [...new Set(tracked)];
+  return [...tracked];
 }
 
 /**

package/src/utils/feature-flags.js

@@ -22,13 +22,13 @@ const DEFAULTS = {
   rate_limiter_integration: false,
   l5_keywords: false,
   prompt_size_guard: false,
-  ids_decision_engine: false,
   surface_criteria: false,
   parallel_fallback: false,
   tool_mesh: false,
   tech_presets: false,
   doctor_autofix: false,
   brandbook: false,
+  execution_kinds: false,
 };
 
 /**

package/src/utils/flatten-entities.js

@@ -1,46 +1,10 @@
 /**
- * @fileoverview Shared entity-flattening utilities.
+ * @fileoverview Shared entity-flattening utility.
  *
- * Two variants exist because the registry YAML stores entities in two different
- * shapes depending on who reads it:
- *
- * - flattenEntitiesFromRegistry: receives the full registry object
- *   (i.e. the result of yaml.load()), where each category's value is an Array.
- *   Used by decision/analyzer.js and decision/engine.js.
- *
- * - flattenEntitiesMap: receives only the `registry.entities` map,
- *   where each category's value is a nested object keyed by entity name.
- *   Used by intelligence/registry-manager.js.
- *
- * Keep both functions here so there is a single canonical implementation.
- */
-
-/**
- * Flatten a full entity registry (as returned by yaml.load) into a flat array.
- *
- * Each category value must be an Array of entity objects.
- * The `type` field is inferred from the category key.
- *
- * @param {object} registry - Full registry object with a top-level `entities` key.
- * @returns {object[]} Flat array of entity objects, each with a `type` field added.
+ * flattenEntitiesMap receives the `registry.entities` map, where each category's
+ * value is a nested object keyed by entity name. Used by
+ * intelligence/registry-manager.js.
  */
-export function flattenEntitiesFromRegistry(registry) {
-  const entities = [];
-
-  if (!registry || !registry.entities) {
-    return entities;
-  }
-
-  Object.entries(registry.entities).forEach(([type, typeEntities]) => {
-    if (Array.isArray(typeEntities)) {
-      typeEntities.forEach(entity => {
-        entities.push({ ...entity, type });
-      });
-    }
-  });
-
-  return entities;
-}
 
 /**
  * Flatten the `entities` section of the registry (a nested object map) into a flat array.

package/src/utils/schema-validator.js

@@ -177,20 +177,6 @@ export const SESSION_SCHEMA = {
   },
 };
 
-/**
- * Build state schema (build-state.json).
- */
-export const BUILD_STATE_SCHEMA = {
-  required: ['sessionId', 'status', 'checkpoints'],
-  properties: {
-    sessionId: { type: 'string', required: true },
-    status: { type: 'string', required: true, enum: ['idle', 'running', 'completed', 'failed', 'abandoned'] },
-    checkpoints: { type: 'array', required: true },
-    startedAt: { type: 'string' },
-    totalAttempts: { type: 'number', min: 0 },
-  },
-};
-
 /**
  * Config schema (config.yaml).
  */

package/src/wizard/i18n.js

@@ -39,7 +39,7 @@ const FALLBACK_EN = {
     agents_count: 'Specialized agent definitions across DISCOVER, PLAN, BUILD, DEPLOY phases',
     workflows_count: '6 workflow blueprints',
     templates_count: '6 templates (PRD, Brownfield PRD, Architecture, Task, QA Gate, Quick Brief)',
-    constitution: 'Constitution (23 Articles + Preamble)',
+    constitution: 'Constitution (25 Articles + Preamble)',
     session_mgmt: 'Session management system',
     quality_gates: 'Quality gates (3-tier verdicts)',
     proceed: 'Proceed with installation?',
@@ -47,7 +47,7 @@ const FALLBACK_EN = {
     created_chati: 'Created .chati/ session directory',
     created_framework: 'Created chati.dev/ system directory (agents, templates, workflows)',
     created_commands: 'Created .claude/commands/ (thin router)',
-    installed_constitution: 'Installed Constitution (Articles I-XXIII)',
+    installed_constitution: 'Installed Constitution (Articles I-XXV)',
     created_session: 'Created session.yaml schema',
     created_claude_md: 'Created CLAUDE.md',
     configured_mcps: 'Configured MCPs:',
@@ -55,7 +55,7 @@ const FALLBACK_EN = {
     agents_valid: 'All agents implement 8 protocols',
     handoff_ok: 'Handoff protocol: OK',
     validation_ok: 'Self-validation criteria: OK',
-    constitution_ok: 'Constitution: 23 articles verified',
+    constitution_ok: 'Constitution: 25 articles verified',
     created_memories: 'Created .chati/memories/ (Memory Layer)',
     installed_intelligence: 'Installed Intelligence Layer (Context Engine, Memory, Registry)',
     intelligence_valid: 'Intelligence: 6 spec files verified',

package/src/api/index.js

@@ -1,120 +0,0 @@
-/**
- * @fileoverview Public API surface for chati-dev.
- *
- * Re-exports stable functions from core modules, providing
- * a clean entry point for programmatic usage.
- *
- * @example
- * import { createSession, runHealthChecks, classifyIntent } from 'chati-dev/api';
- */
-
-// ---------------------------------------------------------------------------
-// Health & Diagnostics
-// ---------------------------------------------------------------------------
-
-export { runHealthChecks } from '../health/engine.js';
-
-// ---------------------------------------------------------------------------
-// Context Engine (PRISM)
-// ---------------------------------------------------------------------------
-
-export { runPrism } from '../context/engine.js';
-
-// ---------------------------------------------------------------------------
-// Orchestrator
-// ---------------------------------------------------------------------------
-
-export { classifyIntent, INTENT_TYPES } from '../orchestrator/intent-classifier.js';
-export {
-  initPipeline,
-  advancePipeline,
-  initQuickFlowPipeline,
-  initStandardFlowPipeline,
-} from '../orchestrator/pipeline-manager.js';
-export { selectAgent } from '../orchestrator/agent-selector.js';
-
-// ---------------------------------------------------------------------------
-// Session Management
-// ---------------------------------------------------------------------------
-
-import { initSession as _initSession } from '../orchestrator/session-manager.js';
-
-export {
-  initSession,
-  loadSession,
-  updateSession,
-  validateSession,
-  getSessionSummary,
-  claimSession,
-  releaseSession,
-  getSessionOwner,
-} from '../orchestrator/session-manager.js';
-
-// ---------------------------------------------------------------------------
-// Autonomy
-// ---------------------------------------------------------------------------
-
-export { runBuildLoop } from '../autonomy/build-loop.js';
-export { checkSafety, SAFETY_TRIGGERS } from '../autonomy/safety-net.js';
-
-// ---------------------------------------------------------------------------
-// Memory
-// ---------------------------------------------------------------------------
-
-export { recordError, getGotchas } from '../memory/gotchas.js';
-
-// ---------------------------------------------------------------------------
-// Quality
-// ---------------------------------------------------------------------------
-
-export { getMetricsHistory, getQualityDashboard, recordMetric } from '../quality/metrics-collector.js';
-
-// ---------------------------------------------------------------------------
-// Extensions
-// ---------------------------------------------------------------------------
-
-export {
-  registerExtension,
-  getExtensions,
-  executeExtensions,
-  clearExtensions,
-  EXTENSION_POINTS,
-} from '../extensions/registry.js';
-export { loadProjectExtensions, validateExtension } from '../extensions/loader.js';
-
-// ---------------------------------------------------------------------------
-// Configuration
-// ---------------------------------------------------------------------------
-
-export { loadCustomization, applyCustomization, validateCustomization } from '../config/agent-customizer.js';
-export { IDE_CONFIGS, getIDEChoices } from '../config/ide-configs.js';
-
-// ---------------------------------------------------------------------------
-// Convenience Wrapper
-// ---------------------------------------------------------------------------
-
-/**
- * Create and initialize a new chati.dev session.
- *
- * Convenience wrapper that initializes session state.
- *
- * @param {string} projectDir - Project root directory
- * @param {object} [options]
- * @param {string} [options.mode='discover'] - Initial pipeline mode
- * @param {boolean} [options.isGreenfield=true] - Project type
- * @param {string} [options.language='en'] - Interaction language
- * @param {string} [options.projectName=''] - Project name
- * @param {string[]} [options.ides=[]] - Selected IDEs
- * @param {string[]} [options.mcps=[]] - Selected MCPs
- * @returns {{ created: boolean, session: object, path: string }}
- */
-export function createSession(projectDir, options = {}) {
-  return _initSession(projectDir, {
-    mode: options.mode || 'discover',
-    isGreenfield: options.isGreenfield !== false,
-    language: options.language || 'en',
-    projectName: options.projectName || '',
-    ides: options.ides || [],
-    mcps: options.mcps || [],
-  });
-}