chati-dev 4.2.2 → 4.3.0

package/scripts/validate-package.js

@@ -1,505 +0,0 @@
-#!/usr/bin/env node
-
-/**
- * Package Completeness Validator
- *
- * Validates that the npm package has all required files before publishing.
- * Run as part of prepublishOnly (after bundle, before sign-manifest).
- *
- * Exports:
- *   validatePackage(packageRoot) → { errors, warnings, checks, passed }
- */
-
-import { existsSync, readFileSync, readdirSync } from 'fs';
-import { join, dirname } from 'path';
-import { fileURLToPath } from 'url';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-
-/**
- * Expected directories in framework/ (must match bundle-framework.js)
- */
-const EXPECTED_BUNDLE_DIRS = [
-  'orchestrator',
-  'agents/discover', 'agents/plan', 'agents/quality', 'agents/build', 'agents/deploy',
-  'templates', 'workflows', 'quality-gates',
-  'schemas', 'frameworks', 'intelligence', 'patterns',
-  'hooks', 'domains',
-  'i18n', 'migrations', 'data',
-  'tasks', 'context',
-];
-
-const EXPECTED_ROOT_FILES = ['constitution.md', 'config.yaml'];
-
-const SENSITIVE_FILES = ['.signing-key.pem', '.env', '.env.local', '.env.production'];
-
-/**
- * Validate that framework/ directory exists.
- */
-function checkFrameworkExists(packageRoot, results) {
-  results.checks++;
-  const frameworkDir = join(packageRoot, 'framework');
-  if (existsSync(frameworkDir)) {
-    results.passed++;
-  } else {
-    results.errors.push('framework/ directory not found. Run `npm run bundle` first.');
-  }
-}
-
-/**
- * Validate all expected bundle directories exist.
- */
-function checkBundledDirs(packageRoot, results) {
-  results.checks++;
-  const frameworkDir = join(packageRoot, 'framework');
-  if (!existsSync(frameworkDir)) return;
-
-  const missing = [];
-  for (const dir of EXPECTED_BUNDLE_DIRS) {
-    if (!existsSync(join(frameworkDir, dir))) {
-      missing.push(dir);
-    }
-  }
-
-  if (missing.length === 0) {
-    results.passed++;
-  } else {
-    results.errors.push(`Missing framework directories: ${missing.join(', ')}`);
-  }
-}
-
-/**
- * Validate root framework files exist.
- */
-function checkRootFiles(packageRoot, results) {
-  results.checks++;
-  const frameworkDir = join(packageRoot, 'framework');
-  if (!existsSync(frameworkDir)) return;
-
-  const missing = [];
-  for (const file of EXPECTED_ROOT_FILES) {
-    if (!existsSync(join(frameworkDir, file))) {
-      missing.push(file);
-    }
-  }
-
-  if (missing.length === 0) {
-    results.passed++;
-  } else {
-    results.errors.push(`Missing framework root files: ${missing.join(', ')}`);
-  }
-}
-
-/**
- * Check that no sensitive files leaked into the bundle.
- */
-function checkNoSensitiveFiles(packageRoot, results) {
-  results.checks++;
-  const found = [];
-
-  // Only check inside publishable directories (bin/, src/, assets/, framework/, scripts/)
-  // Root-level files like .signing-key.pem are excluded by package.json "files" field
-  const publishableDirs = ['framework', 'src', 'scripts', 'bin', 'assets'];
-  for (const file of SENSITIVE_FILES) {
-    for (const dir of publishableDirs) {
-      if (existsSync(join(packageRoot, dir, file))) {
-        found.push(`${dir}/${file}`);
-      }
-    }
-  }
-
-  if (found.length === 0) {
-    results.passed++;
-  } else {
-    results.errors.push(`Sensitive files found in package: ${found.join(', ')}`);
-  }
-}
-
-/**
- * Validate that all package.json exports resolve to existing files.
- */
-function checkExportsResolve(packageRoot, results) {
-  results.checks++;
-  const pkgPath = join(packageRoot, 'package.json');
-  if (!existsSync(pkgPath)) return;
-
-  const pkg = JSON.parse(readFileSync(pkgPath, 'utf-8'));
-  const exports = pkg.exports || {};
-  const missing = [];
-
-  for (const [key, value] of Object.entries(exports)) {
-    const filePath = join(packageRoot, value);
-    if (!existsSync(filePath)) {
-      missing.push(`${key} → ${value}`);
-    }
-  }
-
-  if (missing.length === 0) {
-    results.passed++;
-  } else {
-    results.errors.push(`Unresolved exports: ${missing.join(', ')}`);
-  }
-}
-
-/**
- * Validate that bin entry exists.
- */
-function checkBinExists(packageRoot, results) {
-  results.checks++;
-  const pkgPath = join(packageRoot, 'package.json');
-  if (!existsSync(pkgPath)) return;
-
-  const pkg = JSON.parse(readFileSync(pkgPath, 'utf-8'));
-  const bin = pkg.bin || {};
-  const missing = [];
-
-  for (const [name, path] of Object.entries(bin)) {
-    if (!existsSync(join(packageRoot, path))) {
-      missing.push(`${name} → ${path}`);
-    }
-  }
-
-  if (missing.length === 0) {
-    results.passed++;
-  } else {
-    results.errors.push(`Missing bin entries: ${missing.join(', ')}`);
-  }
-}
-
-/**
- * Validate that every hook referenced in hooks/settings.json exists on disk.
- * Prevents shipping a bundle where settings.json references a hook file that
- * was never copied.
- */
-function checkHooksParity(packageRoot, results) {
-  results.checks++;
-  const settingsPath = join(packageRoot, 'framework', 'hooks', 'settings.json');
-  if (!existsSync(settingsPath)) {
-    results.warnings.push('framework/hooks/settings.json not found — skipping hooks parity check.');
-    results.passed++;
-    return;
-  }
-
-  try {
-    const settings = JSON.parse(readFileSync(settingsPath, 'utf-8'));
-    const missing = new Set();
-    const hooksDir = join(packageRoot, 'framework', 'hooks');
-
-    // Walk all hook events and collect referenced .js files
-    for (const event of Object.keys(settings.hooks || {})) {
-      for (const matcher of settings.hooks[event] || []) {
-        for (const hook of matcher.hooks || []) {
-          if (hook.type === 'command' && typeof hook.command === 'string') {
-            // command format: "node chati.dev/hooks/foo.js"
-            const match = hook.command.match(/hooks\/([^\s]+\.js)/);
-            if (match) {
-              const hookFile = match[1];
-              if (!existsSync(join(hooksDir, hookFile))) {
-                missing.add(hookFile);
-              }
-            }
-          }
-        }
-      }
-    }
-
-    if (missing.size === 0) {
-      results.passed++;
-    } else {
-      results.errors.push(`Hooks referenced in settings.json but missing from framework/hooks/: ${[...missing].join(', ')}`);
-    }
-  } catch (err) {
-    results.errors.push(`Failed to parse hooks/settings.json: ${err.message}`);
-  }
-}
-
-/**
- * Parity check: every file in source chati.dev/ (that belongs to a copied
- * directory) must exist in framework/. Catches bundling bugs where new files
- * are added to the source but not included in the bundle.
- *
- * Only runs when the monorepo source is available (skipped inside the
- * published package since the source is not shipped).
- */
-function checkSourceBundleParity(packageRoot, results) {
-  results.checks++;
-  const monorepoSource = join(packageRoot, '..', '..', 'chati.dev');
-  const bundleDir = join(packageRoot, 'framework');
-
-  if (!existsSync(monorepoSource)) {
-    // Running inside the published package — skip (nothing to compare against)
-    results.passed++;
-    return;
-  }
-
-  // Collect all files in source, grouped by the top-level directory
-  const missing = [];
-  const COPIED_DIRS = [
-    'orchestrator', 'agents', 'templates', 'workflows', 'quality-gates',
-    'schemas', 'frameworks', 'intelligence', 'patterns', 'hooks',
-    'domains', 'i18n', 'migrations', 'data', 'context', 'tasks', 'presets',
-  ];
-  const COPIED_ROOT_FILES = ['constitution.md'];
-
-  function walk(srcDir, relBase) {
-    if (!existsSync(srcDir)) return;
-    for (const entry of readdirSync(srcDir, { withFileTypes: true })) {
-      const srcPath = join(srcDir, entry.name);
-      const relPath = relBase ? `${relBase}/${entry.name}` : entry.name;
-      if (entry.isDirectory()) {
-        walk(srcPath, relPath);
-      } else if (entry.isFile()) {
-        const bundlePath = join(bundleDir, relPath);
-        if (!existsSync(bundlePath)) missing.push(relPath);
-      }
-    }
-  }
-
-  for (const file of COPIED_ROOT_FILES) {
-    const src = join(monorepoSource, file);
-    const bundled = join(bundleDir, file);
-    if (existsSync(src) && !existsSync(bundled)) missing.push(file);
-  }
-
-  for (const dir of COPIED_DIRS) {
-    walk(join(monorepoSource, dir), dir);
-  }
-
-  if (missing.length === 0) {
-    results.passed++;
-  } else {
-    const sample = missing.slice(0, 10).join(', ');
-    const more = missing.length > 10 ? ` (+ ${missing.length - 10} more)` : '';
-    results.errors.push(`Files in source chati.dev/ missing from framework/ bundle: ${sample}${more}`);
-  }
-}
-
-/**
- * Compare entity count in registry vs actual files in framework/.
- */
-function checkEntityCount(packageRoot, results) {
-  results.checks++;
-  const registryPath = join(packageRoot, 'framework', 'data', 'entity-registry.yaml');
-  if (!existsSync(registryPath)) {
-    results.warnings.push('Entity registry not found in framework/data/ — skipping count check.');
-    results.passed++;
-    return;
-  }
-
-  // Count files in framework/ recursively (excluding manifest.json, manifest.sig)
-  let fileCount = 0;
-  function countFiles(dir) {
-    try {
-      for (const entry of readdirSync(dir, { withFileTypes: true })) {
-        if (entry.isDirectory()) {
-          countFiles(join(dir, entry.name));
-        } else if (entry.name !== 'manifest.json' && entry.name !== 'manifest.sig') {
-          fileCount++;
-        }
-      }
-    } catch { /* skip unreadable dirs */ }
-  }
-
-  countFiles(join(packageRoot, 'framework'));
-
-  if (fileCount > 0) {
-    results.passed++;
-  } else {
-    results.errors.push('Framework directory is empty (0 files).');
-  }
-}
-
-/**
- * v4.2.2: Validate that generateClaudeSettings() produces a settings.json
- * that wires all 10 chati hooks via the canonical hookSpecificOutput schema
- * — at the right events and with paths that resolve to existing files.
- *
- * This catches the v4.2.0/v4.2.1 catastrophe (hooks dormant because the
- * installer never wrote .claude/settings.json) at validation time.
- */
-async function checkClaudeHooksWired(packageRoot, results) {
-  results.checks++;
-  try {
-    const genPath = join(packageRoot, 'src', 'config', 'claude-settings-generator.js');
-    if (!existsSync(genPath)) {
-      results.errors.push('claude-settings-generator.js missing — Claude hooks would not be wired in installs.');
-      return;
-    }
-
-    const mod = await import(genPath);
-    if (typeof mod.generateClaudeSettings !== 'function') {
-      results.errors.push('claude-settings-generator.js does not export generateClaudeSettings.');
-      return;
-    }
-
-    const settings = JSON.parse(mod.generateClaudeSettings());
-
-    // Verify required events
-    const requiredEvents = ['UserPromptSubmit', 'PreToolUse', 'PreCompact'];
-    const missingEvents = requiredEvents.filter(e => !settings.hooks?.[e]);
-    if (missingEvents.length > 0) {
-      results.errors.push(`generateClaudeSettings missing events: ${missingEvents.join(', ')}`);
-      return;
-    }
-
-    // Collect all referenced hook commands
-    const allCommands = [];
-    for (const event of Object.values(settings.hooks)) {
-      for (const group of event) {
-        for (const hook of group.hooks || []) {
-          allCommands.push(hook.command || '');
-        }
-      }
-    }
-
-    // Verify all 10 chati hooks are referenced
-    const requiredHooks = [
-      'license-guard', 'prism-engine', 'model-governance',
-      'read-protection', 'constitution-guard', 'mode-governance',
-      'style-guard', 'undercover-guard', 'team-quality-gate', 'session-digest',
-    ];
-    const missingHooks = requiredHooks.filter(h => !allCommands.some(c => c.includes(h)));
-    if (missingHooks.length > 0) {
-      results.errors.push(`generateClaudeSettings missing hook references: ${missingHooks.join(', ')}`);
-      return;
-    }
-
-    // Verify each referenced hook file exists in framework/hooks/
-    const hooksDir = join(packageRoot, 'framework', 'hooks');
-    if (existsSync(hooksDir)) {
-      const missingFiles = [];
-      for (const cmd of allCommands) {
-        const match = cmd.match(/hooks\/([^\s]+\.js)/);
-        if (match && !existsSync(join(hooksDir, match[1]))) {
-          missingFiles.push(match[1]);
-        }
-      }
-      if (missingFiles.length > 0) {
-        results.errors.push(`Claude settings reference hook files missing from bundle: ${missingFiles.join(', ')}`);
-        return;
-      }
-    }
-
-    results.passed++;
-  } catch (err) {
-    results.errors.push(`checkClaudeHooksWired failed: ${err.message}`);
-  }
-}
-
-/**
- * v4.2.2: Verify license-guard is wired for ALL three providers.
- * Without this, an expired trial keeps working forever — exactly the bug
- * the user flagged in v4.2.1 (they could see chati.dev with no license check).
- */
-async function checkLicenseEntryPointAcrossProviders(packageRoot, results) {
-  results.checks++;
-  try {
-    const missing = [];
-
-    // Claude — settings.json must include license-guard in UserPromptSubmit
-    const genPath = join(packageRoot, 'src', 'config', 'claude-settings-generator.js');
-    if (existsSync(genPath)) {
-      const mod = await import(genPath);
-      const settings = JSON.parse(mod.generateClaudeSettings());
-      const ups = settings.hooks?.UserPromptSubmit || [];
-      const claudeCmds = ups.flatMap(g => (g.hooks || []).map(h => h.command || ''));
-      if (!claudeCmds.some(c => c.includes('license-guard'))) {
-        missing.push('Claude (UserPromptSubmit)');
-      }
-    } else {
-      missing.push('Claude (generator file missing)');
-    }
-
-    // Gemini — HOOK_MAP must include license-guard at BeforeModel
-    const geminiPath = join(packageRoot, 'src', 'config', 'gemini-hooks-generator.js');
-    if (existsSync(geminiPath)) {
-      const mod = await import(geminiPath);
-      if (!mod.HOOK_MAP?.['license-guard'] || mod.HOOK_MAP['license-guard'].event !== 'BeforeModel') {
-        missing.push('Gemini (HOOK_MAP missing license-guard at BeforeModel)');
-      }
-    } else {
-      missing.push('Gemini (generator file missing)');
-    }
-
-    // Codex — installer/core.js must write .codex/hooks.json with license-guard
-    const corePath = join(packageRoot, 'src', 'installer', 'core.js');
-    if (existsSync(corePath)) {
-      const coreContent = readFileSync(corePath, 'utf-8');
-      if (!coreContent.includes('.codex/hooks.json') || !coreContent.includes("license-guard")) {
-        missing.push('Codex (.codex/hooks.json not wired with license-guard in core.js)');
-      }
-    } else {
-      missing.push('Codex (core.js missing)');
-    }
-
-    if (missing.length > 0) {
-      results.errors.push(`License enforcement gaps: ${missing.join('; ')}`);
-      return;
-    }
-
-    results.passed++;
-  } catch (err) {
-    results.errors.push(`checkLicenseEntryPointAcrossProviders failed: ${err.message}`);
-  }
-}
-
-/**
- * Validate the npm package completeness.
- * @param {string} packageRoot - Root of the package (packages/chati-dev/)
- * @returns {Promise<{ errors: string[], warnings: string[], checks: number, passed: number }>}
- */
-export async function validatePackage(packageRoot) {
-  const results = { errors: [], warnings: [], checks: 0, passed: 0 };
-
-  checkFrameworkExists(packageRoot, results);
-  checkBundledDirs(packageRoot, results);
-  checkRootFiles(packageRoot, results);
-  checkNoSensitiveFiles(packageRoot, results);
-  checkExportsResolve(packageRoot, results);
-  checkBinExists(packageRoot, results);
-  checkEntityCount(packageRoot, results);
-  checkHooksParity(packageRoot, results);
-  checkSourceBundleParity(packageRoot, results);
-  await checkClaudeHooksWired(packageRoot, results);
-  await checkLicenseEntryPointAcrossProviders(packageRoot, results);
-
-  return results;
-}
-
-/**
- * Format results for CLI output.
- */
-function formatResults(results) {
-  const status = results.errors.length === 0 ? 'PASS' : 'FAIL';
-  const lines = [
-    `Package Validation: ${status} (${results.passed}/${results.checks} checks passed)`,
-  ];
-
-  if (results.errors.length > 0) {
-    lines.push('');
-    lines.push('Errors:');
-    results.errors.forEach(e => lines.push(`  ✗ ${e}`));
-  }
-
-  if (results.warnings.length > 0) {
-    lines.push('');
-    lines.push('Warnings:');
-    results.warnings.forEach(w => lines.push(`  ⚠ ${w}`));
-  }
-
-  return lines.join('\n');
-}
-
-// CLI entry point
-if (process.argv[1] === fileURLToPath(import.meta.url)) {
-  const packageRoot = join(__dirname, '..');
-  validatePackage(packageRoot).then(results => {
-    console.log(formatResults(results));
-    if (results.errors.length > 0) {
-      process.exit(1);
-    }
-  }).catch(err => {
-    console.error('validate-package failed:', err);
-    process.exit(1);
-  });
-}