chatccc 0.2.232 → 0.2.233

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "chatccc",
-  "version": "0.2.232",
+  "version": "0.2.233",
   "description": "Feishu bot bridge for Claude Code",
   "license": "Apache-2.0",
   "type": "module",

package/src/__tests__/crash-logging.test.ts

@@ -1,9 +1,15 @@
 import { mkdtemp, readFile, rm } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
+import { EventEmitter } from "node:events";
 import { describe, it, expect, vi } from "vitest";
 
-import { buildCrashLoggingHandlers, installCrashLogging, setupFileLogging } from "../shared.ts";
+import {
+  buildCrashLoggingHandlers,
+  installCrashLogging,
+  installEpipeGuard,
+  setupFileLogging,
+} from "../shared.ts";
 
 describe("buildCrashLoggingHandlers", () => {
   it("uncaughtException: 写诊断、刷新日志、调用 onFatal", () => {
@@ -212,6 +218,69 @@ describe("installCrashLogging", () => {
   });
 });
 
+describe("installEpipeGuard", () => {
+  function fakeStream(): EventEmitter & { on: typeof EventEmitter.prototype.on; off: typeof EventEmitter.prototype.off } {
+    return new EventEmitter() as unknown as EventEmitter & {
+      on: typeof EventEmitter.prototype.on;
+      off: typeof EventEmitter.prototype.off;
+    };
+  }
+
+  it("吞掉 EPIPE 写错误并记录非致命 trace，不抛出", () => {
+    const stream = fakeStream();
+    const tracer = vi.fn();
+    const cleanup = installEpipeGuard([stream as never], { tracer });
+
+    const err = Object.assign(new Error("broken pipe"), { code: "EPIPE" });
+    expect(() => stream.emit("error", err)).not.toThrow();
+    expect(tracer).toHaveBeenCalledWith(
+      "stdio write error (non-fatal)",
+      expect.objectContaining({ code: "EPIPE" }),
+    );
+
+    cleanup();
+  });
+
+  it("其它 IO 错误同样非致命（日志失败不能拖垮服务）", () => {
+    const stream = fakeStream();
+    const tracer = vi.fn();
+    const cleanup = installEpipeGuard([stream as never], { tracer });
+
+    const err = Object.assign(new Error("permission denied"), { code: "EACCES" });
+    expect(() => stream.emit("error", err)).not.toThrow();
+    expect(tracer).toHaveBeenCalledWith(
+      "stdio write error (non-fatal)",
+      expect.objectContaining({ code: "EACCES" }),
+    );
+
+    cleanup();
+  });
+
+  it("cleanup 后不再监听，错误可正常传播", () => {
+    const stream = fakeStream();
+    const tracer = vi.fn();
+    const cleanup = installEpipeGuard([stream as never], { tracer });
+    cleanup();
+
+    expect(() => stream.emit("error", new Error("boom"))).toThrow("boom");
+    expect(tracer).not.toHaveBeenCalled();
+  });
+
+  it("默认同时守护 stdout 与 stderr", () => {
+    const stdoutBefore = process.stdout.listenerCount("error");
+    const stderrBefore = process.stderr.listenerCount("error");
+    const cleanup = installEpipeGuard(undefined, { tracer: () => {} });
+    try {
+      expect(process.stdout.listenerCount("error")).toBe(stdoutBefore + 1);
+      expect(process.stderr.listenerCount("error")).toBe(stderrBefore + 1);
+    } finally {
+      cleanup();
+      expect(process.stdout.listenerCount("error")).toBe(stdoutBefore);
+      expect(process.stderr.listenerCount("error")).toBe(stderrBefore);
+    }
+  });
+});
+
 describe("setupFileLogging", () => {
   it("flush 后继续写日志不会触发 write after end，且日志已落盘", async () => {
     const originalLog = console.log;
@@ -263,4 +332,29 @@ describe("setupFileLogging", () => {
       await rm(dir, { recursive: true, force: true });
     }
   });
+
+  it("console.warn 也会落盘并包含 WARN 级别标记", async () => {
+    const originalLog = console.log;
+    const originalError = console.error;
+    const originalWarn = console.warn;
+    console.log = vi.fn() as never;
+    console.error = vi.fn() as never;
+    console.warn = vi.fn() as never;
+    const dir = await mkdtemp(join(tmpdir(), "chatccc-log-"));
+
+    try {
+      const fileLog = setupFileLogging(dir, "index");
+
+      expect(() => console.warn("sdk warning")).not.toThrow();
+      fileLog.flush();
+
+      const content = await readFile(fileLog.logPath, "utf8");
+      expect(content).toContain("[WARN] sdk warning");
+    } finally {
+      console.log = originalLog;
+      console.error = originalError;
+      console.warn = originalWarn;
+      await rm(dir, { recursive: true, force: true });
+    }
+  });
 });

package/src/__tests__/restart.test.ts

@@ -1,132 +1,177 @@
-import { EventEmitter } from "node:events";
-import { join } from "node:path";
-
-import { describe, expect, it, vi } from "vitest";
-
-import {
-  buildRestartSpawnSpec,
-  decideRestartParentExit,
-  spawnRestartChild,
-  RESTART_CHILD_READY_MS,
-} from "../orchestrator.ts";
-import { INTERNAL_RESTART_ENV_VAR } from "../startup-lifecycle.ts";
-
-describe("buildRestartSpawnSpec", () => {
-  it("spawns node directly with the local tsx CLI (never via npx/npm)", () => {
-    const spec = buildRestartSpawnSpec("F:/proj");
-    expect(spec.command).toBe(process.execPath);
-    expect(spec.args[0]).toBe(join("F:/proj", "node_modules", "tsx", "dist", "cli.mjs"));
-    expect(spec.args[1]).toBe("src/index.ts");
-    expect([spec.command, ...spec.args].join(" ")).not.toMatch(/npx|npm/i);
-  });
-
-  it("accepts the default project root", () => {
-    const spec = buildRestartSpawnSpec();
-    expect(spec.command).toBe(process.execPath);
-    expect(spec.args[0]).toContain("tsx");
-  });
-});
-
-describe("spawnRestartChild", () => {
-  class FakeChild extends EventEmitter {
-    pid = 12345;
-    exitCode: number | null = null;
-    signalCode: number | string | null = null;
-    unref = vi.fn();
-    stderr = new EventEmitter();
-  }
-
-  it("spawns without a shell, captures stderr, and marks the internal restart env", () => {
-    const fake = new FakeChild();
-    const spawnImpl = vi.fn(() => fake as never);
-    const trace = vi.fn();
-
-    const child = spawnRestartChild({ projectRoot: "F:/proj", spawnImpl, trace });
-
-    expect(child).toBe(fake);
-    expect(spawnImpl).toHaveBeenCalledWith(
-      process.execPath,
-      [join("F:/proj", "node_modules", "tsx", "dist", "cli.mjs"), "src/index.ts"],
-      expect.objectContaining({
-        detached: true,
-        stdio: ["ignore", "ignore", "pipe"],
-        env: expect.objectContaining({ [INTERNAL_RESTART_ENV_VAR]: "1" }),
-        // 不使用 shell：避免 npm/npx 的 PATH 注入问题
-        shell: false,
-      }),
-    );
-    // spawnImpl 收到的 command/args 中不得出现 npx/npm（env 里的 npm_* 变量不算）
-    const firstCall = spawnImpl.mock.calls[0] as unknown as [string, string[]];
-    const [cmd, args] = firstCall;
-    expect([cmd, ...args].join(" ")).not.toMatch(/npx|npm/i);
-  });
-
-  it("writes captured stderr into the trace on child exit", () => {
-    const fake = new FakeChild();
-    const spawnImpl = vi.fn(() => fake as never);
-    const trace = vi.fn();
-
-    spawnRestartChild({ projectRoot: "F:/proj", spawnImpl, trace });
-
-    fake.stderr.emit("data", Buffer.from("tsx error line 1\n"));
-    fake.stderr.emit("data", Buffer.from("tsx error line 2\n"));
-    fake.exitCode = 1;
-    fake.emit("exit", 1, null);
-
-    const exitCall = trace.mock.calls.find(([name]) => name === "restart: child exit");
-    expect(exitCall).toBeTruthy();
-    expect(exitCall![1]).toEqual(expect.objectContaining({
-      childPid: 12345,
-      code: 1,
-      signal: null,
-    }));
-    expect(exitCall![1].stderr).toContain("tsx error line 1");
-    expect(exitCall![1].stderr).toContain("tsx error line 2");
-  });
-});
-
-describe("decideRestartParentExit", () => {
-  it("returns false (parent stays alive) when the child dies during the window", async () => {
-    const child = { exitCode: 1, signalCode: null, pid: 42 } as never;
-    const trace = vi.fn();
-
-    const shouldExit = await decideRestartParentExit(child, 200, 50, trace);
-
-    expect(shouldExit).toBe(false);
-    expect(trace).toHaveBeenCalledWith(
-      "restart: child died during window, keeping parent",
-      expect.objectContaining({ childPid: 42, exitCode: 1 }),
-    );
-  });
-
-  it("returns true (parent exits) when the child stays alive through the window", async () => {
-    const child = { exitCode: null, signalCode: null, pid: 42 } as never;
-    const trace = vi.fn();
-
-    const shouldExit = await decideRestartParentExit(child, 150, 30, trace);
-
-    expect(shouldExit).toBe(true);
-    expect(trace).toHaveBeenCalledWith(
-      "restart: child alive after window, parent exiting",
-      expect.objectContaining({ childPid: 42 }),
-    );
-  });
-
-  it("surfaces a child that died with a signal", async () => {
-    const child = { exitCode: null, signalCode: "SIGKILL", pid: 42 } as never;
-    const trace = vi.fn();
-
-    const shouldExit = await decideRestartParentExit(child, 100, 25, trace);
-
-    expect(shouldExit).toBe(false);
-    expect(trace).toHaveBeenCalledWith(
-      "restart: child died during window, keeping parent",
-      expect.objectContaining({ signalCode: "SIGKILL" }),
-    );
-  });
-
-  it("exports a sane default readiness window", () => {
-    expect(RESTART_CHILD_READY_MS).toBeGreaterThan(0);
-    expect(RESTART_CHILD_READY_MS).toBeLessThan(60_000);
-  });
-});
+import { EventEmitter } from "node:events";
+import { mkdtemp, readdir, rm, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+import { describe, expect, it, vi, afterEach } from "vitest";
+
+import {
+  buildRestartSpawnSpec,
+  decideRestartParentExit,
+  spawnRestartChild,
+  RESTART_CHILD_READY_MS,
+} from "../orchestrator.ts";
+import { INTERNAL_RESTART_ENV_VAR } from "../startup-lifecycle.ts";
+
+describe("buildRestartSpawnSpec", () => {
+  it("spawns node directly with the local tsx CLI (never via npx/npm)", () => {
+    const spec = buildRestartSpawnSpec("F:/proj");
+    expect(spec.command).toBe(process.execPath);
+    expect(spec.args[0]).toBe(join("F:/proj", "node_modules", "tsx", "dist", "cli.mjs"));
+    expect(spec.args[1]).toBe("src/index.ts");
+    expect([spec.command, ...spec.args].join(" ")).not.toMatch(/npx|npm/i);
+  });
+
+  it("accepts the default project root", () => {
+    const spec = buildRestartSpawnSpec();
+    expect(spec.command).toBe(process.execPath);
+    expect(spec.args[0]).toContain("tsx");
+  });
+});
+
+describe("spawnRestartChild", () => {
+  class FakeChild extends EventEmitter {
+    pid = 12345;
+    exitCode: number | null = null;
+    signalCode: number | string | null = null;
+    unref = vi.fn();
+    stderr = new EventEmitter();
+  }
+
+  let tmpDirs: string[] = [];
+  afterEach(async () => {
+    for (const dir of tmpDirs) await rm(dir, { recursive: true, force: true });
+    tmpDirs = [];
+  });
+
+  async function tmpLogDir(): Promise<string> {
+    const dir = await mkdtemp(join(tmpdir(), "chatccc-restart-"));
+    tmpDirs.push(dir);
+    return dir;
+  }
+
+  it("spawns without a shell, redirects stderr to a restart log file, and marks the internal restart env", async () => {
+    const logDir = await tmpLogDir();
+    const fake = new FakeChild();
+    const spawnImpl = vi.fn(() => fake as never);
+    const trace = vi.fn();
+
+    const child = spawnRestartChild({ projectRoot: "F:/proj", spawnImpl, trace, restartLogDir: logDir });
+
+    expect(child).toBe(fake);
+    expect(spawnImpl).toHaveBeenCalledWith(
+      process.execPath,
+      [join("F:/proj", "node_modules", "tsx", "dist", "cli.mjs"), "src/index.ts"],
+      expect.objectContaining({
+        detached: true,
+        env: expect.objectContaining({ [INTERNAL_RESTART_ENV_VAR]: "1" }),
+        // 不使用 shell：避免 npm/npx 的 PATH 注入问题
+        shell: false,
+      }),
+    );
+    // spawnImpl 收到的 command/args 中不得出现 npx/npm（env 里的 npm_* 变量不算）
+    const firstCall = spawnImpl.mock.calls[0] as unknown as [string, string[]];
+    const [cmd, args] = firstCall;
+    expect([cmd, ...args].join(" ")).not.toMatch(/npx|npm/i);
+
+    // stderr 指向磁盘日志文件（fd），而不是 pipe：pipe 读端随父进程退出关闭后，
+    // 子进程写 stderr 会 EPIPE 崩溃（飞书 SDK console.warn 崩溃根因）。
+    const callArgs = spawnImpl.mock.calls[0] as unknown as Array<unknown>;
+    const stdio = (callArgs[2] as { stdio: unknown[] }).stdio;
+    expect(stdio[0]).toBe("ignore");
+    expect(stdio[1]).toBe("ignore");
+    expect(typeof stdio[2]).toBe("number");
+    expect(stdio[2] as number).toBeGreaterThan(2);
+
+    const files = await readdir(logDir);
+    expect(files.some((f) => f.startsWith("restart-") && f.endsWith(".log"))).toBe(true);
+  });
+
+  it("records child exit code/signal in trace without pipe capture", async () => {
+    const logDir = await tmpLogDir();
+    const fake = new FakeChild();
+    const spawnImpl = vi.fn(() => fake as never);
+    const trace = vi.fn();
+
+    spawnRestartChild({ projectRoot: "F:/proj", spawnImpl, trace, restartLogDir: logDir });
+
+    fake.exitCode = 1;
+    fake.emit("exit", 1, null);
+
+    const exitCall = trace.mock.calls.find(([name]) => name === "restart: child exit");
+    expect(exitCall).toBeTruthy();
+    expect(exitCall![1]).toEqual(expect.objectContaining({
+      childPid: 12345,
+      code: 1,
+      signal: null,
+    }));
+    // 不再用 pipe 收集 stderr，trace 里不再有 stderr 字段
+    expect(exitCall![1]).not.toHaveProperty("stderr");
+  });
+
+  it("falls back to pipe capture when the stderr log file cannot be opened", async () => {
+    const dir = await tmpLogDir();
+    // 用普通文件顶替目录：mkdir/open 日志文件必然失败
+    const blocker = join(dir, "blocker");
+    await writeFile(blocker, "x");
+    const fake = new FakeChild();
+    const spawnImpl = vi.fn(() => fake as never);
+    const trace = vi.fn();
+
+    spawnRestartChild({ projectRoot: "F:/proj", spawnImpl, trace, restartLogDir: blocker });
+
+    const callArgs = spawnImpl.mock.calls[0] as unknown as Array<unknown>;
+    expect((callArgs[2] as { stdio: unknown[] }).stdio[2]).toBe("pipe");
+    const failCall = trace.mock.calls.find(
+      ([name]) => name === "restart: stderr log open failed, falling back to pipe",
+    );
+    expect(failCall).toBeTruthy();
+    expect(typeof (failCall![1] as { error: unknown }).error).toBe("string");
+  });
+});
+
+describe("decideRestartParentExit", () => {
+  it("returns false (parent stays alive) when the child dies during the window", async () => {
+    const child = { exitCode: 1, signalCode: null, pid: 42 } as never;
+    const trace = vi.fn();
+
+    const shouldExit = await decideRestartParentExit(child, 200, 50, trace);
+
+    expect(shouldExit).toBe(false);
+    expect(trace).toHaveBeenCalledWith(
+      "restart: child died during window, keeping parent",
+      expect.objectContaining({ childPid: 42, exitCode: 1 }),
+    );
+  });
+
+  it("returns true (parent exits) when the child stays alive through the window", async () => {
+    const child = { exitCode: null, signalCode: null, pid: 42 } as never;
+    const trace = vi.fn();
+
+    const shouldExit = await decideRestartParentExit(child, 150, 30, trace);
+
+    expect(shouldExit).toBe(true);
+    expect(trace).toHaveBeenCalledWith(
+      "restart: child alive after window, parent exiting",
+      expect.objectContaining({ childPid: 42 }),
+    );
+  });
+
+  it("surfaces a child that died with a signal", async () => {
+    const child = { exitCode: null, signalCode: "SIGKILL", pid: 42 } as never;
+    const trace = vi.fn();
+
+    const shouldExit = await decideRestartParentExit(child, 100, 25, trace);
+
+    expect(shouldExit).toBe(false);
+    expect(trace).toHaveBeenCalledWith(
+      "restart: child died during window, keeping parent",
+      expect.objectContaining({ signalCode: "SIGKILL" }),
+    );
+  });
+
+  it("exports a sane default readiness window", () => {
+    expect(RESTART_CHILD_READY_MS).toBeGreaterThan(0);
+    expect(RESTART_CHILD_READY_MS).toBeLessThan(60_000);
+  });
+});

package/src/index.ts

@@ -27,7 +27,7 @@ import { createServer, type IncomingMessage, type Server, type ServerResponse }
 import { WSClient, EventDispatcher, Domain } from "@larksuiteoapi/node-sdk";
 import WebSocket from "ws";
 
-import { appendStartupTrace, attachRelayWebSocket, ensureSingleInstance, freeRelayListenPort, installCrashLogging, waitForPortFree } from "./shared.ts";
+import { appendStartupTrace, attachRelayWebSocket, ensureSingleInstance, freeRelayListenPort, installCrashLogging, installEpipeGuard, waitForPortFree } from "./shared.ts";
 import { createUiRouter, setExtraApiHandler, setReloadConfigHook, startSetupMode } from "./web-ui.ts";
 import {
   buildWebUiUrl,
@@ -804,6 +804,11 @@ async function main(): Promise<void> {
     onBeforeExit: (code) => serviceLifecycle.handleBeforeExit(code),
   });
 
+  // stdout/stderr 管道读端消失（如 /restart 旧进程退出后）时，第三方 SDK 写
+  // stderr 会 EPIPE；无监听会抛 uncaughtException 杀死整个服务。挂守卫把这类
+  // IO 错误降级为一条非致命 trace。
+  installEpipeGuard();
+
   // 模拟模式：独立端口 18079，不与 SDK 实例冲突，不走飞书凭证/权限/WSClient
   if (USE_SIMULATE) {
     const SIM_PORT = 18079;