channel-worker 2.5.8 → 2.5.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "channel-worker",
-  "version": "2.5.8",
+  "version": "2.5.10",
   "description": "Channel Manager worker daemon — runs on remote machines to execute video pipeline jobs",
   "main": "lib/daemon.js",
   "bin": {

package/scripts/upload_facebook.js

@@ -128,22 +128,40 @@ async function dumpFailure(page, tag, log) {
 // "Đã hiểu" / "Bỏ qua" inside the dialog, then check again.
 async function dismissBsOnboarding(page, log) {
   for (let pass = 0; pass < 3; pass++) {
-    const dlg = page.locator("[role='dialog']").first();
-    const has = await dlg.count().catch(() => 0);
-    if (!has || !(await dlg.isVisible().catch(() => false))) return;
+    // Pick the FIRST visible dialog that is NOT the Reels composer. The
+    // Reels modal ('Tạo thước phim' / 'Create reel') has its own '✕' Close
+    // button with aria-label='Đóng'; without this guard dismissBsOnboarding
+    // happily closes the composer immediately after we just opened it, and
+    // the subsequent 'Thêm video' click can't find the modal.
+    const dlgInfo = await page.evaluate(() => {
+      const dlgs = document.querySelectorAll("[role='dialog']");
+      for (const d of dlgs) {
+        const r = d.getBoundingClientRect();
+        if (r.width < 8 || r.height < 8) continue;
+        const cs = getComputedStyle(d);
+        if (cs.visibility === 'hidden' || cs.display === 'none') continue;
+        const txt = (d.innerText || '').slice(0, 400);
+        // Skip the Reels composer — that's the modal we just opened.
+        if (/Tạo thước phim|Create reel|Create a reel|Tạo thư�?c phim/i.test(txt)) continue;
+        d.setAttribute('__fbpw_onboarding__', '1');
+        return { tag: 'ok', preview: txt.slice(0, 80) };
+      }
+      return null;
+    }).catch(() => null);
+    if (!dlgInfo) return;
     const phrases = ['Đã hiểu', 'Got it', 'Bỏ qua', 'Skip', 'Để sau', 'Not now', 'Đóng', 'Close', 'Tiếp tục', 'Continue'];
     let clicked = false;
     for (const p of phrases) {
       const candidates = [
-        `[role='dialog'] [aria-label*='${p}']`,
-        `[role='dialog'] [role='button']:has-text('${p}')`,
-        `[role='dialog'] button:has-text('${p}')`,
+        `[__fbpw_onboarding__='1'] [aria-label*='${p}']`,
+        `[__fbpw_onboarding__='1'] [role='button']:has-text('${p}')`,
+        `[__fbpw_onboarding__='1'] button:has-text('${p}')`,
       ];
       for (const sel of candidates) {
         const hit = await firstVisible(page.locator(sel), 3);
         if (!hit) continue;
         try {
-          log('info', `[fb-pw] dismissing BS onboarding via "${sel}"`);
+          log('info', `[fb-pw] dismissing BS onboarding via "${sel}" (dlg="${dlgInfo.preview}")`);
           await hit.click({ timeout: 2500 });
           await page.waitForTimeout(700);
           clicked = true;
@@ -152,9 +170,11 @@ async function dismissBsOnboarding(page, log) {
       }
       if (clicked) break;
     }
+    // Clean up the marker attr regardless of outcome.
+    await page.evaluate(() => document.querySelectorAll("[__fbpw_onboarding__]").forEach((el) => el.removeAttribute('__fbpw_onboarding__'))).catch(() => {});
     if (!clicked) {
-      try { await page.keyboard.press('Escape'); } catch {}
-      await page.waitForTimeout(500);
+      // Don't blindly press Escape — would also close the Reels composer
+      // if it's the topmost dialog. Bail instead.
       return;
     }
   }
@@ -1299,6 +1319,17 @@ async function run({ page, payload, log }) {
           throw new Error(`FB publish: thumbnail_url provided but the "Chỉnh sửa hình thu nhỏ" overlay was never detected before publish (step ${step + 1}). Refusing to ship without custom thumb. Inspect dump screenshots in Temp\\cm-worker-pw\\.`);
         }
         log('info', `[fb-pw] click publish "${pub.verb}" via "${pub.sel}" (step ${step + 1})`);
+        // DRY-RUN MODE (temporary, for QA): skip the actual publish click so
+        // we can verify the upstream flow (modal scoping, video upload, thumb
+        // step, metadata fill) without spawning real Reels every iteration.
+        // Throws a recognisable error so the daemon marks the cmd failed
+        // without retrying. REMOVE this block once the page-wall composer
+        // fix is verified end-to-end.
+        if (process.env.FB_PW_DRY_RUN === '1' || payload._dry_run === true) {
+          await dumpInventory(page, log, `dry-run-at-publish-${step + 1}`);
+          await dumpFailure(page, `dry-run-at-publish-${step + 1}`, log);
+          throw new Error(`[fb-pw] DRY-RUN: reached publish step ${step + 1} successfully. Pub button found via "${pub.sel}" verb="${pub.verb}". Thumb=${customThumbDone ? 'uploaded' : 'NOT uploaded'}. NOT clicking. Inspect dump screenshots in Temp\\cm-worker-pw\\.`);
+        }
         // Snapshot the captured-IDs list RIGHT BEFORE the publish click. The
         // network listener captures from EVERY graph response, including the
         // pre-publish page wall feed (~100+ IDs). Only IDs captured AFTER