channel-worker 2.5.61 → 2.5.62

package/lib/nst-manager.js

@@ -1,3 +1,24 @@
+function nstLaunchError(response, { profileId = '', runningCount = 0 } = {}) {
+  const raw = String(response?.msg || 'Failed to connect browser').trim();
+  if (!/exceeded plan limits/i.test(raw)) return new Error(raw);
+
+  const nstCode = response?.code || 6001;
+  const localState = runningCount > 0
+    ? `Máy này đang có ${runningCount} browser NST chạy.`
+    : 'Máy này hiện không còn browser NST chạy; slot cloud có thể chưa được nhả sau batch trước.';
+  const error = new Error(
+    `NST_PLAN_LIMIT (mã ${nstCode}): NSTBrowser đã chạm giới hạn slot/phiên của gói, `
+    + `không mở được profile "${profileId}". Tác vụ CHƯA truy cập nền tảng — đây là lỗi hạ tầng NST, `
+    + 'không phải do nền tảng từ chối bài. '
+    + `${localState} Chờ/đóng bớt profile NST hoặc kiểm tra gói NST, rồi đăng lại.`,
+  );
+  error.code = 'NST_PLAN_LIMIT';
+  error.nstCode = nstCode;
+  error.profileId = profileId;
+  error.localRunningCount = runningCount;
+  return error;
+}
+
 class NstManager {
   constructor(apiKey, options = {}) {
     this.apiKey = apiKey;
@@ -241,7 +262,7 @@ class NstManager {
     const apiUrl = `${this.baseUrl}/connect/${profileId}?config=${encodeURIComponent(JSON.stringify(connectConfig))}`;
     const rawRes = await fetch(apiUrl, { headers: { 'x-api-key': this.apiKey } });
     const res = await rawRes.json();
-    if (res.err) throw new Error(res.msg || 'Failed to connect browser');
+    if (res.err) throw nstLaunchError(res, { profileId: profileIdOrName, runningCount: running.length });
 
     console.log(`[nst] Browser started`);
     return { profileId, wsEndpoint: res?.data?.webSocketDebuggerUrl, response: res };
@@ -265,4 +286,4 @@ class NstManager {
   }
 }
 
-module.exports = { NstManager };
+module.exports = { NstManager, nstLaunchError };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "channel-worker",
-  "version": "2.5.61",
+  "version": "2.5.62",
   "description": "Channel Manager worker daemon — runs on remote machines to execute video pipeline jobs",
   "main": "lib/daemon.js",
   "bin": {

package/scripts/upload_facebook.js

@@ -21,6 +21,19 @@ const { assertAccountUsable, readPublishBlock, publishRateLimitError } = require
 const path = require('path');
 const { downloadToTemp, safeUnlink } = require('./lib/download');
 
+const FB_HOME_URL = 'https://www.facebook.com/';
+const REEL_CREATE_SELECTORS = [
+  "a[aria-label='Tạo thước phim']",
+  "a[aria-label='Create reel']",
+  "a[aria-label='Create a reel']",
+  "a[href*='/reels/create']",
+];
+// Residential proxies can leave Facebook's final "Đang tải..." state active
+// well past three minutes. The API only declares a publish command stale after
+// 20 minutes, so give the real upload enough room instead of failing while FB
+// is visibly still processing it.
+const PUBLISH_ENABLE_TIMEOUT_MS = 10 * 60 * 1000;
+
 async function firstVisible(locator, max = 5) {
   const n = Math.min(await locator.count().catch(() => 0), max);
   for (let i = 0; i < n; i++) {
@@ -49,6 +62,35 @@ async function waitAndClick(loc, { timeoutMs = 60_000, log, label = 'button', cl
   throw new Error(`${label} never became actionable within ${timeoutMs}ms`);
 }
 
+// Facebook occasionally never resolves Playwright's `domcontentloaded` wait
+// even though the Page shell is already usable. Treat that specific state as
+// loaded; otherwise clear the half-navigation and retry once. This turns an
+// intermittent navigation timeout into a guarded retry without hiding a dead
+// proxy or an actually blank page.
+async function navigateFacebookHome(page, log) {
+  let lastError = null;
+  for (let attempt = 1; attempt <= 2; attempt++) {
+    try {
+      await page.goto(FB_HOME_URL, { waitUntil: 'domcontentloaded', timeout: 60_000 });
+      return;
+    } catch (e) {
+      lastError = e;
+      const shellReady = /^https:\/\/(?:www\.)?facebook\.com\//i.test(page.url())
+        && !!await firstVisible(page.locator("a[aria-label='Facebook'], [role='region'][aria-label='Tạo bài viết'], [role='region'][aria-label='Create post']"), 5);
+      if (shellReady) {
+        log('warn', `[fb-pw] home domcontentloaded timed out but Facebook shell is usable — continuing (attempt ${attempt})`);
+        return;
+      }
+      if (attempt < 2) {
+        log('warn', `[fb-pw] home navigation failed — retrying once: ${String(e?.message || e).split('\n')[0]}`);
+        await page.goto('about:blank', { waitUntil: 'commit', timeout: 15_000 }).catch(() => {});
+        await pause(page, 1500);
+      }
+    }
+  }
+  throw lastError || new Error('FB home navigation failed');
+}
+
 // FB drops a "Thông báo mới" toast at the BOTTOM-LEFT of the wall (e.g. "… và
 // 96 người khác thích thước phim của bạn") that lands ON TOP of the Reels
 // composer's bottom CTA. Playwright's hit-target check then blocks every
@@ -265,8 +307,15 @@ async function dismissBsOnboarding(page, log) {
         const cs = getComputedStyle(d);
         if (cs.visibility === 'hidden' || cs.display === 'none') continue;
         const txt = (d.innerText || '').slice(0, 400);
+        const aria = d.getAttribute('aria-label') || '';
         // Skip the Reels composer — that's the modal we just opened.
-        if (/Tạo thước phim|Create reel|Create a reel|Tạo thư�?c phim/i.test(txt)) continue;
+        if (/Tạo thước phim|Create reel|Create a reel|Tạo thư�?c phim/i.test(`${aria}\n${txt}`)) continue;
+        // Do not classify every anonymous dialog with an X as onboarding.
+        // Facebook's newly-mounted Reel composer can briefly have no title;
+        // the old code saw that empty dialog and clicked its "Đóng" button.
+        const knownOnboarding = /^js_/i.test(aria)
+          || /Đã hiểu|Got it|Bỏ qua|Skip|Để sau|Not now|Tiếp tục|Continue/i.test(txt);
+        if (!knownOnboarding) continue;
         d.setAttribute('__fbpw_onboarding__', '1');
         return { tag: 'ok', preview: txt.slice(0, 80) };
       }
@@ -537,7 +586,7 @@ async function runOnce({ page, payload, log }) {
     //    Page-wall flow opens a Reel modal whose publish flow either navigates
     //    or shows a confirmation toast linking to the new reel.
     log('info', '[fb-pw] open https://www.facebook.com/ (page wall flow) …');
-    await page.goto('https://www.facebook.com/', { waitUntil: 'domcontentloaded', timeout: 60_000 });
+    await navigateFacebookHome(page, log);
     await page.waitForLoadState('networkidle', { timeout: 30_000 }).catch(() => {});
     await pause(page, 4000);
     log('info', `[fb-pw] home loaded — url=${page.url()}`);
@@ -660,47 +709,74 @@ async function runOnce({ page, payload, log }) {
       .locator("[role='dialog']")
       .filter({ has: page.locator(":scope :text-matches('^Tạo thước phim$|^Create reel$|^Create a reel$', 'i')") })
       .first();
-    if (!(await reelsDialog.isVisible({ timeout: 6000 }).catch(() => false))) {
-      // FALLBACK: some accounts render a different UI from the create-post
-      // "Thước phim" entry → the composer modal never mounts. Click the Reels
-      // link (any <a href*='/reels'>) instead, then re-wait for the modal.
-      log('warn', '[fb-pw] Reels modal not open — fallback: click <a href*="/reels"> then re-wait…');
-      let xpClicked = false;
-      try {
-        const reelsLink = page.locator("xpath=//a[contains(@href, '/reels')]").first();
-        if (await reelsLink.isVisible({ timeout: 3000 }).catch(() => false)) {
-          await reelsLink.click({ timeout: 4000 });
-          xpClicked = true;
-          log('info', '[fb-pw] clicked Reels link via xpath //a[contains(@href,"/reels")]');
-        } else {
-          log('warn', '[fb-pw] fallback: no visible <a href*="/reels"> found');
-        }
-      } catch (e) { log('warn', `[fb-pw] fallback Reels-link click failed: ${e.message.slice(0, 80)}`); }
-      if (xpClicked) {
-        await pause(page, 5000);
+    const fullPageComposer = page.locator("main, [role='main']").first();
+    const findComposerRoot = async (timeout = 1000) => {
+      if (await reelsDialog.isVisible({ timeout }).catch(() => false)) return reelsDialog;
+      if (/\/reels\/create\/?/i.test(page.url())
+        && await fullPageComposer.isVisible({ timeout: 1000 }).catch(() => false)) {
+        const hasUploadUi = await fullPageComposer.locator("input[type='file'], [aria-label='Tải lên'], [aria-label='Upload'], [aria-label='Thêm video'], [aria-label='Add video']")
+          .count().catch(() => 0);
+        if (hasUploadUi) return fullPageComposer;
+      }
+      return null;
+    };
+
+    let reelsRoot = await findComposerRoot(6000);
+    if (!reelsRoot) {
+      // FALLBACK: target the CREATE link, never the generic /reels feed link.
+      // Inventory from the failing accounts contains both; the old broad xpath
+      // picked the feed link and left us on the wall with no composer.
+      log('warn', '[fb-pw] Reels composer not open — fallback: click exact "Tạo thước phim" create link…');
+      let createClicked = false;
+      for (const sel of REEL_CREATE_SELECTORS) {
+        const link = await firstVisible(page.locator(sel), 3);
+        if (!link) continue;
+        try {
+          await humanClick(page, link, { timeout: 4000 });
+          createClicked = true;
+          log('info', `[fb-pw] clicked Reel create link via "${sel}"`);
+          break;
+        } catch (e) { log('warn', `[fb-pw] create-link click failed (${sel}): ${e.message.slice(0, 80)}`); }
+      }
+      if (createClicked) {
+        await pause(page, 7000);
+        await dismissBsOnboarding(page, log).catch(() => {});
+        reelsRoot = await findComposerRoot(5000);
+      }
+
+      // Last safe fallback: a hard navigation avoids Facebook's occasionally
+      // stuck client-side router. No video has been selected yet, so this
+      // cannot create a duplicate post.
+      if (!reelsRoot) {
+        log('warn', '[fb-pw] create link still produced no composer — hard navigating to /reels/create/…');
+        await page.goto('https://www.facebook.com/reels/create/', { waitUntil: 'commit', timeout: 60_000 });
+        await page.waitForLoadState('domcontentloaded', { timeout: 60_000 }).catch(() => {});
+        await pause(page, 7000);
         await dismissBsOnboarding(page, log).catch(() => {});
+        reelsRoot = await findComposerRoot(8000);
       }
-      if (!(await reelsDialog.isVisible({ timeout: 8000 }).catch(() => false))) {
+
+      if (!reelsRoot) {
         await dumpInventory(page, log, 'no-reels-modal');
         await dumpFailure(page, 'no-reels-modal', log);
-        throw new Error('FB Reels modal "Tạo thước phim" did not open (kể cả sau fallback xpath //a[href*="/reels"])');
+        throw new Error('FB Reel composer did not open (đã thử nút Tạo thước phim và /reels/create/)');
       }
-      log('info', '[fb-pw] Reels modal opened after xpath /reels fallback');
+      log('info', '[fb-pw] Reel composer opened after create-link fallback');
     }
     // Candidates inside the modal only:
     //   - "Tải lên" — the explicit blue upload button at the bottom (preferred)
     //   - "Thêm video" — the drop-zone label (clickable on some variants)
     //   - English equivalents
     const addVideoCandidates = [
-      reelsDialog.locator("div[role='button']:has-text('Tải lên')"),
-      reelsDialog.locator("button:has-text('Tải lên')"),
-      reelsDialog.locator("[aria-label='Tải lên']"),
-      reelsDialog.locator("div[role='button']:has-text('Upload')"),
-      reelsDialog.locator("[aria-label='Upload']"),
-      reelsDialog.locator("div[role='button']:has-text('Thêm video')"),
-      reelsDialog.locator("div[role='button']:has-text('Add video')"),
-      reelsDialog.locator("[aria-label='Thêm video']"),
-      reelsDialog.locator("[aria-label='Add video']"),
+      reelsRoot.locator("div[role='button']:has-text('Tải lên')"),
+      reelsRoot.locator("button:has-text('Tải lên')"),
+      reelsRoot.locator("[aria-label='Tải lên']"),
+      reelsRoot.locator("div[role='button']:has-text('Upload')"),
+      reelsRoot.locator("[aria-label='Upload']"),
+      reelsRoot.locator("div[role='button']:has-text('Thêm video')"),
+      reelsRoot.locator("div[role='button']:has-text('Add video')"),
+      reelsRoot.locator("[aria-label='Thêm video']"),
+      reelsRoot.locator("[aria-label='Add video']"),
     ];
     let videoSet = false;
     for (const loc of addVideoCandidates) {
@@ -724,7 +800,7 @@ async function runOnce({ page, payload, log }) {
     if (!videoSet) {
       // Fallback — find an input[type='file'] that lives INSIDE the Reels
       // modal (not the page-wall composer's hidden input).
-      const fi = reelsDialog.locator("input[type='file']").last();
+      const fi = reelsRoot.locator("input[type='file']").last();
       if (await fi.count().catch(() => 0) > 0) {
         try {
           await setVideoFile(page, await fi.elementHandle(), videoPath, log);
@@ -2087,7 +2163,7 @@ async function runOnce({ page, payload, log }) {
         if (!pubWaitDone) {
           pubWaitDone = true;
           log('info', `[fb-pw] no "Tiếp" + no enabled publish at step ${step + 1} — waiting for "Đăng" to enable (large-video processing)…`);
-          const waitResult = await waitForPublishEnabled(page, publishVerbs, log, 180_000, 'fb-pw', {
+          const waitResult = await waitForPublishEnabled(page, publishVerbs, log, PUBLISH_ENABLE_TIMEOUT_MS, 'fb-pw', {
             // Idempotent: once the field is filled, fillState makes this a
             // no-op. Until then it catches a lazily-mounted final form that
             // the first post-Tiếp pass raced past.
@@ -2106,7 +2182,7 @@ async function runOnce({ page, payload, log }) {
             throw new Error(`FB final description field not found at step ${step + 1}`);
           }
           if (waitResult.sawPresent) {
-            throw new Error(`FB publish remained disabled for 180s at step ${step + 1}`);
+            throw new Error(`FB publish remained disabled for ${Math.round(PUBLISH_ENABLE_TIMEOUT_MS / 1000)}s at step ${step + 1}`);
           }
         }
         await dumpInventory(page, log, `no-advance-${step + 1}`);
@@ -2644,4 +2720,7 @@ module.exports.__testables = {
   waitForPublishEnabled,
   hasVisibleReelComposer,
   SAFE_RETRY_COMPOSER_CLOSED,
+  navigateFacebookHome,
+  PUBLISH_ENABLE_TIMEOUT_MS,
+  REEL_CREATE_SELECTORS,
 };