channel-worker 2.5.5 → 2.5.7

package/lib/command-poller.js

@@ -139,6 +139,26 @@ class CommandPoller {
     }
     // Strip the '_pw' suffix to derive the script name (upload_youtube_pw → upload_youtube).
     const scriptName = command.type.replace(/_pw$/, '');
+
+    // PER-PROFILE MUTEX — two _pw scripts can't share the same NST profile.
+    // The NST browser is launched once and shared via CDP; concurrent
+    // page.goto / navigation calls from sibling scripts abort each other
+    // (saw `net::ERR_ABORTED` on FB while YT was navigating during the same
+    // publish click). Different profiles still run in parallel — this lock
+    // only serializes within a profile. Wait up to 30 min with 5s polling
+    // (upload typically 1-3 min); stale-cleanup picks up zombies separately.
+    if (!this._pwInFlight) this._pwInFlight = new Map();
+    const MUTEX_MAX_WAIT_MS = 30 * 60 * 1000;
+    const waitStart = Date.now();
+    while (this._pwInFlight.has(profileId)) {
+      if (Date.now() - waitStart > MUTEX_MAX_WAIT_MS) {
+        await this.api.updateCommand(command._id, { status: 'failed', error: `pw mutex timeout — profile ${profileId} busy with ${this._pwInFlight.get(profileId)} for >30min` });
+        return;
+      }
+      console.log(`[commands/pw] ${command.type} waiting — profile ${profileId} busy with ${this._pwInFlight.get(profileId)}`);
+      await new Promise(r => setTimeout(r, 5000));
+    }
+    this._pwInFlight.set(profileId, command.type);
     console.log(`[commands/pw] ${command.type} → scripts/${scriptName}.js (profile=${profileId})`);
 
     // Lazy-init NST manager (same pattern as the other handlers).
@@ -177,6 +197,10 @@ class CommandPoller {
     } catch (err) {
       console.error(`[commands/pw] ${command.type} failed: ${err.message}`);
       await this.api.postCommandResult(command._id, { status: 'failed', error: String(err.message || err).slice(0, 500) });
+    } finally {
+      // Always release the per-profile mutex — even on throw — or sibling
+      // pw cmds for the same profile would hang forever.
+      if (this._pwInFlight) this._pwInFlight.delete(profileId);
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "channel-worker",
-  "version": "2.5.5",
+  "version": "2.5.7",
   "description": "Channel Manager worker daemon — runs on remote machines to execute video pipeline jobs",
   "main": "lib/daemon.js",
   "bin": {

package/scripts/upload_facebook.js

@@ -1257,6 +1257,19 @@ async function run({ page, payload, log }) {
       // of publishing).
       const pub = await findByVerbs(publishVerbs, { requireBottomHalf: true });
       if (pub) {
+        // Strict-input contract: if the caller supplied a thumbnail_url but
+        // we never opened the "Chỉnh sửa hình thu nhỏ" overlay (FB didn't
+        // render it / DOM selector miss), refuse to publish — the reel
+        // would otherwise ship with FB's auto-generated thumb and the user
+        // sees no custom artwork. Surface as a hard failure so the daemon
+        // retries with a fresh page load instead of silently shipping bad
+        // output. (Observed on reel 1506614811005729: step 1 → click Tiếp
+        // → publish, the thumb-edit pill never appeared.)
+        if (thumbPath && !customThumbDone) {
+          await dumpInventory(page, log, `thumb-step-missed-${step + 1}`);
+          await dumpFailure(page, `thumb-step-missed-${step + 1}`, log);
+          throw new Error(`FB publish: thumbnail_url provided but the "Chỉnh sửa hình thu nhỏ" overlay was never detected before publish (step ${step + 1}). Refusing to ship without custom thumb. Inspect dump screenshots in Temp\\cm-worker-pw\\.`);
+        }
         log('info', `[fb-pw] click publish "${pub.verb}" via "${pub.sel}" (step ${step + 1})`);
         // Snapshot the captured-IDs list RIGHT BEFORE the publish click. The
         // network listener captures from EVERY graph response, including the