channel-worker 2.5.43 → 2.5.44

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "channel-worker",
-  "version": "2.5.43",
+  "version": "2.5.44",
   "description": "Channel Manager worker daemon — runs on remote machines to execute video pipeline jobs",
   "main": "lib/daemon.js",
   "bin": {

package/scripts/upload_facebook.js

@@ -348,10 +348,17 @@ async function setVideoFile(page, inputHandle, filePath, log, tag = 'fb-pw') {
 // throw no-advance. Poll until a bottom-half publish-verb button is present
 // AND enabled. Returns true once enabled; false on timeout, or fast-false if no
 // publish button ever appears (we're not actually on the final step).
-async function waitForPublishEnabled(page, verbs, log, timeoutMs, tag = 'fb-pw') {
+async function waitForPublishEnabled(page, verbs, log, timeoutMs, tag = 'fb-pw', { onPoll = null } = {}) {
   const deadline = Date.now() + timeoutMs;
   let announced = false, sawPresent = false, absent = 0;
   while (Date.now() < deadline) {
+    // The final metadata form mounts lazily on some FB cohorts. The first
+    // fillMetadata() immediately after Tiếp can run before its textbox exists,
+    // leaving the form blank and Đăng disabled forever. Let the caller retry
+    // its idempotent metadata fill while we wait for video processing.
+    if (onPoll) await onPoll().catch((e) => {
+      log('warn', `[${tag}] final metadata retry failed: ${e.message.slice(0, 100)}`);
+    });
     const st = await page.evaluate((vbs) => {
       const dlgs = document.querySelectorAll("[role='dialog']");
       const roots = dlgs.length ? Array.from(dlgs) : [document];
@@ -374,28 +381,53 @@ async function waitForPublishEnabled(page, verbs, log, timeoutMs, tag = 'fb-pw')
     }, verbs).catch(() => ({ present: false, enabled: false }));
     if (st.enabled) {
       if (announced) log('info', `[${tag}] "Đăng" is now enabled — video finished processing`);
-      return true;
+      return { enabled: true, sawPresent: true };
     }
     if (st.present) {
       sawPresent = true;
       if (!announced) { log('info', `[${tag}] final step: "Đăng" disabled (video still processing) — waiting up to ${Math.round(timeoutMs / 1000)}s…`); announced = true; }
     } else if (!sawPresent && ++absent >= 4) {
-      return false; // no publish CTA after ~10s → not the final step
+      return { enabled: false, sawPresent: false }; // no publish CTA after ~10s → not the final step
     }
     await page.waitForTimeout(2500);
   }
   log('warn', `[${tag}] "Đăng" never became enabled within ${Math.round(timeoutMs / 1000)}s`);
-  return false;
+  return { enabled: false, sawPresent };
+}
+
+const SAFE_RETRY_COMPOSER_CLOSED = 'FB_SAFE_RETRY_COMPOSER_CLOSED';
+
+function safeComposerRetryError(message) {
+  const err = new Error(message);
+  err.code = SAFE_RETRY_COMPOSER_CLOSED;
+  return err;
 }
 
-async function run({ page, payload, log }) {
+async function hasVisibleReelComposer(page) {
+  return page.evaluate(() => {
+    for (const dlg of document.querySelectorAll("[role='dialog']")) {
+      const r = dlg.getBoundingClientRect();
+      if (r.width < 8 || r.height < 8) continue;
+      const cs = getComputedStyle(dlg);
+      if (cs.visibility === 'hidden' || cs.display === 'none' || cs.opacity === '0') continue;
+      const aria = dlg.getAttribute('aria-label') || '';
+      const text = (dlg.innerText || '').slice(0, 500);
+      const signature = `${aria}\n${text}`;
+      if (/Chỉnh sửa hình thu nhỏ|Edit thumbnail/i.test(signature)) continue;
+      if (/Tạo thước phim|Chỉnh sửa thước phim|Cài đặt thước phim|Create (?:a )?reel|Edit reel|Reel settings/i.test(signature)) return true;
+    }
+    return false;
+  }).catch(() => false);
+}
+
+async function runOnce({ page, payload, log }) {
   const {
     video_url, title, description = '', tags = [],
     visibility = 'public', format = 'short',
   } = payload || {};
   if (!video_url) throw new Error('No video_url provided');
 
-  log('info', '[fb-pw] selectors version=2026.08.02-overlay-proof-cta');
+  log('info', '[fb-pw] selectors version=2026.08.06-composer-retry-metadata-poll');
 
   page.on('dialog', (d) => { d.accept().catch(() => {}); });
 
@@ -842,6 +874,13 @@ async function run({ page, payload, log }) {
           "[role='textbox'][aria-placeholder*='Mô tả thước phim']",
           "[role='textbox'][aria-placeholder*='Mô tả']",
           "[role='textbox'][aria-placeholder*='Describe your reel']",
+          // Newer Lexical/contenteditable cohorts expose data-placeholder
+          // instead of aria-placeholder. Scope these to a dialog so a feed
+          // comment box can never receive the reel caption.
+          "[role='dialog'] [contenteditable='true'][data-placeholder*='Mô tả thước phim']",
+          "[role='dialog'] [contenteditable='true'][data-placeholder*='Mô tả']",
+          "[role='dialog'] [contenteditable='true'][data-placeholder*='Describe your reel']",
+          "[role='dialog'] [contenteditable='true'][aria-label*='Mô tả thước phim']",
           // BS composer description — legacy.
           "[role='textbox'][aria-label*='Mô tả']",
           "[role='textbox'][aria-label*='hộp thoại']",
@@ -856,11 +895,61 @@ async function run({ page, payload, log }) {
             const descText = (fbCaption || description || title || '').toString().slice(0, 2100);
             if (!descText) break;
             await f.type(descText, { delay: 12 });
+            // Blur commits the Lexical/React value and re-runs the form's
+            // validation. Without this, the text can be visible while Đăng
+            // remains disabled against the previous empty state.
+            await page.keyboard.press('Tab').catch(() => {});
             fillState.description = true;
             log('info', `[fb-pw] description filled (${descText.length} chars) via "${sel}"`);
             break;
           } catch (e) { log('info', `[fb-pw] desc via "${sel}" failed: ${e.message.slice(0, 80)}`); }
         }
+        // Attribute shapes move frequently. Last-resort probe the visible Reel
+        // dialog for an editable whose combined accessibility signature names
+        // the description, tag it, and let Playwright type through the normal
+        // input path. This specifically covers the production cohort where the
+        // placeholder rendered after step 3 but none of the static selectors
+        // matched it on the first pass.
+        if (!fillState.description) {
+          const probe = await page.evaluate(() => {
+            document.querySelectorAll('[__fbpw_desc__]').forEach((el) => el.removeAttribute('__fbpw_desc__'));
+            const dialogs = [...document.querySelectorAll("[role='dialog']")];
+            for (const dlg of dialogs) {
+              const dr = dlg.getBoundingClientRect();
+              if (dr.width < 8 || dr.height < 8) continue;
+              const ds = `${dlg.getAttribute('aria-label') || ''}\n${(dlg.innerText || '').slice(0, 500)}`;
+              if (!/thước phim|reel/i.test(ds)) continue;
+              for (const el of dlg.querySelectorAll("[role='textbox'], [contenteditable='true'], textarea, input")) {
+                const r = el.getBoundingClientRect();
+                if (r.width < 8 || r.height < 8) continue;
+                const sig = [
+                  el.getAttribute('aria-placeholder'), el.getAttribute('data-placeholder'),
+                  el.getAttribute('placeholder'), el.getAttribute('aria-label'),
+                  el.textContent,
+                ].filter(Boolean).join('|');
+                if (!/Mô tả(?: thước phim)?|Describe (?:your )?reel/i.test(sig)) continue;
+                el.setAttribute('__fbpw_desc__', '1');
+                return "[__fbpw_desc__='1']";
+              }
+            }
+            return null;
+          }).catch(() => null);
+          if (probe) {
+            try {
+              const f = page.locator(probe);
+              const descText = (fbCaption || description || title || '').toString().slice(0, 2100);
+              await f.click({ timeout: 3000 });
+              await f.type(descText, { delay: 12 });
+              await page.keyboard.press('Tab').catch(() => {});
+              fillState.description = true;
+              log('info', `[fb-pw] description filled (${descText.length} chars) via dynamic-probe`);
+            } catch (e) {
+              log('info', `[fb-pw] desc dynamic-probe failed: ${e.message.slice(0, 80)}`);
+            } finally {
+              await page.evaluate(() => document.querySelectorAll('[__fbpw_desc__]').forEach((el) => el.removeAttribute('__fbpw_desc__'))).catch(() => {});
+            }
+          }
+        }
       }
 
       // Tags (Thêm thẻ) — comma-separated; STRIP leading "#" since FB's tag
@@ -1169,15 +1258,32 @@ async function run({ page, payload, log }) {
             // Wait for the thumb-edit modal to mount. Header text =
             // "Chỉnh sửa hình thu nhỏ".
             await page.evaluate(() => document.querySelectorAll("[__fbpw_thumb_edit__]").forEach((el) => el.removeAttribute('__fbpw_thumb_edit__'))).catch(() => {});
+            const thumbDialogReady = await page.evaluate(() => {
+              document.querySelectorAll('[__fbpw_thumb_dialog__]').forEach((el) => el.removeAttribute('__fbpw_thumb_dialog__'));
+              for (const dlg of document.querySelectorAll("[role='dialog']")) {
+                const r = dlg.getBoundingClientRect();
+                if (r.width < 8 || r.height < 8) continue;
+                const cs = getComputedStyle(dlg);
+                if (cs.visibility === 'hidden' || cs.display === 'none' || cs.opacity === '0') continue;
+                const sig = `${dlg.getAttribute('aria-label') || ''}\n${(dlg.innerText || '').slice(0, 300)}`;
+                if (!/Chỉnh sửa hình thu nhỏ|Edit thumbnail/i.test(sig)) continue;
+                dlg.setAttribute('__fbpw_thumb_dialog__', '1');
+                return true;
+              }
+              return false;
+            }).catch(() => false);
+            if (!thumbDialogReady) throw new Error('thumbnail editor dialog did not mount');
 
             // Click "Tải lên" button — opens OS file picker. Use filechooser
-            // race to inject the file path directly.
+            // race to inject the file path directly. Scope every action to the
+            // exact thumbnail dialog: Facebook can simultaneously keep its
+            // Notifications dialog and the outer Reel composer in the DOM.
             const uploadCandidates = [
-              "[role='dialog'] div[role='button']:has-text('Tải lên')",
-              "[role='dialog'] button:has-text('Tải lên')",
-              "[role='dialog'] [aria-label='Tải lên']",
-              "[role='dialog'] [aria-label*='Tải hình thu nhỏ']",
-              "[role='dialog'] div[role='button']:has-text('Upload')",
+              "[__fbpw_thumb_dialog__='1'] div[role='button']:has-text('Tải lên')",
+              "[__fbpw_thumb_dialog__='1'] button:has-text('Tải lên')",
+              "[__fbpw_thumb_dialog__='1'] [aria-label='Tải lên']",
+              "[__fbpw_thumb_dialog__='1'] [aria-label*='Tải hình thu nhỏ']",
+              "[__fbpw_thumb_dialog__='1'] div[role='button']:has-text('Upload')",
             ];
             let uploaded = false;
             for (const sel of uploadCandidates) {
@@ -1201,7 +1307,7 @@ async function run({ page, payload, log }) {
             // Fallback — direct setInputFiles on a hidden image-accepting
             // file input inside the modal.
             if (!uploaded) {
-              const directInput = page.locator("[role='dialog'] input[type='file'][accept*='image']").last();
+              const directInput = page.locator("[__fbpw_thumb_dialog__='1'] input[type='file'][accept*='image']").last();
               if (await directInput.count().catch(() => 0) > 0) {
                 try {
                   await directInput.setInputFiles(thumbPath);
@@ -1217,10 +1323,10 @@ async function run({ page, payload, log }) {
             if (uploaded) {
               // Click "Lưu" to save the new thumbnail.
               const saveCandidates = [
-                "[role='dialog'] div[role='button']:has-text('Lưu')",
-                "[role='dialog'] button:has-text('Lưu')",
-                "[role='dialog'] [aria-label='Lưu']",
-                "[role='dialog'] div[role='button']:has-text('Save')",
+                "[__fbpw_thumb_dialog__='1'] div[role='button']:has-text('Lưu')",
+                "[__fbpw_thumb_dialog__='1'] button:has-text('Lưu')",
+                "[__fbpw_thumb_dialog__='1'] [aria-label='Lưu']",
+                "[__fbpw_thumb_dialog__='1'] div[role='button']:has-text('Save')",
               ];
               let saved = false;
               for (const sel of saveCandidates) {
@@ -1280,13 +1386,21 @@ async function run({ page, payload, log }) {
                   await page.waitForTimeout(1000);
                 }
                 if (modalClosed) {
+                  // Closing the nested thumbnail editor is NOT enough. In the
+                  // 2026-08-05 failure Facebook unmounted the OUTER composer at
+                  // the same moment, leaving us on the Page feed. Retrying is
+                  // safe here because the publish branch has not run yet.
+                  if (!(await hasVisibleReelComposer(page))) {
+                    await dumpFailure(page, 'composer-closed-after-thumb-save', log);
+                    throw safeComposerRetryError('FB Reel composer closed after saving thumbnail (before publish)');
+                  }
                   thumbApplied = true;
                   log('info', `[fb-pw] page-wall thumb — modal closed after save (retries=${retryCount})`);
                 } else {
                   log('warn', '[fb-pw] page-wall thumb — modal still open 60s after Lưu click; trying ESC + click Hủy fallback');
                   await page.keyboard.press('Escape').catch(() => {});
                   await page.waitForTimeout(800);
-                  const cancel = await firstVisible(page.locator("[role='dialog'] div[role='button']:has-text('Hủy'), [role='dialog'] button:has-text('Hủy')"), 2);
+                  const cancel = await firstVisible(page.locator("[__fbpw_thumb_dialog__='1'] div[role='button']:has-text('Hủy'), [__fbpw_thumb_dialog__='1'] button:has-text('Hủy')"), 2);
                   if (cancel) await cancel.click({ timeout: 2000 }).catch(() => {});
                   await page.waitForTimeout(1500);
                 }
@@ -1295,11 +1409,12 @@ async function run({ page, payload, log }) {
               }
             } else {
               log('warn', '[fb-pw] page-wall thumb upload failed — closing modal via Hủy to continue');
-              const cancel = await firstVisible(page.locator("[role='dialog'] div[role='button']:has-text('Hủy'), [role='dialog'] button:has-text('Hủy')"), 2);
+              const cancel = await firstVisible(page.locator("[__fbpw_thumb_dialog__='1'] div[role='button']:has-text('Hủy'), [__fbpw_thumb_dialog__='1'] button:has-text('Hủy')"), 2);
               if (cancel) await cancel.click({ timeout: 2000 }).catch(() => {});
               await page.waitForTimeout(1500);
             }
           } catch (e) {
+            if (e?.code === SAFE_RETRY_COMPOSER_CLOSED) throw e;
             log('warn', `[fb-pw] page-wall thumb flow failed: ${e.message.slice(0, 100)}`);
           }
           customThumbDone = thumbApplied;
@@ -1863,7 +1978,21 @@ async function run({ page, payload, log }) {
         if (!pubWaitDone) {
           pubWaitDone = true;
           log('info', `[fb-pw] no "Tiếp" + no enabled publish at step ${step + 1} — waiting for "Đăng" to enable (large-video processing)…`);
-          if (await waitForPublishEnabled(page, publishVerbs, log, 180_000)) { step--; continue; }
+          const waitResult = await waitForPublishEnabled(page, publishVerbs, log, 180_000, 'fb-pw', {
+            // Idempotent: once the field is filled, fillState makes this a
+            // no-op. Until then it catches a lazily-mounted final form that
+            // the first post-Tiếp pass raced past.
+            onPoll: fillMetadata,
+          });
+          if (waitResult.enabled) { step--; continue; }
+          await dumpInventory(page, log, `no-advance-${step + 1}`);
+          await dumpFailure(page, `no-advance-${step + 1}`, log);
+          if (!fillState.description) {
+            throw new Error(`FB final description field not found at step ${step + 1}`);
+          }
+          if (waitResult.sawPresent) {
+            throw new Error(`FB publish remained disabled for 180s at step ${step + 1}`);
+          }
         }
         await dumpInventory(page, log, `no-advance-${step + 1}`);
         await dumpFailure(page, `no-advance-${step + 1}`, log);
@@ -2336,7 +2465,33 @@ async function run({ page, payload, log }) {
   }
 }
 
+async function run(args) {
+  const { page, log } = args;
+  for (let attempt = 1; attempt <= 2; attempt++) {
+    try {
+      return await runOnce(args);
+    } catch (e) {
+      const safeRetry = e?.code === SAFE_RETRY_COMPOSER_CLOSED;
+      if (!safeRetry || attempt === 2) throw e;
+      log('warn', `[fb-pw] composer vanished before publish — retrying the full upload once (${attempt}/1)`);
+      // Force a clean React tree before runOnce returns to facebook.com and
+      // opens a fresh composer. The first attempt's finally has already removed
+      // its downloaded temp files; runOnce downloads clean copies on retry.
+      await page.goto('about:blank', { waitUntil: 'domcontentloaded', timeout: 15_000 }).catch(() => {});
+      await page.waitForTimeout(1200);
+    }
+  }
+  throw new Error('FB upload exhausted safe retries');
+}
+
 module.exports = { run };
 // Exposed so the overlay-click escalation can be exercised against a synthetic
 // page (toast covering the CTA) without driving the whole upload flow.
-module.exports.__testables = { resilientClick, muteClickInterceptors, unmuteClickInterceptors };
+module.exports.__testables = {
+  resilientClick,
+  muteClickInterceptors,
+  unmuteClickInterceptors,
+  waitForPublishEnabled,
+  hasVisibleReelComposer,
+  SAFE_RETRY_COMPOSER_CLOSED,
+};