channel-worker 2.5.1 → 2.5.2

package/lib/command-poller.js

@@ -1438,17 +1438,24 @@ class CommandPoller {
     // two daemons would happily double-launch and corrupt cookies / kill
     // sessions for the underlying Google/FB accounts.
     if (renderer.nst_profile_id && this.api.leaseRenderer) {
+      // api.leaseRenderer returns json.data on success (a {nst_profile_id,
+      // leased_at, lessee} envelope) and THROWS on success=false. So:
+      //   - throw → another daemon holds the lease OR API rejected → skip
+      //   - return → lease acquired → proceed with NST launch
+      // Previous bug: checked `leaseRes.success !== true` but `.success` is
+      // already stripped from json.data → always falsy → every launch was
+      // wrongfully denied with reason="unknown".
       try {
         const leaseRes = await this.api.leaseRenderer(renderer.nst_profile_id);
-        if (!leaseRes || leaseRes.success !== true) {
-          const reason = leaseRes && leaseRes.message ? leaseRes.message : 'unknown';
-          console.warn(`[scene-dispatch] LEASE DENIED for ${renderer.name || renderer.nst_profile_id}: ${reason} — skipping launch`);
+        if (!leaseRes || !leaseRes.nst_profile_id) {
+          console.warn(`[scene-dispatch] lease returned no data for ${renderer.name || renderer.nst_profile_id} — skipping launch (API may be older)`);
           return;
         }
       } catch (e) {
-        // Treat lease failure as a soft block — the API might be down OR
-        // running an older version. Better to skip than risk double-launch.
-        console.warn(`[scene-dispatch] lease request failed for ${renderer.name || renderer.nst_profile_id}: ${e.message} — skipping launch`);
+        // Either API said success=false (lease held by peer / unowned /
+        // stale rules failed) OR network failure. Either way, do NOT
+        // launch — better idle than collision.
+        console.warn(`[scene-dispatch] LEASE DENIED for ${renderer.name || renderer.nst_profile_id}: ${e.message} — skipping launch`);
         return;
       }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "channel-worker",
-  "version": "2.5.1",
+  "version": "2.5.2",
   "description": "Channel Manager worker daemon — runs on remote machines to execute video pipeline jobs",
   "main": "lib/daemon.js",
   "bin": {