chainlesschain 0.166.136 → 0.166.139

package/src/runtime/agent-core.js

@@ -1,4 +1,7 @@
-import { projectMessagesWithTaskBinding } from "./message-roles.js";
+import {
+  projectMessagesWithTaskBinding,
+  getTaskCompactionBindings,
+} from "./message-roles.js";
 import {
   providerFetch,
   requireUnscopedToolExecution,
@@ -74,7 +77,12 @@ import {
   CODING_TASK_QUALITY_GUIDANCE,
   CODING_CHANGE_REVIEW_PROMPT,
 } from "../lib/coding-task-guidance.js";
-import { CodingChangeReviewContext } from "../lib/coding-change-review-context.js";
+import {
+  CodingChangeReviewContext,
+  changeReviewBudgetNotice,
+  changeReviewBudgetInsufficientError,
+  canReserveChangeReview,
+} from "../lib/coding-change-review-context.js";
 import { RemoteReadLoopGuard } from "../lib/remote-read-loop-guard.js";
 import {
   isPrActionRequest,
@@ -12375,7 +12383,10 @@ export async function chatWithTools(rawMessages, options) {
           ),
         {
           signal,
-          retries: options.workflowEffectId ? 0 : undefined,
+          retries:
+            options.workflowEffectId || options.disableTransportRetry === true
+              ? 0
+              : undefined,
           strictRetryObserver: options.strictUsageTelemetry === true,
           ...(typeof options.onStreamRetry === "function"
             ? {
@@ -12527,7 +12538,10 @@ export async function chatWithTools(rawMessages, options) {
           ),
         {
           signal,
-          retries: options.workflowEffectId ? 0 : undefined,
+          retries:
+            options.workflowEffectId || options.disableTransportRetry === true
+              ? 0
+              : undefined,
           strictRetryObserver: options.strictUsageTelemetry === true,
           ...(typeof options.onStreamRetry === "function"
             ? {
@@ -12655,7 +12669,10 @@ export async function chatWithTools(rawMessages, options) {
           ),
         {
           signal,
-          retries: options.workflowEffectId ? 0 : undefined,
+          retries:
+            options.workflowEffectId || options.disableTransportRetry === true
+              ? 0
+              : undefined,
           strictRetryObserver: options.strictUsageTelemetry === true,
           ...(typeof options.onStreamRetry === "function"
             ? {
@@ -12720,7 +12737,10 @@ export async function chatWithTools(rawMessages, options) {
         ),
       {
         signal,
-        retries: options.workflowEffectId ? 0 : undefined,
+        retries:
+          options.workflowEffectId || options.disableTransportRetry === true
+            ? 0
+            : undefined,
         strictRetryObserver: options.strictUsageTelemetry === true,
         ...(typeof options.onStreamRetry === "function"
           ? {
@@ -12768,7 +12788,10 @@ export async function chatWithTools(rawMessages, options) {
         ),
       {
         signal,
-        retries: options.workflowEffectId ? 0 : undefined,
+        retries:
+          options.workflowEffectId || options.disableTransportRetry === true
+            ? 0
+            : undefined,
         strictRetryObserver: options.strictUsageTelemetry === true,
         ...(typeof options.onStreamRetry === "function"
           ? {
@@ -14607,6 +14630,9 @@ async function _getAutoCompactor(options) {
                     onToken: undefined,
                     onStall: undefined,
                     onStreamRetry: undefined,
+                    // Summary spend is settled once at the compactor boundary.
+                    // A second transport attempt would bypass that accounting.
+                    disableTransportRetry: true,
                     providerRequestId:
                       requestBinding?.providerRequestId || undefined,
                     maxOutputTokens,
@@ -14642,6 +14668,7 @@ async function _getAutoCompactor(options) {
             return compactLiveMessagesCanonical(messages, {
               compressor: compatibilitySummarizer,
               compressOptions,
+              requiredUserBindings: compressOptions.requiredUserBindings,
               sessionId: options.sessionId,
               operationId: `auto-${randomUUID()}`,
               provider: options.provider || "ollama",
@@ -14979,6 +15006,11 @@ export async function* agentLoop(messages, options) {
           ).length === 1,
       }
     : null;
+  const taskCompactionBindings = getTaskCompactionBindings(
+    options.projectProviderMessages,
+    messages,
+    currentUserTaskBinding,
+  );
   if (options.serviceTier != null) {
     resolveModelServiceTier(
       resolveModelCapabilityProfile(options),
@@ -15581,6 +15613,37 @@ export async function* agentLoop(messages, options) {
   toolContext.readFileLoopGuard = readFileLoopGuard;
   let lastTaskProgressIntervention = null;
 
+  // Both an author completion and the reserved review window enter the same
+  // phase. Neither path manufactures an author response or adds request budget.
+  const beginChangeReview = (draft = null) => {
+    throwIfAborted(signal);
+    if (budget.remaining() < 2)
+      throw changeReviewBudgetInsufficientError(budget.remaining());
+    if (independentReviewSetupError) throw independentReviewSetupError;
+    changeReviewState.requested = true;
+    const reviewPrompt = markRuntimeOnlySessionMessage({
+      role: "user",
+      content: CODING_CHANGE_REVIEW_PROMPT,
+    });
+    if (draft)
+      appendMessages(
+        markRuntimeOnlySessionMessage({
+          role: "assistant",
+          content: draft.content || "",
+        }),
+      );
+    appendMessages(reviewPrompt);
+    if (independentReviewContext) {
+      independentReviewContext.activate(reviewPrompt);
+      changeReviewState.independentReviewPending = true;
+      readFileLoopGuard = new ReadFileLoopGuard();
+      remoteReadLoopGuard = new RemoteReadLoopGuard();
+      taskProgressTracker = new TaskProgressTracker();
+      toolContext.readFileLoopGuard = readFileLoopGuard;
+      lastTaskProgressIntervention = null;
+    }
+  };
+
   while (budget.hasRemaining()) {
     if (loopMcpCatalog) {
       currentMcpSnapshot = readMcpToolCatalog(loopMcpCatalog);
@@ -15627,6 +15690,24 @@ export async function* agentLoop(messages, options) {
       return;
     }
     readFileLoopGuard.finishBatch();
+    if (
+      canReserveChangeReview({
+        enabled: options.reviewChanges,
+        changed: hasFileContentChanges,
+        requested: changeReviewState.requested,
+        usageKnown: changeReviewState.usageKnown,
+        pendingMutations: pendingSubtreeMutations.size,
+        pendingChildren: backgroundSubAgents.size,
+        remaining: budget.remaining(),
+        limit: budget.limit,
+      })
+    ) {
+      beginChangeReview();
+      yield {
+        type: "iteration-warning",
+        message: "Reviewing changed files against the task before finishing.",
+      };
+    }
     if (remoteReadLoopGuard.stalled && !remoteReadLoopGuard.synthesisRequired) {
       await _awaitBackgroundUsageSettlement(
         backgroundSubAgents,
@@ -15901,6 +15982,7 @@ export async function* agentLoop(messages, options) {
               }
             : await compactor.compress(workingMessages, {
                 preserveToolPairs: true,
+                requiredUserBindings: taskCompactionBindings,
                 ...pinOpts,
               });
           if (
@@ -15936,6 +16018,9 @@ export async function* agentLoop(messages, options) {
                   reason:
                     stats.summaryUsageUnknownReason ||
                     "provider_transport_outcome_unknown",
+                  ...(stats.summaryProviderError
+                    ? { providerError: stats.summaryProviderError }
+                    : {}),
                 };
               }
             }
@@ -16042,6 +16127,9 @@ export async function* agentLoop(messages, options) {
                   ? compactionUsageCall.model
                   : stats.summaryModel || options.model || null,
               reason: unknownReason,
+              ...(stats.summaryProviderError
+                ? { providerError: stats.summaryProviderError }
+                : {}),
               code:
                 unknownReason === "provider_usage_not_reported"
                   ? "provider_usage_missing"
@@ -16551,7 +16639,10 @@ export async function* agentLoop(messages, options) {
             `Execution budget: this request plus ${furtherRequests} further model requests. ` +
             "For requested changes, reserve requests for implementation, focused validation, and repair or an accurate unfinished-work report. " +
             "Reading or an existing passing baseline does not deliver requested changes. " +
-            "For research or monitoring, use the remaining requests for evidence and the requested answer; do not create files just to show activity.",
+            "For research or monitoring, use the remaining requests for evidence and the requested answer; do not create files just to show activity." +
+            (options.reviewChanges === true
+              ? changeReviewBudgetNotice(budget, changeReviewState.requested)
+              : ""),
         },
       ];
       contextMemoryTrustedSystemIndexes.push(callMessages.length - 1);
@@ -16954,7 +17045,7 @@ export async function* agentLoop(messages, options) {
     }
     throwIfAborted(signal);
     if (
-      independentReviewContext?.active &&
+      options.reviewChanges === true &&
       changeReviewState.usageKnown === false
     ) {
       const error = new Error(
@@ -17213,42 +17304,14 @@ export async function* agentLoop(messages, options) {
         };
         return;
       }
-      // Opt-in review uses the same loop, tools, usage settlement and budget.
-      // Never emit a provisional completion or turn this self-check into an
-      // acceptance verdict. Failed/deferred writes do not arm the review.
+      // Author completion is provisional until the independent review phase.
       if (
         options.reviewChanges === true &&
         hasFileContentChanges &&
         !changeReviewState.requested &&
-        changeReviewState.usageKnown !== false &&
-        budget.hasRemaining()
+        changeReviewState.usageKnown !== false
       ) {
-        throwIfAborted(signal);
-        if (independentReviewSetupError) throw independentReviewSetupError;
-        changeReviewState.requested = true;
-        const reviewPrompt = markRuntimeOnlySessionMessage({
-          role: "user",
-          content: CODING_CHANGE_REVIEW_PROMPT,
-        });
-        appendMessages(
-          markRuntimeOnlySessionMessage({
-            role: "assistant",
-            content: msg.content || "",
-          }),
-          reviewPrompt,
-        );
-        if (independentReviewContext) {
-          independentReviewContext.activate(reviewPrompt);
-          changeReviewState.independentReviewPending = true;
-          // These are phase-local discovery hints, not permission or spend
-          // authorities. Fresh inspection must not inherit author assertions,
-          // old visible file pages, or a pause caused by author exploration.
-          readFileLoopGuard = new ReadFileLoopGuard();
-          remoteReadLoopGuard = new RemoteReadLoopGuard();
-          taskProgressTracker = new TaskProgressTracker();
-          toolContext.readFileLoopGuard = readFileLoopGuard;
-          lastTaskProgressIntervention = null;
-        }
+        beginChangeReview(msg);
         yield {
           type: "iteration-warning",
           message: "Reviewing changed files against the task before finishing.",

package/src/runtime/headless-runner.js

@@ -2942,6 +2942,7 @@ async function runAgentHeadlessInWorkspace(
     });
   };
   const loopOptions = {
+    contextMemoryModelWindowTokens: options.contextMemoryModelWindowTokens,
     ...(evolutionIngress === null ? {} : { evolutionIngress }),
     model,
     provider,

package/src/runtime/headless-stream.js

@@ -964,6 +964,7 @@ async function runTurn(
   let endReason = "complete";
   let stopForCost = false;
   let stopForCompactionUsageUnknown = false;
+  let compactionUsageUnknown = null;
   let responseCompleted = false;
   // P0-2: the side-effect op currently in flight (at most one — the loop runs
   // tools serially). Non-null only between a dangerous tool's tool-executing
@@ -1223,6 +1224,7 @@ async function runTurn(
         }
         break;
       case "compaction-usage-unknown":
+        compactionUsageUnknown = compactionUsageUnknownDiagnostic(event);
         if (event.ledgerPersisted !== true) {
           persistUsageEvent?.({
             ...event,
@@ -1282,7 +1284,52 @@ async function runTurn(
   ) {
     sideEffects.persist();
   }
-  return { finalText, endReason, usage, toolCalls };
+  return { finalText, endReason, usage, toolCalls, compactionUsageUnknown };
+}
+
+function compactionUsageUnknownDiagnostic(event) {
+  const reason =
+    event?.reason === "provider_usage_not_reported"
+      ? "provider_usage_not_reported"
+      : "provider_transport_outcome_unknown";
+  const providerError = event?.providerError;
+  const providerHints = {
+    authentication:
+      "Provider authentication failed; check the API credentials.",
+    access_denied: "Provider access was denied; check model permissions.",
+    rate_limit: "The provider rate limit was reached; wait before resuming.",
+    server_error:
+      "The provider returned a server error; check service availability.",
+    http_error:
+      "The provider rejected the compaction request; check the model endpoint.",
+    network: "The model connection failed; check network and proxy settings.",
+    invalid_response:
+      "The provider returned an invalid response; check API compatibility.",
+    unknown: "The provider request failed.",
+  };
+  const category = providerError?.category;
+  const projected = Object.hasOwn(providerHints, category || "")
+    ? {
+        category,
+        ...(Number.isInteger(providerError.httpStatus) &&
+        providerError.httpStatus >= 400 &&
+        providerError.httpStatus <= 599
+          ? { httpStatus: providerError.httpStatus }
+          : {}),
+      }
+    : null;
+  return {
+    code: "CC_COMPACTION_USAGE_UNKNOWN",
+    usage_unknown_reason: reason,
+    ...(projected ? { provider_error: projected } : {}),
+    error:
+      (reason === "provider_usage_not_reported"
+        ? "Compaction provider did not report valid token usage"
+        : "Compaction request failed before provider usage could be confirmed") +
+      "; the session stopped without retrying the request. " +
+      (projected ? providerHints[category] + " " : "") +
+      "Review the saved session and provider usage, check the model connection, then resume explicitly.",
+  };
 }
 
 /**
@@ -3821,6 +3868,31 @@ async function runAgentHeadlessStreamInWorkspace(
         { code: "CC_SESSION_TOOL_ROUND_SETTLEMENT_HEAD_UNKNOWN" },
       );
     }
+    // Only a new, acknowledged tool_round has item positions to associate
+    // with live IDE output. A no-op settlement returns an existing head only.
+    if (appended.event?.type === "tool_round") {
+      const items = appended.event.data.messages.map((message, itemIndex) => ({
+        itemIndex,
+        role: message.role,
+        toolCallId:
+          message.role === "assistant"
+            ? message.tool_calls[0].id
+            : message.tool_call_id,
+      }));
+      for (let offset = 0; offset < items.length; offset += 100) {
+        emit({
+          type: "system",
+          subtype: "tool_round_persisted",
+          session_id: sessionId,
+          transcript_refs: {
+            schema: "chainlesschain.session-tool-round-references/v1",
+            sessionId,
+            eventId: appended.hash,
+            items: items.slice(offset, offset + 100),
+          },
+        });
+      }
+    }
     return appended;
   };
   const settleToolRoundsForHost = (phase, clientMessageId = null) => {
@@ -3873,6 +3945,7 @@ async function runAgentHeadlessStreamInWorkspace(
     return settleToolRoundsForHost(phase);
   };
   const loopOptionsBase = {
+    contextMemoryModelWindowTokens: options.contextMemoryModelWindowTokens,
     ...(evolutionIngress === null ? {} : { evolutionIngress }),
     reviewChanges: options.reviewChanges === true,
     model,
@@ -4851,9 +4924,11 @@ async function runAgentHeadlessStreamInWorkspace(
             type: "result",
             subtype: "error_compaction_usage_unknown",
             is_error: true,
-            code: "CC_COMPACTION_USAGE_UNKNOWN",
-            error:
-              "Compaction provider usage is unknown; the paid compaction is not retried",
+            ...compactionUsageUnknownDiagnostic(
+              compatibilityResult?.usageUnknownEvent || {
+                reason: "provider_transport_outcome_unknown",
+              },
+            ),
             session_id: sessionId,
           });
           sawError = true;
@@ -4905,9 +4980,7 @@ async function runAgentHeadlessStreamInWorkspace(
           type: "result",
           subtype: "error_compaction_usage_unknown",
           is_error: true,
-          code: "CC_COMPACTION_USAGE_UNKNOWN",
-          error:
-            "Compaction provider usage is unknown; the paid compaction is not retried",
+          ...compactionUsageUnknownDiagnostic(usageUnknownEvent),
           session_id: sessionId,
           ...(costBudget ? { budget_state: "unverifiable" } : {}),
         });
@@ -5908,9 +5981,8 @@ async function runAgentHeadlessStreamInWorkspace(
         type: "result",
         subtype: "error_compaction_usage_unknown",
         is_error: true,
-        code: "CC_COMPACTION_USAGE_UNKNOWN",
-        error:
-          "Compaction provider usage is unknown; the paid compaction is not retried",
+        ...(outcome.compactionUsageUnknown ||
+          compactionUsageUnknownDiagnostic(null)),
         session_id: sessionId,
         turn: turns,
         usage: outcome.usage,

package/src/runtime/message-roles.js

@@ -166,6 +166,34 @@ export function createResumeRoleProjection(messages) {
   return projection;
 }
 
+/** Capture the original user sources needed by an owned resume merge. */
+export function getTaskCompactionBindings(projection, input, taskBinding) {
+  if (!taskBinding) return [];
+  const owned = RESUME_ROLE_PROJECTIONS.get(projection);
+  const capture = (binding) => ({
+    ...binding,
+    matchCount: input.filter((message) =>
+      isDeepStrictEqual(message, binding.message),
+    ).length,
+  });
+  if (!owned) return [capture(taskBinding)];
+  const sourceIndex = input.indexOf(taskBinding.original);
+  const group = owned(input).sources.find((indices) =>
+    indices.includes(sourceIndex),
+  );
+  return (group || [sourceIndex]).map((index) => {
+    if (index === sourceIndex) return capture(taskBinding);
+    const original = input[index];
+    return capture({
+      original,
+      message: JSON.parse(canonicalJson(original)),
+      allowContentRelocation:
+        input.filter((message) => isDeepStrictEqual(message, original))
+          .length === 1,
+    });
+  });
+}
+
 /**
  * Preserve a bound task through this module's exact, captured resume merges.
  * Arbitrary callbacks, wrappers and forged properties never receive lineage.

package/src/runtime/policies/agent-policy.js

@@ -23,6 +23,7 @@ export function resolveAgentPolicy({
 
   return {
     model: connection.model || defaults.model || "qwen2:7b",
+    contextMemoryModelWindowTokens: overrides.contextMemoryModelWindowTokens,
     visionModel: overrides.visionModel,
     provider: connection.provider,
     baseUrl: connection.baseUrl,