chainlesschain 0.166.135 → 0.166.138

package/src/lib/context-memory-kernel/task-worklog-port.js

@@ -1,6 +1,7 @@
 import fs from "node:fs";
 import path from "node:path";
 import { randomUUID } from "node:crypto";
+import { renameWithRetry } from "../config-manager.js";
 import { redactSecretsInText } from "../ide-context-redaction.js";
 import {
   diagnosticExcerpt,
@@ -437,6 +438,11 @@ export class TaskWorklog {
 function writeProjection(cwd, sessionId, markdown) {
   const file = worklogPath(cwd, sessionId, true);
   const temporary = file + "." + randomUUID() + ".tmp";
+  let writeError;
+  const validatePath = () => {
+    if (worklogPath(cwd, sessionId) !== file)
+      throw new Error("Worklog workspace path changed while saving");
+  };
   try {
     const fd = fs.openSync(temporary, "wx", 0o600);
     try {
@@ -445,9 +451,26 @@ function writeProjection(cwd, sessionId, markdown) {
     } finally {
       fs.closeSync(fd);
     }
-    worklogPath(cwd, sessionId);
-    fs.renameSync(temporary, file);
+    // Windows readers can briefly lock the existing projection. Retry only
+    // the atomic replacement, rechecking directory/link boundaries each time.
+    renameWithRetry(temporary, file, {
+      attempts: process.platform === "win32" ? 8 : 1,
+      _rename: (source, target) => {
+        validatePath();
+        fs.renameSync(source, target);
+      },
+    });
+  } catch (error) {
+    writeError = error;
+    throw error;
   } finally {
-    if (fs.existsSync(temporary)) fs.unlinkSync(temporary);
+    try {
+      validatePath();
+      if (fs.existsSync(temporary)) fs.unlinkSync(temporary);
+    } catch (error) {
+      // Never follow a redirected directory to clean up, or hide the original
+      // write failure behind a second transient lock on its temporary file.
+      if (!writeError) throw error;
+    }
   }
 }

package/src/lib/evolution/evidence-json-text.js

@@ -1,3 +1,5 @@
+import { parse as parseSource, parseExpressionAt, tokenizer } from "acorn";
+
 // Decode data only: no evaluation, revivers, prototype setters or permissive
 // JSON repair. Budgets belong to the entire projection, including nested text.
 export const EVIDENCE_JSON_POLICY = Object.freeze({
@@ -177,6 +179,7 @@ export function createEvidenceJsonTextBoundary(
   policy = EVIDENCE_JSON_POLICY,
 ) {
   let nodes = 0;
+  let sourceTokens = 0;
   let bytes = 0;
   const PARSE_FAILURE = Symbol("evidence-json-parse-failure");
   const reject = (
@@ -303,7 +306,11 @@ export function createEvidenceJsonTextBoundary(
   const parser = (
     text,
     start,
-    { allowSingleQuotedStrings = false, allowSourceExpressions = false } = {},
+    {
+      allowSingleQuotedStrings = false,
+      allowSourceExpressions = false,
+      allowSourceLiteralSyntax = false,
+    } = {},
   ) => {
     let index = start;
     const whitespace = () => {
@@ -405,9 +412,36 @@ export function createEvidenceJsonTextBoundary(
           }
           index++;
           whitespace();
+          if (text[index] === end) {
+            if (!allowSourceLiteralSyntax) parserReject("trailing-comma");
+            index++;
+            return output;
+          }
         }
         return parserReject("syntax");
       }
+      // JavaScript numeric separators/radices are never JSON syntax. Admit
+      // them only in a container independently proven by the source parser.
+      const sourceNumber =
+        /^[+-]?(?:0[xX][0-9a-fA-F_]+|0[bB][01_]+|0[oO][0-7_]+|[0-9][0-9_]*(?:\.[0-9_]*)?(?:[eE][+-]?[0-9_]+)?)/u.exec(
+          text.slice(index),
+        )?.[0];
+      if (
+        sourceNumber &&
+        (sourceNumber.includes("_") || /^[+-]?0[xXbBoO]/u.test(sourceNumber))
+      ) {
+        if (!allowSourceLiteralSyntax) parserReject("source-number");
+        const unsigned = sourceNumber.replace(/^[+-]/u, "").replaceAll("_", "");
+        const number =
+          (sourceNumber.startsWith("-") ? -1 : 1) * Number(unsigned);
+        if (
+          !Number.isFinite(number) ||
+          (Number.isInteger(number) && !Number.isSafeInteger(number))
+        )
+          parserReject("budget");
+        index += sourceNumber.length;
+        return number;
+      }
       const token =
         /^(?:true|false|null|-?(?:0|[1-9]\d*)(?:\.\d+)?(?:[eE][+-]?\d+)?)/u.exec(
           text.slice(index),
@@ -460,6 +494,7 @@ export function createEvidenceJsonTextBoundary(
       layer = 0,
       objectOnly = false,
       codeText = false,
+      sourceText = false,
       pythonFString = false,
       fencedCodeLanguages = null,
       visit,
@@ -478,6 +513,7 @@ export function createEvidenceJsonTextBoundary(
           output += scanText(text.slice(start, end), {
             ...options,
             codeText: true,
+            sourceText: layer === 0,
           });
           offset = end;
         }
@@ -516,6 +552,214 @@ export function createEvidenceJsonTextBoundary(
           "Agent model code expression under an opaque source context cannot be safely projected",
         ),
     );
+    // Source syntax is a separate, explicit boundary. A paired tool's decoded
+    // string values do not inherit it. JSON-shaped standalone expressions still
+    // require strict JSON, even when they happen to parse as JavaScript arrays.
+    let sourceRanges;
+    let sourceBindings;
+    let tokenStarts;
+    let containerEnds;
+    let interpolationStarts;
+    const sourceOptions = {
+      ecmaVersion: "latest",
+      sourceType: "module",
+      allowReturnOutsideFunction: true,
+    };
+    const sourceContainer = (start) => {
+      if (
+        !sourceText ||
+        !codeText ||
+        policy.sourceLiteralPolicy !== "explicit-source-containers-v1"
+      )
+        return null;
+      const explicit = new Set([
+        "VariableDeclarator",
+        "FunctionDeclaration",
+        "FunctionExpression",
+        "ArrowFunctionExpression",
+        "CallExpression",
+        "NewExpression",
+        "MemberExpression",
+        "AssignmentExpression",
+        "ReturnStatement",
+      ]);
+      const bindingNames = (root) => {
+        const names = [];
+        const pending = [root];
+        while (pending.length) {
+          const node = pending.pop();
+          if (!node || typeof node.type !== "string") continue;
+          if (
+            (node.type === "MemberExpression" || node.type === "Property") &&
+            node.computed
+          )
+            return null;
+          if (["Identifier", "PrivateIdentifier"].includes(node.type))
+            names.push(node.name);
+          if (node.type === "Literal" && typeof node.value === "string")
+            names.push(node.value);
+          for (const child of Object.values(node)) {
+            if (Array.isArray(child)) pending.push(...child);
+            else if (child && typeof child === "object") pending.push(child);
+          }
+        }
+        return names;
+      };
+      const collect = (root, admitted = false, bindings = null) => {
+        const provenAncestry = bindings !== null;
+        const stack = [[root, admitted, bindings]];
+        while (stack.length) {
+          const [node, parentSource, parentBindings] = stack.pop();
+          if (!node || typeof node.type !== "string") continue;
+          const isSource = parentSource || explicit.has(node.type);
+          let ownBindings = [];
+          if (node.type === "VariableDeclarator")
+            ownBindings = bindingNames(node.id);
+          if (["AssignmentExpression", "AssignmentPattern"].includes(node.type))
+            ownBindings = bindingNames(node.left);
+          if (
+            ["Property", "PropertyDefinition", "MethodDefinition"].includes(
+              node.type,
+            )
+          )
+            ownBindings = node.computed ? null : bindingNames(node.key);
+          const activeBindings =
+            parentBindings && ownBindings
+              ? [...parentBindings, ...ownBindings]
+              : null;
+          if (
+            isSource &&
+            ["ArrayExpression", "ObjectExpression"].includes(node.type)
+          ) {
+            sourceRanges.set(node.start, node.end);
+            if (provenAncestry) sourceBindings.set(node.start, activeBindings);
+          }
+          if (node.type === "TemplateLiteral" && provenAncestry) {
+            for (const quasi of node.quasis.slice(0, -1))
+              sourceBindings.set(quasi.end + 1, activeBindings);
+          }
+          for (const value of Object.values(node)) {
+            if (Array.isArray(value))
+              for (const child of value)
+                stack.push([child, isSource, activeBindings]);
+            else if (value && typeof value === "object")
+              stack.push([value, isSource, activeBindings]);
+          }
+        }
+      };
+      if (!sourceRanges) {
+        sourceRanges = new Map();
+        sourceBindings = new Map();
+        tokenStarts = new Set();
+        containerEnds = new Map();
+        interpolationStarts = new Set();
+        const templates = [];
+        const delimiters = [];
+        let completePrefixEnd = 0;
+        try {
+          for (const token of tokenizer(text, sourceOptions)) {
+            if (++sourceTokens > (policy.maxSourceTokens ?? policy.maxNodes))
+              parserReject("budget");
+            tokenStarts.add(token.start);
+            const label = token.type.label;
+            if (label === "`") {
+              if (templates.at(-1)?.inText) templates.pop();
+              else templates.push({ start: token.start, inText: true });
+            }
+            if (label === "${" && templates.length) {
+              templates.at(-1).inText = false;
+            }
+            if (["[", "{", "${", "("].includes(label)) {
+              delimiters.push(token);
+              if (label === "${") interpolationStarts.add(token.start);
+            } else if (["]", "}", ")"].includes(label)) {
+              const opening = delimiters.pop();
+              if (
+                opening?.type.label === "${" &&
+                label === "}" &&
+                templates.length
+              )
+                templates.at(-1).inText = true;
+              if (
+                opening &&
+                ((opening.type.label === "[" && label === "]") ||
+                  (opening.type.label === "(" && label === ")") ||
+                  (["{", "${"].includes(opening.type.label) && label === "}"))
+              )
+                containerEnds.set(opening.start, token.end);
+            }
+            if (
+              delimiters.length === 0 &&
+              templates.length === 0 &&
+              [";", "}"].includes(label)
+            )
+              completePrefixEnd = token.end;
+          }
+        } catch (error) {
+          if (error?.[PARSE_FAILURE]) throw error;
+          tokenStarts.clear();
+          interpolationStarts.clear();
+          return null;
+        }
+        try {
+          collect(parseSource(text, sourceOptions), false, []);
+        } catch {
+          // A page may end inside a later statement. A fully parsed top-level
+          // prefix still proves the ancestors of earlier complete constructs.
+          // Try only one tokenizer-bounded prefix; partial/unproven constructs
+          // retain the conservative source-prefix checks.
+          if (completePrefixEnd > 0 && completePrefixEnd < text.length) {
+            try {
+              collect(
+                parseSource(text.slice(0, completePrefixEnd), sourceOptions),
+                false,
+                [],
+              );
+            } catch {
+              /* No complete program prefix was proven. */
+            }
+          }
+        }
+      }
+      if (!sourceRanges.has(start) && tokenStarts.has(start)) {
+        try {
+          const end = containerEnds.get(start);
+          if (!end) return null;
+          const expression = parseExpressionAt(
+            text.slice(0, end),
+            start,
+            sourceOptions,
+          );
+          // A complete member/call expression proves source syntax itself.
+          // A declaration prefix can also prove a complete literal on a page
+          // whose later statements are incomplete. Comments/strings cannot
+          // nominate starts: only tokenizer-confirmed source tokens qualify.
+          const declared =
+            /(?:^|[;\n])\s*(?:const|let|var)\s+[$_A-Za-z][$_A-Za-z0-9]*\s*=\s*$/u.test(
+              text.slice(0, start),
+            );
+          const iteration =
+            /(?:^|[;\n])\s*for\s*\(\s*(?:const|let|var)\s+[$_A-Za-z][$_A-Za-z0-9]*\s+of\s*$/u.test(
+              text.slice(0, start),
+            );
+          const member = /^\s*\.\s*[$_A-Za-z][$_A-Za-z0-9]*/u.exec(
+            text.slice(end),
+          );
+          if (member) {
+            const memberExpression = parseExpressionAt(
+              text.slice(0, end + member[0].length),
+              start,
+              sourceOptions,
+            );
+            collect(memberExpression);
+          }
+          collect(expression, declared || iteration);
+        } catch {
+          /* No complete, explicit source expression. */
+        }
+      }
+      return sourceRanges.get(start) ?? null;
+    };
     if (objectOnly) {
       const reader = parser(text, 0);
       let parsed;
@@ -543,6 +787,43 @@ export function createEvidenceJsonTextBoundary(
     let plainStart = 0;
     for (let index = 0; index < text.length; ) {
       const char = text[index];
+      // A tokenizer-proven template interpolation is source punctuation,
+      // not a JSON object. Its complete expression must parse independently;
+      // the normal scanner still visits all literals inside it.
+      if (
+        sourceText &&
+        codeText &&
+        char === "{" &&
+        text[index - 1] === "$" &&
+        ['"', "'"].includes(text.slice(index + 1).trimStart()[0]) &&
+        policy.sourceLiteralPolicy === "explicit-source-containers-v1"
+      ) {
+        sourceContainer(index);
+        const end = containerEnds?.get(index - 1);
+        if (interpolationStarts?.has(index - 1) && end) {
+          try {
+            const expression = parseExpressionAt(
+              text.slice(0, end - 1),
+              index + 1,
+              sourceOptions,
+            );
+            if (text.slice(expression.end, end - 1).trim() === "") {
+              const bindings = sourceBindings.get(index);
+              if (!bindings)
+                reject(
+                  "Agent model code expression under an opaque source context cannot be safely projected",
+                );
+              bindings.forEach(requireSafeSourceKey);
+              index++;
+              continue;
+            }
+          } catch (error) {
+            // Projection failures must propagate; only Acorn syntax failures
+            // may fall back to the strict scanner.
+            if (!(error instanceof SyntaxError)) throw error;
+          }
+        }
+      }
       const next =
         char === "{" || char === "["
           ? text.slice(index + 1).match(/^\s*(.)/u)?.[1]
@@ -652,7 +933,7 @@ export function createEvidenceJsonTextBoundary(
         index++;
         continue;
       }
-      const reader = parser(text, index, {
+      let reader = parser(text, index, {
         // A recognized container is always tried as strict JSON first, even
         // inside code. Only an explicit non-JSON token allows literal scanning.
         allowSingleQuotedStrings: codeText && !container,
@@ -667,21 +948,50 @@ export function createEvidenceJsonTextBoundary(
         valueEnd = reader.end();
       } catch (error) {
         const kind = error?.[PARSE_FAILURE];
-        if (
-          !codeText ||
-          !["code-expression", "source-expression"].includes(kind)
-        )
-          rejectParseFailure(error);
-        if (kind === "source-expression") {
-          requireSafeSourceAssignments(index);
+        let sourceEnd = null;
+        if (["trailing-comma", "source-number"].includes(kind)) {
+          try {
+            sourceEnd = sourceContainer(index);
+          } catch (sourceError) {
+            rejectParseFailure(sourceError);
+          }
+        }
+        if (sourceEnd !== null) {
+          const bindings = sourceBindings.get(index);
+          if (sourceBindings.has(index)) {
+            if (!bindings)
+              reject(
+                "Agent model code expression under an opaque source context cannot be safely projected",
+              );
+            bindings.forEach(requireSafeSourceKey);
+          } else requireSafeSourceAssignments(index);
           const key = assignmentKeyBefore(text, plainStart, index);
           if (key) requireSafeSourceKey(key);
+          reader = parser(text, index, { allowSourceLiteralSyntax: true });
+          try {
+            parsed = reader.value();
+            valueEnd = reader.end();
+          } catch (sourceError) {
+            rejectParseFailure(sourceError);
+          }
+          if (valueEnd !== sourceEnd) reject();
+        } else {
+          if (
+            !codeText ||
+            !["code-expression", "source-expression"].includes(kind)
+          )
+            rejectParseFailure(error);
+          if (kind === "source-expression") {
+            requireSafeSourceAssignments(index);
+            const key = assignmentKeyBefore(text, plainStart, index);
+            if (key) requireSafeSourceKey(key);
+          }
+          // Python/JavaScript containers may contain single quotes or expressions.
+          // Scan their literals individually, preserving nested strict JSON scans.
+          // Keep consumed nodes charged so repeated fallback cannot reset budgets.
+          index++;
+          continue;
         }
-        // Python/JavaScript containers may contain single quotes or expressions.
-        // Scan their literals individually, preserving nested strict JSON scans.
-        // Keep consumed nodes charged so repeated fallback cannot reset budgets.
-        index++;
-        continue;
       }
       reader.whitespace();
       let pair = quoted && text[reader.end()] === ":";

package/src/lib/evolution/evolution-evidence-projector.js

@@ -614,7 +614,7 @@ export const EVOLUTION_AGENT_MODEL_PROJECTION_RULESET_V7_DIGEST = `sha256:${crea
     "utf8",
   )
   .digest("hex")}`;
-const AGENT_MODEL_RULESET = Object.freeze({
+const AGENT_MODEL_RULESET_V8 = Object.freeze({
   ...AGENT_MODEL_RULESET_V7,
   schema: "chainlesschain.evolution-agent-model-projection-rules/v8",
   version: 8,
@@ -624,6 +624,25 @@ const AGENT_MODEL_RULESET = Object.freeze({
     sourceExpressionPolicy: "bounded-source-tokens-v1",
   }),
 });
+export const EVOLUTION_AGENT_MODEL_PROJECTION_RULESET_V8_DIGEST = `sha256:${createHash(
+  "sha256",
+)
+  .update(
+    `${AGENT_MODEL_RULESET_V8.schema}\0${JSON.stringify(AGENT_MODEL_RULESET_V8)}`,
+    "utf8",
+  )
+  .digest("hex")}`;
+const AGENT_MODEL_RULESET = Object.freeze({
+  ...AGENT_MODEL_RULESET_V8,
+  schema: "chainlesschain.evolution-agent-model-projection-rules/v9",
+  version: 9,
+  jsonTextPolicy: Object.freeze({
+    ...AGENT_MODEL_RULESET_V8.jsonTextPolicy,
+    version: 6,
+    sourceLiteralPolicy: "explicit-source-containers-v1",
+    maxSourceTokens: 32768,
+  }),
+});
 export const EVOLUTION_AGENT_MODEL_PROJECTION_RULESET_DIGEST = `sha256:${createHash(
   "sha256",
 )
@@ -659,6 +678,7 @@ const SUPPORTED_RULESETS = new Map([
   [EVOLUTION_AGENT_MODEL_PROJECTION_RULESET_V5_DIGEST, AGENT_MODEL_RULESET_V5],
   [EVOLUTION_AGENT_MODEL_PROJECTION_RULESET_V6_DIGEST, AGENT_MODEL_RULESET_V6],
   [EVOLUTION_AGENT_MODEL_PROJECTION_RULESET_V7_DIGEST, AGENT_MODEL_RULESET_V7],
+  [EVOLUTION_AGENT_MODEL_PROJECTION_RULESET_V8_DIGEST, AGENT_MODEL_RULESET_V8],
   [EVOLUTION_AGENT_MODEL_PROJECTION_RULESET_DIGEST, AGENT_MODEL_RULESET],
 ]);
 
@@ -734,6 +754,7 @@ const AGENT_VALUE_PATTERNS = Object.freeze([
 function valuePatterns(ruleset) {
   return ruleset === SKILL_DECISION_RULESET ||
     ruleset === AGENT_MODEL_RULESET ||
+    ruleset === AGENT_MODEL_RULESET_V8 ||
     ruleset === AGENT_MODEL_RULESET_V7 ||
     ruleset === AGENT_MODEL_RULESET_V6 ||
     ruleset === AGENT_MODEL_RULESET_V5 ||
@@ -1459,6 +1480,43 @@ function isAgentCodeTextPath(payload, path, resultToolNames) {
   return false;
 }
 
+// Unlike historical codeText literal scanning, source grammar is confined to
+// exact paired-tool source fields. A second $json descent is ordinary data.
+function isAgentSourceTextPath(payload, path, resultToolNames) {
+  if (!isAgentCodeTextPath(payload, path, resultToolNames)) return false;
+  const message = payload.messages[Number(path[1])];
+  if (path[2] === "tool_calls") {
+    const fields = path.slice(6);
+    if (fields[0] === "$json") fields.shift();
+    return fields.length === 1 && fields[0] === "code";
+  }
+  const calls = payload.messages.flatMap((candidate) =>
+    candidate?.role === "assistant" && Array.isArray(candidate.tool_calls)
+      ? candidate.tool_calls.filter((call) => call?.id === message.tool_call_id)
+      : [],
+  );
+  if (calls.length !== 1) return false;
+  const tool = calls[0].function?.name;
+  const fields = path.slice(3);
+  if (fields[0] === "$json") fields.shift();
+  if (fields.includes("$json")) return false;
+  if (tool === "search_files")
+    return (
+      fields.length === 3 &&
+      fields[0] === "matches" &&
+      /^\d+$/u.test(fields[1]) &&
+      ["context", "text"].includes(fields[2])
+    );
+  const sourceFields = {
+    read_file: ["content"],
+    run_code: ["output"],
+    run_shell: ["stdout", "stderr"],
+    check_shell: ["stdout", "stderr"],
+    git: ["stdout", "stderr"],
+  };
+  return fields.length === 1 && (sourceFields[tool] || []).includes(fields[0]);
+}
+
 function sanitizePayload(
   payload,
   ruleset = RULESET,
@@ -1489,6 +1547,7 @@ function sanitizePayload(
     const toolArguments = jsonText && isAgentToolArgumentsPath(path);
     const opaqueTransportBlock =
       ruleset === AGENT_MODEL_RULESET ||
+      ruleset === AGENT_MODEL_RULESET_V8 ||
       ruleset === AGENT_MODEL_RULESET_V7 ||
       ruleset === AGENT_MODEL_RULESET_V6 ||
       ruleset === AGENT_MODEL_RULESET_V5 ||
@@ -1515,6 +1574,11 @@ function sanitizePayload(
         layer,
         objectOnly: toolArguments,
         codeText: codeText || textContext?.pythonFString === true,
+        sourceText: isAgentSourceTextPath(
+          payload,
+          path,
+          ruleset.codeTextResultTools,
+        ),
         pythonFString: textContext?.pythonFString === true,
         // Only direct message text can contain Markdown code examples. Tool
         // arguments and recursively decoded strings keep their existing rules.
@@ -3385,6 +3449,7 @@ function validateBundleIntegrity(bundle) {
     }
     if (
       ruleset === AGENT_MODEL_RULESET ||
+      ruleset === AGENT_MODEL_RULESET_V8 ||
       ruleset === AGENT_MODEL_RULESET_V7 ||
       ruleset === AGENT_MODEL_RULESET_V6 ||
       ruleset === AGENT_MODEL_RULESET_V5 ||
@@ -3397,6 +3462,7 @@ function validateBundleIntegrity(bundle) {
         allowStructuredArgumentText: ruleset !== AGENT_MODEL_RULESET_V1,
         allowOpaqueTransportBlocks:
           ruleset === AGENT_MODEL_RULESET ||
+          ruleset === AGENT_MODEL_RULESET_V8 ||
           ruleset === AGENT_MODEL_RULESET_V7 ||
           ruleset === AGENT_MODEL_RULESET_V6 ||
           ruleset === AGENT_MODEL_RULESET_V5 ||