chainlesschain 0.162.181 → 0.162.182

package/src/gateways/ws/ws-server.js

@@ -114,6 +114,7 @@ import {
   handleArtifactShow,
 } from "./artifact-protocol.js";
 import { executionBroker } from "../../lib/process-execution-broker/index.js";
+import { collectWorkspacePluginBinSandboxPolicy } from "../../lib/plugin-runtime/bin.js";
 
 export const _deps = {
   spawn: (...args) => executionBroker.spawn(...args),
@@ -1215,7 +1216,15 @@ export class ChainlessChainWSServer extends EventEmitter {
     if (this._taskManager) return this._taskManager;
     const { BackgroundTaskManager } =
       await import("../../harness/background-task-manager.js");
-    this._taskManager = new BackgroundTaskManager({ recoverOnStart: true });
+    this._taskManager = new BackgroundTaskManager({
+      recoverOnStart: true,
+      policyCwd: this.projectRoot,
+      resolveSandboxPolicy: ({ workspaceCwd, executionCwd }) =>
+        collectWorkspacePluginBinSandboxPolicy({
+          workspaceCwd,
+          executionCwd,
+        }),
+    });
     this._subscribeTaskNotifications();
     return this._taskManager;
   }

package/src/harness/background-task-manager.js

@@ -9,7 +9,7 @@
  */
 
 import { existsSync, mkdirSync, appendFileSync, readFileSync } from "node:fs";
-import { join } from "node:path";
+import { join, resolve } from "node:path";
 import { createHash } from "node:crypto";
 import { EventEmitter } from "node:events";
 import { getHomeDir } from "../lib/paths.js";
@@ -42,9 +42,55 @@ const RECOVERABLE_TASK_STATUSES = new Set([
   TaskStatus.RUNNING,
 ]);
 
+function validatePinnedSandboxPolicy(policy) {
+  if (policy == null) return null;
+  if (
+    typeof policy !== "object" ||
+    Array.isArray(policy) ||
+    typeof policy.then === "function" ||
+    !Array.isArray(policy.requiredBoundaries) ||
+    policy.requiredBoundaries.length === 0 ||
+    policy.requiredBoundaries.some(
+      (boundary) => typeof boundary !== "string" || boundary.length === 0,
+    ) ||
+    !Object.isFrozen(policy) ||
+    !Object.isFrozen(policy.requiredBoundaries)
+  ) {
+    const error = new TypeError("invalid_background_task_sandbox_policy");
+    error.code = "ERR_BACKGROUND_TASK_SANDBOX_POLICY_INVALID";
+    error.sandboxReason = "invalid_background_task_sandbox_policy";
+    error.sandboxFailClosed = true;
+    throw error;
+  }
+  return policy;
+}
+
+function createUnsupportedSandboxError(sandboxPolicy) {
+  const requiredBoundaries = [...sandboxPolicy.requiredBoundaries];
+  const error = new Error(
+    `Background tasks cannot run without their required sandbox boundaries: ${requiredBoundaries.join(", ")}`,
+  );
+  error.code = "ERR_BACKGROUND_TASK_SANDBOX_UNSUPPORTED";
+  error.sandboxReason = "background_execution_unsupported";
+  error.sandboxFailClosed = true;
+  error.requiredBoundaries = requiredBoundaries;
+  error.actualGuarantees = [];
+  error.missingBoundaries = [...requiredBoundaries];
+  error.sandboxBackend = null;
+  error.sandboxCandidateBackend = null;
+  return error;
+}
+
 export class BackgroundTaskManager extends EventEmitter {
   constructor(options = {}) {
     super();
+    const resolveSandboxPolicy = options.resolveSandboxPolicy ?? null;
+    if (
+      resolveSandboxPolicy !== null &&
+      typeof resolveSandboxPolicy !== "function"
+    ) {
+      throw new TypeError("resolveSandboxPolicy must be a function or null");
+    }
     this.maxConcurrent = options.maxConcurrent || 3;
     this.heartbeatTimeout = options.heartbeatTimeout || 60000;
     this.historyLimit = options.historyLimit || 50;
@@ -54,6 +100,10 @@ export class BackgroundTaskManager extends EventEmitter {
       `${process.pid}@${process.platform}`;
     this.recoveryPolicy = options.recoveryPolicy || "claim-stale";
     this.staleNodeTimeout = options.staleNodeTimeout || 5 * 60 * 1000;
+    this._policyCwd = resolveSandboxPolicy
+      ? resolve(options.policyCwd || process.cwd())
+      : null;
+    this._resolveSandboxPolicy = resolveSandboxPolicy;
     this.tasks = new Map();
     this.processes = new Map();
     this._checkInterval = null;
@@ -72,12 +122,15 @@ export class BackgroundTaskManager extends EventEmitter {
       );
     }
 
+    const cwd = spec.cwd || process.cwd();
+    this._assertSandboxSupported(cwd);
+
     const id = `task-${Date.now()}-${createHash("sha256").update(Math.random().toString()).digest("hex").slice(0, 6)}`;
     const task = {
       id,
       type: spec.type || "shell",
       command: spec.command,
-      cwd: spec.cwd || process.cwd(),
+      cwd,
       description: spec.description || spec.command,
       status: TaskStatus.PENDING,
       createdAt: Date.now(),
@@ -111,6 +164,8 @@ export class BackgroundTaskManager extends EventEmitter {
       throw new Error(`Task ${taskId} is not pending (status: ${task.status})`);
     }
 
+    this._assertSandboxSupported(task.cwd);
+
     task.status = TaskStatus.RUNNING;
     task.startedAt = Date.now();
     task.lastHeartbeat = Date.now();
@@ -185,6 +240,19 @@ export class BackgroundTaskManager extends EventEmitter {
     return task;
   }
 
+  _assertSandboxSupported(executionCwd) {
+    if (!this._resolveSandboxPolicy) return;
+    const sandboxPolicy = validatePinnedSandboxPolicy(
+      this._resolveSandboxPolicy({
+        workspaceCwd: this._policyCwd,
+        executionCwd,
+      }),
+    );
+    if (sandboxPolicy) {
+      throw createUnsupportedSandboxError(sandboxPolicy);
+    }
+  }
+
   get(taskId) {
     return this.tasks.get(taskId) || null;
   }

package/src/harness/worktree-isolator.js

@@ -456,7 +456,11 @@ export function previewWorktreeMerge(repoDir, branchName, options = {}) {
 
   let mergeStarted = false;
   try {
-    gitExec(`merge ${baseBranch} --no-commit --no-ff`, worktree.path);
+    // Use argv form here rather than routing through a shell. Besides avoiding
+    // another quoting surface, this is important on Windows where a conflicted
+    // `git merge` followed immediately by another shell-wrapped git process can
+    // race the hosted runner's process/job cleanup and hide the unmerged index.
+    gitExecArgs(["merge", baseBranch, "--no-commit", "--no-ff"], worktree.path);
     mergeStarted = true;
 
     return {
@@ -713,7 +717,14 @@ function _hasBranchCommits(repoDir, branchName) {
 
 function _collectConflictFiles(repoDir) {
   try {
-    const output = gitExec("diff --name-only --diff-filter=U", repoDir);
+    // A conflict is expected to make the preceding merge exit non-zero. Query
+    // the index with a direct git argv invocation so Windows shell/process
+    // teardown cannot turn the authoritative conflict probe into an empty
+    // best-effort result.
+    const output = gitExecArgs(
+      ["diff", "--name-only", "--diff-filter=U"],
+      repoDir,
+    );
     return output
       .split("\n")
       .map((line) => line.trim())
@@ -988,7 +999,7 @@ function _resolveAutomationCandidate(type, filePath, branchName, candidateId) {
 
 function _abortMergeIfPresent(repoDir) {
   try {
-    gitExec("merge --abort", repoDir);
+    gitExecArgs(["merge", "--abort"], repoDir);
   } catch (_e) {
     // Ignore if there is no in-progress merge.
   }

package/src/lib/agent-core.js

@@ -12,6 +12,7 @@ export {
   getAgentToolDefinitions,
   getAgentToolDescriptors,
   getCachedPython,
+  _resetCachedPythonForTests,
   getEnvironmentInfo,
   _environmentProcessDeps,
   _agentToolProcessDeps,

package/src/lib/agent-schedule-store.js

@@ -48,6 +48,14 @@ function normalizeJitterMs(v) {
   return Number.isFinite(n) && n > 0 ? n : 0;
 }
 
+function normalizeMonitorWorkspaceCwd(value) {
+  if (value == null) return null;
+  if (typeof value !== "string" || value.length === 0) {
+    throw new Error("monitor workspaceCwd must be a non-empty string");
+  }
+  return path.resolve(value);
+}
+
 /**
  * A per-task execution policy for wakeup/cron entries — how the spawned
  * `cc agent` run should behave when this entry fires. Each field maps to a real
@@ -388,6 +396,7 @@ export class AgentScheduleStore {
 
   createMonitor({
     command,
+    workspaceCwd = null,
     watchFile = null,
     watchUrl = null,
     watchChange = false,
@@ -443,16 +452,22 @@ export class AgentScheduleStore {
     if (stopWhen != null) {
       // Validate the regex up-front so a bad pattern errors at creation, not
       // silently at the first check.
-      // eslint-disable-next-line no-new
+
       new RegExp(stopWhen);
     }
     const now = this._now();
     const source = hasFile ? "file" : hasUrl ? "http" : "command";
+    const normalizedWorkspaceCwd = hasCommand
+      ? normalizeMonitorWorkspaceCwd(workspaceCwd)
+      : null;
     const entry = {
       id: randomUUID(),
       kind: "monitor",
       source,
       command: hasCommand ? command : null,
+      ...(normalizedWorkspaceCwd
+        ? { workspaceCwd: normalizedWorkspaceCwd }
+        : {}),
       watchFile: hasFile ? watchFile : null,
       watchUrl: hasUrl ? watchUrl : null,
       watchChange: hasFile ? Boolean(watchChange) : false,
@@ -513,28 +528,36 @@ export class AgentScheduleStore {
     const now = atMs != null ? Number(atMs) : this._now();
     const ttl = Math.max(1000, Number(leaseMs) || 120000);
     this._ensureDir();
-    return withFileLock(path.join(this.dir, ".agenda-claims"), () => {
-      const claimed = [];
-      for (const kind of SCHEDULE_KINDS) {
-        const entries = this._readAll(kind);
-        let changed = false;
-        for (const entry of entries) {
-          if (!isSchedulableStatus(entry) || isEntryExpired(entry, now)) continue;
-          if (hasLiveExecutionLease(entry, now)) continue;
-          const fireAt = effectiveFireAt(entry);
-          if (fireAt == null || fireAt > now) continue;
-          entry.executionLease = {
-            owner: `${process.pid}:${randomUUID()}`,
-            claimedAt: now,
-            expiresAt: now + ttl,
-          };
-          claimed.push({ ...entry, executionLease: { ...entry.executionLease } });
-          changed = true;
+    return withFileLock(
+      path.join(this.dir, ".agenda-claims"),
+      () => {
+        const claimed = [];
+        for (const kind of SCHEDULE_KINDS) {
+          const entries = this._readAll(kind);
+          let changed = false;
+          for (const entry of entries) {
+            if (!isSchedulableStatus(entry) || isEntryExpired(entry, now))
+              continue;
+            if (hasLiveExecutionLease(entry, now)) continue;
+            const fireAt = effectiveFireAt(entry);
+            if (fireAt == null || fireAt > now) continue;
+            entry.executionLease = {
+              owner: `${process.pid}:${randomUUID()}`,
+              claimedAt: now,
+              expiresAt: now + ttl,
+            };
+            claimed.push({
+              ...entry,
+              executionLease: { ...entry.executionLease },
+            });
+            changed = true;
+          }
+          if (changed) this._writeAll(kind, entries);
         }
-        if (changed) this._writeAll(kind, entries);
-      }
-      return claimed;
-    }, { failIfUnavailable: true });
+        return claimed;
+      },
+      { failIfUnavailable: true },
+    );
   }
 
   /** Release a failed/aborted claim so a later runner can retry it. */

package/src/lib/hook-runner.js

@@ -35,8 +35,12 @@ function runHookProcessSync(file, argsOrOptions, maybeOptions) {
   });
 }
 
-runner._deps.run = runHookProcess;
-runner._deps.runSync = runHookProcessSync;
+export function _restoreProcessRunners() {
+  runner._deps.run = runHookProcess;
+  runner._deps.runSync = runHookProcessSync;
+}
+
+_restoreProcessRunners();
 
 export const {
   runCommandHook,

package/src/lib/packer/pkg-config-generator.js

@@ -385,7 +385,9 @@ export function generatePkgConfig(ctx) {
   const assets = [
     `${posixify(distDir)}/**/*`,
     `${posixify(templatesDir)}/**/*`,
-    `${posixify(cliRoot)}/src/lib/process-execution-broker/*.ps1`,
+    `${posixify(cliRoot)}/src/lib/process-execution-broker/windows-sandbox-helper.dll`,
+    `${posixify(cliRoot)}/src/lib/process-execution-broker/windows-sandbox-helper.exe`,
+    `${posixify(cliRoot)}/src/lib/process-execution-broker/windows-sandbox.cs`,
   ];
   if (prebuildsDir) assets.push(`${posixify(prebuildsDir)}/**/*`);
   // Project mode: bundle the collected .chainlesschain/ snapshot as an asset.