chai 4.3.7 → 4.3.9

package/CONTRIBUTING.md

@@ -21,7 +21,6 @@ Following these guidelines helps to communicate that you respect the time of the
 
 - Creating an Issue or Pull Request requires a [GitHub](http://github.com) account.
 - Issue reports should be **clear**, **concise** and **reproducible**. Check to see if your issue has already been resolved in the [master]() branch or already reported in Chai's [GitHub Issue Tracker](https://github.com/chaijs/chai/issues).
-- Pull Requests must adhere to strict [coding style guidelines](https://github.com/chaijs/chai/wiki/Chai-Coding-Style-Guide).
 - In general, avoid submitting PRs for new Assertions without asking core contributors first. More than likely it would be better implemented as a plugin.
 - Additional support is available via the [Google Group](http://groups.google.com/group/chaijs) or on irc.freenode.net#chaijs.
 - **IMPORTANT**: By submitting a patch, you agree to allow the project owner to license your work under the same license as that used by the project.
@@ -91,7 +90,7 @@ Good pull requests - patches, improvements, new features - are a fantastic help.
 
 **Please ask first** before embarking on any significant pull request (e.g. implementing features, refactoring code), otherwise you risk spending a lot of time working on something that the project's developers might not want to merge into the project.
 
-Please adhere to the coding conventions used throughout a project (indentation, accurate comments, etc.) and any other requirements (such as test coverage). Please review the [Chai.js Coding Style Guide](https://github.com/chaijs/chai/wiki/Chai-Coding-Style-Guide).
+Please adhere to the coding conventions used throughout a project (indentation, accurate comments, etc.) and any other requirements (such as test coverage).
 
 Follow this process if you'd like your work considered for inclusion in the project:
 
@@ -185,11 +184,6 @@ For most of the documentation you are going to want to visit [ChaiJS.com](http:/
 - [API Reference](http://chaijs.com/api/)
 - [Plugins](http://chaijs.com/plugins/)
 
-Alternatively, the [wiki](https://github.com/chaijs/chai/wiki) might be what you are looking for.
-
-- [Chai Coding Style Guide](https://github.com/chaijs/chai/wiki/Chai-Coding-Style-Guide)
-- [Third-party Resources](https://github.com/chaijs/chai/wiki/Third-Party-Resources)
-
 Or finally, you may find a core-contributor or like-minded developer in any of our support channels.
 
 - IRC: irc.freenode.org #chaijs

package/History.md

@@ -1,7 +1,7 @@
 ### Note
 
 As of 3.0.0, the History.md file has been deprecated. [Please refer to the full
-commit logs available on GitHub](https://github.com/chaijs/chai/commits/master).
+commit logs available on GitHub](https://github.com/chaijs/chai/commits).
 
 ---
 

package/chai.js

@@ -14,7 +14,7 @@ var used = [];
  * Chai version
  */
 
-exports.version = '4.3.3';
+exports.version = '4.3.8';
 
 /*!
  * Assertion Error
@@ -8608,6 +8608,7 @@ var config = require('../config');
  * messages or should be truncated.
  *
  * @param {Mixed} javascript object to inspect
+ * @returns {string} stringified object
  * @name objDisplay
  * @namespace Utils
  * @api public
@@ -9062,7 +9063,7 @@ var flag = require('./flag');
 /**
  * ### .test(object, expression)
  *
- * Test and object for expression.
+ * Test an object for expression.
  *
  * @param {Object} object (constructed Assertion)
  * @param {Arguments} chai.Assertion.prototype.assert arguments
@@ -9250,6 +9251,7 @@ AssertionError.prototype.toJSON = function (stack) {
  * MIT Licensed
  */
 
+var getFunctionName = require('get-func-name');
 /**
  * ### .checkError
  *
@@ -9329,34 +9331,6 @@ function compatibleMessage(thrown, errMatcher) {
   return false;
 }
 
-/**
- * ### .getFunctionName(constructorFn)
- *
- * Returns the name of a function.
- * This also includes a polyfill function if `constructorFn.name` is not defined.
- *
- * @name getFunctionName
- * @param {Function} constructorFn
- * @namespace Utils
- * @api private
- */
-
-var functionNameMatch = /\s*function(?:\s|\s*\/\*[^(?:*\/)]+\*\/\s*)*([^\(\/]+)/;
-function getFunctionName(constructorFn) {
-  var name = '';
-  if (typeof constructorFn.name === 'undefined') {
-    // Here we run a polyfill if constructorFn.name is not defined
-    var match = String(constructorFn).match(functionNameMatch);
-    if (match) {
-      name = match[1];
-    }
-  } else {
-    name = constructorFn.name;
-  }
-
-  return name;
-}
-
 /**
  * ### .getConstructorName(errorLike)
  *
@@ -9376,8 +9350,11 @@ function getConstructorName(errorLike) {
     // If `err` is not an instance of Error it is an error constructor itself or another function.
     // If we've got a common function we get its name, otherwise we may need to create a new instance
     // of the error just in case it's a poorly-constructed error. Please see chaijs/chai/issues/45 to know more.
-    constructorName = getFunctionName(errorLike).trim() ||
-        getFunctionName(new errorLike()); // eslint-disable-line new-cap
+    constructorName = getFunctionName(errorLike);
+    if (constructorName === '') {
+      var newConstructorName = getFunctionName(new errorLike()); // eslint-disable-line new-cap
+      constructorName = newConstructorName || constructorName;
+    }
   }
 
   return constructorName;
@@ -9415,7 +9392,7 @@ module.exports = {
   getConstructorName: getConstructorName,
 };
 
-},{}],35:[function(require,module,exports){
+},{"get-func-name":36}],35:[function(require,module,exports){
 'use strict';
 /* globals Symbol: false, Uint8Array: false, WeakMap: false */
 /*!
@@ -9810,8 +9787,15 @@ function getEnumerableKeys(target) {
   return keys;
 }
 
-function getNonEnumerableSymbols(target) {
-  var keys = Object.getOwnPropertySymbols(target);
+function getEnumerableSymbols(target) {
+  var keys = [];
+  var allKeys = Object.getOwnPropertySymbols(target);
+  for (var i = 0; i < allKeys.length; i += 1) {
+    var key = allKeys[i];
+    if (Object.getOwnPropertyDescriptor(target, key).enumerable) {
+      keys.push(key);
+    }
+  }
   return keys;
 }
 
@@ -9850,8 +9834,8 @@ function keysEqual(leftHandOperand, rightHandOperand, keys, options) {
 function objectEqual(leftHandOperand, rightHandOperand, options) {
   var leftHandKeys = getEnumerableKeys(leftHandOperand);
   var rightHandKeys = getEnumerableKeys(rightHandOperand);
-  var leftHandSymbols = getNonEnumerableSymbols(leftHandOperand);
-  var rightHandSymbols = getNonEnumerableSymbols(rightHandOperand);
+  var leftHandSymbols = getEnumerableSymbols(leftHandOperand);
+  var rightHandSymbols = getEnumerableSymbols(rightHandOperand);
   leftHandKeys = leftHandKeys.concat(leftHandSymbols);
   rightHandKeys = rightHandKeys.concat(rightHandSymbols);
 
@@ -9927,6 +9911,7 @@ function mapSymbols(arr) {
 
 var toString = Function.prototype.toString;
 var functionNameMatch = /\s*function(?:\s|\s*\/\*[^(?:*\/)]+\*\/\s*)*([^\s\(\/]+)/;
+var maxFunctionSourceLength = 512;
 function getFuncName(aFunc) {
   if (typeof aFunc !== 'function') {
     return null;
@@ -9934,8 +9919,15 @@ function getFuncName(aFunc) {
 
   var name = '';
   if (typeof Function.prototype.name === 'undefined' && typeof aFunc.name === 'undefined') {
+    // eslint-disable-next-line prefer-reflect
+    var functionSource = toString.call(aFunc);
+    // To avoid unconstrained resource consumption due to pathalogically large function names,
+    // we limit the available return value to be less than 512 characters.
+    if (functionSource.indexOf('(') > maxFunctionSourceLength) {
+      return name;
+    }
     // Here we run a polyfill if Function does not support the `name` property and if aFunc.name is not defined
-    var match = toString.call(aFunc).match(functionNameMatch);
+    var match = functionSource.match(functionNameMatch);
     if (match) {
       name = match[1];
     }
@@ -10331,9 +10323,15 @@ module.exports = getFuncName;
   }
 
   function inspectDate(dateObject, options) {
-    // If we need to - truncate the time portion, but never the date
-    var split = dateObject.toJSON().split('T');
-    var date = split[0];
+    var stringRepresentation = dateObject.toJSON();
+
+    if (stringRepresentation === null) {
+      return 'Invalid Date';
+    }
+
+    var split = stringRepresentation.split('T');
+    var date = split[0]; // If we need to - truncate the time portion, but never the date
+
     return options.stylize("".concat(date, "T").concat(truncate(split[1], options.truncate - date.length - 1)), 'date');
   }
 
@@ -10630,7 +10628,32 @@ module.exports = getFuncName;
     nodeInspect = false;
   }
 
-  var constructorMap = new WeakMap();
+  function FakeMap() {
+    // eslint-disable-next-line prefer-template
+    this.key = 'chai/loupe__' + Math.random() + Date.now();
+  }
+
+  FakeMap.prototype = {
+    // eslint-disable-next-line object-shorthand
+    get: function get(key) {
+      return key[this.key];
+    },
+    // eslint-disable-next-line object-shorthand
+    has: function has(key) {
+      return this.key in key;
+    },
+    // eslint-disable-next-line object-shorthand
+    set: function set(key, value) {
+      if (Object.isExtensible(key)) {
+        Object.defineProperty(key, this.key, {
+          // eslint-disable-next-line object-shorthand
+          value: value,
+          configurable: true
+        });
+      }
+    }
+  };
+  var constructorMap = new (typeof WeakMap === 'function' ? WeakMap : FakeMap)();
   var stringTagMap = {};
   var baseTypesMap = {
     undefined: function undefined$1(value, options) {
@@ -10764,6 +10787,11 @@ module.exports = getFuncName;
       } // If it is an object with an anonymous prototype, display it as an object.
 
 
+      return inspectObject(value, options);
+    } // last chance to check if it's an object
+
+
+    if (value === Object(value)) {
       return inspectObject(value, options);
     } // We have run out of options! Just stringify the value
 
@@ -10775,7 +10803,7 @@ module.exports = getFuncName;
       return false;
     }
 
-    constructorMap.add(constructor, inspector);
+    constructorMap.set(constructor, inspector);
     return true;
   }
   function registerStringTag(stringTag, inspector) {

package/lib/chai/utils/objDisplay.js

@@ -19,6 +19,7 @@ var config = require('../config');
  * messages or should be truncated.
  *
  * @param {Mixed} javascript object to inspect
+ * @returns {string} stringified object
  * @name objDisplay
  * @namespace Utils
  * @api public

package/lib/chai/utils/test.js

@@ -13,7 +13,7 @@ var flag = require('./flag');
 /**
  * ### .test(object, expression)
  *
- * Test and object for expression.
+ * Test an object for expression.
  *
  * @param {Object} object (constructed Assertion)
  * @param {Arguments} chai.Assertion.prototype.assert arguments

package/lib/chai.js

@@ -10,7 +10,7 @@ var used = [];
  * Chai version
  */
 
-exports.version = '4.3.3';
+exports.version = '4.3.8';
 
 /*!
  * Assertion Error

package/package.json

@@ -17,7 +17,7 @@
     "Veselin Todorov <hi@vesln.com>",
     "John Firebaugh <john.firebaugh@gmail.com>"
   ],
-  "version": "4.3.7",
+  "version": "4.3.9",
   "repository": {
     "type": "git",
     "url": "https://github.com/chaijs/chai"
@@ -41,7 +41,7 @@
   },
   "dependencies": {
     "assertion-error": "^1.1.0",
-    "check-error": "^1.0.2",
+    "check-error": "^1.0.3",
     "deep-eql": "^4.1.2",
     "get-func-name": "^2.0.0",
     "loupe": "^2.3.1",