cdk-cost-analyzer 0.1.1 → 0.1.3

package/.cdk-cost-analyzer-cache/metadata.json

@@ -2,11 +2,11 @@
   "entries": {
     "AmazonS3:EU (Frankfurt):storageClass:General Purpose|volumeType:Standard": {
       "price": 0.023,
-      "timestamp": 1767969942826
+      "timestamp": 1768909325265
     },
     "AmazonS3:invalid-region-123:storageClass:General Purpose|volumeType:Standard": {
       "price": 0.023,
-      "timestamp": 1767969942865
+      "timestamp": 1768909325302
     }
   }
 }

package/.kiro/specs/fix-pricing-calculators.md

@@ -0,0 +1,203 @@
+---
+title: Fix Pricing Calculator Detection Issues
+status: draft
+created: 2026-01-19
+---
+
+# Fix Pricing Calculator Detection Issues
+
+## Problem Statement
+
+The cdk-cost-analyzer tool fails to detect and calculate costs for most AWS resources, showing $0.00 for resources that have working calculators. Testing with a real-world CDK stack reveals that only Lambda functions are properly priced, while NAT Gateways, Application Load Balancers, ECS Fargate services, DynamoDB tables, and AutoScaling Groups all show $0.00.
+
+## Current Behavior
+
+When analyzing a CloudFormation template containing:
+- AWS::EC2::NatGateway
+- AWS::ElasticLoadBalancingV2::LoadBalancer
+- AWS::ECS::Service (Fargate)
+- AWS::DynamoDB::Table
+- AWS::AutoScaling::AutoScalingGroup
+- AWS::Lambda::Function
+
+Only the Lambda function returns a cost estimate ($2.08/month). All other resources show `$0.00 [unknown]`.
+
+## Root Cause Analysis
+
+1. **Pricing API queries work** - Manual testing confirms AWS Pricing API returns correct data
+2. **Calculators exist** - Code inspection shows calculators for all major resource types
+3. **Query generation fails** - The pricing queries generated by calculators don't match AWS Pricing API format
+
+### Verified Issues
+
+#### NAT Gateway Calculator
+- Calculator exists at `src/pricing/calculators/NatGatewayCalculator.ts`
+- Supports resource type `AWS::EC2::NatGateway`
+- Pricing API query likely fails due to filter mismatch
+
+#### ALB Calculator
+- Calculator exists at `src/pricing/calculators/ALBCalculator.ts`
+- Supports resource type `AWS::ElasticLoadBalancingV2::LoadBalancer`
+- Needs to distinguish between ALB and NLB
+
+#### ECS Calculator
+- Calculator exists at `src/pricing/calculators/ECSCalculator.ts`
+- Supports resource type `AWS::ECS::Service`
+- Must extract Fargate CPU/memory from task definition
+
+#### DynamoDB Calculator
+- Calculator exists at `src/pricing/calculators/DynamoDBCalculator.ts`
+- Supports resource type `AWS::DynamoDB::Table`
+- Pay-per-request pricing requires usage assumptions
+
+#### AutoScaling Group Support
+- No calculator for `AWS::AutoScaling::AutoScalingGroup`
+- No calculator for `AWS::AutoScaling::LaunchConfiguration`
+- EC2Calculator exists but doesn't support ASG resources
+
+## Expected Behavior
+
+For the test stack, the analyzer should report:
+- NAT Gateway: ~$33/month (hourly + data processing)
+- Application Load Balancer: ~$16/month (hourly + LCU charges)
+- ECS Fargate (2 tasks, 0.25 vCPU, 0.5 GB): ~$15-20/month
+- DynamoDB (pay-per-request): $0.00 with usage assumptions note
+- Lambda: $2.08/month (currently working)
+- AutoScaling Group (2 x t3.micro): ~$17.52/month
+
+**Total expected: ~$83-103/month**
+
+## Proposed Solution
+
+### Phase 1: Diagnostic Improvements
+
+1. **Add debug logging**
+   - Log pricing API queries before execution
+   - Log pricing API responses
+   - Log filter values used in queries
+   - Add `--debug` flag to CLI
+
+2. **Improve error messages**
+   - Show which filters failed to match
+   - Suggest correct filter values
+   - Display pricing API error responses
+
+### Phase 2: Fix Existing Calculators
+
+1. **NAT Gateway Calculator**
+   - Verify region prefix generation
+   - Test filter combinations against Pricing API
+   - Add integration test with real API calls
+
+2. **ALB Calculator**
+   - Fix LoadBalancer type detection (ALB vs NLB)
+   - Verify pricing filters for eu-central-1
+   - Add LCU cost calculation
+
+3. **ECS Calculator**
+   - Extract task definition properties from CloudFormation
+   - Calculate Fargate pricing based on vCPU and memory
+   - Handle both Fargate and EC2 launch types
+
+4. **DynamoDB Calculator**
+   - Implement pay-per-request pricing
+   - Use usage assumptions from config
+   - Add on-demand vs provisioned detection
+
+### Phase 3: Add Missing Calculators
+
+1. **AutoScaling Group Calculator**
+   - Extract instance type from LaunchConfiguration/LaunchTemplate
+   - Calculate cost based on min/max/desired capacity
+   - Support multiple instance types in mixed instance policy
+
+2. **LaunchTemplate Support**
+   - Parse AWS::EC2::LaunchTemplate resources
+   - Extract instance type and other pricing factors
+   - Link to AutoScaling Groups
+
+### Phase 4: Testing & Validation
+
+1. **Integration Tests**
+   - Test against real AWS Pricing API
+   - Verify costs for all supported regions
+   - Compare with AWS Pricing Calculator
+
+2. **Test Fixtures**
+   - Add CloudFormation templates for each resource type
+   - Include edge cases (mixed instance types, spot instances)
+   - Test with actual deployed stacks
+
+3. **Documentation**
+   - Document supported resource types
+   - List known limitations
+   - Provide troubleshooting guide
+
+## Test Cases
+
+### Test Case 1: NAT Gateway Pricing
+```yaml
+Input: CloudFormation template with AWS::EC2::NatGateway
+Region: eu-central-1
+Expected: ~$33/month (hourly rate + data processing)
+Config: usageAssumptions.natGateway.dataProcessedGB = 500
+```
+
+### Test Case 2: Application Load Balancer
+```yaml
+Input: CloudFormation template with AWS::ElasticLoadBalancingV2::LoadBalancer (Type: application)
+Region: eu-central-1
+Expected: ~$16/month (hourly rate + LCU charges)
+Config: usageAssumptions.alb.processedBytesGB = 1000
+```
+
+### Test Case 3: ECS Fargate Service
+```yaml
+Input: CloudFormation template with AWS::ECS::Service + TaskDefinition
+Task: 0.25 vCPU, 0.5 GB memory
+Desired Count: 2
+Region: eu-central-1
+Expected: ~$15-20/month
+```
+
+### Test Case 4: AutoScaling Group
+```yaml
+Input: CloudFormation template with AWS::AutoScaling::AutoScalingGroup
+Instance Type: t3.micro
+Desired Capacity: 2
+Region: eu-central-1
+Expected: ~$17.52/month (2 x $0.012/hour x 730 hours)
+```
+
+## Success Criteria
+
+1. All calculators return non-zero costs for valid resources
+2. Cost estimates within 10% of AWS Pricing Calculator
+3. Debug mode shows pricing API queries and responses
+4. Integration tests pass against real Pricing API
+5. Documentation updated with supported resources
+
+## Implementation Plan
+
+1. **Week 1**: Add debug logging and improve error messages
+2. **Week 2**: Fix NAT Gateway and ALB calculators
+3. **Week 3**: Fix ECS and DynamoDB calculators
+4. **Week 4**: Add AutoScaling Group calculator
+5. **Week 5**: Integration tests and documentation
+
+## GitHub Issues to Create
+
+1. **Add debug logging for pricing API calls** (Phase 1)
+2. **Fix NAT Gateway calculator pricing detection** (Phase 2)
+3. **Fix ALB calculator pricing detection** (Phase 2)
+4. **Fix ECS Fargate calculator pricing detection** (Phase 2)
+5. **Fix DynamoDB calculator pricing detection** (Phase 2)
+6. **Add AutoScaling Group calculator** (Phase 3)
+7. **Add LaunchTemplate support for EC2 pricing** (Phase 3)
+8. **Add integration tests for pricing calculators** (Phase 4)
+
+## References
+
+- AWS Pricing API: https://docs.aws.amazon.com/awsaccountbilling/latest/aboutv2/price-changes.html
+- Test stack: `demo/cdk.out/demo-dev.template.json`
+- Pricing verification: Manual AWS Pricing API queries confirmed correct pricing data exists

package/.kiro/steering/github-cli-best-practices.md

@@ -0,0 +1,383 @@
+---
+title: GitHub CLI Best Practices
+inclusion: always
+---
+
+# GitHub CLI Best Practices
+
+## Authentication
+
+Always verify authentication status before creating issues or PRs:
+
+```bash
+gh auth status
+```
+
+Expected output should show:
+- Logged in account
+- Active account: true
+- Required token scopes: repo, workflow
+
+## Creating Issues
+
+### Basic Issue Creation
+
+Use simple, direct syntax to avoid shell escaping issues:
+
+```bash
+gh issue create \
+  --title "Issue title here" \
+  --body "Issue description" \
+  --label "bug"
+```
+
+### Avoiding Common Pitfalls
+
+**DO NOT use complex multi-line bodies with special characters:**
+```bash
+# BAD - Will fail with quotes, backticks, dollar signs
+gh issue create --title "Fix bug" --body "The `$variable` doesn't work"
+```
+
+**DO use simple bodies:**
+```bash
+# GOOD - Simple body
+gh issue create --title "Fix bug" --body "Variable expansion fails in calculator" --label "bug"
+
+# GOOD - Use single quotes for special characters
+gh issue create --title "Fix bug" --body 'The calculator fails with $variables and backticks' --label "bug"
+```
+
+**AVOID heredoc (EOF) syntax - it can cause issues in some environments**
+
+### Label Management
+
+**Check available labels first:**
+```bash
+gh label list
+```
+
+**Only use existing labels:**
+```bash
+# Common labels that usually exist
+--label "bug"
+--label "enhancement"
+--label "documentation"
+
+# Avoid custom labels that may not exist
+--label "pricing"  # May not exist
+--label "testing"  # May not exist
+```
+
+**Multiple labels:**
+```bash
+gh issue create --title "Title" --body "Body" --label "bug,documentation"
+```
+
+### Issue Body Best Practices
+
+**Keep it simple for CLI:**
+- Use plain text without special formatting
+- Avoid backticks, dollar signs, quotes in CLI body
+- For complex content, use --web flag to open browser editor
+- Or create issue first with simple body, then edit in browser
+
+**Example - Simple approach:**
+```bash
+gh issue create \
+  --title "Add debug logging" \
+  --body "Add --debug flag to show pricing API queries and responses" \
+  --label "enhancement"
+```
+
+**Example - Complex content:**
+```bash
+# Use --web flag to open browser for complex formatting
+gh issue create --title "Fix NAT Gateway pricing" --label "bug" --web
+```
+
+## Creating Pull Requests
+
+### Basic PR Creation
+
+```bash
+gh pr create \
+  --title "Fix: NAT Gateway pricing detection" \
+  --body "Fixes #26" \
+  --base main
+```
+
+### Draft PRs
+
+```bash
+gh pr create --draft --title "WIP: Add AutoScaling calculator" --body "Work in progress"
+```
+
+### PR from Issue
+
+```bash
+# Create branch and PR linked to issue
+gh issue develop 26 --checkout
+# Make changes, commit
+gh pr create --title "Fix NAT Gateway pricing" --body "Closes #26"
+```
+
+## Viewing Issues and PRs
+
+### List Issues
+
+```bash
+# All open issues
+gh issue list
+
+# Filter by label
+gh issue list --label "bug"
+
+# Filter by assignee
+gh issue list --assignee "@me"
+
+# Show more details
+gh issue list --limit 20
+```
+
+### View Issue Details
+
+```bash
+gh issue view 26
+gh issue view 26 --web  # Open in browser
+```
+
+### List PRs
+
+```bash
+gh pr list
+gh pr list --state "all"
+gh pr list --author "@me"
+```
+
+## Commenting
+
+### Add Comment to Issue
+
+```bash
+# Simple comment
+gh issue comment 26 --body "Working on this now"
+
+# Long comment with special characters - use single quotes
+gh issue comment 26 --body 'Fixed the $variable issue. The calculator now works correctly.'
+
+# For multi-line comments, keep them simple or use --web flag
+gh issue comment 26 --body 'Update: Fixed pricing queries, added tests, ready for review'
+```
+
+### Add Comment to PR
+
+```bash
+# Simple comment
+gh pr comment 123 --body "LGTM"
+
+# Detailed review comment - use single quotes
+gh pr comment 123 --body 'Great work! Just one suggestion: consider using `const` instead of `let` on line 42.'
+```
+
+### Comment Best Practices
+
+**Use single quotes for comments with special characters:**
+```bash
+# GOOD - Single quotes prevent shell expansion
+gh issue comment 26 --body 'The $variable and `code` work now'
+
+# BAD - Double quotes cause shell expansion issues
+gh issue comment 26 --body "The $variable and `code` work now"
+```
+
+**For long multi-line comments, keep them simple:**
+```bash
+# Keep it concise in a single line
+gh issue comment 26 --body 'Completed: Fixed NAT Gateway pricing, added debug logging, updated tests. Next: Review PR and update docs.'
+
+# Or use --web flag to open browser for complex formatting
+gh issue comment 26 --web
+```
+
+## Closing and Reopening
+
+### Close Issue
+
+```bash
+gh issue close 26
+gh issue close 26 --comment "Fixed in PR #123"
+```
+
+### Reopen Issue
+
+```bash
+gh issue reopen 26
+```
+
+## Repository Context
+
+### Check Current Repository
+
+```bash
+gh repo view
+```
+
+### Set Repository Context
+
+```bash
+# Work with different repo
+gh issue list --repo owner/repo
+
+# Or set default
+cd /path/to/repo
+gh issue list  # Uses current directory's repo
+```
+
+## Common Workflows
+
+### Create Issue from Template
+
+```bash
+# List available templates
+gh issue create --web
+
+# Or use CLI with simple body
+gh issue create --title "Bug report" --body "Description here" --label "bug"
+```
+
+### Bulk Operations
+
+```bash
+# Close multiple issues
+for issue in 10 11 12; do
+  gh issue close $issue
+done
+
+# Add label to multiple issues
+for issue in 26 27 28; do
+  gh issue edit $issue --add-label "priority-high"
+done
+```
+
+### Search Issues
+
+```bash
+# Search in title and body
+gh issue list --search "pricing calculator"
+
+# Search with filters
+gh issue list --search "is:open label:bug pricing"
+```
+
+## Error Handling
+
+### Common Errors and Solutions
+
+**Error: "could not add label: 'labelname' not found"**
+```bash
+# Solution: Check available labels first
+gh label list
+# Use only existing labels
+```
+
+**Error: "authentication required"**
+```bash
+# Solution: Login or refresh token
+gh auth login
+gh auth refresh
+```
+
+**Error: "repository not found"**
+```bash
+# Solution: Verify you're in correct directory or specify repo
+gh repo view  # Check current repo
+cd /path/to/correct/repo
+```
+
+**Error: Shell escaping issues with body text**
+```bash
+# Solution: Use single quotes or --web flag
+gh issue create --title "Title" --label "bug" --body 'Complex body with special characters'
+# Or use --web flag to open browser
+gh issue create --title "Title" --label "bug" --web
+```
+
+## Best Practices Summary
+
+1. **Always verify auth status** before operations
+2. **Check available labels** before using them
+3. **Keep CLI bodies simple** - use --web flag for complex content
+4. **Use single quotes** for strings with special characters ($, `, ", etc.)
+5. **NEVER use heredoc (EOF) syntax** - it can crash some environments
+6. **Test with one issue** before bulk operations
+7. **Use --web flag** for complex issue creation or editing
+8. **Link issues and PRs** with "Fixes #123" or "Closes #123"
+9. **Check repository context** with `gh repo view`
+10. **Use issue templates** when available
+
+## Integration with Workflow
+
+### Spec-Driven Development
+
+```bash
+# 1. Create spec document first
+vim .kiro/specs/feature-name.md
+
+# 2. Create GitHub issues from spec
+gh issue create --title "Implement feature X" --body "See spec in .kiro/specs/feature-name.md" --label "enhancement"
+
+# 3. Create branch for issue
+gh issue develop 26 --checkout
+
+# 4. Implement and create PR
+gh pr create --title "Implement feature X" --body "Closes #26"
+```
+
+### Issue Tracking
+
+```bash
+# Check your assigned issues
+gh issue list --assignee "@me"
+
+# Check issues in current milestone
+gh issue list --milestone "v1.0"
+
+# Check issues by project
+gh issue list --search "project:ProjectName"
+```
+
+## Troubleshooting
+
+### Debug Mode
+
+```bash
+# Enable debug output
+GH_DEBUG=1 gh issue create --title "Test" --body "Test"
+```
+
+### Verbose Output
+
+```bash
+# Show more details
+gh issue list --json number,title,labels,state
+```
+
+### Check Configuration
+
+```bash
+# View current config
+gh config list
+
+# Set default editor
+gh config set editor vim
+
+# Set default protocol
+gh config set git_protocol https
+```
+
+## References
+
+- Official docs: https://cli.github.com/manual/
+- Issue creation: https://cli.github.com/manual/gh_issue_create
+- PR creation: https://cli.github.com/manual/gh_pr_create

package/CHANGELOG.md

@@ -7,9 +7,54 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Features
+- Add demo CDK project with ECS Fargate, bastion hosts, and serverless API
+
+### Documentation
+- Add GitHub CLI best practices steering document
+
+### Bug Fixes
+- Fix locale formatting in CustomAssumptions property test
+
 ### Security
 - Improved command execution security in CDK synthesis by using `shell: false` to prevent command injection vulnerabilities
 
+## [0.1.2] - 2025-01-20
+
+### Features
+- Add debug logging for pricing API calls with `--debug` flag
+- Add Logger utility class for consistent debug output
+- Add region normalization logging
+- Add cache status logging (memory/persistent)
+- Add comprehensive debug logging documentation
+
+### Changed
+- Upgrade dependencies to latest versions
+
+## [0.1.1] - 2024-12-11
+
+### Features
+- Enable npm release workflow
+- Add GitHub Actions workflow validation with act pre-commit hook
+- Migrate from Vitest to Jest and improve projen configuration
+- Add dedicated test workflow for GitHub Actions status checks
+
+### Bug Fixes
+- Update package name to unscoped cdk-cost-analyzer
+- Increase property test timeouts for CDK synthesis from 15s to 30s
+- Enforce npm version consistency in CI workflow
+- Pin Node.js version to 20.18.1 in GitHub Actions workflows
+- Ensure npm ci is used consistently in GitHub Actions
+- Add example project dependencies installation to build workflow
+
+### Changed
+- Clean up temporary CDK output files and artifacts
+- Remove temporary log files
+- Exclude CDK output directories from version control
+
+### Security
+- Fix security vulnerability in CDK synthesis process
+
 ## [0.1.0] - 2024-12-10
 
 ### Added
@@ -45,5 +90,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - AWS::ElastiCache::CacheCluster
 - AWS::EC2::VPCEndpoint
 
-[Unreleased]: https://github.com/buildinginthecloud/cdk-cost-analyzer/compare/v0.1.0...HEAD
+[Unreleased]: https://github.com/buildinginthecloud/cdk-cost-analyzer/compare/v0.1.2...HEAD
+[0.1.2]: https://github.com/buildinginthecloud/cdk-cost-analyzer/compare/v0.1.1...v0.1.2
+[0.1.1]: https://github.com/buildinginthecloud/cdk-cost-analyzer/compare/v0.1.0...v0.1.1
 [0.1.0]: https://github.com/buildinginthecloud/cdk-cost-analyzer/releases/tag/v0.1.0