cdd-cli 3.1.6 → 3.1.9

package/FIXES_APPLIED.md

@@ -1,419 +0,0 @@
-# Applied Fixes - CDD CLI
-
-**Date:** 2025-10-17  
-**Project:** CDD-CLI (CLI Docker Dashboard)
-
----
-
-## Fixes Summary
-
-A total of 11 critical fixes were applied to address security, stability, and portability issues identified during the code audit.
-
----
-
-## 1. APPLIED CRITICAL FIXES
-
-### ✅ 1.1. Import Order Fix
-
-**File:** `src/helpers/dockerService/serviceComponents/containerActions.js`
-
-**Issue:** Imports were declared after exports.
-
-**Applied fix:**
-```javascript
-// BEFORE (incorrect):
-export async function removeContainer(containerId) { ... }
-import { docker } from "../dockerService";
-
-// AFTER (correct):
-import { docker } from "../dockerService";
-import { imageExists, pullImage } from "./imageUtils.js";
-export async function removeContainer(containerId) { ... }
-```
-
-**Impact:** Removes potential reference errors and follows ES6 standards.
-
----
-
-### ✅ 1.2. Optional Ports in Container Creation
-
-**File:** `src/hooks/creation/useContainerCreation.js`
-
-**Issue:** Users were forced to specify ports, but many containers don’t need them.
-
-**Applied fix:**
-```javascript
-// BEFORE:
-if (!portInput.trim()) {
-  setMessage("You must specify at least one port to expose");
-  return;
-}
-
-// AFTER:
-// Ports are optional — only validate if provided
-if (portInput.trim() && !validatePorts(portInput)) {
-  setMessage("Port format must be host:container...");
-  return;
-}
-```
-
-**Impact:** Allows creating containers without exposed ports (workers, internal services, etc.).
-
----
-
-### ✅ 1.3. Error Handling in getLogsStream
-
-**File:** `src/helpers/dockerService/serviceComponents/containerLogs.js`
-
-**Issue:** No try-catch to handle synchronous exceptions.
-
-**Applied fix:**
-```javascript
-export function getLogsStream(containerId, onData, onEnd, onError) {
-  try {
-    const container = docker.getContainer(containerId);
-    // ... rest of the code
-  } catch (err) {
-    onError?.(err);
-  }
-}
-```
-
-**Impact:** Prevents crashes when the container doesn’t exist or connection errors occur.
-
----
-
-### ✅ 1.4. Cross-Platform Docker Socket Configuration
-
-**File:** `src/helpers/dockerService/dockerService.js`
-
-**Issue:** Hardcoded path `/var/run/docker.sock` only works on Linux/macOS.
-
-**Applied fix:**
-```javascript
-// BEFORE:
-const docker = new Docker({ socketPath: "/var/run/docker.sock" });
-
-// AFTER:
-// Use default configuration that automatically handles:
-// - /var/run/docker.sock on Linux/macOS
-// - //./pipe/docker_engine on Windows
-const docker = new Docker();
-```
-
-**Impact:** Works on Windows, Linux, and macOS without manual changes.
-
----
-
-### ✅ 1.5. Race Condition Prevention in Stats
-
-**File:** `src/components/ContainerRow.jsx`
-
-**Issue:** State updates on unmounted components caused memory leaks.
-
-**Applied fix:**
-```javascript
-useEffect(() => {
-  if (state !== "running") return;
-  
-  let isMounted = true;  // ← Mount flag
-  
-  const fetchStats = async () => {
-    try {
-      const s = await getStats(id);
-      if (isMounted) {  // ← Only update if mounted
-        setStats(s);
-      }
-    } catch (err) {
-      if (isMounted) {
-        setStatsError("Error fetching stats");
-      }
-    }
-  };
-  
-  fetchStats();
-  const timer = setInterval(fetchStats, 1500);
-  
-  return () => {
-    isMounted = false;  // ← Cleanup
-    clearInterval(timer);
-  };
-}, [id, state]);
-```
-
-**Impact:** Eliminates React warnings and prevents memory leaks.
-
----
-
-### ✅ 1.6. Environment Variables Validation
-
-**File:** `src/helpers/validationHelpers.js`
-
-**Issue:** `validateEnvVars` always returned `true`.
-
-**Applied fix:**
-```javascript
-export function validateEnvVars(envInput) {
-  if (!envInput || !envInput.trim()) return true; // Empty is valid
-  
-  const vars = envInput.split(",").map(v => v.trim()).filter(Boolean);
-  const invalid = vars.find(v => {
-    const parts = v.split("=");
-    if (parts.length < 2) return true;  // Must be VAR=value
-    const varName = parts[0].trim();
-    // Names must be alphanumeric with underscores
-    if (!/^[A-Z_][A-Z0-9_]*$/i.test(varName)) return true;
-    return false;
-  });
-  
-  return !invalid;
-}
-```
-
-**Impact:** Detects malformed variables before sending them to Docker.
-
----
-
-### ✅ 1.7. CPU Stats Calculation Fix
-
-**File:** `src/helpers/dockerService/serviceComponents/containerStats.js`
-
-**Issue:** Not normalized by number of CPUs, producing wrong values on multi-core hosts.
-
-**Applied fix:**
-```javascript
-// Determine number of CPUs
-const numCpus = stream.cpu_stats.online_cpus || 
-                stream.cpu_stats.cpu_usage.percpu_usage?.length || 1;
-
-// Compute normalized percentage
-const cpuPercent = systemDelta > 0 
-  ? ((cpuDelta / systemDelta) * numCpus * 100) 
-  : 0;
-```
-
-**Impact:** Correct CPU stats on multi-core systems.
-
----
-
-### ✅ 1.8. Timeouts in Docker Operations
-
-**File:** `src/helpers/dockerService/serviceComponents/containerActions.js`
-
-**Issue:** Operations without timeouts could freeze the UI indefinitely.
-
-**Applied fix:**
-```javascript
-function withTimeout(promise, ms = 30000) {
-  return Promise.race([
-    promise,
-    new Promise((_, reject) => 
-      setTimeout(() => reject(new Error('Operation timed out')), ms)
-    )
-  ]);
-}
-
-export async function startContainer(containerId) {
-  const container = docker.getContainer(containerId);
-  await withTimeout(container.start(), 30000);
-}
-```
-
-**Impact:** Prevents frozen UI during long or failing operations.
-
----
-
-### ✅ 1.9. In-Memory Log Limit
-
-**File:** `src/hooks/useControls.js`
-
-**Issue:** Logs accumulated indefinitely causing a memory leak.
-
-**Applied fix:**
-```javascript
-getLogsStream(
-  containers[selected].id,
-  (data) => logsViewer.setLogs((prev) => {
-    const newLogs = [...prev, ...data.split("\n").filter(Boolean)];
-    // Limit to last 1000 lines
-    return newLogs.slice(-1000);
-  }),
-  // ...
-);
-```
-
-**Impact:** Prevents memory leaks on long-running log streams.
-
----
-
-### ✅ 1.10. Duplicate Message Fix
-
-**File:** `src/helpers/actionHelpers.js`
-
-**Issue:** Success message was identical to the start message.
-
-**Applied fix:**
-```javascript
-// BEFORE:
-setMessage(`${actionLabel} container...`); // start
-await actionFn(c.id);
-setMessage(`${actionLabel} container...`); // success (duplicate)
-
-// AFTER:
-setMessage(`${actionLabel} container...`); // start
-await actionFn(c.id);
-setMessage(`${actionLabel} container completed successfully`); // success
-```
-
-**Impact:** Clear feedback that the operation completed.
-
----
-
-### ✅ 1.11. Container Names Validation
-
-**File:** `src/helpers/dockerService/serviceComponents/containerList.js`
-
-**Issue:** Didn’t validate when `Names` was empty.
-
-**Applied fix:**
-```javascript
-// BEFORE:
-name: container.Names[0].replace("/", ""),
-
-// AFTER:
-name: (container.Names && container.Names[0] || 'Unknown').replace("/", ""),
-```
-
-**Impact:** Prevents crashes when Docker returns unexpected data.
-
----
-
-## 2. TEST IMPROVEMENTS
-
-### ✅ Tests for validateEnvVars
-
-**File:** `test/validationHelpers.test.js`
-
-**New tests added:**
-- Empty input is valid
-- Valid single env var
-- Valid multiple env vars
-- Valid env var with underscores
-- Invalid env var without equals sign
-- Invalid env var with invalid name
-- Invalid env var with special characters in name
-
-**Result:**
-```
-Test Suites: 1 passed, 1 total
-Tests:       12 passed, 12 total (previously: 5)
-```
-
----
-
-## 3. SECURITY ANALYSIS
-
-### ✅ CodeQL Security Scan
-
-**Result:** ✅ 0 vulnerabilities found
-
-```
-Analysis Result for 'javascript'. Found 0 alert(s):
-- javascript: No alerts found.
-```
-
----
-
-## 4. BUILD VERIFICATION
-
-### ✅ Successful Build
-
-```bash
-$ npm run build
-Successfully compiled 28 files with Babel (815ms).
-```
-
----
-
-## 5. OVERALL IMPACT OF FIXES
-
-### Security
-- ✅ No security vulnerabilities detected
-- ✅ Improved input validation
-- ✅ Robust error handling
-
-### Stability
-- ✅ Memory leak prevention
-- ✅ Race condition prevention
-- ✅ Crash prevention due to unhandled errors
-- ✅ Timeouts for potentially long operations
-
-### Portability
-- ✅ Windows compatibility
-- ✅ Linux compatibility
-- ✅ macOS compatibility
-
-### User Experience
-- ✅ Optional ports in container creation
-- ✅ Clearer feedback messages
-- ✅ Correct CPU statistics
-- ✅ Better error handling with informative messages
-
-### Code Quality
-- ✅ ES6 compliant
-- ✅ Better test coverage (5 → 12 tests)
-- ✅ More maintainable code
-
----
-
-## 6. MODIFIED FILES
-
-1. `src/helpers/dockerService/serviceComponents/containerActions.js`
-2. `src/hooks/creation/useContainerCreation.js`
-3. `src/helpers/dockerService/serviceComponents/containerLogs.js`
-4. `src/helpers/dockerService/dockerService.js`
-5. `src/components/ContainerRow.jsx`
-6. `src/helpers/validationHelpers.js`
-7. `src/helpers/dockerService/serviceComponents/containerStats.js`
-8. `src/hooks/useControls.js`
-9. `src/helpers/actionHelpers.js`
-10. `src/helpers/dockerService/serviceComponents/containerList.js`
-11. `test/validationHelpers.test.js`
-
----
-
-## 7. FUTURE RECOMMENDATIONS
-
-While the critical issues have been addressed, the internal audit yielded additional recommendations for future improvements:
-
-### Medium Priority
-- Add more unit tests
-- Implement PropTypes or migrate to TypeScript
-- Extract magic numbers into constants
-- Improve the logging system
-
-### Low Priority
-- Implement i18n (internationalization)
-- Improve JSDoc documentation
-- Consider websockets for real-time updates
-- Implement retry logic for Docker reconnection
-
----
-
-## 8. CONCLUSION
-
-We applied 11 critical fixes that significantly improve:
-
-- Security: 0 vulnerabilities
-- Stability: Prevention of memory leaks and race conditions
-- Portability: Works on Windows, Linux, and macOS
-- Quality: +140% more tests (5 → 12)
-
-All fixes have been tested and verified via:
-- ✅ Unit tests (12/12 passing)
-- ✅ Successful build
-- ✅ CodeQL security analysis (0 alerts)
-
----
-
-**End of fixes document**

package/SECURITY.md

@@ -1,5 +0,0 @@
-# Security
-
-If you discover a security vulnerability, please report it privately to the repository owner.
-
-Do not disclose vulnerabilities publicly until they are resolved.

package/dist/hooks/useLogsStream.js

@@ -1,41 +0,0 @@
-function _toConsumableArray(r) { return _arrayWithoutHoles(r) || _iterableToArray(r) || _unsupportedIterableToArray(r) || _nonIterableSpread(); }
-function _nonIterableSpread() { throw new TypeError("Invalid attempt to spread non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); }
-function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
-function _iterableToArray(r) { if ("undefined" != typeof Symbol && null != r[Symbol.iterator] || null != r["@@iterator"]) return Array.from(r); }
-function _arrayWithoutHoles(r) { if (Array.isArray(r)) return _arrayLikeToArray(r); }
-function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
-import React, { useRef, useCallback } from "react";
-import { getLogsStream } from "../helpers/dockerService/serviceComponents/containerLogs.js";
-import { safeCall } from "../helpers/safeCall.js";
-
-/**
- * Hook that manages opening and closing a logs stream for a container.
- *
- * @returns {Object} { openLogs, closeLogs }
- */
-export function useLogsStream() {
-  var logsStreamRef = useRef(null);
-  var openLogs = useCallback(function (containerId, setLogs) {
-    setLogs([]);
-    logsStreamRef.current = getLogsStream(containerId, function (data) {
-      return setLogs(function (prev) {
-        return [].concat(_toConsumableArray(prev), _toConsumableArray(data.split("\n").filter(Boolean)));
-      });
-    }, function () {}, function (err) {
-      return setLogs(function (prev) {
-        return [].concat(_toConsumableArray(prev), ["Error: ".concat(err.message)]);
-      });
-    });
-  }, []);
-  var closeLogs = useCallback(function () {
-    if (logsStreamRef.current) {
-      var _logsStreamRef$curren;
-      safeCall((_logsStreamRef$curren = logsStreamRef.current.destroy) === null || _logsStreamRef$curren === void 0 ? void 0 : _logsStreamRef$curren.bind(logsStreamRef.current));
-      logsStreamRef.current = null;
-    }
-  }, []);
-  return {
-    openLogs: openLogs,
-    closeLogs: closeLogs
-  };
-}

package/docs/_config.yml

@@ -1,13 +0,0 @@
-title: CDD Documentation
-# Disable the default GitHub Pages theme so Jekyll just copies our static output
-# (the static HTML is generated by JSDoc and already styled).
-theme: null
-
-# Explicitly include asset folders that Jekyll might otherwise ignore.
-include:
-  - fonts
-  - scripts
-  - styles
-
-# No Jekyll plugins are required for this pre-rendered site.
-plugins: []

package/docs/components_ContainerCreationPrompt.jsx.html

@@ -1,114 +0,0 @@
-<!DOCTYPE html>
-<html lang="en">
-<head>
-    <meta charset="utf-8">
-    <title>JSDoc: Source: components/ContainerCreationPrompt.jsx</title>
-
-    <script src="scripts/prettify/prettify.js"> </script>
-    <script src="scripts/prettify/lang-css.js"> </script>
-    <!--[if lt IE 9]>
-      <script src="//html5shiv.googlecode.com/svn/trunk/html5.js"></script>
-    <![endif]-->
-    <link type="text/css" rel="stylesheet" href="styles/prettify-tomorrow.css">
-    <link type="text/css" rel="stylesheet" href="styles/jsdoc-default.css">
-</head>
-
-<body>
-
-<div id="main">
-
-    <h1 class="page-title">Source: components/ContainerCreationPrompt.jsx</h1>
-
-    
-
-
-
-    
-    <section>
-        <article>
-            <pre class="prettyprint source linenums"><code>import React from "react";
-import { Box, Text } from "ink";
-import { PromptField, PromptMessage } from "./PromptField.jsx";
-import PropTypes from 'prop-types';
-
-/**
- * Prompt UI shown when creating a new container.
- * Presents a step-by-step form (image, name, ports, env) and displays
- * a contextual message provided by the creation hook.
- *
- * @param {Object} props
- * @param {number} props.step - Current step index (0..3)
- * @param {string} props.imageName - Value for the image name field
- * @param {string} props.containerName - Value for the container name field
- * @param {string} props.portInput - Value for the ports input field
- * @param {string} props.envInput - Value for the environment variables field
- * @param {string} props.message - Contextual message to display (errors/hints)
- * @param {string} props.messageColor - Color for the contextual message
- * @returns {JSX.Element}
- */
-export default function ContainerCreationPrompt(props) {
-  const { step, imageName, containerName, portInput, envInput, message, messageColor } = props;
-  const prompts = [
-    {
-      label: "Name of the image to create (e.g., nginx:latest):",
-      value: imageName,
-      required: true,
-    },
-    {
-      label: "Name of the container (optional):",
-      value: containerName,
-      required: false,
-    },
-    {
-      label: "Ports (optional, format 8080:80,443:443):",
-      value: portInput,
-      required: false,
-    },
-    {
-      label: "Environment variables (optional, format VAR1=val1,VAR2=val2):",
-      value: envInput,
-      required: false,
-    },
-  ];
-  const { label, value, required } = prompts[step] || {};
-  return (
-    &lt;Box flexDirection="column" borderStyle="round" borderColor="yellow" padding={1}>
-      &lt;PromptField label={label} value={value} required={required} />
-      &lt;PromptMessage message={message} color={messageColor} />
-      &lt;Text dimColor>Press Enter to continue, Escape to cancel&lt;/Text>
-    &lt;/Box>
-  );
-}
-
-ContainerCreationPrompt.propTypes = {
-  step: PropTypes.number.isRequired,
-  imageName: PropTypes.string,
-  containerName: PropTypes.string,
-  portInput: PropTypes.string,
-  envInput: PropTypes.string,
-  message: PropTypes.string,
-  messageColor: PropTypes.string,
-};
-</code></pre>
-        </article>
-    </section>
-
-
-
-
-</div>
-
-<nav>
-    <h2><a href="index.html">Home</a></h2><h3>Modules</h3><ul><li><a href="module-index.html">index</a></li></ul><h3>Global</h3><ul><li><a href="global.html#EXIT_DELAY">EXIT_DELAY</a></li><li><a href="global.html#MESSAGE_TIMEOUTS">MESSAGE_TIMEOUTS</a></li><li><a href="global.html#PromptField">PromptField</a></li><li><a href="global.html#PromptMessage">PromptMessage</a></li><li><a href="global.html#REFRESH_INTERVALS">REFRESH_INTERVALS</a></li><li><a href="global.html#TIMEOUTS">TIMEOUTS</a></li><li><a href="global.html#colorize">colorize</a></li><li><a href="global.html#createContainer">createContainer</a></li><li><a href="global.html#docker">docker</a></li><li><a href="global.html#exitWithMessage">exitWithMessage</a></li><li><a href="global.html#getContainers">getContainers</a></li><li><a href="global.html#getLogsStream">getLogsStream</a></li><li><a href="global.html#getStats">getStats</a></li><li><a href="global.html#handleAction">handleAction</a></li><li><a href="global.html#imageExists">imageExists</a></li><li><a href="global.html#makeBar">makeBar</a></li><li><a href="global.html#pullImage">pullImage</a></li><li><a href="global.html#removeContainer">removeContainer</a></li><li><a href="global.html#restartContainer">restartContainer</a></li><li><a href="global.html#safeCall">safeCall</a></li><li><a href="global.html#startContainer">startContainer</a></li><li><a href="global.html#stopContainer">stopContainer</a></li><li><a href="global.html#useContainerActions">useContainerActions</a></li><li><a href="global.html#useContainerCreation">useContainerCreation</a></li><li><a href="global.html#useControls">useControls</a></li><li><a href="global.html#useLogsStream">useLogsStream</a></li><li><a href="global.html#useLogsViewer">useLogsViewer</a></li><li><a href="global.html#validateEnvVars">validateEnvVars</a></li><li><a href="global.html#validatePorts">validatePorts</a></li><li><a href="global.html#withTimeout">withTimeout</a></li></ul>
-</nav>
-
-<br class="clear">
-
-<footer>
-    Documentation generated by <a href="https://github.com/jsdoc/jsdoc">JSDoc 4.0.5</a> on Fri Oct 17 2025 16:07:18 GMT-0500 (hora estándar de Colombia)
-</footer>
-
-<script> prettyPrint(); </script>
-<script src="scripts/linenumber.js"> </script>
-</body>
-</html>