cdd-cli 3.1.2 → 3.1.4

package/src/helpers/dockerService/serviceComponents/containerStats.js

@@ -15,7 +15,15 @@ export async function getStats(containerId) {
     stream.precpu_stats.cpu_usage.total_usage;
   const systemDelta =
     stream.cpu_stats.system_cpu_usage - stream.precpu_stats.system_cpu_usage;
-  const cpuPercent = systemDelta > 0 ? (cpuDelta / systemDelta) * 100 : 0;
+  
+  // Get number of CPUs for proper normalization
+  const numCpus = stream.cpu_stats.online_cpus || 
+                  stream.cpu_stats.cpu_usage.percpu_usage?.length || 1;
+  
+  // Calculate normalized CPU percentage
+  const cpuPercent = systemDelta > 0 
+    ? ((cpuDelta / systemDelta) * numCpus * 100) 
+    : 0;
 
   const memUsage = stream.memory_stats.usage || 0;
   const memLimit = stream.memory_stats.limit || 1;

package/src/helpers/validationHelpers.js

@@ -11,6 +11,18 @@ export function validatePorts(portInput) {
 }
 
 export function validateEnvVars(envInput) {
-  // Future specific validations
-  return true;
+  if (!envInput || !envInput.trim()) return true; // Empty is valid
+  
+  const vars = envInput.split(",").map(v => v.trim()).filter(Boolean);
+  const invalid = vars.find(v => {
+    const parts = v.split("=");
+    // Must have at least VAR=value format
+    if (parts.length < 2) return true;
+    const varName = parts[0].trim();
+    // Variable names should be alphanumeric with underscores
+    if (!/^[A-Z_][A-Z0-9_]*$/i.test(varName)) return true;
+    return false;
+  });
+  
+  return !invalid;
 }

package/src/hooks/creation/useContainerCreation.js

@@ -42,12 +42,8 @@ export function useContainerCreation({ onCreate, onCancel, dbImages = [] }) {
       return;
     }
     if (step === 2) {
-      if (!portInput.trim()) {
-        setMessage("You must specify at least one port to expose (e.g. 8080:80)");
-        setMessageColor("red");
-        return;
-      }
-      if (!validatePorts(portInput)) {
+      // Ports are now optional - only validate if provided
+      if (portInput.trim() && !validatePorts(portInput)) {
         setMessage("Port format must be host:container and both must be numbers (e.g. 8080:80)");
         setMessageColor("red");
         return;

package/src/hooks/useControls.js

@@ -200,7 +200,11 @@ export function useControls(containers = []) {
       logsViewer.openLogs();
       getLogsStream(
         containers[selected].id,
-        (data) => logsViewer.setLogs((prev) => [...prev, ...data.split("\n").filter(Boolean)]),
+        (data) => logsViewer.setLogs((prev) => {
+          const newLogs = [...prev, ...data.split("\n").filter(Boolean)];
+          // Limit to last 1000 lines to prevent memory leak
+          return newLogs.slice(-1000);
+        }),
         () => {},
         (err) => logsViewer.setLogs((prev) => [...prev, `Error: ${err.message}`])
       );

package/test/validationHelpers.test.js

@@ -1,8 +1,10 @@
 let validatePorts;
+let validateEnvVars;
 
 beforeAll(async () => {
   const mod = await import('../src/helpers/validationHelpers.js');
   validatePorts = mod.validatePorts;
+  validateEnvVars = mod.validateEnvVars;
 });
 
 describe('validatePorts', () => {
@@ -26,3 +28,33 @@ describe('validatePorts', () => {
     expect(validatePorts('')).toBe(false);
   });
 });
+
+describe('validateEnvVars', () => {
+  test('empty input is valid', () => {
+    expect(validateEnvVars('')).toBe(true);
+  });
+
+  test('valid single env var', () => {
+    expect(validateEnvVars('NODE_ENV=production')).toBe(true);
+  });
+
+  test('valid multiple env vars', () => {
+    expect(validateEnvVars('NODE_ENV=production,PORT=3000')).toBe(true);
+  });
+
+  test('valid env var with underscores', () => {
+    expect(validateEnvVars('MY_VAR_NAME=value')).toBe(true);
+  });
+
+  test('invalid env var without equals sign', () => {
+    expect(validateEnvVars('NOEQUALS')).toBe(false);
+  });
+
+  test('invalid env var with invalid name', () => {
+    expect(validateEnvVars('123INVALID=value')).toBe(false);
+  });
+
+  test('invalid env var with special characters in name', () => {
+    expect(validateEnvVars('MY-VAR=value')).toBe(false);
+  });
+});