ccxt 4.5.8 → 4.5.9

package/js/src/pro/kraken.js

@@ -299,7 +299,7 @@ export default class kraken extends krakenRest {
         const market = this.market(symbol);
         const url = this.urls['api']['ws']['privateV2'];
         const requestId = this.requestId();
-        const messageHash = requestId;
+        const messageHash = this.numberToString(requestId);
         let request = {
             'method': 'add_order',
             'params': {
@@ -343,7 +343,7 @@ export default class kraken extends krakenRest {
         //
         const result = this.safeDict(message, 'result', {});
         const order = this.parseOrder(result);
-        const messageHash = this.safeValue2(message, 'reqid', 'req_id');
+        const messageHash = this.safeString2(message, 'reqid', 'req_id');
         client.resolve(order, messageHash);
     }
     /**
@@ -365,7 +365,7 @@ export default class kraken extends krakenRest {
         const token = await this.authenticate();
         const url = this.urls['api']['ws']['privateV2'];
         const requestId = this.requestId();
-        const messageHash = requestId;
+        const messageHash = this.numberToString(requestId);
         let request = {
             'method': 'amend_order',
             'params': {
@@ -396,7 +396,7 @@ export default class kraken extends krakenRest {
         const token = await this.authenticate();
         const url = this.urls['api']['ws']['privateV2'];
         const requestId = this.requestId();
-        const messageHash = requestId;
+        const messageHash = this.numberToString(requestId);
         const request = {
             'method': 'cancel_order',
             'params': {
@@ -425,7 +425,7 @@ export default class kraken extends krakenRest {
         const token = await this.authenticate();
         const url = this.urls['api']['ws']['privateV2'];
         const requestId = this.requestId();
-        const messageHash = requestId;
+        const messageHash = this.numberToString(requestId);
         const request = {
             'method': 'cancel_order',
             'params': {
@@ -449,7 +449,7 @@ export default class kraken extends krakenRest {
         //         "time_out": "2023-09-21T14:36:57.437952Z"
         //     }
         //
-        const reqId = this.safeValue(message, 'req_id');
+        const reqId = this.safeString(message, 'req_id');
         client.resolve(message, reqId);
     }
     /**
@@ -469,7 +469,7 @@ export default class kraken extends krakenRest {
         const token = await this.authenticate();
         const url = this.urls['api']['ws']['privateV2'];
         const requestId = this.requestId();
-        const messageHash = requestId;
+        const messageHash = this.numberToString(requestId);
         const request = {
             'method': 'cancel_all',
             'params': {
@@ -492,7 +492,7 @@ export default class kraken extends krakenRest {
         //         "time_out": "2023-09-21T14:36:57.437952Z"
         //     }
         //
-        const reqId = this.safeValue(message, 'req_id');
+        const reqId = this.safeString(message, 'req_id');
         client.resolve(message, reqId);
     }
     handleTicker(client, message) {

package/js/src/pro/krakenfutures.js

@@ -79,7 +79,7 @@ export default class krakenfutures extends krakenfuturesRest {
         const url = this.urls['api']['ws'];
         const messageHash = 'challenge';
         const client = this.client(url);
-        const future = client.future(messageHash);
+        const future = client.reusableFuture(messageHash);
         const authenticated = this.safeValue(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             const request = {

package/js/src/pro/kucoin.js

@@ -63,16 +63,16 @@ export default class kucoin extends kucoinRest {
     async negotiate(privateChannel, params = {}) {
         const connectId = privateChannel ? 'private' : 'public';
         const urls = this.safeValue(this.options, 'urls', {});
-        const spawaned = this.safeValue(urls, connectId);
-        if (spawaned !== undefined) {
-            return await spawaned;
+        let future = this.safeValue(urls, connectId);
+        if (future !== undefined) {
+            return await future;
         }
         // we store an awaitable to the url
         // so that multiple calls don't asynchronously
         // fetch different urls and overwrite each other
         urls[connectId] = this.spawn(this.negotiateHelper, privateChannel, params);
         this.options['urls'] = urls;
-        const future = urls[connectId];
+        future = urls[connectId];
         return await future;
     }
     async negotiateHelper(privateChannel, params = {}) {

package/js/src/pro/kucoinfutures.js

@@ -82,16 +82,16 @@ export default class kucoinfutures extends kucoinfuturesRest {
     async negotiate(privateChannel, params = {}) {
         const connectId = privateChannel ? 'private' : 'public';
         const urls = this.safeValue(this.options, 'urls', {});
-        const spawaned = this.safeValue(urls, connectId);
-        if (spawaned !== undefined) {
-            return await spawaned;
+        let future = this.safeValue(urls, connectId);
+        if (future !== undefined) {
+            return await future;
         }
         // we store an awaitable to the url
         // so that multiple calls don't asynchronously
         // fetch different urls and overwrite each other
         urls[connectId] = this.spawn(this.negotiateHelper, privateChannel, params); // we have to wait here otherwsie in c# will not work
         this.options['urls'] = urls;
-        const future = urls[connectId];
+        future = urls[connectId];
         return await future;
     }
     async negotiateHelper(privateChannel, params = {}) {

package/js/src/pro/mexc.js

@@ -866,6 +866,7 @@ export default class mexc extends mexcRest {
         }
         const storedOrderBook = this.orderbooks[symbol];
         const nonce = this.safeInteger(storedOrderBook, 'nonce');
+        let shouldReturn = false;
         if (nonce === undefined) {
             const cacheLength = storedOrderBook.cache.length;
             const snapshotDelay = this.handleOption('watchOrderBook', 'snapshotDelay', 25);
@@ -884,7 +885,11 @@ export default class mexc extends mexcRest {
         catch (e) {
             delete client.subscriptions[messageHash];
             client.reject(e, messageHash);
-            return;
+            // return;
+            shouldReturn = true;
+        }
+        if (shouldReturn) {
+            return; // go requirement
         }
         client.resolve(storedOrderBook, messageHash);
     }

package/js/src/pro/modetrade.js

@@ -80,7 +80,7 @@ export default class modetrade extends modetradeRest {
     async watchPublic(messageHash, message) {
         // the default id
         let id = 'OqdphuyCtYWxwzhxyLLjOWNdFP7sQt8RPWzmb5xY';
-        if (this.accountId !== undefined) {
+        if (this.accountId !== undefined && this.accountId !== '') {
             id = this.accountId;
         }
         const url = this.urls['api']['ws']['public'] + '/' + id;
@@ -595,7 +595,7 @@ export default class modetrade extends modetradeRest {
         const client = this.client(url);
         const messageHash = 'authenticated';
         const event = 'auth';
-        const future = client.future(messageHash);
+        const future = client.reusableFuture(messageHash);
         const authenticated = this.safeValue(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             const ts = this.nonce().toString();

package/js/src/pro/okx.d.ts

@@ -388,7 +388,7 @@ export default class okx extends okxRest {
      * @param {object} [params] extra parameters specific to the exchange API endpoint
      * @returns {object} an list of [order structures]{@link https://docs.ccxt.com/#/?id=order-structure}
      */
-    cancelOrdersWs(ids: string[], symbol?: Str, params?: {}): Promise<any>;
+    cancelOrdersWs(ids: string[], symbol?: Str, params?: {}): Promise<Order[]>;
     /**
      * @method
      * @name okx#cancelAllOrdersWs
@@ -398,7 +398,7 @@ export default class okx extends okxRest {
      * @param {object} [params] extra parameters specific to the exchange API endpoint
      * @returns {object[]} a list of [order structures]{@link https://docs.ccxt.com/#/?id=order-structure}
      */
-    cancelAllOrdersWs(symbol?: Str, params?: {}): Promise<any>;
+    cancelAllOrdersWs(symbol?: Str, params?: {}): Promise<Order[]>;
     handleCancelAllOrders(client: Client, message: any): void;
     handleSubscriptionStatus(client: Client, message: any): any;
     handleAuthenticate(client: Client, message: any): void;

package/js/src/pro/okx.js

@@ -1349,7 +1349,9 @@ export default class okx extends okxRest {
             }
             if (error !== undefined) {
                 delete client.subscriptions[messageHash];
-                delete this.orderbooks[symbol];
+                if (symbol !== undefined) {
+                    delete this.orderbooks[symbol];
+                }
                 client.reject(error, messageHash);
             }
         }
@@ -1503,7 +1505,7 @@ export default class okx extends okxRest {
         const url = this.getUrl('users', access);
         const messageHash = 'authenticated';
         const client = this.client(url);
-        const future = client.future(messageHash);
+        const future = client.reusableFuture(messageHash);
         const authenticated = this.safeValue(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             const timestamp = this.seconds().toString();

package/js/src/pro/onetrading.js

@@ -1328,7 +1328,7 @@ export default class onetrading extends onetradingRest {
         const url = this.urls['api']['ws'];
         const client = this.client(url);
         const messageHash = 'authenticated';
-        const future = client.future('authenticated');
+        const future = client.reusableFuture('authenticated');
         const authenticated = this.safeValue(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             this.checkRequiredCredentials();

package/js/src/pro/oxfun.d.ts

@@ -225,7 +225,7 @@ export default class oxfun extends oxfunRest {
      * @param {object} [params] extra parameters specific to the exchange API endpoint
      * @returns {object} an list of [order structures]{@link https://docs.ccxt.com/#/?id=order-structure}
      */
-    cancelOrdersWs(ids: string[], symbol?: Str, params?: {}): Promise<any>;
+    cancelOrdersWs(ids: string[], symbol?: Str, params?: {}): Promise<Order[]>;
     authenticate(params?: {}): Promise<any>;
     handleAuthenticationMessage(client: Client, message: any): void;
     ping(client: Client): string;

package/js/src/pro/oxfun.js

@@ -1023,7 +1023,7 @@ export default class oxfun extends oxfunRest {
         const url = this.urls['api']['ws'];
         const client = this.client(url);
         const messageHash = 'authenticated';
-        const future = client.future(messageHash);
+        const future = client.reusableFuture(messageHash);
         const authenticated = this.safeDict(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             this.checkRequiredCredentials();

package/js/src/pro/poloniex.d.ts

@@ -78,7 +78,7 @@ export default class poloniex extends poloniexRest {
      * @param {string[]} [params.clientOrderIds] client order ids
      * @returns {object} an list of [order structures]{@link https://github.com/ccxt/ccxt/wiki/Manual#order-structure}
      */
-    cancelOrdersWs(ids: string[], symbol?: Str, params?: {}): Promise<any>;
+    cancelOrdersWs(ids: string[], symbol?: Str, params?: {}): Promise<Order[]>;
     /**
      * @method
      * @name poloniex#cancelAllOrdersWs
@@ -88,7 +88,7 @@ export default class poloniex extends poloniexRest {
      * @param {object} [params] extra parameters specific to the poloniex api endpoint
      * @returns {object[]} a list of [order structures]{@link https://github.com/ccxt/ccxt/wiki/Manual#order-structure}
      */
-    cancelAllOrdersWs(symbol?: Str, params?: {}): Promise<any>;
+    cancelAllOrdersWs(symbol?: Str, params?: {}): Promise<Order[]>;
     handleOrderRequest(client: Client, message: any): void;
     /**
      * @method

package/js/src/pro/toobit.js

@@ -1089,7 +1089,7 @@ export default class toobit extends toobitRest {
     async authenticate(params = {}) {
         const client = this.client(this.getUserStreamUrl());
         const messageHash = 'authenticated';
-        const future = client.future(messageHash);
+        const future = client.reusableFuture(messageHash);
         const authenticated = this.safeValue(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             this.checkRequiredCredentials();

package/js/src/pro/whitebit.js

@@ -832,7 +832,7 @@ export default class whitebit extends whitebitRest {
         const url = this.urls['api']['ws'];
         const messageHash = 'authenticated';
         const client = this.client(url);
-        const future = client.future('authenticated');
+        const future = client.reusableFuture('authenticated');
         const authenticated = this.safeValue(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             const authToken = await this.v4PrivatePostProfileWebsocketToken();

package/js/src/pro/woo.js

@@ -843,7 +843,7 @@ export default class woo extends wooRest {
         const client = this.client(url);
         const messageHash = 'authenticated';
         const event = 'auth';
-        const future = client.future(messageHash);
+        const future = client.reusableFuture(messageHash);
         const authenticated = this.safeValue(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             const ts = this.nonce().toString();

package/js/src/pro/woofipro.js

@@ -80,7 +80,7 @@ export default class woofipro extends woofiproRest {
     async watchPublic(messageHash, message) {
         // the default id
         let id = 'OqdphuyCtYWxwzhxyLLjOWNdFP7sQt8RPWzmb5xY';
-        if (this.accountId !== undefined) {
+        if (this.accountId !== undefined && this.accountId !== '') {
             id = this.accountId;
         }
         const url = this.urls['api']['ws']['public'] + '/' + id;
@@ -595,7 +595,7 @@ export default class woofipro extends woofiproRest {
         const client = this.client(url);
         const messageHash = 'authenticated';
         const event = 'auth';
-        const future = client.future(messageHash);
+        const future = client.reusableFuture(messageHash);
         const authenticated = this.safeValue(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             const ts = this.nonce().toString();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.5.8",
+  "version": "4.5.9",
   "description": "A cryptocurrency trading API with more than 100 exchanges in JavaScript / TypeScript / Python / C# / PHP / Go",
   "unpkg": "dist/ccxt.browser.min.js",
   "type": "module",
@@ -31,9 +31,12 @@
     "transpileCS": "tsx build/csharpTranspiler.ts --multi",
     "transpileCSWs": "tsx build/csharpTranspiler.ts --ws",
     "buildCS": "dotnet build cs/ccxt.sln",
+    "buildGO": "go build -C go ./v4 && go build -C go ./v4/pro",
+    "formatGO": "go fmt -C go v4 tests",
+    "transpileGOWs": "tsx build/goTranspiler.ts --ws",
+    "transpileGORest": "tsx build/goTranspiler.ts && tsx build/goTranspiler.ts --ws",
+    "transpileGO": "npm run transpileGORest && npm run transpileGOWs",
     "buildCSTests": "dotnet build cs/tests/tests.csproj",
-    "buildGO": "go build -C go ./v4",
-    "transpileGO": "tsx build/goTranspiler.ts",
     "buildCSRelease": "dotnet build cs --configuration Release",
     "csharp": "npm run transpileCS && npm run transpileCSWs && npm run buildCS",
     "go": "npm run transpileGO && npm run buildGO",
@@ -126,6 +129,7 @@
     "live-tests-rest-csharp": "npm run live-tests -- --csharp",
     "live-tests-rest-go": "npm run live-tests -- --go",
     "live-tests-ws-csharp": "npm run live-tests -- --csharp --ws",
+    "live-tests-ws-go": "npm run live-tests -- --go --ws",
     "ti-ts": "tsx ts/src/test/tests.init.ts",
     "ti-js": "node js/src/test/tests.init.js",
     "ti-py": "python3 python/ccxt/test/tests_init.py",
@@ -175,15 +179,17 @@
     "test-base-ws-py": "npm run ti-py  -- --baseTests --ws",
     "test-base-ws-php": "npm run ti-php -- --baseTests --ws",
     "test-base-ws-cs": "npm run ti-cs  -- --baseTests --ws",
+    "test-base-ws-go": "npm run ti-go  -- --baseTests --ws",
     "test-base-rest": "npm run test-base-rest-js && npm run test-base-rest-py && npm run test-base-rest-php && npm run test-base-rest-cs",
-    "test-base-ws": "npm run test-base-ws-js   && npm run test-base-ws-py   && npm run test-base-ws-php   && npm run test-base-ws-cs",
+    "test-base-ws": "npm run test-base-ws-js   && npm run test-base-ws-py   && npm run test-base-ws-php   && npm run test-base-ws-cs && npm run test-base-ws-go",
     "test": "npm run build && npm run commonjs-test && npm run id-tests && npm run request-tests && npm run response-tests && npm run live-tests",
     "commonjs-test": "node ./utils/test-commonjs.cjs",
     "package-test": "./utils/package-test.sh",
     "test-freshness": "tsx ./utils/test-freshness.ts",
     "benchmark": "tsx examples/ts/benchmark.ts",
     "cleanup-old-tags": "tsx ./build/cleanup-old-tags.ts",
-    "test-types-go": "go run -C go ./tests/types/types.go"
+    "test-types-go": "go run -C go ./tests/types/types.go",
+    "test-go": "npm run test-types-go && npm run response-go && npm run request-go && npm run test-base-rest-go && npm run test-base-ws-go"
   },
   "types": "./js/ccxt.d.ts",
   "devDependencies": {
@@ -197,26 +203,31 @@
     "as-table": "^1.0.55",
     "asciichart": "^1.5.25",
     "assert": "^2.0.0",
-    "ast-transpiler": "^0.0.70",
+    "ast-transpiler": "^0.0.71",
+    "blessed": "^0.1.81",
+    "clipboardy": "^5.0.0",
+    "commander": "^14.0.1",
     "docsify": "^4.13.1",
-    "eslint": "8.22.0",
     "eslint-config-airbnb-base": "15.0.0",
     "eslint-plugin-import": "2.25.4",
     "eslint-plugin-jsdoc": "^46.9.0",
+    "eslint": "8.22.0",
     "https-proxy-agent": "^5.0.1",
     "jsdoc-to-markdown": "^8.0.0",
     "ololog": "^1.1.175",
+    "open": "^10.2.0",
+    "ora": "^9.0.0",
     "piscina": "^3.2.0",
     "protobufjs": "^7.5.3",
     "replace-in-file": "^6.3.5",
-    "rollup": "^2.70.1",
     "rollup-plugin-execute": "1.1.1",
+    "rollup": "^2.70.1",
     "terser-webpack-plugin": "^5.3.9",
     "ts-loader": "^9.4.2",
     "tsx": "^4.7.2",
     "typescript": "4.7.4",
-    "webpack": "^5.76.2",
-    "webpack-cli": "^5.0.1"
+    "webpack-cli": "^5.0.1",
+    "webpack": "^5.76.2"
   },
   "author": {
     "name": "Igor Kroitor",