ccxt 4.5.6 → 4.5.7

package/js/src/binance.js

@@ -12062,6 +12062,9 @@ export default class binance extends Exchange {
         }
         else if ((api === 'private') || (api === 'eapiPrivate') || (api === 'sapi' && path !== 'system/status') || (api === 'sapiV2') || (api === 'sapiV3') || (api === 'sapiV4') || (api === 'dapiPrivate') || (api === 'dapiPrivateV2') || (api === 'fapiPrivate') || (api === 'fapiPrivateV2') || (api === 'fapiPrivateV3') || (api === 'papi' && path !== 'ping')) {
             this.checkRequiredCredentials();
+            if ((url.indexOf('testnet.binancefuture.com') > -1) && this.isSandboxModeEnabled && (!this.safeBool(this.options, 'disableFuturesSandboxWarning'))) {
+                throw new NotSupported(this.id + ' testnet/sandbox mode is not supported for futures anymore, please check the deprecation announcement https://t.me/ccxt_announcements/92 and consider using the demo trading instead.');
+            }
             if (method === 'POST' && ((path === 'order') || (path === 'sor/order'))) {
                 // inject in implicit API calls
                 const newClientOrderId = this.safeString(params, 'newClientOrderId');

package/js/src/bitbank.js

@@ -43,6 +43,7 @@ export default class bitbank extends Exchange {
                 'fetchBorrowRatesPerSymbol': false,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchDepositAddress': true,
                 'fetchDepositAddresses': false,
                 'fetchDepositAddressesByNetwork': false,

package/js/src/bitbns.js

@@ -32,6 +32,7 @@ export default class bitbns extends Exchange {
                 'createStopOrder': true,
                 'createTriggerOrder': true,
                 'fetchBalance': true,
+                'fechCurrencies': false,
                 'fetchDepositAddress': true,
                 'fetchDepositAddresses': false,
                 'fetchDepositAddressesByNetwork': false,

package/js/src/bitflyer.js

@@ -30,6 +30,7 @@ export default class bitflyer extends Exchange {
                 'createOrder': true,
                 'fetchBalance': true,
                 'fetchClosedOrders': 'emulated',
+                'fetchCurrencies': false,
                 'fetchDeposits': true,
                 'fetchFundingRate': true,
                 'fetchFundingRateHistory': false,

package/js/src/bithumb.js

@@ -45,6 +45,7 @@ export default class bithumb extends Exchange {
                 'fetchBorrowRatesPerSymbol': false,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchFundingHistory': false,
                 'fetchFundingInterval': false,
                 'fetchFundingIntervals': false,

package/js/src/bitso.js

@@ -48,6 +48,7 @@ export default class bitso extends Exchange {
                 'fetchBorrowRatesPerSymbol': false,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchDeposit': true,
                 'fetchDepositAddress': true,
                 'fetchDepositAddresses': false,

package/js/src/bitvavo.d.ts

@@ -6,8 +6,6 @@ import type { Balances, Currencies, Currency, Dict, Int, Market, Num, OHLCV, Ord
  */
 export default class bitvavo extends Exchange {
     describe(): any;
-    amountToPrecision(symbol: any, amount: any): string;
-    priceToPrecision(symbol: any, price: any): string;
     /**
      * @method
      * @name bitvavo#fetchTime

package/js/src/bitvavo.js

@@ -1,7 +1,7 @@
 // ----------------------------------------------------------------------------
 import Exchange from './abstract/bitvavo.js';
 import { ExchangeError, BadSymbol, AuthenticationError, InsufficientFunds, InvalidOrder, ArgumentsRequired, OrderNotFound, InvalidAddress, BadRequest, RateLimitExceeded, PermissionDenied, ExchangeNotAvailable, AccountSuspended, OnMaintenance } from './base/errors.js';
-import { SIGNIFICANT_DIGITS, DECIMAL_PLACES, TRUNCATE, ROUND } from './base/functions/number.js';
+import { TRUNCATE, TICK_SIZE } from './base/functions/number.js';
 import { Precise } from './base/Precise.js';
 import { sha256 } from './static_dependencies/noble-hashes/sha256.js';
 // ----------------------------------------------------------------------------
@@ -377,26 +377,12 @@ export default class bitvavo extends Exchange {
                 'operatorId': undefined,
                 'fiatCurrencies': ['EUR'], // only fiat atm
             },
-            'precisionMode': SIGNIFICANT_DIGITS,
+            'precisionMode': TICK_SIZE,
             'commonCurrencies': {
                 'MIOTA': 'IOTA', // https://github.com/ccxt/ccxt/issues/7487
             },
         });
     }
-    amountToPrecision(symbol, amount) {
-        // https://docs.bitfinex.com/docs/introduction#amount-precision
-        // The amount field allows up to 8 decimals.
-        // Anything exceeding this will be rounded to the 8th decimal.
-        return this.decimalToPrecision(amount, TRUNCATE, this.markets[symbol]['precision']['amount'], DECIMAL_PLACES);
-    }
-    priceToPrecision(symbol, price) {
-        price = this.decimalToPrecision(price, ROUND, this.markets[symbol]['precision']['price'], this.precisionMode);
-        // https://docs.bitfinex.com/docs/introduction#price-precision
-        // The precision level of all trading prices is based on significant figures.
-        // All pairs on Bitfinex use up to 5 significant digits and up to 8 decimals (e.g. 1.2345, 123.45, 1234.5, 0.00012345).
-        // Prices submit with a precision larger than 5 will be cut by the API.
-        return this.decimalToPrecision(price, TRUNCATE, 8, DECIMAL_PLACES);
-    }
     /**
      * @method
      * @name bitvavo#fetchTime
@@ -422,24 +408,27 @@ export default class bitvavo extends Exchange {
     async fetchMarkets(params = {}) {
         const response = await this.publicGetMarkets(params);
         //
-        //     [
-        //         {
-        //             "market":"ADA-BTC",
-        //             "status":"trading", // "trading" "halted" "auction"
-        //             "base":"ADA",
-        //             "quote":"BTC",
-        //             "pricePrecision":5,
-        //             "minOrderInBaseAsset":"100",
-        //             "minOrderInQuoteAsset":"0.001",
-        //             "orderTypes": [ "market", "limit" ]
-        //         }
-        //     ]
+        //    {
+        //        "market": "BTC-EUR",
+        //        "status": "trading",
+        //        "base": "BTC",
+        //        "quote": "EUR",
+        //        "pricePrecision": "0", // deprecated, this is mostly 0 across other markets too, which is abnormal, so we ignore this.
+        //        "tickSize": "1.00",
+        //        "minOrderInBaseAsset": "0.00006100",
+        //        "minOrderInQuoteAsset": "5.00",
+        //        "maxOrderInBaseAsset": "1000000000.00000000",
+        //        "maxOrderInQuoteAsset": "1000000000.00",
+        //        "quantityDecimals": "8",
+        //        "notionalDecimals": "2",
+        //        "maxOpenOrders": "100",
+        //        "feeCategory": "A",
+        //        "orderTypes": [ "market", "limit", "stopLoss", "stopLossLimit", "takeProfit", "takeProfitLimit" ]
+        //    }
         //
         return this.parseMarkets(response);
     }
     parseMarkets(markets) {
-        const currencies = this.currencies;
-        const currenciesById = this.indexBy(currencies, 'id');
         const result = [];
         const fees = this.fees;
         for (let i = 0; i < markets.length; i++) {
@@ -450,8 +439,6 @@ export default class bitvavo extends Exchange {
             const base = this.safeCurrencyCode(baseId);
             const quote = this.safeCurrencyCode(quoteId);
             const status = this.safeString(market, 'status');
-            const baseCurrency = this.safeValue(currenciesById, baseId);
-            const basePrecision = this.safeInteger(baseCurrency, 'precision');
             result.push(this.safeMarketStructure({
                 'id': id,
                 'symbol': base + '/' + quote,
@@ -479,8 +466,9 @@ export default class bitvavo extends Exchange {
                 'taker': fees['trading']['taker'],
                 'maker': fees['trading']['maker'],
                 'precision': {
-                    'amount': this.safeInteger(baseCurrency, 'decimals', basePrecision),
-                    'price': this.safeInteger(market, 'pricePrecision'),
+                    'amount': this.parseNumber(this.parsePrecision(this.safeString(market, 'quantityDecimals'))),
+                    'price': this.safeNumber(market, 'tickSize'),
+                    'cost': this.parseNumber(this.parsePrecision(this.safeString(market, 'notionalDecimals'))),
                 },
                 'limits': {
                     'leverage': {
@@ -489,7 +477,7 @@ export default class bitvavo extends Exchange {
                     },
                     'amount': {
                         'min': this.safeNumber(market, 'minOrderInBaseAsset'),
-                        'max': undefined,
+                        'max': this.safeNumber(market, 'maxOrderInBaseAsset'),
                     },
                     'price': {
                         'min': undefined,
@@ -497,7 +485,7 @@ export default class bitvavo extends Exchange {
                     },
                     'cost': {
                         'min': this.safeNumber(market, 'minOrderInQuoteAsset'),
-                        'max': undefined,
+                        'max': this.safeNumber(market, 'maxOrderInQuoteAsset'),
                     },
                 },
                 'created': undefined,
@@ -598,7 +586,7 @@ export default class bitvavo extends Exchange {
             const withdrawal = this.safeString(currency, 'withdrawalStatus') === 'OK';
             const active = deposit && withdrawal;
             const withdrawFee = this.safeNumber(currency, 'withdrawalFee');
-            const precision = this.safeInteger(currency, 'decimals', 8);
+            const precision = this.safeString(currency, 'decimals', '8');
             const minWithdraw = this.safeNumber(currency, 'withdrawalMinAmount');
             // btw, absolutely all of them have 1 network atm
             for (let j = 0; j < networksArray.length; j++) {
@@ -612,7 +600,7 @@ export default class bitvavo extends Exchange {
                     'deposit': deposit,
                     'withdraw': withdrawal,
                     'fee': withdrawFee,
-                    'precision': precision,
+                    'precision': this.parseNumber(this.parsePrecision(precision)),
                     'limits': {
                         'withdraw': {
                             'min': minWithdraw,
@@ -631,7 +619,7 @@ export default class bitvavo extends Exchange {
                 'withdraw': withdrawal,
                 'networks': networks,
                 'fee': withdrawFee,
-                'precision': precision,
+                'precision': undefined,
                 'type': isFiat ? 'fiat' : 'crypto',
                 'limits': {
                     'amount': {
@@ -649,8 +637,6 @@ export default class bitvavo extends Exchange {
                 },
             });
         }
-        // set currencies here to avoid calling publicGetAssets twice
-        this.currencies = this.mapToSafeMap(this.deepExtend(this.currencies, result));
         return result;
     }
     /**

package/js/src/blockchaincom.js

@@ -34,6 +34,7 @@ export default class blockchaincom extends Exchange {
                 'fetchBalance': true,
                 'fetchCanceledOrders': true,
                 'fetchClosedOrders': true,
+                'fetchCurrencies': false,
                 'fetchDeposit': true,
                 'fetchDepositAddress': true,
                 'fetchDepositAddresses': false,

package/js/src/btcalpha.js

@@ -49,6 +49,7 @@ export default class btcalpha extends Exchange {
                 'fetchClosedOrders': true,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchDeposit': false,
                 'fetchDepositAddress': false,
                 'fetchDepositAddresses': false,

package/js/src/btcbox.js

@@ -47,6 +47,7 @@ export default class btcbox extends Exchange {
                 'fetchBorrowRatesPerSymbol': false,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchFundingHistory': false,
                 'fetchFundingInterval': false,
                 'fetchFundingIntervals': false,

package/js/src/btcmarkets.js

@@ -49,6 +49,7 @@ export default class btcmarkets extends Exchange {
                 'fetchClosedOrders': 'emulated',
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchDepositAddress': false,
                 'fetchDepositAddresses': false,
                 'fetchDepositAddressesByNetwork': false,

package/js/src/btcturk.js

@@ -46,6 +46,7 @@ export default class btcturk extends Exchange {
                 'fetchBorrowRatesPerSymbol': false,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchDepositAddress': false,
                 'fetchDepositAddresses': false,
                 'fetchDepositAddressesByNetwork': false,

package/js/src/deribit.js

@@ -2705,8 +2705,9 @@ export default class deribit extends Exchange {
             'notional': this.parseNumber(notionalStringAbs),
             'leverage': this.safeInteger(position, 'leverage'),
             'unrealizedPnl': this.parseNumber(unrealizedPnl),
-            'contracts': undefined,
-            'contractSize': this.safeNumber(market, 'contractSize'),
+            'realizedPnl': this.safeNumber(position, 'realized_profit_loss'),
+            'contracts': this.safeNumber(position, 'size'),
+            'contractSize': this.safeNumber(position, 'contractSize'),
             'marginRatio': undefined,
             'liquidationPrice': this.safeNumber(position, 'estimated_liquidation_price'),
             'markPrice': this.safeNumber(position, 'mark_price'),

package/js/src/digifinex.js

@@ -523,7 +523,7 @@ export default class digifinex extends Exchange {
             const networks = {};
             for (let j = 0; j < networkEntries.length; j++) {
                 const networkEntry = networkEntries[j];
-                const networkId = this.safeString(networkEntry, 'chain');
+                const networkId = this.safeString2(networkEntry, 'chain', 'currency');
                 const networkCode = this.networkIdToCode(networkId);
                 networks[networkCode] = {
                     'id': networkId,

package/js/src/gate.d.ts

@@ -63,8 +63,8 @@ export default class gate extends Exchange {
         contract: boolean;
         linear: boolean;
         inverse: boolean;
-        taker: number;
-        maker: number;
+        taker: any;
+        maker: any;
         contractSize: number;
         expiry: number;
         expiryDatetime: string;

package/js/src/gate.js

@@ -1439,8 +1439,8 @@ export default class gate extends Exchange {
         //        "leverage_min": "1",
         //        "leverage_max": "100",
         //        "risk_limit_max": "8000000",
-        //        "maker_fee_rate": "-0.00025",
-        //        "taker_fee_rate": "0.00075",
+        //        "maker_fee_rate": "-0.00025", // not actual value for regular users
+        //        "taker_fee_rate": "0.00075", // not actual value for regular users
         //        "funding_rate": "0.002053",
         //        "order_size_max": 1000000,
         //        "funding_next_apply": 1610035200,
@@ -1484,8 +1484,8 @@ export default class gate extends Exchange {
         //        "risk_limit_base": "140.726652109199",
         //        "risk_limit_step": "1000000",
         //        "risk_limit_max": "8000000",
-        //        "maker_fee_rate": "-0.00025",
-        //        "taker_fee_rate": "0.00075",
+        //        "maker_fee_rate": "-0.00025", // not actual value for regular users
+        //        "taker_fee_rate": "0.00075", // not actual value for regular users
         //        "ref_discount_rate": "0",
         //        "ref_rebate_rate": "0.2",
         //        "order_price_deviate": "0.5",
@@ -1524,8 +1524,6 @@ export default class gate extends Exchange {
         const maxMultiplier = Precise.stringAdd('1', priceDeviate);
         const minPrice = Precise.stringMul(minMultiplier, markPrice);
         const maxPrice = Precise.stringMul(maxMultiplier, markPrice);
-        const takerPercent = this.safeString(market, 'taker_fee_rate');
-        const makerPercent = this.safeString(market, 'maker_fee_rate', takerPercent);
         const isLinear = quote === settle;
         let contractSize = this.safeString(market, 'quanto_multiplier');
         // exception only for one market: https://api.gateio.ws/api/v4/futures/btc/contracts
@@ -1551,8 +1549,8 @@ export default class gate extends Exchange {
             'contract': true,
             'linear': isLinear,
             'inverse': !isLinear,
-            'taker': this.parseNumber(Precise.stringDiv(takerPercent, '100')),
-            'maker': this.parseNumber(Precise.stringDiv(makerPercent, '100')),
+            'taker': undefined,
+            'maker': undefined,
             'contractSize': this.parseNumber(contractSize),
             'expiry': expiry,
             'expiryDatetime': this.iso8601(expiry),
@@ -1651,8 +1649,6 @@ export default class gate extends Exchange {
                 const maxMultiplier = Precise.stringAdd('1', priceDeviate);
                 const minPrice = Precise.stringMul(minMultiplier, markPrice);
                 const maxPrice = Precise.stringMul(maxMultiplier, markPrice);
-                const takerPercent = this.safeString(market, 'taker_fee_rate');
-                const makerPercent = this.safeString(market, 'maker_fee_rate', takerPercent);
                 result.push({
                     'id': id,
                     'symbol': symbol,
@@ -1672,8 +1668,8 @@ export default class gate extends Exchange {
                     'contract': true,
                     'linear': true,
                     'inverse': false,
-                    'taker': this.parseNumber(Precise.stringDiv(takerPercent, '100')),
-                    'maker': this.parseNumber(Precise.stringDiv(makerPercent, '100')),
+                    'taker': undefined,
+                    'maker': undefined,
                     'contractSize': this.parseNumber('1'),
                     'expiry': expiry,
                     'expiryDatetime': this.iso8601(expiry),

package/js/src/gemini.js

@@ -665,9 +665,9 @@ export default class gemini extends Exchange {
                 const indexedTradingPairs = this.indexBy(tradingPairs, 0);
                 for (let i = 0; i < marketIds.length; i++) {
                     const marketId = marketIds[i];
-                    const tradingPair = this.safeList(indexedTradingPairs, marketId.toUpperCase());
-                    if (tradingPair !== undefined && !this.inArray(tradingPair, brokenPairs)) {
-                        result.push(this.parseMarket(tradingPair));
+                    const pairInfo = this.safeList(indexedTradingPairs, marketId.toUpperCase());
+                    if (pairInfo !== undefined && !this.inArray(marketId, brokenPairs)) {
+                        result.push(this.parseMarket(pairInfo));
                     }
                 }
             }

package/js/src/htx.js

@@ -2791,7 +2791,17 @@ export default class htx extends Exchange {
                 'currency': feeCurrency,
             };
         }
-        const id = this.safeStringN(trade, ['trade_id', 'trade-id', 'id']);
+        // htx's multi-market trade-id is a bit complex to parse accordingly.
+        // - for `id` which contains hyphen, it would be the unique id, eg. xxxxxx-1, xxxxxx-2 (this happens mostly for contract markets)
+        // - otherwise the least priority is given to the `id` key
+        let id = undefined;
+        const safeId = this.safeString(trade, 'id');
+        if (safeId !== undefined && safeId.indexOf('-') >= 0) {
+            id = safeId;
+        }
+        else {
+            id = this.safeStringN(trade, ['trade_id', 'trade-id', 'id']);
+        }
         return this.safeTrade({
             'id': id,
             'info': trade,

package/js/src/independentreserve.js

@@ -47,6 +47,7 @@ export default class independentreserve extends Exchange {
                 'fetchClosedOrders': true,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchDepositAddress': true,
                 'fetchDepositAddresses': false,
                 'fetchDepositAddressesByNetwork': false,

package/js/src/indodax.js

@@ -51,6 +51,7 @@ export default class indodax extends Exchange {
                 'fetchClosedOrders': true,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchDeposit': false,
                 'fetchDepositAddress': 'emulated',
                 'fetchDepositAddresses': true,
@@ -360,7 +361,7 @@ export default class indodax extends Exchange {
         const result = [];
         for (let i = 0; i < response.length; i++) {
             const market = response[i];
-            const id = this.safeString(market, 'ticker_id');
+            const id = this.safeString(market, 'id');
             const baseId = this.safeString(market, 'traded_currency');
             const quoteId = this.safeString(market, 'base_currency');
             const base = this.safeCurrencyCode(baseId);
@@ -499,7 +500,7 @@ export default class indodax extends Exchange {
         await this.loadMarkets();
         const market = this.market(symbol);
         const request = {
-            'pair': market['base'] + market['quote'],
+            'pair': market['id'],
         };
         const orderbook = await this.publicGetApiDepthPair(this.extend(request, params));
         return this.parseOrderBook(orderbook, market['symbol'], undefined, 'buy', 'sell');
@@ -558,7 +559,7 @@ export default class indodax extends Exchange {
         await this.loadMarkets();
         const market = this.market(symbol);
         const request = {
-            'pair': market['base'] + market['quote'],
+            'pair': market['id'],
         };
         const response = await this.publicGetApiTickerPair(this.extend(request, params));
         //
@@ -607,7 +608,17 @@ export default class indodax extends Exchange {
         //
         const response = await this.publicGetApiTickerAll(params);
         const tickers = this.safeDict(response, 'tickers', {});
-        return this.parseTickers(tickers, symbols);
+        const keys = Object.keys(tickers);
+        const parsedTickers = {};
+        for (let i = 0; i < keys.length; i++) {
+            const key = keys[i];
+            const rawTicker = tickers[key];
+            const marketId = key.replace('_', '');
+            const market = this.safeMarket(marketId);
+            const parsed = this.parseTicker(rawTicker, market);
+            parsedTickers[marketId] = parsed;
+        }
+        return this.filterByArray(parsedTickers, 'symbol', symbols);
     }
     parseTrade(trade, market = undefined) {
         const timestamp = this.safeTimestamp(trade, 'date');
@@ -642,7 +653,7 @@ export default class indodax extends Exchange {
         await this.loadMarkets();
         const market = this.market(symbol);
         const request = {
-            'pair': market['base'] + market['quote'],
+            'pair': market['id'],
         };
         const response = await this.publicGetApiTradesPair(this.extend(request, params));
         return this.parseTrades(response, market, since, limit);
@@ -689,7 +700,7 @@ export default class indodax extends Exchange {
         const request = {
             'to': until,
             'tf': selectedTimeframe,
-            'symbol': market['base'] + market['quote'],
+            'symbol': market['id'],
         };
         if (limit === undefined) {
             limit = 1000;

package/js/src/kraken.d.ts

@@ -304,7 +304,7 @@ export default class kraken extends Exchange {
      * @name kraken#cancelAllOrders
      * @description cancel all open orders
      * @see https://docs.kraken.com/rest/#tag/Spot-Trading/operation/cancelAllOrders
-     * @param {string} symbol unified market symbol, only orders in the market of this symbol are cancelled when symbol is not undefined
+     * @param {string} symbol unified market symbol, not used by kraken cancelAllOrders (all open orders are cancelled)
      * @param {object} [params] extra parameters specific to the exchange API endpoint
      * @returns {object[]} a list of [order structures]{@link https://docs.ccxt.com/#/?id=order-structure}
      */

package/js/src/kraken.js

@@ -231,6 +231,23 @@ export default class kraken extends Exchange {
                 'XBT': 'BTC',
                 'XDG': 'DOGE',
                 'FEE': 'KFEE',
+                'XETC': 'ETC',
+                'XETH': 'ETH',
+                'XLTC': 'LTC',
+                'XMLN': 'MLN',
+                'XREP': 'REP',
+                'XXBT': 'BTC',
+                'XXDG': 'DOGE',
+                'XXLM': 'XLM',
+                'XXMR': 'XMR',
+                'XXRP': 'XRP',
+                'XZEC': 'ZEC',
+                'ZAUD': 'AUD',
+                'ZCAD': 'CAD',
+                'ZEUR': 'EUR',
+                'ZGBP': 'GBP',
+                'ZJPY': 'JPY',
+                'ZUSD': 'USD',
             },
             'options': {
                 'timeDifference': 0,
@@ -611,10 +628,12 @@ export default class kraken extends Exchange {
         for (let i = 0; i < keys.length; i++) {
             const id = keys[i];
             const market = markets[id];
-            const baseId = this.safeString(market, 'base');
-            const quoteId = this.safeString(market, 'quote');
-            const base = this.safeCurrencyCode(baseId);
-            const quote = this.safeCurrencyCode(quoteId);
+            const baseIdRaw = this.safeString(market, 'base');
+            const quoteIdRaw = this.safeString(market, 'quote');
+            const baseId = this.safeCurrencyCode(baseIdRaw);
+            const quoteId = this.safeCurrencyCode(quoteIdRaw);
+            const base = baseId;
+            const quote = quoteId;
             const makerFees = this.safeList(market, 'fees_maker', []);
             const firstMakerFee = this.safeList(makerFees, 0, []);
             const firstMakerFeeRate = this.safeString(firstMakerFee, 1);
@@ -2524,7 +2543,7 @@ export default class kraken extends Exchange {
      * @name kraken#cancelAllOrders
      * @description cancel all open orders
      * @see https://docs.kraken.com/rest/#tag/Spot-Trading/operation/cancelAllOrders
-     * @param {string} symbol unified market symbol, only orders in the market of this symbol are cancelled when symbol is not undefined
+     * @param {string} symbol unified market symbol, not used by kraken cancelAllOrders (all open orders are cancelled)
      * @param {object} [params] extra parameters specific to the exchange API endpoint
      * @returns {object[]} a list of [order structures]{@link https://docs.ccxt.com/#/?id=order-structure}
      */
@@ -3196,7 +3215,6 @@ export default class kraken extends Exchange {
      */
     async withdraw(code, amount, address, tag = undefined, params = {}) {
         [tag, params] = this.handleWithdrawTagAndParams(tag, params);
-        this.checkAddress(address);
         if ('key' in params) {
             await this.loadMarkets();
             const currency = this.currency(code);
@@ -3207,6 +3225,7 @@ export default class kraken extends Exchange {
             };
             if (address !== undefined && address !== '') {
                 request['address'] = address;
+                this.checkAddress(address);
             }
             const response = await this.privatePostWithdraw(this.extend(request, params));
             //

package/js/src/krakenfutures.js

@@ -47,6 +47,7 @@ export default class krakenfutures extends Exchange {
                 'fetchClosedOrders': true,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchDepositAddress': false,
                 'fetchDepositAddresses': false,
                 'fetchDepositAddressesByNetwork': false,

package/js/src/mercado.js

@@ -47,6 +47,7 @@ export default class mercado extends Exchange {
                 'fetchBorrowRatesPerSymbol': false,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchCurrencies': false,
                 'fetchDepositAddress': false,
                 'fetchDepositAddresses': false,
                 'fetchDepositAddressesByNetwork': false,

package/js/src/mexc.d.ts

@@ -624,10 +624,13 @@ export default class mexc extends Exchange {
      * @description fetch a history of internal transfers made on an account
      * @see https://mexcdevelop.github.io/apidocs/spot_v2_en/#get-internal-assets-transfer-records
      * @see https://mexcdevelop.github.io/apidocs/contract_v1_en/#get-the-user-39-s-asset-transfer-records
-     * @param {string} code unified currency code of the currency transferred
+     * @see https://www.mexc.com/api-docs/spot-v3/wallet-endpoints#query-user-universal-transfer-history     * @param {string} code unified currency code of the currency transferred
+     * @param code
      * @param {int} [since] the earliest time in ms to fetch transfers for
      * @param {int} [limit] the maximum number of  transfers structures to retrieve
      * @param {object} [params] extra parameters specific to the exchange API endpoint
+     * @param {string} [params.fromAccountType] 'SPOT' for spot wallet, 'FUTURES' for contract wallet
+     * @param {string} [params.toAccountType] 'SPOT' for spot wallet, 'FUTURES' for contract wallet
      * @returns {object[]} a list of [transfer structures]{@link https://docs.ccxt.com/#/?id=transfer-structure}
      */
     fetchTransfers(code?: Str, since?: Int, limit?: Int, params?: {}): Promise<TransferEntry[]>;