ccxt 4.5.55 → 4.5.57

package/js/src/bitfinex.js

@@ -846,74 +846,87 @@ export default class bitfinex extends Exchange {
             indexedNetworks[networkName] = networksList;
         }
         const ids = this.safeList(response, 0, []);
-        const result = {};
+        return this.parseCurrenciesCustom(ids, indexed, indexedNetworks);
+    }
+    parseCurrenciesCustom(ids, indexed, indexedNetworks) {
+        const allowedIds = [];
         for (let i = 0; i < ids.length; i++) {
             const id = ids[i];
             if (id.endsWith('F0')) {
                 // we get a lot of F0 currencies, skip those
                 continue;
             }
-            const code = this.safeCurrencyCode(id);
-            const label = this.safeList(indexed['label'], id, []);
-            const name = this.safeString(label, 1);
-            const pool = this.safeList(indexed['pool'], id, []);
-            const rawType = this.safeString(pool, 1);
-            const isCryptoCoin = (rawType !== undefined) || (id in indexed['explorer']); // "hacky" solution
-            const type = isCryptoCoin ? 'crypto' : undefined;
-            const feeValues = this.safeList(indexed['fees'], id, []);
-            const fees = this.safeList(feeValues, 1, []);
-            const fee = this.safeNumber(fees, 1);
-            const undl = this.safeList(indexed['undl'], id, []);
-            const precision = this.safeString(this.options, 'defaultCurrencyPrecision', '8');
-            const networks = {};
-            const netwokIds = this.safeList(indexedNetworks, id, []);
-            for (let j = 0; j < netwokIds.length; j++) {
-                const networkId = netwokIds[j];
-                const network = this.networkIdToCode(networkId);
-                const dwStatuses = this.safeList(indexed['statuses'], networkId, []);
-                networks[network] = {
-                    'info': networkId,
-                    'id': networkId.toLowerCase(),
-                    'network': networkId,
-                    'active': undefined,
-                    'deposit': this.safeInteger(dwStatuses, 1) === 1,
-                    'withdraw': this.safeInteger(dwStatuses, 2) === 1,
-                    'fee': undefined,
-                    'precision': undefined,
-                    'limits': {
-                        'withdraw': {
-                            'min': undefined,
-                            'max': undefined,
-                        },
-                    },
-                };
-            }
-            result[code] = this.safeCurrencyStructure({
-                'id': id,
-                'code': code,
-                'info': [id, label, pool, feeValues, undl],
-                'type': type,
-                'name': name,
-                'active': true,
-                'deposit': undefined,
-                'withdraw': undefined,
-                'fee': fee,
-                'precision': this.parseNumber(precision),
+            allowedIds.push(id);
+        }
+        const result = {};
+        const arr = this.toArray(allowedIds);
+        for (let i = 0; i < arr.length; i++) {
+            const parsed = this.parseCurrencyCustom(arr[i], indexed, indexedNetworks);
+            const code = parsed['code'];
+            result[code] = parsed;
+        }
+        return result;
+    }
+    parseCurrencyCustom(id, indexed, indexedNetworks) {
+        const code = this.safeCurrencyCode(id);
+        const label = this.safeList(indexed['label'], id, []);
+        const name = this.safeString(label, 1);
+        const pool = this.safeList(indexed['pool'], id, []);
+        const rawType = this.safeString(pool, 1);
+        const isCryptoCoin = (rawType !== undefined) || (id in indexed['explorer']); // "hacky" solution
+        const type = isCryptoCoin ? 'crypto' : undefined;
+        const feeValues = this.safeList(indexed['fees'], id, []);
+        const fees = this.safeList(feeValues, 1, []);
+        const fee = this.safeNumber(fees, 1);
+        const undl = this.safeList(indexed['undl'], id, []);
+        const precision = this.safeString(this.options, 'defaultCurrencyPrecision', '8');
+        const networks = {};
+        const networkIds = this.safeList(indexedNetworks, id, []);
+        for (let j = 0; j < networkIds.length; j++) {
+            const networkId = networkIds[j];
+            const network = this.networkIdToCode(networkId, code);
+            const dwStatuses = this.safeList(indexed['statuses'], networkId, []);
+            networks[network] = {
+                'info': networkId,
+                'id': networkId.toLowerCase(),
+                'network': networkId,
+                'active': undefined,
+                'deposit': this.safeInteger(dwStatuses, 1) === 1,
+                'withdraw': this.safeInteger(dwStatuses, 2) === 1,
+                'fee': undefined,
+                'precision': undefined,
                 'limits': {
-                    'amount': {
-                        'min': undefined,
-                        'max': undefined,
-                    },
                     'withdraw': {
-                        'min': fee,
+                        'min': undefined,
                         'max': undefined,
                     },
                 },
-                'networks': networks,
-                'margin': this.inArray(id, indexed['marginables']),
-            });
+            };
         }
-        return result;
+        return this.safeCurrencyStructure({
+            'id': id,
+            'code': code,
+            'info': [id, label, pool, feeValues, undl],
+            'type': type,
+            'name': name,
+            'active': true,
+            'deposit': undefined,
+            'withdraw': undefined,
+            'fee': fee,
+            'precision': this.parseNumber(precision),
+            'limits': {
+                'amount': {
+                    'min': undefined,
+                    'max': undefined,
+                },
+                'withdraw': {
+                    'min': fee,
+                    'max': undefined,
+                },
+            },
+            'networks': networks,
+            'margin': this.inArray(id, indexed['marginables']),
+        });
     }
     /**
      * @method
@@ -2482,14 +2495,14 @@ export default class bitfinex extends Exchange {
             tag = this.safeString(data, 3);
             type = 'withdrawal';
             const networkId = this.safeString(data, 2);
-            network = this.networkIdToCode(networkId.toUpperCase()); // withdraw returns in lowercase
+            network = this.networkIdToCode(networkId.toUpperCase(), code); // withdraw returns in lowercase
         }
         else if (transactionLength === 22) {
             id = this.safeString(transaction, 0);
             const currencyId = this.safeString(transaction, 1);
             code = this.safeCurrencyCode(currencyId, currency);
             const networkId = this.safeString(transaction, 2);
-            network = this.networkIdToCode(networkId);
+            network = this.networkIdToCode(networkId, code);
             timestamp = this.safeInteger(transaction, 5);
             updated = this.safeInteger(transaction, 6);
             status = this.parseTransactionStatus(this.safeString(transaction, 9));

package/js/src/bitflyer.js

@@ -1191,7 +1191,8 @@ export default class bitflyer extends Exchange {
         if (api === 'private') {
             this.checkRequiredCredentials();
             const nonce = this.nonce().toString();
-            let auth = [nonce, method, request].join('');
+            const content = [nonce, method, request];
+            let auth = content.join('');
             if (Object.keys(params).length) {
                 if (method !== 'GET') {
                     body = this.json(params);

package/js/src/bitget.js

@@ -1960,9 +1960,7 @@ export default class bitget extends Exchange {
         if (uta) {
             return await this.fetchUtaMarkets(params);
         }
-        else {
-            return await this.fetchDefaultMarkets(params);
-        }
+        return await this.fetchDefaultMarkets(params);
     }
     async fetchDefaultMarkets(params) {
         let types = undefined;
@@ -2893,7 +2891,7 @@ export default class bitget extends Exchange {
         }
         await this.loadMarkets();
         const currency = this.currency(code);
-        const networkId = this.networkCodeToId(networkCode);
+        const networkId = this.networkCodeToId(networkCode, code);
         const request = {
             'coin': currency['id'],
             'address': address,
@@ -3062,7 +3060,7 @@ export default class bitget extends Exchange {
             'txid': this.safeString(transaction, 'tradeId'),
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
-            'network': this.networkIdToCode(networkId),
+            'network': this.networkIdToCode(networkId, code),
             'addressFrom': this.safeString(transaction, 'fromAddress'),
             'address': this.safeString(transaction, 'toAddress'),
             'addressTo': this.safeString(transaction, 'toAddress'),
@@ -5363,6 +5361,13 @@ export default class bitget extends Exchange {
         const trailingTriggerPrice = this.safeString(params, 'trailingTriggerPrice', this.numberToString(price));
         const trailingPercent = this.safeString2(params, 'trailingPercent', 'callbackRatio');
         const isTrailingPercentOrder = trailingPercent !== undefined;
+        // const multipleTriggers = (isTriggerOrder && (isStopLossTriggerOrder || isTakeProfitTriggerOrder || isTrailingPercentOrder))
+        //     || (isStopLossTriggerOrder && (isTakeProfitTriggerOrder || isTrailingPercentOrder))
+        //     || (isTakeProfitTriggerOrder && isTrailingPercentOrder);
+        // if (multipleTriggers) {
+        //     throw new ExchangeError (this.id + ' createOrder() params can only contain one of triggerPrice, stopLossPrice, takeProfitPrice, trailingPercent');
+        // }
+        //
         if (this.sum(isTriggerOrder, isStopLossTriggerOrder, isTakeProfitTriggerOrder, isTrailingPercentOrder) > 1) {
             throw new ExchangeError(this.id + ' createOrder() params can only contain one of triggerPrice, stopLossPrice, takeProfitPrice, trailingPercent');
         }
@@ -5787,6 +5792,12 @@ export default class bitget extends Exchange {
         const trailingTriggerPrice = this.safeString(params, 'trailingTriggerPrice', this.numberToString(price));
         const trailingPercent = this.safeString2(params, 'trailingPercent', 'newCallbackRatio');
         const isTrailingPercentOrder = trailingPercent !== undefined;
+        // const multipleTriggers = (isTriggerOrder && (isStopLossOrder || isTakeProfitOrder || isTrailingPercentOrder))
+        //     || (isStopLossOrder && (isTakeProfitOrder || isTrailingPercentOrder))
+        //     || (isTakeProfitOrder && isTrailingPercentOrder);
+        // if (multipleTriggers) {
+        //     throw new ExchangeError (this.id + ' editOrder() params can only contain one of triggerPrice, stopLossPrice, takeProfitPrice, trailingPercent');
+        // }
         if (this.sum(isTriggerOrder, isStopLossOrder, isTakeProfitOrder, isTrailingPercentOrder) > 1) {
             throw new ExchangeError(this.id + ' editOrder() params can only contain one of triggerPrice, stopLossPrice, takeProfitPrice, trailingPercent');
         }

package/js/src/bitmart.js

@@ -1256,7 +1256,7 @@ export default class bitmart extends Exchange {
                     'type': isNtf ? 'other' : 'crypto',
                 };
             }
-            const networkCode = this.networkIdToCode(networkId);
+            const networkCode = this.networkIdToCode(networkId, currencyCode);
             const withdraw = this.safeBool(currency, 'withdraw_enabled');
             const deposit = this.safeBool(currency, 'deposit_enabled');
             entry['networks'][networkCode] = {
@@ -2974,8 +2974,10 @@ export default class bitmart extends Exchange {
         }
         const request = {
             'symbol': market['id'],
-            'size': parseInt(this.amountToPrecision(symbol, amount)),
         };
+        if (amount !== undefined) {
+            request['size'] = parseInt(this.amountToPrecision(symbol, amount));
+        }
         const timeInForce = this.safeString(params, 'timeInForce');
         const mode = this.safeInteger(params, 'mode'); // only for swap
         const isMarketOrder = type === 'market';
@@ -3039,7 +3041,11 @@ export default class bitmart extends Exchange {
         if (isStopLoss || isTakeProfit) {
             reduceOnly = true;
             request['price_type'] = this.safeInteger(params, 'price_type', 1);
-            request['executive_price'] = this.priceToPrecision(symbol, price);
+            if (price !== undefined) {
+                request['executive_price'] = this.priceToPrecision(symbol, price);
+            }
+            const marketOrLimitStr = isLimitOrder ? 'limit' : 'market';
+            request['category'] = this.safeString(params, 'category', marketOrLimitStr);
             if (isStopLoss) {
                 request['trigger_price'] = this.priceToPrecision(symbol, stopLossPrice);
             }
@@ -3296,9 +3302,9 @@ export default class bitmart extends Exchange {
         }
         const succeeded = this.safeValue(data, 'succeed');
         if (succeeded !== undefined) {
-            id = this.safeString(succeeded, 0);
-            if (id === undefined) {
-                throw new InvalidOrder(this.id + ' cancelOrder() failed to cancel ' + symbol + ' order id ' + id);
+            const id2 = this.safeString(succeeded, 0);
+            if (id2 === undefined) {
+                throw new InvalidOrder(this.id + ' cancelOrder() failed to cancel ' + symbol + ' order id ' + id2);
             }
         }
         else {
@@ -3921,11 +3927,12 @@ export default class bitmart extends Exchange {
         }
         const address = this.safeString(depositAddress, 'address');
         currency = this.safeCurrency(currencyId, currency);
+        const code = this.safeString(currency, 'code');
         this.checkAddress(address);
         return {
             'info': depositAddress,
-            'currency': this.safeString(currency, 'code'),
-            'network': this.networkIdToCode(network),
+            'currency': code,
+            'network': this.networkIdToCode(network, code),
             'address': address,
             'tag': this.safeString2(depositAddress, 'address_memo', 'memo'),
         };
@@ -4217,7 +4224,7 @@ export default class bitmart extends Exchange {
             'id': id,
             'currency': code,
             'amount': amount,
-            'network': this.networkIdToCode(networkId),
+            'network': this.networkIdToCode(networkId, code),
             'address': address,
             'addressFrom': undefined,
             'addressTo': undefined,
@@ -4636,8 +4643,9 @@ export default class bitmart extends Exchange {
         if (limit === undefined) {
             limit = 10;
         }
+        const pageNumber = this.safeInteger(params, 'page', 1);
         const request = {
-            'page': this.safeInteger(params, 'page', 1),
+            'page': pageNumber,
             'limit': limit, // default is 10, max is 100
         };
         let currency = undefined;

package/js/src/bitmex.js

@@ -477,7 +477,7 @@ export default class bitmex extends Exchange {
         for (let j = 0; j < chains.length; j++) {
             const chain = chains[j];
             const networkId = this.safeString(chain, 'asset');
-            const network = this.networkIdToCode(networkId);
+            const network = this.networkIdToCode(networkId, code);
             const withdrawalFeeRaw = this.safeString(chain, 'withdrawalFee');
             const withdrawalFee = this.parseNumber(Precise.stringMul(withdrawalFeeRaw, precisionString));
             const isDepositEnabled = this.safeBool(chain, 'depositEnabled', false);
@@ -1481,13 +1481,14 @@ export default class bitmex extends Exchange {
         if (status !== undefined) {
             status = this.parseTransactionStatus(status);
         }
+        const code = currency['code'];
         return {
             'info': transaction,
             'id': this.safeString(transaction, 'transactID'),
             'txid': this.safeString(transaction, 'tx'),
             'type': type,
-            'currency': currency['code'],
-            'network': this.networkIdToCode(this.safeString(transaction, 'network'), currency['code']),
+            'currency': code,
+            'network': this.networkIdToCode(this.safeString(transaction, 'network'), code),
             'amount': this.parseNumber(amount),
             'status': status,
             'timestamp': transactTime,
@@ -2022,6 +2023,7 @@ export default class bitmex extends Exchange {
         await this.loadMarkets();
         const market = this.market(symbol);
         let orderType = this.capitalize(type);
+        const capitalizeOrderType = orderType;
         const reduceOnly = this.safeValue(params, 'reduceOnly');
         if (reduceOnly !== undefined) {
             if ((!market['swap']) && (!market['future'])) {
@@ -2036,7 +2038,7 @@ export default class bitmex extends Exchange {
             'symbol': market['id'],
             'side': this.capitalize(side),
             'orderQty': qty,
-            'ordType': orderType,
+            'ordType': capitalizeOrderType,
             'text': brokerId,
         };
         const execInstructions = [];
@@ -2857,9 +2859,10 @@ export default class bitmex extends Exchange {
         }
         const currency = this.currency(code);
         params = this.omit(params, 'network');
+        const parsedNetwork = this.networkCodeToId(networkCode, currency['code']);
         const request = {
             'currency': currency['id'],
-            'network': this.networkCodeToId(networkCode, currency['code']),
+            'network': parsedNetwork,
         };
         const response = await this.privateGetUserDepositAddress(this.extend(request, params));
         //

package/js/src/bitopro.js

@@ -1015,7 +1015,7 @@ export default class bitopro extends Exchange {
             '4': 'canceled',
             '6': 'canceled',
         };
-        return this.safeString(statuses, status, undefined);
+        return this.safeString(statuses, status);
     }
     parseOrder(order, market = undefined) {
         //
@@ -1552,7 +1552,7 @@ export default class bitopro extends Exchange {
             'txid': this.safeString(transaction, 'txid'),
             'type': undefined,
             'currency': code,
-            'network': this.networkIdToCode(networkId),
+            'network': this.networkIdToCode(networkId, code),
             'amount': this.safeNumber(transaction, 'total'),
             'status': this.parseTransactionStatus(status),
             'timestamp': timestamp,

package/js/src/bitrue.js

@@ -442,7 +442,6 @@ export default class bitrue extends Exchange {
                     'XML': 'Stellar Lumens',
                     'XYM': 'Symbol',
                     'XTZ': 'Tezos',
-                    'theta': 'theta',
                     'THETA': 'THETA',
                     'VECHAIN': 'VeChain',
                     'WANCHAIN': 'Wanchain',
@@ -593,6 +592,7 @@ export default class bitrue extends Exchange {
                     "You don't have permission.": PermissionDenied,
                     'Market is closed.': ExchangeNotAvailable,
                     'Too many requests. Please try again later.': DDoSProtection,
+                    'quantity less then minQty': InvalidOrder,
                     '-1000': ExchangeNotAvailable,
                     '-1001': ExchangeNotAvailable,
                     '-1002': AuthenticationError,
@@ -978,6 +978,7 @@ export default class bitrue extends Exchange {
         if (minCost === undefined) {
             minCost = this.safeNumber(market, 'minOrderMoney');
         }
+        const isSpot = (type === 'spot');
         return {
             'id': id,
             'lowercaseId': lowercaseId,
@@ -989,7 +990,7 @@ export default class bitrue extends Exchange {
             'quoteId': quoteId,
             'settleId': settleId,
             'type': type,
-            'spot': (type === 'spot'),
+            'spot': isSpot,
             'margin': false,
             'swap': isContract,
             'future': false,
@@ -2901,7 +2902,7 @@ export default class bitrue extends Exchange {
         let networkCode = undefined;
         [networkCode, params] = this.handleNetworkCodeAndParams(params);
         if (networkCode !== undefined) {
-            request['chainName'] = this.networkCodeToId(networkCode);
+            request['chainName'] = this.networkCodeToId(networkCode, currency['code']);
         }
         if (tag !== undefined) {
             request['tag'] = tag;

package/js/src/bitso.js

@@ -1046,8 +1046,9 @@ export default class bitso extends Exchange {
         }
         // convert it to an integer unconditionally
         if (markerInParams) {
+            const marker = parseInt(params['marker']);
             params = this.extend(params, {
-                'marker': parseInt(params['marker']),
+                'marker': marker,
             });
         }
         const request = {
@@ -1266,8 +1267,9 @@ export default class bitso extends Exchange {
         }
         // convert it to an integer unconditionally
         if (markerInParams) {
+            const marker = parseInt(params['marker']);
             params = this.extend(params, {
-                'marker': parseInt(params['marker']),
+                'marker': marker,
             });
         }
         const request = {
@@ -1777,7 +1779,7 @@ export default class bitso extends Exchange {
         const networkId = this.safeString2(transaction, 'network', 'method');
         const status = this.safeString(transaction, 'status');
         const withdrawId = this.safeString(transaction, 'wid');
-        const networkCode = this.networkIdToCode(networkId);
+        const networkCode = this.networkIdToCode(networkId, currency['code']);
         const networkCodeUpper = (networkCode !== undefined) ? networkCode.toUpperCase() : undefined;
         return {
             'id': this.safeString2(transaction, 'wid', 'fid'),
@@ -1827,7 +1829,8 @@ export default class bitso extends Exchange {
             this.checkRequiredCredentials();
             const nonce = this.nonce().toString();
             endpoint = '/api' + endpoint;
-            let request = [nonce, method, endpoint].join('');
+            const content = [nonce, method, endpoint];
+            let request = content.join('');
             if (method !== 'GET' && method !== 'DELETE') {
                 if (Object.keys(query).length) {
                     body = this.json(query);

package/js/src/bitstamp.js

@@ -677,12 +677,13 @@ export default class bitstamp extends Exchange {
                 }
             }
             const isSpot = (type === 'spot');
+            const settle = settleId ? this.safeCurrencyCode(settleId) : undefined;
             result.push({
                 'id': this.safeString(market, 'market_symbol'),
                 'symbol': symbol,
                 'base': base,
                 'quote': quote,
-                'settle': settleId ? this.safeCurrencyCode(settleId) : undefined,
+                'settle': settle,
                 'baseId': baseId,
                 'quoteId': quoteId,
                 'settleId': settleId,
@@ -910,7 +911,7 @@ export default class bitstamp extends Exchange {
         // }
         //
         const marketId = this.safeString(ticker, 'pair');
-        const symbol = this.safeSymbol(marketId, market, undefined);
+        const symbol = this.safeSymbol(marketId, market);
         const timestamp = this.safeTimestamp(ticker, 'timestamp');
         const vwap = this.safeString(ticker, 'vwap');
         const baseVolume = this.safeString(ticker, 'volume');
@@ -1332,8 +1333,9 @@ export default class bitstamp extends Exchange {
         return this.parseOHLCVs(ohlc, market, timeframe, since, limit);
     }
     parseBalance(response) {
+        const finalResponse = response; // java req
         const result = {
-            'info': response,
+            'info': finalResponse,
             'timestamp': undefined,
             'datetime': undefined,
         };
@@ -1529,10 +1531,11 @@ export default class bitstamp extends Exchange {
     }
     parseDepositWithdrawFee(fee, currency = undefined) {
         const result = this.depositWithdrawFee(fee);
+        const code = this.safeString(currency, 'code');
         for (let j = 0; j < fee.length; j++) {
             const networkEntry = fee[j];
             const networkId = this.safeString(networkEntry, 'network');
-            const networkCode = this.networkIdToCode(networkId);
+            const networkCode = this.networkIdToCode(networkId, code);
             const withdrawFee = this.safeNumber(networkEntry, 'fee');
             result['withdraw'] = {
                 'fee': withdrawFee,

package/js/src/bitteam.js

@@ -2330,7 +2330,7 @@ export default class bitteam extends Exchange {
             'txid': txid,
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
-            'network': this.networkIdToCode(networkId),
+            'network': this.networkIdToCode(networkId, code),
             'addressFrom': addressFrom,
             'address': undefined,
             'addressTo': addressTo,

package/js/src/bittrade.js

@@ -373,7 +373,6 @@ export default class bittrade extends Exchange {
                     'HECO': 'hrc20',
                     'HT': 'hrc20',
                     'ALGO': 'algo',
-                    'OMNI': '',
                 },
                 // https://github.com/ccxt/ccxt/issues/5376
                 'fetchOrdersByStatesMethod': 'private_get_order_orders',
@@ -1991,8 +1990,9 @@ export default class bittrade extends Exchange {
             const requestSorted = this.keysort(request);
             let auth = this.urlencode(requestSorted);
             // unfortunately, PHP demands double quotes for the escaped newline symbol
+            const content = [method, this.hostname, url, auth];
             // eslint-disable-next-line quotes
-            const payload = [method, this.hostname, url, auth].join("\n");
+            const payload = content.join("\n");
             const signature = this.hmac(this.encode(payload), this.encode(this.secret), sha256, 'base64');
             auth += '&' + this.urlencode({ 'Signature': signature });
             url += '?' + auth;