ccxt 4.5.51 → 4.5.52

package/js/src/base/Exchange.d.ts

@@ -66,16 +66,16 @@ export default class Exchange {
     validateClientSsl: boolean;
     timeout: Int;
     verbose: boolean;
-    twofa: string;
     apiKey: string;
     secret: string;
     uid: string;
-    accountId: string;
     login: string;
     password: string;
     privateKey: string;
     walletAddress: string;
     token: string;
+    twofa: string;
+    accountId: string;
     balance: any;
     liquidations: any;
     orderbooks: Dictionary<Ob>;
@@ -187,11 +187,9 @@ export default class Exchange {
     exceptions: Dictionary<string>;
     timeframes: Dictionary<number | string>;
     version: Str;
-    marketsByAltname: Dictionary<Market>;
     name: Str;
     lastRestRequestTimestamp: int;
     targetAccount: string;
-    stablePairs: Dictionary<boolean>;
     httpProxyAgentModule: any;
     httpsProxyAgentModule: any;
     socksProxyAgentModule: any;
@@ -439,6 +437,7 @@ export default class Exchange {
     safeDict(dictionary: any, key: IndexType, defaultValue?: Dictionary<any>): Dictionary<any> | undefined;
     safeDict2(dictionary: any, key1: IndexType, key2: string, defaultValue?: Dictionary<any>): Dictionary<any> | undefined;
     safeListN(dictionaryOrList: any, keys: IndexType[], defaultValue?: any[]): any[] | undefined;
+    isDictionary(value: any): boolean;
     safeList2(dictionaryOrList: any, key1: IndexType, key2: string, defaultValue?: any[]): any[] | undefined;
     safeList(dictionaryOrList: any, key: IndexType, defaultValue?: any[]): any[] | undefined;
     handleDeltas(orderbook: any, deltas: any): void;

package/js/src/base/Exchange.js

@@ -82,7 +82,6 @@ export default class Exchange {
         this.validateClientSsl = false;
         this.timeout = 10000; // milliseconds
         this.verbose = false;
-        this.twofa = undefined; // two-factor authentication (2-FA)
         this.balance = {};
         this.liquidations = undefined;
         this.orderbooks = {};
@@ -110,10 +109,10 @@ export default class Exchange {
         this.markets = undefined;
         this.features = undefined;
         this.status = undefined;
-        this.rateLimit = undefined; // milliseconds
+        this.rateLimit = 2000; // milliseconds
         this.tokenBucket = undefined;
         this.throttler = undefined;
-        this.enableRateLimit = undefined;
+        this.enableRateLimit = true;
         this.rollingWindowSize = 0.0; // set to 0.0 to use leaky bucket rate limiter
         this.rateLimiterAlgorithm = 'leakyBucket';
         this.httpExceptions = undefined;
@@ -137,10 +136,8 @@ export default class Exchange {
         this.exceptions = {};
         this.timeframes = {};
         this.version = undefined;
-        this.marketsByAltname = undefined;
         this.name = undefined;
         this.targetAccount = undefined;
-        this.stablePairs = {};
         this.httpProxyAgentModule = undefined;
         this.httpsProxyAgentModule = undefined;
         this.socksProxyAgentModule = undefined;
@@ -680,7 +677,7 @@ export default class Exchange {
             if (typeof userAgent === 'string') {
                 headers = this.extend({ 'User-Agent': userAgent }, headers);
             }
-            else if ((typeof userAgent === 'object') && ('User-Agent' in userAgent)) {
+            else if (this.isDictionary(userAgent) && ('User-Agent' in userAgent)) {
                 headers = this.extend(userAgent, headers);
             }
         }
@@ -1776,15 +1773,16 @@ export default class Exchange {
     // METHODS BELOW THIS LINE ARE TRANSPILED FROM TYPESCRIPT
     describe() {
         return {
-            'id': undefined,
-            'name': undefined,
-            'countries': undefined,
-            'enableRateLimit': true,
-            'rateLimit': 2000,
+            'id': this.id,
+            'name': this.name,
+            'countries': this.countries,
+            'enableRateLimit': this.enableRateLimit,
+            'rateLimit': this.rateLimit,
+            'rateLimiterAlgorithm': this.rateLimiterAlgorithm,
             'timeout': this.timeout,
-            'certified': false,
-            'pro': false,
-            'alias': false,
+            'certified': this.certified,
+            'pro': this.pro,
+            'alias': this.alias,
             'dex': false,
             'has': {
                 'publicAPI': true,
@@ -2030,9 +2028,12 @@ export default class Exchange {
             'urls': {
                 'logo': undefined,
                 'api': undefined,
+                'test': undefined,
                 'www': undefined,
                 'doc': undefined,
+                'api_management': undefined,
                 'fees': undefined,
+                'referral': undefined,
             },
             'api': undefined,
             'requiredCredentials': {
@@ -2069,6 +2070,7 @@ export default class Exchange {
                 'updated': undefined,
                 'eta': undefined,
                 'url': undefined,
+                'info': undefined,
             },
             'exceptions': undefined,
             'httpExceptions': {
@@ -2159,7 +2161,7 @@ export default class Exchange {
         if (value === undefined) {
             return defaultValue;
         }
-        if ((typeof value === 'object') && !Array.isArray(value)) {
+        if (this.isDictionary(value)) {
             return value;
         }
         return defaultValue;
@@ -2175,7 +2177,7 @@ export default class Exchange {
         if (value === undefined) {
             return defaultValue;
         }
-        if ((typeof value === 'object') && !Array.isArray(value)) {
+        if (this.isDictionary(value)) {
             return value;
         }
         return defaultValue;
@@ -2205,6 +2207,9 @@ export default class Exchange {
         }
         return defaultValue;
     }
+    isDictionary(value) {
+        return (value !== undefined) && (typeof value === 'object') && !Array.isArray(value);
+    }
     safeList2(dictionaryOrList, key1, key2, defaultValue = undefined) {
         /**
          * @ignore
@@ -5957,7 +5962,7 @@ export default class Exchange {
         if (triggerPrice === undefined) {
             throw new ArgumentsRequired(this.id + ' createTriggerOrder() requires a triggerPrice argument');
         }
-        params['triggerPrice'] = triggerPrice;
+        params = this.extend(params, { 'triggerPrice': triggerPrice });
         if (this.has['createTriggerOrder']) {
             return await this.createOrder(symbol, type, side, amount, price, params);
         }
@@ -5980,7 +5985,7 @@ export default class Exchange {
         if (triggerPrice === undefined) {
             throw new ArgumentsRequired(this.id + ' createTriggerOrderWs() requires a triggerPrice argument');
         }
-        params['triggerPrice'] = triggerPrice;
+        params = this.extend(params, { 'triggerPrice': triggerPrice });
         if (this.has['createTriggerOrderWs']) {
             return await this.createOrderWs(symbol, type, side, amount, price, params);
         }
@@ -6003,7 +6008,7 @@ export default class Exchange {
         if (stopLossPrice === undefined) {
             throw new ArgumentsRequired(this.id + ' createStopLossOrder() requires a stopLossPrice argument');
         }
-        params['stopLossPrice'] = stopLossPrice;
+        params = this.extend(params, { 'stopLossPrice': stopLossPrice });
         if (this.has['createStopLossOrder']) {
             return await this.createOrder(symbol, type, side, amount, price, params);
         }
@@ -6026,7 +6031,7 @@ export default class Exchange {
         if (stopLossPrice === undefined) {
             throw new ArgumentsRequired(this.id + ' createStopLossOrderWs() requires a stopLossPrice argument');
         }
-        params['stopLossPrice'] = stopLossPrice;
+        params = this.extend(params, { 'stopLossPrice': stopLossPrice });
         if (this.has['createStopLossOrderWs']) {
             return await this.createOrderWs(symbol, type, side, amount, price, params);
         }
@@ -6049,7 +6054,7 @@ export default class Exchange {
         if (takeProfitPrice === undefined) {
             throw new ArgumentsRequired(this.id + ' createTakeProfitOrder() requires a takeProfitPrice argument');
         }
-        params['takeProfitPrice'] = takeProfitPrice;
+        params = this.extend(params, { 'takeProfitPrice': takeProfitPrice });
         if (this.has['createTakeProfitOrder']) {
             return await this.createOrder(symbol, type, side, amount, price, params);
         }
@@ -6072,7 +6077,7 @@ export default class Exchange {
         if (takeProfitPrice === undefined) {
             throw new ArgumentsRequired(this.id + ' createTakeProfitOrderWs() requires a takeProfitPrice argument');
         }
-        params['takeProfitPrice'] = takeProfitPrice;
+        params = this.extend(params, { 'takeProfitPrice': takeProfitPrice });
         if (this.has['createTakeProfitOrderWs']) {
             return await this.createOrderWs(symbol, type, side, amount, price, params);
         }
@@ -6497,7 +6502,7 @@ export default class Exchange {
         return false;
     }
     handleWithdrawTagAndParams(tag, params) {
-        if ((tag !== undefined) && (typeof tag === 'object')) {
+        if (this.isDictionary(tag)) {
             params = this.extend(tag, params);
             tag = undefined;
         }
@@ -6550,7 +6555,7 @@ export default class Exchange {
             return undefined;
         }
         const market = this.market(symbol);
-        return this.decimalToPrecision(cost, TRUNCATE, market['precision']['price'], this.precisionMode, this.paddingMode);
+        return this.decimalToPrecision(cost, TRUNCATE, this.safeString2(market['precision'], 'cost', 'price'), this.precisionMode, this.paddingMode);
     }
     priceToPrecision(symbol, price) {
         if (price === undefined) {

package/js/src/bequant.js

@@ -8,6 +8,9 @@ export default class bequant extends hitbtc {
             'name': 'Bequant',
             'pro': true,
             'countries': ['MT'],
+            'has': {
+                'swap': false,
+            },
             'urls': {
                 'logo': 'https://github.com/user-attachments/assets/0583ef1f-29fe-4b7c-8189-63565a0e2867',
                 'api': {

package/js/src/binance.js

@@ -1491,6 +1491,7 @@ export default class binance extends Exchange {
                     'BUSD': 'USD',
                 },
                 'defaultWithdrawPrecision': 0.00000001,
+                'defaultFiatWithdrawPrecision': 0.01,
             },
             'features': {
                 'spot': {
@@ -3054,29 +3055,33 @@ export default class binance extends Exchange {
             //        ]
             //    }
             //
+            //     some coins (e.g. ETH, BIGTIME, SONIC, etc) return extra fields under network entry
+            //
+            //                "specialTips": "",
+            //                "specialWithdrawTips": "",
+            //                "withdrawInternalMin": "0",
+            //                "contractAddressUrl": "https://etherscan.io/address/",
+            //                "contractAddress": "0x64bc2ca1be492be7185faa2c8835d9b824c8a194"
+            //
             const entry = responseCurrencies[i];
             const id = this.safeString(entry, 'coin');
             const name = this.safeString(entry, 'name');
             const code = this.safeCurrencyCode(id);
             const isFiat = this.safeBool(entry, 'isLegalMoney');
-            let minPrecision = undefined;
-            let isWithdrawEnabled = true;
-            let isDepositEnabled = true;
             const networkList = this.safeList(entry, 'networkList', []);
             const fees = {};
             let fee = undefined;
             const networks = {};
+            let isETF = false;
             for (let j = 0; j < networkList.length; j++) {
                 const networkItem = networkList[j];
                 const network = this.safeString(networkItem, 'network');
                 const networkCode = this.networkIdToCode(network, code);
-                const isETF = (network === 'ETF'); // e.g. BTCUP, ETHDOWN
+                isETF = (network === 'ETF'); // ETF currencies (e.g. BTCUP, ETHDOWN) have only 1 "network" entry and are deterministic to set
                 // const name = this.safeString (networkItem, 'name');
                 const withdrawFee = this.safeNumber(networkItem, 'withdrawFee');
                 const depositEnable = this.safeBool(networkItem, 'depositEnable');
                 const withdrawEnable = this.safeBool(networkItem, 'withdrawEnable');
-                isDepositEnabled = isDepositEnabled || depositEnable;
-                isWithdrawEnabled = isWithdrawEnabled || withdrawEnable;
                 fees[network] = withdrawFee;
                 const isDefault = this.safeBool(networkItem, 'isDefault');
                 if (isDefault || (fee === undefined)) {
@@ -3086,27 +3091,16 @@ export default class binance extends Exchange {
                 // if (isDefault) {
                 //     this.options['defaultNetworkCodesForCurrencies'][code] = networkCode;
                 // }
-                const precisionTick = this.safeString(networkItem, 'withdrawIntegerMultiple');
-                let withdrawPrecision = precisionTick;
-                // avoid zero values, which are mostly from fiat or leveraged tokens or some abandoned coins : https://github.com/ccxt/ccxt/pull/14902#issuecomment-1271636731
-                if (!Precise.stringEq(precisionTick, '0')) {
-                    minPrecision = (minPrecision === undefined) ? precisionTick : Precise.stringMin(minPrecision, precisionTick);
-                }
-                else {
-                    if (!isFiat && !isETF) {
-                        // non-fiat and non-ETF currency, there are many cases when precision is set to zero (probably bug, we've reported to binance already)
-                        // in such cases, we can set default precision of 8 (which is in UI for such coins)
-                        withdrawPrecision = this.omitZero(this.safeString(networkItem, 'withdrawInternalMin'));
-                        if (withdrawPrecision === undefined) {
-                            withdrawPrecision = this.safeString(this.options, 'defaultWithdrawPrecision');
-                        }
-                    }
+                let withdrawPrecision = this.omitZero(this.safeString2(networkItem, 'withdrawIntegerMultiple', 'withdrawInternalMin'));
+                // zero values happen only on fiat or leveraged(ETF) tokens: https://t.me/binance_api_english/393075
+                if (withdrawPrecision === undefined && isFiat) {
+                    withdrawPrecision = this.safeString(this.options, 'defaultFiatWithdrawPrecision');
                 }
                 networks[networkCode] = {
                     'info': networkItem,
                     'id': network,
                     'network': networkCode,
-                    'active': depositEnable && withdrawEnable,
+                    'active': undefined,
                     'deposit': depositEnable,
                     'withdraw': withdrawEnable,
                     'fee': withdrawFee,
@@ -3123,8 +3117,17 @@ export default class binance extends Exchange {
                     },
                 };
             }
+            let type = undefined;
+            if (isETF) {
+                type = 'other';
+            }
+            else if (isFiat) {
+                type = 'fiat';
+            }
+            else {
+                type = 'crypto';
+            }
             const trading = this.safeBool(entry, 'trading');
-            const active = (isWithdrawEnabled && isDepositEnabled && trading);
             const marginEntry = this.safeDict(marginablesById, id, {});
             //
             //     {
@@ -3136,22 +3139,22 @@ export default class binance extends Exchange {
             //         userMinRepay: "0",
             //     }
             //
-            result[code] = {
+            result[code] = this.safeCurrencyStructure({
                 'id': id,
                 'name': name,
                 'code': code,
-                'type': isFiat ? 'fiat' : 'crypto',
-                'precision': this.parseNumber(minPrecision),
+                'type': type,
+                'precision': undefined,
                 'info': entry,
-                'active': active,
-                'deposit': isDepositEnabled,
-                'withdraw': isWithdrawEnabled,
+                'active': trading,
+                'deposit': undefined,
+                'withdraw': undefined,
                 'networks': networks,
-                'fee': fee,
+                'fee': undefined,
                 'fees': fees,
-                'limits': this.limits,
+                'limits': undefined,
                 'margin': this.safeBool(marginEntry, 'isBorrowable'),
-            };
+            });
         }
         return result;
     }

package/js/src/binanceusdm.js

@@ -28,6 +28,7 @@ export default class binanceusdm extends binance {
                 'fetchMarkets': {
                     'types': ['linear'],
                 },
+                'defaultType': 'swap',
                 'defaultSubType': 'linear',
                 // https://www.binance.com/en/support/faq/360033162192
                 // tier amount, maintenance margin, initial margin,

package/js/src/grvt.js

@@ -482,13 +482,17 @@ export default class grvt extends Exchange {
      * @returns response from exchange
      */
     async signIn(params = {}) {
-        if (this.usesPrivateKey()) {
-            await this.signInWithPrivateKey(params);
-            await this.initializeClient(params);
-        }
-        else {
-            await this.signInWithApiKey(params);
+        // if (this.usesPrivateKey ()) {
+        //     await this.signInWithPrivateKey (params);
+        //     await this.initializeClient (params);
+        // } else {
+        //     await this.signInWithApiKey (params);
+        // }
+        if (this.privateKey === undefined || this.privateKey === '') {
+            throw new PermissionDenied('Private key is required for this operation. If you used joined GRVT through email registration instead of Web3 wallet, then read: https://github.com/ccxt/ccxt/wiki/FAQ#how-to-use-the-grvt-exchange-in-ccxt');
         }
+        await this.signInWithPrivateKey(params);
+        await this.initializeClient(params);
         await this.loadAccountInfos();
         return true;
     }
@@ -1961,7 +1965,10 @@ export default class grvt extends Exchange {
         else {
             throw new InvalidOrder(this.id + ' createOrder(): order side must be either "buy" or "sell"');
         }
-        const clientOrderId = this.safeString(params, 'clientOrderId');
+        let clientOrderId = this.safeString(params, 'clientOrderId');
+        if (clientOrderId === undefined) {
+            clientOrderId = this.nonce().toString() + '000' + this.requestId().toString();
+        }
         params = this.omit(params, ['clientOrderId']);
         const isMarketOrder = (type === 'market');
         const orderRequest = {
@@ -1970,7 +1977,7 @@ export default class grvt extends Exchange {
             'legs': [orderLeg],
             'signature': this.defaultSignature(),
             'metadata': {
-                'client_order_id': clientOrderId !== undefined ? clientOrderId : this.nonce().toString() + '000' + this.requestId().toString(),
+                'client_order_id': clientOrderId,
             },
             'is_market': isMarketOrder,
             'post_only': false,

package/js/src/kraken.js

@@ -644,6 +644,10 @@ export default class kraken extends Exchange {
         const result = [];
         for (let i = 0; i < keys.length; i++) {
             const id = keys[i];
+            let isSynthetic = false;
+            if (id.indexOf(':BTNL') >= 0) {
+                isSynthetic = true;
+            }
             const market = markets[id];
             const baseIdRaw = this.safeString(market, 'base');
             const quoteIdRaw = this.safeString(market, 'quote');
@@ -681,10 +685,11 @@ export default class kraken extends Exchange {
             }
             const status = this.safeString(market, 'status');
             const isActive = status === 'online';
+            const symbol = (!isSynthetic) ? (base + '/' + quote) : id;
             result.push({
                 'id': id,
                 'wsId': this.safeString(market, 'wsname'),
-                'symbol': base + '/' + quote,
+                'symbol': symbol,
                 'base': base,
                 'quote': quote,
                 'settle': undefined,