ccxt 4.4.85 → 4.4.87

package/js/src/poloniex.js

@@ -309,6 +309,11 @@ export default class poloniex extends Exchange {
                     'BEP20': 'BSC',
                     'ERC20': 'ETH',
                     'TRC20': 'TRON',
+                    'TRX': 'TRON',
+                },
+                'networksById': {
+                    'TRX': 'TRC20',
+                    'TRON': 'TRC20',
                 },
                 'limits': {
                     'cost': {
@@ -1151,105 +1156,107 @@ export default class poloniex extends Exchange {
         const response = await this.publicGetCurrencies(this.extend(params, { 'includeMultiChainCurrencies': true }));
         //
         //     [
-        //         {
-        //             "1CR": {
-        //                 "id": 1,
-        //                 "name": "1CRedit",
-        //                 "description": "BTC Clone",
-        //                 "type": "address",
-        //                 "withdrawalFee": "0.01000000",
-        //                 "minConf": 10000,
-        //                 "depositAddress": null,
-        //                 "blockchain": "1CR",
-        //                 "delisted": false,
-        //                 "tradingState": "NORMAL",
-        //                 "walletState": "DISABLED",
-        //                 "walletDepositState": "DISABLED",
-        //                 "walletWithdrawalState": "DISABLED",
-        //                 "parentChain": null,
-        //                 "isMultiChain": false,
-        //                 "isChildChain": false,
-        //                 "childChains": []
-        //             }
-        //         }
+        //      {
+        //        "USDT": {
+        //           "id": 214,
+        //           "name": "Tether USD",
+        //           "description": "Sweep to Main Account",
+        //           "type": "address",
+        //           "withdrawalFee": "0.00000000",
+        //           "minConf": 2,
+        //           "depositAddress": null,
+        //           "blockchain": "OMNI",
+        //           "delisted": false,
+        //           "tradingState": "NORMAL",
+        //           "walletState": "DISABLED",
+        //           "walletDepositState": "DISABLED",
+        //           "walletWithdrawalState": "DISABLED",
+        //           "supportCollateral": true,
+        //           "supportBorrow": true,
+        //           "parentChain": null,
+        //           "isMultiChain": true,
+        //           "isChildChain": false,
+        //           "childChains": [
+        //             "USDTBSC",
+        //             "USDTETH",
+        //             "USDTSOL",
+        //             "USDTTRON"
+        //           ]
+        //        }
+        //      },
+        //      ...
+        //      {
+        //        "USDTBSC": {
+        //              "id": 582,
+        //              "name": "Binance-Peg BSC-USD",
+        //              "description": "Sweep to Main Account",
+        //              "type": "address",
+        //              "withdrawalFee": "0.00000000",
+        //              "minConf": 15,
+        //              "depositAddress": null,
+        //              "blockchain": "BSC",
+        //              "delisted": false,
+        //              "tradingState": "OFFLINE",
+        //              "walletState": "ENABLED",
+        //              "walletDepositState": "ENABLED",
+        //              "walletWithdrawalState": "DISABLED",
+        //              "supportCollateral": false,
+        //              "supportBorrow": false,
+        //              "parentChain": "USDT",
+        //              "isMultiChain": true,
+        //              "isChildChain": true,
+        //              "childChains": []
+        //        }
+        //      },
+        //      ...
         //     ]
         //
         const result = {};
+        // poloniex has a complicated structure of currencies, so we handle them differently
+        // at first, turn the response into a normal dictionary
+        const currenciesDict = {};
         for (let i = 0; i < response.length; i++) {
-            const item = this.safeValue(response, i);
+            const item = this.safeDict(response, i);
             const ids = Object.keys(item);
-            const id = this.safeValue(ids, 0);
-            const currency = this.safeValue(item, id);
+            const id = this.safeString(ids, 0);
+            currenciesDict[id] = item[id];
+        }
+        const keys = Object.keys(currenciesDict);
+        for (let i = 0; i < keys.length; i++) {
+            const id = keys[i];
+            const entry = currenciesDict[id];
             const code = this.safeCurrencyCode(id);
-            const name = this.safeString(currency, 'name');
-            const networkId = this.safeString(currency, 'blockchain');
-            let networkCode = undefined;
-            if (networkId !== undefined) {
-                networkCode = this.networkIdToCode(networkId, code);
-            }
-            const delisted = this.safeValue(currency, 'delisted');
-            const walletEnabled = this.safeString(currency, 'walletState') === 'ENABLED';
-            const depositEnabled = this.safeString(currency, 'walletDepositState') === 'ENABLED';
-            const withdrawEnabled = this.safeString(currency, 'walletWithdrawalState') === 'ENABLED';
-            const active = !delisted && walletEnabled && depositEnabled && withdrawEnabled;
-            const numericId = this.safeInteger(currency, 'id');
-            const feeString = this.safeString(currency, 'withdrawalFee');
-            const parentChain = this.safeValue(currency, 'parentChain');
-            const noParentChain = parentChain === undefined;
-            if (this.safeValue(result, code) === undefined) {
-                result[code] = {
-                    'id': id,
-                    'code': code,
-                    'info': undefined,
-                    'name': name,
-                    'active': active,
-                    'deposit': depositEnabled,
-                    'withdraw': withdrawEnabled,
-                    'fee': this.parseNumber(feeString),
-                    'precision': undefined,
-                    'type': 'crypto',
-                    'limits': {
-                        'amount': {
-                            'min': undefined,
-                            'max': undefined,
-                        },
-                        'deposit': {
-                            'min': undefined,
-                            'max': undefined,
-                        },
-                        'withdraw': {
-                            'min': undefined,
-                            'max': undefined,
-                        },
-                    },
-                };
+            // skip childChains, as they are collected in parentChain loop
+            if (this.safeBool(entry, 'isChildChain')) {
+                continue;
             }
-            let minFeeString = this.safeString(result[code], 'fee');
-            if (feeString !== undefined) {
-                minFeeString = (minFeeString === undefined) ? feeString : Precise.stringMin(feeString, minFeeString);
+            const allChainEntries = [];
+            const childChains = this.safeList(entry, 'childChains', []);
+            if (childChains !== undefined) {
+                for (let j = 0; j < childChains.length; j++) {
+                    const childChainId = childChains[j];
+                    const childNetworkEntry = this.safeDict(currenciesDict, childChainId);
+                    allChainEntries.push(childNetworkEntry);
+                }
             }
-            let depositAvailable = this.safeValue(result[code], 'deposit');
-            depositAvailable = (depositEnabled) ? depositEnabled : depositAvailable;
-            let withdrawAvailable = this.safeValue(result[code], 'withdraw');
-            withdrawAvailable = (withdrawEnabled) ? withdrawEnabled : withdrawAvailable;
-            const networks = this.safeValue(result[code], 'networks', {});
-            if (networkCode !== undefined) {
+            allChainEntries.push(entry);
+            const networks = {};
+            for (let j = 0; j < allChainEntries.length; j++) {
+                const chainEntry = allChainEntries[j];
+                const networkName = this.safeString(chainEntry, 'blockchain');
+                const networkCode = this.networkIdToCode(networkName, code);
+                const specialNetworkId = this.safeString(childChains, j, id); // in case it's primary chain, defeault to ID
                 networks[networkCode] = {
-                    'info': currency,
-                    'id': networkId,
+                    'info': chainEntry,
+                    'id': specialNetworkId,
+                    'numericId': this.safeInteger(chainEntry, 'id'),
                     'network': networkCode,
-                    'currencyId': id,
-                    'numericId': numericId,
-                    'deposit': depositEnabled,
-                    'withdraw': withdrawEnabled,
-                    'active': active,
-                    'fee': this.parseNumber(feeString),
+                    'active': this.safeBool(chainEntry, 'walletState'),
+                    'deposit': this.safeString(chainEntry, 'walletDepositState') === 'ENABLED',
+                    'withdraw': this.safeString(chainEntry, 'walletWithdrawalState') === 'ENABLED',
+                    'fee': this.safeNumber(chainEntry, 'withdrawalFee'),
                     'precision': undefined,
                     'limits': {
-                        'amount': {
-                            'min': undefined,
-                            'max': undefined,
-                        },
                         'withdraw': {
                             'min': undefined,
                             'max': undefined,
@@ -1261,20 +1268,34 @@ export default class poloniex extends Exchange {
                     },
                 };
             }
-            result[code]['networks'] = networks;
-            const info = this.safeValue(result[code], 'info', []);
-            const rawInfo = {};
-            rawInfo[id] = currency;
-            info.push(rawInfo);
-            result[code]['info'] = info;
-            if (noParentChain) {
-                result[code]['id'] = id;
-                result[code]['name'] = name;
-            }
-            result[code]['active'] = depositAvailable && withdrawAvailable;
-            result[code]['deposit'] = depositAvailable;
-            result[code]['withdraw'] = withdrawAvailable;
-            result[code]['fee'] = this.parseNumber(minFeeString);
+            result[code] = this.safeCurrencyStructure({
+                'info': entry,
+                'code': code,
+                'id': id,
+                'numericId': this.safeInteger(entry, 'id'),
+                'type': 'crypto',
+                'name': this.safeString(entry, 'name'),
+                'active': undefined,
+                'deposit': undefined,
+                'withdraw': undefined,
+                'fee': undefined,
+                'precision': undefined,
+                'limits': {
+                    'amount': {
+                        'min': undefined,
+                        'max': undefined,
+                    },
+                    'withdraw': {
+                        'min': undefined,
+                        'max': undefined,
+                    },
+                    'deposit': {
+                        'min': undefined,
+                        'max': undefined,
+                    },
+                },
+                'networks': networks,
+            });
         }
         return result;
     }
@@ -2669,45 +2690,15 @@ export default class poloniex extends Exchange {
      */
     async createDepositAddress(code, params = {}) {
         await this.loadMarkets();
-        const currency = this.currency(code);
-        const request = {
-            'currency': currency['id'],
-        };
-        const networks = this.safeValue(this.options, 'networks', {});
-        let network = this.safeStringUpper(params, 'network'); // this line allows the user to specify either ERC20 or ETH
-        network = this.safeString(networks, network, network); // handle ERC20>ETH alias
-        if (network !== undefined) {
-            request['currency'] = request['currency'] + network; // when network the currency need to be changed to currency+network https://docs.poloniex.com/#withdraw on MultiChain Currencies section
-            params = this.omit(params, 'network');
-        }
-        else {
-            if (currency['id'] === 'USDT') {
-                throw new ArgumentsRequired(this.id + ' createDepositAddress requires a network parameter for ' + code + '.');
-            }
-        }
+        const [request, extraParams, currency, networkEntry] = this.prepareRequestForDepositAddress(code, params);
+        params = extraParams;
         const response = await this.privatePostWalletsAddress(this.extend(request, params));
         //
         //     {
         //         "address" : "0xfxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxf"
         //     }
         //
-        let address = this.safeString(response, 'address');
-        let tag = undefined;
-        this.checkAddress(address);
-        if (currency !== undefined) {
-            const depositAddress = this.safeString(currency['info'], 'depositAddress');
-            if (depositAddress !== undefined) {
-                tag = address;
-                address = depositAddress;
-            }
-        }
-        return {
-            'currency': code,
-            'address': address,
-            'tag': tag,
-            'network': network,
-            'info': response,
-        };
+        return this.parseDepositAddressSpecial(response, currency, networkEntry);
     }
     /**
      * @method
@@ -2720,33 +2711,55 @@ export default class poloniex extends Exchange {
      */
     async fetchDepositAddress(code, params = {}) {
         await this.loadMarkets();
-        const currency = this.currency(code);
-        const request = {
-            'currency': currency['id'],
-        };
-        const networks = this.safeValue(this.options, 'networks', {});
-        let network = this.safeStringUpper(params, 'network'); // this line allows the user to specify either ERC20 or ETH
-        network = this.safeString(networks, network, network); // handle ERC20>ETH alias
-        if (network !== undefined) {
-            request['currency'] = request['currency'] + network; // when network the currency need to be changed to currency+network https://docs.poloniex.com/#withdraw on MultiChain Currencies section
-            params = this.omit(params, 'network');
-        }
-        else {
-            if (currency['id'] === 'USDT') {
-                throw new ArgumentsRequired(this.id + ' fetchDepositAddress requires a network parameter for ' + code + '.');
-            }
-        }
+        const [request, extraParams, currency, networkEntry] = this.prepareRequestForDepositAddress(code, params);
+        params = extraParams;
         const response = await this.privateGetWalletsAddresses(this.extend(request, params));
         //
         //     {
         //         "USDTTRON" : "Txxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxp"
         //     }
         //
-        let address = this.safeString(response, request['currency']);
+        const keys = Object.keys(response);
+        const length = keys.length;
+        if (length < 1) {
+            throw new ExchangeError(this.id + ' fetchDepositAddress() returned an empty response, you might need to try "createDepositAddress" at first and then use "fetchDepositAddress"');
+        }
+        return this.parseDepositAddressSpecial(response, currency, networkEntry);
+    }
+    prepareRequestForDepositAddress(code, params = {}) {
+        if (!(code in this.currencies)) {
+            throw new BadSymbol(this.id + ' fetchDepositAddress(): can not recognize ' + code + ' currency, you might try using unified currency-code and add provide specific "network" parameter, like: fetchDepositAddress("USDT", { "network": "TRC20" })');
+        }
+        const currency = this.currency(code);
+        let networkCode = undefined;
+        [networkCode, params] = this.handleNetworkCodeAndParams(params);
+        if (networkCode === undefined) {
+            // we need to know the network to find out the currency-junction
+            throw new ArgumentsRequired(this.id + ' fetchDepositAddress requires a network parameter for ' + code + '.');
+        }
+        let exchangeNetworkId = undefined;
+        networkCode = this.networkIdToCode(networkCode, code);
+        const networkEntry = this.safeDict(currency['networks'], networkCode);
+        if (networkEntry !== undefined) {
+            exchangeNetworkId = networkEntry['id'];
+        }
+        else {
+            exchangeNetworkId = networkCode;
+        }
+        const request = {
+            'currency': exchangeNetworkId,
+        };
+        return [request, params, currency, networkEntry];
+    }
+    parseDepositAddressSpecial(response, currency, networkEntry) {
+        let address = this.safeString(response, 'address');
+        if (address === undefined) {
+            address = this.safeString(response, networkEntry['id']);
+        }
         let tag = undefined;
         this.checkAddress(address);
-        if (currency !== undefined) {
-            const depositAddress = this.safeString(currency['info'], 'depositAddress');
+        if (networkEntry !== undefined) {
+            const depositAddress = this.safeString(networkEntry['info'], 'depositAddress');
             if (depositAddress !== undefined) {
                 tag = address;
                 address = depositAddress;
@@ -2754,8 +2767,8 @@ export default class poloniex extends Exchange {
         }
         return {
             'info': response,
-            'currency': code,
-            'network': network,
+            'currency': currency['code'],
+            'network': this.safeString(networkEntry, 'network'),
             'address': address,
             'tag': tag,
         };
@@ -2825,23 +2838,13 @@ export default class poloniex extends Exchange {
     async withdraw(code, amount, address, tag = undefined, params = {}) {
         [tag, params] = this.handleWithdrawTagAndParams(tag, params);
         this.checkAddress(address);
-        await this.loadMarkets();
-        const currency = this.currency(code);
-        const request = {
-            'currency': currency['id'],
-            'amount': amount,
-            'address': address,
-        };
+        const [request, extraParams, currency, networkEntry] = this.prepareRequestForDepositAddress(code, params);
+        params = extraParams;
+        request['amount'] = this.currencyToPrecision(code, amount);
+        request['address'] = address;
         if (tag !== undefined) {
             request['paymentId'] = tag;
         }
-        const networks = this.safeValue(this.options, 'networks', {});
-        let network = this.safeStringUpper(params, 'network'); // this line allows the user to specify either ERC20 or ETH
-        network = this.safeString(networks, network, network); // handle ERC20>ETH alias
-        if (network !== undefined) {
-            request['currency'] = request['currency'] + network; // when network the currency need to be changed to currency+network https://docs.poloniex.com/#withdraw on MultiChain Currencies section
-            params = this.omit(params, 'network');
-        }
         const response = await this.privatePostWalletsWithdraw(this.extend(request, params));
         //
         //     {
@@ -2850,7 +2853,11 @@ export default class poloniex extends Exchange {
         //         "withdrawalNumber": 13449869
         //     }
         //
-        return this.parseTransaction(response, currency);
+        const withdrawResponse = {
+            'response': response,
+            'withdrawNetworkEntry': networkEntry,
+        };
+        return this.parseTransaction(withdrawResponse, currency);
     }
     async fetchTransactionsHelper(code = undefined, since = undefined, limit = undefined, params = {}) {
         await this.loadMarkets();
@@ -3176,6 +3183,10 @@ export default class poloniex extends Exchange {
         //         "withdrawalRequestsId": 33485231
         //     }
         //
+        // if it's being parsed from "withdraw()" method, get the original response
+        if ('withdrawNetworkEntry' in transaction) {
+            transaction = transaction['response'];
+        }
         const timestamp = this.safeTimestamp(transaction, 'timestamp');
         const currencyId = this.safeString(transaction, 'currency');
         const code = this.safeCurrencyCode(currencyId);

package/js/src/pro/binance.js

@@ -830,6 +830,7 @@ export default class binance extends binanceRest {
             orderbook.reset(snapshot);
             // unroll the accumulated deltas
             const messages = orderbook.cache;
+            orderbook.cache = [];
             for (let i = 0; i < messages.length; i++) {
                 const messageItem = messages[i];
                 const U = this.safeInteger(messageItem, 'U');

package/js/src/pro/{huobijp.d.ts → bittrade.d.ts}

@@ -1,12 +1,12 @@
-import huobijpRest from '../huobijp.js';
+import bittradeRest from '../bittrade.js';
 import type { Int, OrderBook, Trade, Ticker, OHLCV } from '../base/types.js';
 import Client from '../base/ws/Client.js';
-export default class huobijp extends huobijpRest {
+export default class bittrade extends bittradeRest {
     describe(): any;
     requestId(): any;
     /**
      * @method
-     * @name huobijp#watchTicker
+     * @name bittrade#watchTicker
      * @description watches a price ticker, a statistical calculation with the information calculated over the past 24 hours for a specific market
      * @param {string} symbol unified symbol of the market to fetch the ticker for
      * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -16,7 +16,7 @@ export default class huobijp extends huobijpRest {
     handleTicker(client: Client, message: any): any;
     /**
      * @method
-     * @name huobijp#watchTrades
+     * @name bittrade#watchTrades
      * @description get the list of most recent trades for a particular symbol
      * @param {string} symbol unified symbol of the market to fetch trades for
      * @param {int} [since] timestamp in ms of the earliest trade to fetch
@@ -28,7 +28,7 @@ export default class huobijp extends huobijpRest {
     handleTrades(client: Client, message: any): any;
     /**
      * @method
-     * @name huobijp#watchOHLCV
+     * @name bittrade#watchOHLCV
      * @description watches historical candlestick data containing the open, high, low, and close price, and the volume of a market
      * @param {string} symbol unified symbol of the market to fetch OHLCV data for
      * @param {string} timeframe the length of time each candle represents
@@ -41,7 +41,7 @@ export default class huobijp extends huobijpRest {
     handleOHLCV(client: Client, message: any): void;
     /**
      * @method
-     * @name huobijp#watchOrderBook
+     * @name bittrade#watchOrderBook
      * @description watches information on open orders with bid (buy) and ask (sell) prices, volumes and other data
      * @param {string} symbol unified symbol of the market to fetch the order book for
      * @param {int} [limit] the maximum amount of order book entries to return

package/js/src/pro/{huobijp.js → bittrade.js}

@@ -5,11 +5,11 @@
 // EDIT THE CORRESPONDENT .ts FILE INSTEAD
 
 // ----------------------------------------------------------------------------
-import huobijpRest from '../huobijp.js';
+import bittradeRest from '../bittrade.js';
 import { ExchangeError } from '../base/errors.js';
 import { ArrayCache, ArrayCacheByTimestamp } from '../base/ws/Cache.js';
 // ----------------------------------------------------------------------------
-export default class huobijp extends huobijpRest {
+export default class bittrade extends bittradeRest {
     describe() {
         return this.deepExtend(super.describe(), {
             'has': {
@@ -49,7 +49,7 @@ export default class huobijp extends huobijpRest {
     }
     /**
      * @method
-     * @name huobijp#watchTicker
+     * @name bittrade#watchTicker
      * @description watches a price ticker, a statistical calculation with the information calculated over the past 24 hours for a specific market
      * @param {string} symbol unified symbol of the market to fetch the ticker for
      * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -111,7 +111,7 @@ export default class huobijp extends huobijpRest {
     }
     /**
      * @method
-     * @name huobijp#watchTrades
+     * @name bittrade#watchTrades
      * @description get the list of most recent trades for a particular symbol
      * @param {string} symbol unified symbol of the market to fetch trades for
      * @param {int} [since] timestamp in ms of the earliest trade to fetch
@@ -188,7 +188,7 @@ export default class huobijp extends huobijpRest {
     }
     /**
      * @method
-     * @name huobijp#watchOHLCV
+     * @name bittrade#watchOHLCV
      * @description watches historical candlestick data containing the open, high, low, and close price, and the volume of a market
      * @param {string} symbol unified symbol of the market to fetch OHLCV data for
      * @param {string} timeframe the length of time each candle represents
@@ -262,7 +262,7 @@ export default class huobijp extends huobijpRest {
     }
     /**
      * @method
-     * @name huobijp#watchOrderBook
+     * @name bittrade#watchOrderBook
      * @description watches information on open orders with bid (buy) and ask (sell) prices, volumes and other data
      * @param {string} symbol unified symbol of the market to fetch the order book for
      * @param {int} [limit] the maximum amount of order book entries to return
@@ -585,7 +585,7 @@ export default class huobijp extends huobijpRest {
             //
             //           ________________________
             //
-            // sometimes huobijp responds with half of a JSON response like
+            // sometimes bittrade responds with half of a JSON response like
             //
             //     " {"ch":"market.ethbtc.m "
             //

package/js/src/pro/luno.js

@@ -198,17 +198,18 @@ export default class luno extends lunoRest {
         if (!(symbol in this.orderbooks)) {
             this.orderbooks[symbol] = this.indexedOrderBook({});
         }
-        const orderbook = this.orderbooks[symbol];
         const asks = this.safeValue(message, 'asks');
         if (asks !== undefined) {
             const snapshot = this.customParseOrderBook(message, symbol, timestamp, 'bids', 'asks', 'price', 'volume', 'id');
-            orderbook.reset(snapshot);
+            this.orderbooks[symbol] = this.indexedOrderBook(snapshot);
         }
         else {
-            this.handleDelta(orderbook, message);
-            orderbook['timestamp'] = timestamp;
-            orderbook['datetime'] = this.iso8601(timestamp);
+            const ob = this.orderbooks[symbol];
+            this.handleDelta(ob, message);
+            ob['timestamp'] = timestamp;
+            ob['datetime'] = this.iso8601(timestamp);
         }
+        const orderbook = this.orderbooks[symbol];
         const nonce = this.safeInteger(message, 'sequence');
         orderbook['nonce'] = nonce;
         client.resolve(orderbook, messageHash);

package/js/src/pro/mexc.js

@@ -797,6 +797,9 @@ export default class mexc extends mexcRest {
         const messageHash = 'orderbook:' + symbol;
         const subscription = this.safeValue(client.subscriptions, messageHash);
         const limit = this.safeInteger(subscription, 'limit');
+        if (!(symbol in this.orderbooks)) {
+            this.orderbooks[symbol] = this.orderBook();
+        }
         const storedOrderBook = this.orderbooks[symbol];
         const nonce = this.safeInteger(storedOrderBook, 'nonce');
         if (nonce === undefined) {