ccxt 4.4.75 → 4.4.78

package/js/src/tradeogre.js

@@ -21,7 +21,7 @@ export default class tradeogre extends Exchange {
             'countries': [],
             'rateLimit': 100,
             'version': 'v2',
-            'pro': false,
+            'pro': true,
             'has': {
                 'CORS': undefined,
                 'spot': true,
@@ -532,6 +532,7 @@ export default class tradeogre extends Exchange {
             'asks': rawAsks,
         };
         const orderbook = this.parseOrderBook(rawOrderbook, symbol);
+        orderbook['nonce'] = this.safeInteger(response, 's');
         return orderbook;
     }
     parseBidsAsks(bidasks, priceKey = 0, amountKey = 1, countOrIdKey = 2) {

package/js/src/upbit.d.ts

@@ -1,5 +1,5 @@
 import Exchange from './abstract/upbit.js';
-import type { Balances, Currency, Dict, Int, Market, Num, OHLCV, Order, OrderBook, OrderSide, OrderType, Str, Strings, Ticker, Tickers, Trade, TradingFeeInterface, Transaction, int, DepositAddress, OrderBooks } from './base/types.js';
+import type { Balances, Currency, Dict, Int, Market, Num, OHLCV, Order, OrderBook, OrderSide, OrderType, Str, Strings, Ticker, Tickers, Trade, TradingFeeInterface, Transaction, int, DepositAddress, OrderBooks, TradingFees } from './base/types.js';
 /**
  * @class upbit
  * @augments Exchange
@@ -124,6 +124,14 @@ export default class upbit extends Exchange {
      * @returns {object} a [fee structure]{@link https://docs.ccxt.com/#/?id=fee-structure}
      */
     fetchTradingFee(symbol: string, params?: {}): Promise<TradingFeeInterface>;
+    /**
+     * @method
+     * @name upbit#fetchTradingFees
+     * @description fetch the trading fees for markets
+     * @param {object} [params] extra parameters specific to the exchange API endpoint
+     * @returns {object} a [trading fee structure]{@link https://docs.ccxt.com/#/?id=trading-fee-structure}
+     */
+    fetchTradingFees(params?: {}): Promise<TradingFees>;
     parseOHLCV(ohlcv: any, market?: Market): OHLCV;
     /**
      * @method
@@ -138,6 +146,7 @@ export default class upbit extends Exchange {
      * @returns {int[][]} A list of candles ordered as timestamp, open, high, low, close, volume
      */
     fetchOHLCV(symbol: string, timeframe?: string, since?: Int, limit?: Int, params?: {}): Promise<OHLCV[]>;
+    calcOrderPrice(symbol: string, amount: number, price?: Num, params?: {}): string;
     /**
      * @method
      * @name upbit#createOrder
@@ -145,13 +154,14 @@ export default class upbit extends Exchange {
      * @see https://docs.upbit.com/reference/%EC%A3%BC%EB%AC%B8%ED%95%98%EA%B8%B0
      * @see https://global-docs.upbit.com/reference/order
      * @param {string} symbol unified symbol of the market to create an order in
-     * @param {string} type 'market' or 'limit'
+     * @param {string} type supports 'market' and 'limit'. if params.ordType is set to best, a best-type order will be created regardless of the value of type.
      * @param {string} side 'buy' or 'sell'
      * @param {float} amount how much you want to trade in units of the base currency
      * @param {float} [price] the price at which the order is to be fulfilled, in units of the quote currency, ignored in market orders
      * @param {object} [params] extra parameters specific to the exchange API endpoint
-     * @param {float} [params.cost] for market buy orders, the quote quantity that can be used as an alternative for the amount
-     * @param {string} [params.timeInForce] 'IOC' or 'FOK'
+     * @param {float} [params.cost] for market buy and best buy orders, the quote quantity that can be used as an alternative for the amount
+     * @param {string} [params.ordType] this field can be used to place a ‘best’ type order
+     * @param {string} [params.timeInForce] 'IOC' or 'FOK'. only for limit or best type orders. this field is required when the order type is 'best'.
      * @returns {object} an [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
      */
     createOrder(symbol: string, type: OrderType, side: OrderSide, amount: number, price?: Num, params?: {}): Promise<Order>;
@@ -166,6 +176,26 @@ export default class upbit extends Exchange {
      * @returns {object} An [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
      */
     cancelOrder(id: string, symbol?: Str, params?: {}): Promise<Order>;
+    /**
+     * @method
+     * @name upbit#editOrder
+     * @see https://docs.upbit.com/reference/%EC%B7%A8%EC%86%8C-%ED%9B%84-%EC%9E%AC%EC%A3%BC%EB%AC%B8
+     * @description canceled existing order and create new order. It's only generated same side and symbol as the canceled order. it returns the data of the canceled order, except for `new_order_uuid` and `new_identifier`. to get the details of the new order, use `fetchOrder(new_order_uuid)`.
+     * @param {string} id the uuid of the previous order you want to edit.
+     * @param {string} symbol the symbol of the new order. it must be the same as the symbol of the previous order.
+     * @param {string} type the type of the new order. only limit or market is accepted. if params.newOrdType is set to best, a best-type order will be created regardless of the value of type.
+     * @param {string} side the side of the new order. it must be the same as the side of the previous order.
+     * @param {number} amount the amount of the asset you want to buy or sell. It could be overridden by specifying the new_volume parameter in params.
+     * @param {number} price the price of the asset you want to buy or sell. It could be overridden by specifying the new_price parameter in params.
+     * @param {object} [params] extra parameters specific to the exchange API endpoint.
+     * @param {string} [params.clientOrderId] to identify the previous order, either the id or this field is required in this method.
+     * @param {float} [params.cost] for market buy and best buy orders, the quote quantity that can be used as an alternative for the amount.
+     * @param {string} [params.newTimeInForce] 'IOC' or 'FOK'. only for limit or best type orders. this field is required when the order type is 'best'.
+     * @param {string} [params.newClientOrderId] the order ID that the user can define.
+     * @param {string} [params.newOrdType] this field only accepts limit, price, market, or best. You can refer to the Upbit developer documentation for details on how to use this field.
+     * @returns {object} An [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
+     */
+    editOrder(id: string, symbol: string, type: OrderType, side: OrderSide, amount?: Num, price?: Num, params?: {}): Promise<Order>;
     /**
      * @method
      * @name upbit#fetchDeposits

package/js/src/upbit.js

@@ -24,7 +24,7 @@ export default class upbit extends Exchange {
             'name': 'Upbit',
             'countries': ['KR'],
             'version': 'v1',
-            'rateLimit': 1000,
+            'rateLimit': 50,
             'pro': true,
             // new metainfo interface
             'has': {
@@ -41,6 +41,7 @@ export default class upbit extends Exchange {
                 'createMarketOrderWithCost': false,
                 'createMarketSellOrderWithCost': false,
                 'createOrder': true,
+                'editOrder': true,
                 'fetchBalance': true,
                 'fetchCanceledOrders': true,
                 'fetchClosedOrders': true,
@@ -71,7 +72,7 @@ export default class upbit extends Exchange {
                 'fetchTickers': true,
                 'fetchTrades': true,
                 'fetchTradingFee': true,
-                'fetchTradingFees': false,
+                'fetchTradingFees': true,
                 'fetchTransactions': false,
                 'fetchWithdrawal': true,
                 'fetchWithdrawals': true,
@@ -79,6 +80,7 @@ export default class upbit extends Exchange {
                 'withdraw': true,
             },
             'timeframes': {
+                '1s': 'seconds',
                 '1m': 'minutes',
                 '3m': 'minutes',
                 '5m': 'minutes',
@@ -90,6 +92,7 @@ export default class upbit extends Exchange {
                 '1d': 'days',
                 '1w': 'weeks',
                 '1M': 'months',
+                '1y': 'years',
             },
             'hostname': 'api.upbit.com',
             'urls': {
@@ -103,54 +106,70 @@ export default class upbit extends Exchange {
                 'fees': 'https://upbit.com/service_center/guide',
             },
             'api': {
+                // 'endpoint','API Cost'
+                // cost = 1000 / (rateLimit * RPS)
                 'public': {
-                    'get': [
-                        'market/all',
-                        'candles/{timeframe}',
-                        'candles/{timeframe}/{unit}',
-                        'candles/minutes/{unit}',
-                        'candles/minutes/1',
-                        'candles/minutes/3',
-                        'candles/minutes/5',
-                        'candles/minutes/10',
-                        'candles/minutes/15',
-                        'candles/minutes/30',
-                        'candles/minutes/60',
-                        'candles/minutes/240',
-                        'candles/days',
-                        'candles/weeks',
-                        'candles/months',
-                        'trades/ticks',
-                        'ticker',
-                        'orderbook',
-                    ],
+                    'get': {
+                        'market/all': 2,
+                        'candles/{timeframe}': 2,
+                        'candles/{timeframe}/{unit}': 2,
+                        'candles/seconds': 2,
+                        'candles/minutes/{unit}': 2,
+                        'candles/minutes/1': 2,
+                        'candles/minutes/3': 2,
+                        'candles/minutes/5': 2,
+                        'candles/minutes/10': 2,
+                        'candles/minutes/15': 2,
+                        'candles/minutes/30': 2,
+                        'candles/minutes/60': 2,
+                        'candles/minutes/240': 2,
+                        'candles/days': 2,
+                        'candles/weeks': 2,
+                        'candles/months': 2,
+                        'candles/years': 2,
+                        'trades/ticks': 2,
+                        'ticker': 2,
+                        'ticker/all': 2,
+                        'orderbook': 2,
+                        'orderbook/supported_levels': 2, // Upbit KR only
+                    },
                 },
                 'private': {
-                    'get': [
-                        'accounts',
-                        'orders/chance',
-                        'order',
-                        'orders',
-                        'orders/closed',
-                        'orders/open',
-                        'orders/uuids',
-                        'withdraws',
-                        'withdraw',
-                        'withdraws/chance',
-                        'deposits',
-                        'deposit',
-                        'deposits/coin_addresses',
-                        'deposits/coin_address',
-                    ],
-                    'post': [
-                        'orders',
-                        'withdraws/coin',
-                        'withdraws/krw',
-                        'deposits/generate_coin_address',
-                    ],
-                    'delete': [
-                        'order',
-                    ],
+                    'get': {
+                        'accounts': 0.67,
+                        'orders/chance': 0.67,
+                        'order': 0.67,
+                        'orders/closed': 0.67,
+                        'orders/open': 0.67,
+                        'orders/uuids': 0.67,
+                        'withdraws': 0.67,
+                        'withdraw': 0.67,
+                        'withdraws/chance': 0.67,
+                        'withdraws/coin_addresses': 0.67,
+                        'deposits': 0.67,
+                        'deposits/chance/coin': 0.67,
+                        'deposit': 0.67,
+                        'deposits/coin_addresses': 0.67,
+                        'deposits/coin_address': 0.67,
+                        'travel_rule/vasps': 0.67,
+                        'status/wallet': 0.67,
+                        'api_keys': 0.67, // Upbit KR only
+                    },
+                    'post': {
+                        'orders': 2.5,
+                        'orders/cancel_and_new': 2.5,
+                        'withdraws/coin': 0.67,
+                        'withdraws/krw': 0.67,
+                        'deposits/krw': 0.67,
+                        'deposits/generate_coin_address': 0.67,
+                        'travel_rule/deposit/uuid': 0.67,
+                        'travel_rule/deposit/txid': 0.67, // RPS: 30, but each deposit can only be queried once every 10 minutes
+                    },
+                    'delete': {
+                        'order': 0.67,
+                        'orders/open': 40,
+                        'orders/uuids': 0.67,
+                    },
                 },
             },
             'fees': {
@@ -253,8 +272,6 @@ export default class upbit extends Exchange {
             },
             'options': {
                 'createMarketBuyOrderRequiresPrice': true,
-                'fetchTickersMaxLength': 4096,
-                'fetchOrderBooksMaxLength': 4096,
                 'tradingFeesByQuoteCurrency': {
                     'KRW': 0.0005,
                 },
@@ -609,11 +626,6 @@ export default class upbit extends Exchange {
         let ids = undefined;
         if (symbols === undefined) {
             ids = this.ids.join(',');
-            // max URL length is 2083 symbols, including http schema, hostname, tld, etc...
-            if (ids.length > this.options['fetchOrderBooksMaxLength']) {
-                const numIds = this.ids.length;
-                throw new ExchangeError(this.id + ' fetchOrderBooks() has ' + numIds.toString() + ' symbols (' + ids.length.toString() + ' characters) exceeding max URL length (' + this.options['fetchOrderBooksMaxLength'].toString() + ' characters), you are required to specify a list of symbols in the first argument to fetchOrderBooks');
-            }
         }
         else {
             ids = this.marketIds(symbols);
@@ -753,11 +765,6 @@ export default class upbit extends Exchange {
         let ids = undefined;
         if (symbols === undefined) {
             ids = this.ids.join(',');
-            // max URL length is 2083 symbols, including http schema, hostname, tld, etc...
-            if (ids.length > this.options['fetchTickersMaxLength']) {
-                const numIds = this.ids.length;
-                throw new ExchangeError(this.id + ' fetchTickers() has ' + numIds.toString() + ' symbols exceeding max URL length, you are required to specify a list of symbols in the first argument to fetchTickers');
-            }
         }
         else {
             ids = this.marketIds(symbols);
@@ -999,6 +1006,29 @@ export default class upbit extends Exchange {
             'tierBased': false,
         };
     }
+    /**
+     * @method
+     * @name upbit#fetchTradingFees
+     * @description fetch the trading fees for markets
+     * @param {object} [params] extra parameters specific to the exchange API endpoint
+     * @returns {object} a [trading fee structure]{@link https://docs.ccxt.com/#/?id=trading-fee-structure}
+     */
+    async fetchTradingFees(params = {}) {
+        await this.loadMarkets();
+        const fetchMarketResponse = await this.fetchMarkets(params);
+        const response = {};
+        for (let i = 0; i < fetchMarketResponse.length; i++) {
+            const element = {};
+            element['maker'] = this.safeNumber(fetchMarketResponse[i], 'maker');
+            element['taker'] = this.safeNumber(fetchMarketResponse[i], 'taker');
+            element['symbol'] = this.safeString(fetchMarketResponse[i], 'symbol');
+            element['percentage'] = true;
+            element['tierBased'] = false;
+            element['info'] = fetchMarketResponse[i];
+            response[this.safeString(fetchMarketResponse[i], 'symbol')] = element;
+        }
+        return response;
+    }
     parseOHLCV(ohlcv, market = undefined) {
         //
         //     {
@@ -1094,6 +1124,30 @@ export default class upbit extends Exchange {
         //
         return this.parseOHLCVs(response, market, timeframe, since, limit);
     }
+    calcOrderPrice(symbol, amount, price = undefined, params = {}) {
+        let quoteAmount = undefined;
+        const createMarketBuyOrderRequiresPrice = this.safeValue(this.options, 'createMarketBuyOrderRequiresPrice');
+        const cost = this.safeString(params, 'cost');
+        if (cost !== undefined) {
+            quoteAmount = this.costToPrecision(symbol, cost);
+        }
+        else if (createMarketBuyOrderRequiresPrice) {
+            if (price === undefined || amount === undefined) {
+                throw new InvalidOrder(this.id + ' createOrder() requires the price and amount argument for market buy orders to calculate the total cost to spend (amount * price), alternatively set the createMarketBuyOrderRequiresPrice option or param to false and pass the cost to spend (quote quantity) in the amount argument');
+            }
+            const amountString = this.numberToString(amount);
+            const priceString = this.numberToString(price);
+            const costRequest = Precise.stringMul(amountString, priceString);
+            quoteAmount = this.costToPrecision(symbol, costRequest);
+        }
+        else {
+            if (amount === undefined) {
+                throw new ArgumentsRequired(this.id + ' When createMarketBuyOrderRequiresPrice is false, "amount" is required and should be the total quote amount to spend.');
+            }
+            quoteAmount = this.costToPrecision(symbol, amount);
+        }
+        return quoteAmount;
+    }
     /**
      * @method
      * @name upbit#createOrder
@@ -1101,13 +1155,14 @@ export default class upbit extends Exchange {
      * @see https://docs.upbit.com/reference/%EC%A3%BC%EB%AC%B8%ED%95%98%EA%B8%B0
      * @see https://global-docs.upbit.com/reference/order
      * @param {string} symbol unified symbol of the market to create an order in
-     * @param {string} type 'market' or 'limit'
+     * @param {string} type supports 'market' and 'limit'. if params.ordType is set to best, a best-type order will be created regardless of the value of type.
      * @param {string} side 'buy' or 'sell'
      * @param {float} amount how much you want to trade in units of the base currency
      * @param {float} [price] the price at which the order is to be fulfilled, in units of the quote currency, ignored in market orders
      * @param {object} [params] extra parameters specific to the exchange API endpoint
-     * @param {float} [params.cost] for market buy orders, the quote quantity that can be used as an alternative for the amount
-     * @param {string} [params.timeInForce] 'IOC' or 'FOK'
+     * @param {float} [params.cost] for market buy and best buy orders, the quote quantity that can be used as an alternative for the amount
+     * @param {string} [params.ordType] this field can be used to place a ‘best’ type order
+     * @param {string} [params.timeInForce] 'IOC' or 'FOK'. only for limit or best type orders. this field is required when the order type is 'best'.
      * @returns {object} an [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
      */
     async createOrder(symbol, type, side, amount, price = undefined, params = {}) {
@@ -1121,58 +1176,69 @@ export default class upbit extends Exchange {
             orderSide = 'ask';
         }
         else {
-            throw new InvalidOrder(this.id + ' createOrder() allows buy or sell side only!');
+            throw new InvalidOrder(this.id + ' createOrder() supports only buy or sell in the side argument.');
         }
         const request = {
             'market': market['id'],
             'side': orderSide,
         };
         if (type === 'limit') {
+            if (price === undefined || amount === undefined) {
+                throw new ArgumentsRequired(this.id + ' the limit type order in createOrder() is required price and amount.');
+            }
+            request['ord_type'] = 'limit';
             request['price'] = this.priceToPrecision(symbol, price);
+            request['volume'] = this.amountToPrecision(symbol, amount);
         }
-        if ((type === 'market') && (side === 'buy')) {
-            // for market buy it requires the amount of quote currency to spend
-            let quoteAmount = undefined;
-            let createMarketBuyOrderRequiresPrice = true;
-            [createMarketBuyOrderRequiresPrice, params] = this.handleOptionAndParams(params, 'createOrder', 'createMarketBuyOrderRequiresPrice', true);
-            const cost = this.safeNumber(params, 'cost');
-            params = this.omit(params, 'cost');
-            if (cost !== undefined) {
-                quoteAmount = this.costToPrecision(symbol, cost);
-            }
-            else if (createMarketBuyOrderRequiresPrice) {
-                if (price === undefined) {
-                    throw new InvalidOrder(this.id + ' createOrder() requires the price argument for market buy orders to calculate the total cost to spend (amount * price), alternatively set the createMarketBuyOrderRequiresPrice option or param to false and pass the cost to spend (quote quantity) in the amount argument');
-                }
-                else {
-                    const amountString = this.numberToString(amount);
-                    const priceString = this.numberToString(price);
-                    const costRequest = Precise.stringMul(amountString, priceString);
-                    quoteAmount = this.costToPrecision(symbol, costRequest);
-                }
+        else if (type === 'market') {
+            if (side === 'buy') {
+                request['ord_type'] = 'price';
+                const orderPrice = this.calcOrderPrice(symbol, amount, price, params);
+                request['price'] = orderPrice;
             }
             else {
-                quoteAmount = this.costToPrecision(symbol, amount);
+                if (amount === undefined) {
+                    throw new ArgumentsRequired(this.id + ' the market sell type order in createOrder() is required amount.');
+                }
+                request['ord_type'] = 'market';
+                request['volume'] = this.amountToPrecision(symbol, amount);
             }
-            request['ord_type'] = 'price';
-            request['price'] = quoteAmount;
         }
         else {
-            request['ord_type'] = type;
-            request['volume'] = this.amountToPrecision(symbol, amount);
+            throw new InvalidOrder(this.id + ' createOrder() supports only limit or market types in the type argument.');
         }
-        const clientOrderId = this.safeString2(params, 'clientOrderId', 'identifier');
+        const customType = this.safeString2(params, 'ordType', 'ord_type');
+        if (customType === 'best') {
+            params = this.omit(params, ['ordType', 'ord_type']);
+            request['ord_type'] = 'best';
+            if (side === 'buy') {
+                const orderPrice = this.calcOrderPrice(symbol, amount, price, params);
+                request['price'] = orderPrice;
+            }
+            else {
+                if (amount === undefined) {
+                    throw new ArgumentsRequired(this.id + ' the best sell type order in createOrder() is required amount.');
+                }
+                request['volume'] = this.amountToPrecision(symbol, amount);
+            }
+        }
+        const clientOrderId = this.safeString(params, 'clientOrderId');
         if (clientOrderId !== undefined) {
             request['identifier'] = clientOrderId;
         }
-        if (type !== 'market') {
+        if (request['ord_type'] !== 'market' && request['ord_type'] !== 'price') {
             const timeInForce = this.safeStringLower2(params, 'timeInForce', 'time_in_force');
-            params = this.omit(params, 'timeInForce');
+            params = this.omit(params, ['timeInForce']);
             if (timeInForce !== undefined) {
                 request['time_in_force'] = timeInForce;
             }
+            else {
+                if (request['ord_type'] === 'best') {
+                    throw new ArgumentsRequired(this.id + ' the best type order in createOrder() is required timeInForce.');
+                }
+            }
         }
-        params = this.omit(params, ['clientOrderId', 'identifier']);
+        params = this.omit(params, ['clientOrderId', 'cost']);
         const response = await this.privatePostOrders(this.extend(request, params));
         //
         //     {
@@ -1233,6 +1299,125 @@ export default class upbit extends Exchange {
         //
         return this.parseOrder(response);
     }
+    /**
+     * @method
+     * @name upbit#editOrder
+     * @see https://docs.upbit.com/reference/%EC%B7%A8%EC%86%8C-%ED%9B%84-%EC%9E%AC%EC%A3%BC%EB%AC%B8
+     * @description canceled existing order and create new order. It's only generated same side and symbol as the canceled order. it returns the data of the canceled order, except for `new_order_uuid` and `new_identifier`. to get the details of the new order, use `fetchOrder(new_order_uuid)`.
+     * @param {string} id the uuid of the previous order you want to edit.
+     * @param {string} symbol the symbol of the new order. it must be the same as the symbol of the previous order.
+     * @param {string} type the type of the new order. only limit or market is accepted. if params.newOrdType is set to best, a best-type order will be created regardless of the value of type.
+     * @param {string} side the side of the new order. it must be the same as the side of the previous order.
+     * @param {number} amount the amount of the asset you want to buy or sell. It could be overridden by specifying the new_volume parameter in params.
+     * @param {number} price the price of the asset you want to buy or sell. It could be overridden by specifying the new_price parameter in params.
+     * @param {object} [params] extra parameters specific to the exchange API endpoint.
+     * @param {string} [params.clientOrderId] to identify the previous order, either the id or this field is required in this method.
+     * @param {float} [params.cost] for market buy and best buy orders, the quote quantity that can be used as an alternative for the amount.
+     * @param {string} [params.newTimeInForce] 'IOC' or 'FOK'. only for limit or best type orders. this field is required when the order type is 'best'.
+     * @param {string} [params.newClientOrderId] the order ID that the user can define.
+     * @param {string} [params.newOrdType] this field only accepts limit, price, market, or best. You can refer to the Upbit developer documentation for details on how to use this field.
+     * @returns {object} An [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
+     */
+    async editOrder(id, symbol, type, side, amount = undefined, price = undefined, params = {}) {
+        await this.loadMarkets();
+        const request = {};
+        const prevClientOrderId = this.safeString(params, 'clientOrderId');
+        params = this.omit(params, 'clientOrderId');
+        if (id !== undefined) {
+            request['prev_order_uuid'] = id;
+        }
+        else if (prevClientOrderId !== undefined) {
+            request['prev_order_identifier'] = prevClientOrderId;
+        }
+        else {
+            throw new ArgumentsRequired(this.id + ' editOrder() is required id or clientOrderId.');
+        }
+        if (type === 'limit') {
+            if (price === undefined || amount === undefined) {
+                throw new ArgumentsRequired(this.id + ' editOrder() is required price and amount to create limit type order.');
+            }
+            request['new_ord_type'] = 'limit';
+            request['new_price'] = this.priceToPrecision(symbol, price);
+            request['new_volume'] = this.amountToPrecision(symbol, amount);
+        }
+        else if (type === 'market') {
+            if (side === 'buy') {
+                request['new_ord_type'] = 'price';
+                const orderPrice = this.calcOrderPrice(symbol, amount, price, params);
+                request['new_price'] = orderPrice;
+            }
+            else {
+                if (amount === undefined) {
+                    throw new ArgumentsRequired(this.id + ' editOrder() is required amount to create market sell type order.');
+                }
+                request['new_ord_type'] = 'market';
+                request['new_volume'] = this.amountToPrecision(symbol, amount);
+            }
+        }
+        else {
+            throw new InvalidOrder(this.id + ' editOrder() supports only limit or market types in the type argument.');
+        }
+        const customType = this.safeString2(params, 'newOrdType', 'new_ord_type');
+        if (customType === 'best') {
+            params = this.omit(params, ['newOrdType', 'new_ord_type']);
+            request['new_ord_type'] = 'best';
+            if (side === 'buy') {
+                const orderPrice = this.calcOrderPrice(symbol, amount, price, params);
+                request['new_price'] = orderPrice;
+            }
+            else {
+                if (amount === undefined) {
+                    throw new ArgumentsRequired(this.id + ' editOrder() is required amount to create best sell order.');
+                }
+                request['new_volume'] = this.amountToPrecision(symbol, amount);
+            }
+        }
+        const clientOrderId = this.safeString(params, 'newClientOrderId');
+        if (clientOrderId !== undefined) {
+            request['new_identifier'] = clientOrderId;
+        }
+        if (request['new_ord_type'] !== 'market' && request['new_ord_type'] !== 'price') {
+            const timeInForce = this.safeStringLower2(params, 'newTimeInForce', 'new_time_in_force');
+            params = this.omit(params, ['newTimeInForce', 'new_time_in_force']);
+            if (timeInForce !== undefined) {
+                request['new_time_in_force'] = timeInForce;
+            }
+            else {
+                if (request['new_ord_type'] === 'best') {
+                    throw new ArgumentsRequired(this.id + ' the best type order is required timeInForce.');
+                }
+            }
+        }
+        params = this.omit(params, ['newClientOrderId', 'cost']);
+        // console.log ('check the each request params: ', request);
+        const response = await this.privatePostOrdersCancelAndNew(this.extend(request, params));
+        //   {
+        //     uuid: '63b38774-27db-4439-ac20-1be16a24d18e',        //previous order data
+        //     side: 'bid',                                         //previous order data
+        //     ord_type: 'limit',                                   //previous order data
+        //     price: '100000000',                                  //previous order data
+        //     state: 'wait',                                       //previous order data
+        //     market: 'KRW-BTC',                                   //previous order data
+        //     created_at: '2025-04-01T15:30:47+09:00',             //previous order data
+        //     volume: '0.00008',                                   //previous order data
+        //     remaining_volume: '0.00008',                         //previous order data
+        //     reserved_fee: '4',                                   //previous order data
+        //     remaining_fee: '4',                                  //previous order data
+        //     paid_fee: '0',                                       //previous order data
+        //     locked: '8004',                                      //previous order data
+        //     executed_volume: '0',                                //previous order data
+        //     trades_count: '0',                                   //previous order data
+        //     identifier: '21',                                    //previous order data
+        //     new_order_uuid: 'cb1cce56-6237-4a78-bc11-4cfffc1bb4c2',  // new order data
+        //     new_order_identifier: '22'                               // new order data
+        //   }
+        const result = {};
+        result['uuid'] = this.safeString(response, 'new_order_uuid');
+        result['identifier'] = this.safeString(response, 'new_order_identifier');
+        result['side'] = this.safeString(response, 'side');
+        result['market'] = this.safeString(response, 'market');
+        return this.parseOrder(result);
+    }
     /**
      * @method
      * @name upbit#fetchDeposits
@@ -1553,6 +1738,26 @@ export default class upbit extends Exchange {
         //         "time_in_force": "ioc"
         //     }
         //
+        //     {
+        //        uuid: '63b38774-27db-4439-ac20-1be16a24d18e',
+        //        side: 'bid',
+        //        ord_type: 'limit',
+        //        price: '100000000',
+        //        state: 'wait',
+        //        market: 'KRW-BTC',
+        //        created_at: '2025-04-01T15:30:47+09:00',
+        //        volume: '0.00008',
+        //        remaining_volume: '0.00008',
+        //        reserved_fee: '4',
+        //        remaining_fee: '4',
+        //        paid_fee: '0',
+        //        locked: '8004',
+        //        executed_volume: '0',
+        //        trades_count: '0',
+        //        identifier: '21',
+        //        new_order_uuid: 'cb1cce56-6237-4a78-bc11-4cfffc1bb4c2',
+        //        new_order_identifier: '22'
+        //      }
         const id = this.safeString(order, 'uuid');
         let side = this.safeString(order, 'side');
         if (side === 'bid') {
@@ -1561,6 +1766,7 @@ export default class upbit extends Exchange {
         else {
             side = 'sell';
         }
+        const identifier = this.safeString(order, 'identifier');
         let type = this.safeString(order, 'ord_type');
         const timestamp = this.parse8601(this.safeString(order, 'created_at'));
         const status = this.parseOrderStatus(this.safeString(order, 'state'));
@@ -1617,7 +1823,7 @@ export default class upbit extends Exchange {
         return this.safeOrder({
             'info': order,
             'id': id,
-            'clientOrderId': undefined,
+            'clientOrderId': identifier,
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
             'lastTradeTimestamp': lastTradeTimestamp,