ccxt 4.4.53 → 4.4.57

package/js/src/base/Exchange.js

@@ -802,7 +802,8 @@ export default class Exchange {
                 if (numberNormalized.indexOf('e-') > -1) {
                     return this.number(numberToString(parseFloat(numberNormalized)));
                 }
-                return this.number(numberNormalized);
+                const result = this.number(numberNormalized);
+                return isNaN(result) ? d : result;
             }
             catch (e) {
                 return d;
@@ -1193,7 +1194,7 @@ export default class Exchange {
     starknetEncodeStructuredData(domain, messageTypes, messageData, address) {
         const types = Object.keys(messageTypes);
         if (types.length > 1) {
-            throw new NotSupported(this.id + 'starknetEncodeStructuredData only support single type');
+            throw new NotSupported(this.id + ' starknetEncodeStructuredData only support single type');
         }
         const request = {
             'domain': domain,
@@ -1895,10 +1896,22 @@ export default class Exchange {
                     if (limit > arrayLength) {
                         limit = arrayLength;
                     }
-                    array = ascending ? this.arraySlice(array, 0, limit) : this.arraySlice(array, -limit);
+                    // array = ascending ? this.arraySlice (array, 0, limit) : this.arraySlice (array, -limit);
+                    if (ascending) {
+                        array = this.arraySlice(array, 0, limit);
+                    }
+                    else {
+                        array = this.arraySlice(array, -limit);
+                    }
                 }
                 else {
-                    array = ascending ? this.arraySlice(array, -limit) : this.arraySlice(array, 0, limit);
+                    // array = ascending ? this.arraySlice (array, -limit) : this.arraySlice (array, 0, limit);
+                    if (ascending) {
+                        array = this.arraySlice(array, -limit);
+                    }
+                    else {
+                        array = this.arraySlice(array, 0, limit);
+                    }
                 }
             }
         }
@@ -2313,36 +2326,17 @@ export default class Exchange {
     }
     featuresGenerator() {
         //
-        // the exchange-specific features can be something like this, where we support 'string' aliases too:
+        // in the exchange-specific features can be something like this, where we support 'string' aliases too:
         //
         //     {
-        //         'myItem' : {
+        //         'my' : {
         //             'createOrder' : {...},
-        //             'fetchOrders' : {...},
         //         },
         //         'swap': {
-        //             'linear': 'myItem',
-        //             'inverse': 'myItem',
-        //         },
-        //         'future': {
-        //             'linear': 'myItem',
-        //             'inverse': 'myItem',
-        //         }
-        //     }
-        //
-        //
-        //
-        // this method would regenerate the blank features tree, eg:
-        //
-        //     {
-        //         "spot": {
-        //             "createOrder": undefined,
-        //             "fetchBalance": undefined,
-        //             ...
+        //             'linear': {
+        //                 'extends': my',
+        //             },
         //         },
-        //         "swap": {
-        //             ...
-        //         }
         //     }
         //
         if (this.features === undefined) {
@@ -2387,14 +2381,13 @@ export default class Exchange {
             featuresObj = this.deepExtend(extendObj, featuresObj);
         }
         //
-        // corrections
+        // ### corrections ###
         //
+        // createOrder
         if ('createOrder' in featuresObj) {
             const value = this.safeDict(featuresObj['createOrder'], 'attachedStopLossTakeProfit');
-            if (value !== undefined) {
-                featuresObj['createOrder']['stopLoss'] = value;
-                featuresObj['createOrder']['takeProfit'] = value;
-            }
+            featuresObj['createOrder']['stopLoss'] = value;
+            featuresObj['createOrder']['takeProfit'] = value;
             if (marketType === 'spot') {
                 // default 'hedged': false
                 featuresObj['createOrder']['hedged'] = false;
@@ -2408,6 +2401,18 @@ export default class Exchange {
                 featuresObj['createOrder']['timeInForce']['GTC'] = true;
             }
         }
+        // other methods
+        const keys = Object.keys(featuresObj);
+        for (let i = 0; i < keys.length; i++) {
+            const key = keys[i];
+            const featureBlock = featuresObj[key];
+            if (!this.inArray(key, ['sandbox']) && featureBlock !== undefined) {
+                // default "symbolRequired" to false to all methods (except `createOrder`)
+                if (!('symbolRequired' in featureBlock)) {
+                    featureBlock['symbolRequired'] = this.inArray(key, ['createOrder', 'createOrders', 'fetchOHLCV']);
+                }
+            }
+        }
         return featuresObj;
     }
     orderbookChecksumMessage(symbol) {
@@ -2673,7 +2678,9 @@ export default class Exchange {
         for (let i = 0; i < marketValues.length; i++) {
             const value = marketValues[i];
             if (value['id'] in this.markets_by_id) {
-                this.markets_by_id[value['id']].push(value);
+                const marketsByIdArray = this.markets_by_id[value['id']];
+                marketsByIdArray.push(value);
+                this.markets_by_id[value['id']] = marketsByIdArray;
             }
             else {
                 this.markets_by_id[value['id']] = [value];
@@ -3106,7 +3113,8 @@ export default class Exchange {
         let results = [];
         if (Array.isArray(orders)) {
             for (let i = 0; i < orders.length; i++) {
-                const order = this.extend(this.parseOrder(orders[i], market), params);
+                const parsed = this.parseOrder(orders[i], market); // don't inline this call
+                const order = this.extend(parsed, params);
                 results.push(order);
             }
         }
@@ -3114,7 +3122,9 @@ export default class Exchange {
             const ids = Object.keys(orders);
             for (let i = 0; i < ids.length; i++) {
                 const id = ids[i];
-                const order = this.extend(this.parseOrder(this.extend({ 'id': id }, orders[id]), market), params);
+                const idExtended = this.extend({ 'id': id }, orders[id]);
+                const parsedOrder = this.parseOrder(idExtended, market); // don't  inline these calls
+                const order = this.extend(parsedOrder, params);
                 results.push(order);
             }
         }
@@ -3514,12 +3524,18 @@ export default class Exchange {
         result[volume] = [];
         for (let i = 0; i < ohlcvs.length; i++) {
             const ts = ms ? ohlcvs[i][0] : this.parseToInt(ohlcvs[i][0] / 1000);
-            result[timestamp].push(ts);
-            result[open].push(ohlcvs[i][1]);
-            result[high].push(ohlcvs[i][2]);
-            result[low].push(ohlcvs[i][3]);
-            result[close].push(ohlcvs[i][4]);
-            result[volume].push(ohlcvs[i][5]);
+            const resultTimestamp = result[timestamp];
+            resultTimestamp.push(ts);
+            const resultOpen = result[open];
+            resultOpen.push(ohlcvs[i][1]);
+            const resultHigh = result[high];
+            resultHigh.push(ohlcvs[i][2]);
+            const resultLow = result[low];
+            resultLow.push(ohlcvs[i][3]);
+            const resultClose = result[close];
+            resultClose.push(ohlcvs[i][4]);
+            const resultVolume = result[volume];
+            resultVolume.push(ohlcvs[i][5]);
         }
         return result;
     }
@@ -3535,9 +3551,11 @@ export default class Exchange {
             const maxRetries = this.safeValue(options, 'webApiRetries', 10);
             let response = undefined;
             let retry = 0;
+            let shouldBreak = false;
             while (retry < maxRetries) {
                 try {
                     response = await this[endpointMethod]({});
+                    shouldBreak = true;
                     break;
                 }
                 catch (e) {
@@ -3546,6 +3564,9 @@ export default class Exchange {
                         throw e;
                     }
                 }
+                if (shouldBreak) {
+                    break; // this is needed because of GO
+                }
             }
             let content = response;
             if (startRegex !== undefined) {
@@ -4128,7 +4149,13 @@ export default class Exchange {
         objects = this.toArray(objects);
         // return all of them if no values were passed
         if (values === undefined || !values) {
-            return indexed ? this.indexBy(objects, key) : objects;
+            // return indexed ? this.indexBy (objects, key) : objects;
+            if (indexed) {
+                return this.indexBy(objects, key);
+            }
+            else {
+                return objects;
+            }
         }
         const results = [];
         for (let i = 0; i < objects.length; i++) {
@@ -4136,7 +4163,11 @@ export default class Exchange {
                 results.push(objects[i]);
             }
         }
-        return indexed ? this.indexBy(results, key) : results;
+        // return indexed ? this.indexBy (results, key) : results;
+        if (indexed) {
+            return this.indexBy(results, key);
+        }
+        return results;
     }
     async fetch2(path, api = 'public', method = 'GET', params = {}, headers = undefined, body = undefined, config = {}) {
         if (this.enableRateLimit) {
@@ -4165,10 +4196,12 @@ export default class Exchange {
                         if ((retryDelay !== undefined) && (retryDelay !== 0)) {
                             await this.sleep(retryDelay);
                         }
-                        continue;
+                        // continue; //check this
                     }
                 }
-                throw e;
+                if (i >= retries) {
+                    throw e;
+                }
             }
         }
         return undefined; // this line is never reached, but exists for c# value return requirement
@@ -4346,7 +4379,7 @@ export default class Exchange {
             'precision': undefined,
         });
     }
-    safeMarket(marketId, market = undefined, delimiter = undefined, marketType = undefined) {
+    safeMarket(marketId = undefined, market = undefined, delimiter = undefined, marketType = undefined) {
         const result = this.safeMarketStructure({
             'symbol': marketId,
             'marketId': marketId,
@@ -4544,9 +4577,8 @@ export default class Exchange {
         return [value2, params];
     }
     handleOption(methodName, optionName, defaultValue = undefined) {
-        // eslint-disable-next-line no-unused-vars
-        const [result, empty] = this.handleOptionAndParams({}, methodName, optionName, defaultValue);
-        return result;
+        const res = this.handleOptionAndParams({}, methodName, optionName, defaultValue);
+        return this.safeValue(res, 0);
     }
     handleMarketTypeAndParams(methodName, market = undefined, params = {}, defaultValue = undefined) {
         /**
@@ -4747,6 +4779,18 @@ export default class Exchange {
     async createOrder(symbol, type, side, amount, price = undefined, params = {}) {
         throw new NotSupported(this.id + ' createOrder() is not supported yet');
     }
+    async createConvertTrade(id, fromCode, toCode, amount = undefined, params = {}) {
+        throw new NotSupported(this.id + ' createConvertTrade() is not supported yet');
+    }
+    async fetchConvertTrade(id, code = undefined, params = {}) {
+        throw new NotSupported(this.id + ' fetchConvertTrade() is not supported yet');
+    }
+    async fetchConvertTradeHistory(code = undefined, since = undefined, limit = undefined, params = {}) {
+        throw new NotSupported(this.id + ' fetchConvertTradeHistory() is not supported yet');
+    }
+    async fetchPositionMode(symbol = undefined, params = {}) {
+        throw new NotSupported(this.id + ' fetchPositionMode() is not supported yet');
+    }
     async createTrailingAmountOrder(symbol, type, side, amount, price = undefined, trailingAmount = undefined, trailingTriggerPrice = undefined, params = {}) {
         /**
          * @method
@@ -5439,10 +5483,16 @@ export default class Exchange {
         return await this.createOrderWs(symbol, 'market', 'sell', amount, undefined, params);
     }
     costToPrecision(symbol, cost) {
+        if (cost === undefined) {
+            return undefined;
+        }
         const market = this.market(symbol);
         return this.decimalToPrecision(cost, TRUNCATE, market['precision']['price'], this.precisionMode, this.paddingMode);
     }
     priceToPrecision(symbol, price) {
+        if (price === undefined) {
+            return undefined;
+        }
         const market = this.market(symbol);
         const result = this.decimalToPrecision(price, ROUND, market['precision']['price'], this.precisionMode, this.paddingMode);
         if (result === '0') {
@@ -5451,6 +5501,9 @@ export default class Exchange {
         return result;
     }
     amountToPrecision(symbol, amount) {
+        if (amount === undefined) {
+            return undefined;
+        }
         const market = this.market(symbol);
         const result = this.decimalToPrecision(amount, TRUNCATE, market['precision']['amount'], this.precisionMode, this.paddingMode);
         if (result === '0') {
@@ -5459,6 +5512,9 @@ export default class Exchange {
         return result;
     }
     feeToPrecision(symbol, fee) {
+        if (fee === undefined) {
+            return undefined;
+        }
         const market = this.market(symbol);
         return this.decimalToPrecision(fee, ROUND, market['precision']['price'], this.precisionMode, this.paddingMode);
     }
@@ -5569,28 +5625,28 @@ export default class Exchange {
     }
     async createPostOnlyOrder(symbol, type, side, amount, price = undefined, params = {}) {
         if (!this.has['createPostOnlyOrder']) {
-            throw new NotSupported(this.id + 'createPostOnlyOrder() is not supported yet');
+            throw new NotSupported(this.id + ' createPostOnlyOrder() is not supported yet');
         }
         const query = this.extend(params, { 'postOnly': true });
         return await this.createOrder(symbol, type, side, amount, price, query);
     }
     async createPostOnlyOrderWs(symbol, type, side, amount, price = undefined, params = {}) {
         if (!this.has['createPostOnlyOrderWs']) {
-            throw new NotSupported(this.id + 'createPostOnlyOrderWs() is not supported yet');
+            throw new NotSupported(this.id + ' createPostOnlyOrderWs() is not supported yet');
         }
         const query = this.extend(params, { 'postOnly': true });
         return await this.createOrderWs(symbol, type, side, amount, price, query);
     }
     async createReduceOnlyOrder(symbol, type, side, amount, price = undefined, params = {}) {
         if (!this.has['createReduceOnlyOrder']) {
-            throw new NotSupported(this.id + 'createReduceOnlyOrder() is not supported yet');
+            throw new NotSupported(this.id + ' createReduceOnlyOrder() is not supported yet');
         }
         const query = this.extend(params, { 'reduceOnly': true });
         return await this.createOrder(symbol, type, side, amount, price, query);
     }
     async createReduceOnlyOrderWs(symbol, type, side, amount, price = undefined, params = {}) {
         if (!this.has['createReduceOnlyOrderWs']) {
-            throw new NotSupported(this.id + 'createReduceOnlyOrderWs() is not supported yet');
+            throw new NotSupported(this.id + ' createReduceOnlyOrderWs() is not supported yet');
         }
         const query = this.extend(params, { 'reduceOnly': true });
         return await this.createOrderWs(symbol, type, side, amount, price, query);
@@ -5722,7 +5778,8 @@ export default class Exchange {
         const results = [];
         if (Array.isArray(tickers)) {
             for (let i = 0; i < tickers.length; i++) {
-                const ticker = this.extend(this.parseTicker(tickers[i]), params);
+                const parsedTicker = this.parseTicker(tickers[i]);
+                const ticker = this.extend(parsedTicker, params);
                 results.push(ticker);
             }
         }
@@ -5731,7 +5788,8 @@ export default class Exchange {
             for (let i = 0; i < marketIds.length; i++) {
                 const marketId = marketIds[i];
                 const market = this.safeMarket(marketId);
-                const ticker = this.extend(this.parseTicker(tickers[marketId], market), params);
+                const parsed = this.parseTicker(tickers[marketId], market);
+                const ticker = this.extend(parsed, params);
                 results.push(ticker);
             }
         }

package/js/src/base/types.d.ts

@@ -140,6 +140,8 @@ export interface OrderBook {
     nonce: Int;
     symbol: Str;
 }
+export interface OrderBooks extends Dictionary<OrderBook> {
+}
 export interface Ticker {
     symbol: string;
     info: any;

package/js/src/bigone.d.ts

@@ -160,7 +160,7 @@ export default class bigone extends Exchange {
      * @param {object} [params] extra parameters specific to the exchange API endpoint
      * @returns {object[]} a list of [order structures]{@link https://docs.ccxt.com/#/?id=order-structure}
      */
-    cancelAllOrders(symbol?: Str, params?: {}): Promise<any[]>;
+    cancelAllOrders(symbol?: Str, params?: {}): Promise<Order[]>;
     /**
      * @method
      * @name bigone#fetchOrder

package/js/src/bigone.js

@@ -330,17 +330,20 @@ export default class bigone extends Exchange {
                         'limit': 200,
                         'daysBack': undefined,
                         'untilDays': undefined,
+                        'symbolRequired': true,
                     },
                     'fetchOrder': {
                         'marginMode': false,
                         'trigger': false,
                         'trailing': false,
+                        'symbolRequired': false,
                     },
                     'fetchOpenOrders': {
                         'marginMode': false,
                         'limit': 200,
                         'trigger': false,
                         'trailing': false,
+                        'symbolRequired': true,
                     },
                     'fetchOrders': {
                         'marginMode': false,
@@ -349,6 +352,7 @@ export default class bigone extends Exchange {
                         'untilDays': undefined,
                         'trigger': false,
                         'trailing': false,
+                        'symbolRequired': true,
                     },
                     'fetchClosedOrders': {
                         'marginMode': false,
@@ -358,6 +362,7 @@ export default class bigone extends Exchange {
                         'untilDays': undefined,
                         'trigger': false,
                         'trailing': false,
+                        'symbolRequired': true,
                     },
                     'fetchOHLCV': {
                         'limit': 500,