ccxt 4.3.77 → 4.3.78

package/js/src/kraken.js

@@ -1385,7 +1385,7 @@ export default class kraken extends Exchange {
          * @method
          * @name kraken#createMarketOrderWithCost
          * @description create a market order by providing the symbol, side and cost
-         * @see https://docs.kraken.com/rest/#tag/Trading/operation/addOrder
+         * @see https://docs.kraken.com/rest/#tag/Spot-Trading/operation/addOrder
          * @param {string} symbol unified symbol of the market to create an order in (only USD markets are supported)
          * @param {string} side 'buy' or 'sell'
          * @param {float} cost how much you want to trade in units of the quote currency
@@ -1402,7 +1402,7 @@ export default class kraken extends Exchange {
          * @method
          * @name kraken#createMarketBuyOrderWithCost
          * @description create a market buy order by providing the symbol, side and cost
-         * @see https://docs.kraken.com/rest/#tag/Trading/operation/addOrder
+         * @see https://docs.kraken.com/rest/#tag/Spot-Trading/operation/addOrder
          * @param {string} symbol unified symbol of the market to create an order in
          * @param {float} cost how much you want to trade in units of the quote currency
          * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -1415,7 +1415,7 @@ export default class kraken extends Exchange {
         /**
          * @method
          * @name kraken#createOrder
-         * @see https://docs.kraken.com/rest/#tag/Trading/operation/addOrder
+         * @see https://docs.kraken.com/rest/#tag/Spot-Trading/operation/addOrder
          * @description create a trade order
          * @param {string} symbol unified symbol of the market to create an order in
          * @param {string} type 'market' or 'limit'
@@ -1554,6 +1554,8 @@ export default class kraken extends Exchange {
         //         "status": "ok",
         //         "txid": "OAW2BO-7RWEK-PZY5UO",
         //         "originaltxid": "OXL6SS-UPNMC-26WBE7",
+        //         "newuserref": 1234,
+        //         "olduserref": 123,
         //         "volume": "0.00075000",
         //         "price": "13500.0",
         //         "orders_cancelled": 1,
@@ -1697,7 +1699,7 @@ export default class kraken extends Exchange {
             const txid = this.safeList(order, 'txid');
             id = this.safeString(txid, 0);
         }
-        const clientOrderId = this.safeString(order, 'userref');
+        const clientOrderId = this.safeString2(order, 'userref', 'newuserref');
         const rawTrades = this.safeValue(order, 'trades', []);
         const trades = [];
         for (let i = 0; i < rawTrades.length; i++) {
@@ -1853,7 +1855,7 @@ export default class kraken extends Exchange {
             const extendedPostFlags = (flags !== undefined) ? flags + ',post' : 'post';
             request['oflags'] = extendedPostFlags;
         }
-        if ((flags !== undefined) && (request['oflags'] === undefined)) {
+        if ((flags !== undefined) && !('oflags' in request)) {
             request['oflags'] = flags;
         }
         params = this.omit(params, ['timeInForce', 'reduceOnly', 'stopLossPrice', 'takeProfitPrice', 'trailingAmount', 'trailingLimitAmount', 'offset']);
@@ -1864,7 +1866,7 @@ export default class kraken extends Exchange {
          * @method
          * @name kraken#editOrder
          * @description edit a trade order
-         * @see https://docs.kraken.com/rest/#tag/Trading/operation/editOrder
+         * @see https://docs.kraken.com/rest/#tag/Spot-Trading/operation/editOrder
          * @param {string} id order id
          * @param {string} symbol unified symbol of the market to create an order in
          * @param {string} type 'market' or 'limit'
@@ -1926,8 +1928,8 @@ export default class kraken extends Exchange {
         await this.loadMarkets();
         const clientOrderId = this.safeValue2(params, 'userref', 'clientOrderId');
         const request = {
-            'trades': true, // whether or not to include trades in output (optional, default false)
-            // 'txid': id, // do not comma separate a list of ids - use fetchOrdersByIds instead
+            'trades': true,
+            'txid': id, // do not comma separate a list of ids - use fetchOrdersByIds instead
             // 'userref': 'optional', // restrict results to given user reference id (optional)
         };
         let query = params;
@@ -1935,9 +1937,6 @@ export default class kraken extends Exchange {
             request['userref'] = clientOrderId;
             query = this.omit(params, ['userref', 'clientOrderId']);
         }
-        else {
-            request['txid'] = id;
-        }
         const response = await this.privatePostQueryOrders(this.extend(request, query));
         //
         //     {

package/js/src/kuna.js

@@ -888,7 +888,6 @@ export default class kuna extends Exchange {
             'fee': {
                 'cost': this.safeString(trade, 'fee'),
                 'currency': this.safeCurrencyCode(this.safeString(trade, 'feeCurrency')),
-                'rate': undefined,
             },
         }, market);
     }

package/js/src/pro/binance.js

@@ -206,7 +206,7 @@ export default class binance extends binanceRest {
          * @param {object} [params] exchange specific parameters for the bitmex api endpoint
          * @returns {object} an array of [liquidation structures]{@link https://github.com/ccxt/ccxt/wiki/Manual#liquidation-structure}
          */
-        return this.watchLiquidationsForSymbols([symbol], since, limit, params);
+        return await this.watchLiquidationsForSymbols([symbol], since, limit, params);
     }
     async watchLiquidationsForSymbols(symbols = undefined, since = undefined, limit = undefined, params = {}) {
         /**

package/js/src/pro/paradex.js

@@ -117,6 +117,7 @@ export default class paradex extends paradexRest {
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} A dictionary of [order book structures]{@link https://docs.ccxt.com/#/?id=order-book-structure} indexed by market symbols
          */
+        await this.loadMarkets();
         const market = this.market(symbol);
         const messageHash = 'order_book.' + market['id'] + '.snapshot@15@100ms';
         const url = this.urls['api']['ws'];
@@ -226,6 +227,7 @@ export default class paradex extends paradexRest {
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a [ticker structure]{@link https://docs.ccxt.com/#/?id=ticker-structure}
          */
+        await this.loadMarkets();
         symbols = this.marketSymbols(symbols);
         const channel = 'markets_summary';
         const url = this.urls['api']['ws'];

package/js/src/vertex.js

@@ -668,6 +668,13 @@ export default class vertex extends Exchange {
         let amount = undefined;
         let side = undefined;
         let fee = undefined;
+        const feeCost = this.convertFromX18(this.safeString(trade, 'fee'));
+        if (feeCost !== undefined) {
+            fee = {
+                'cost': feeCost,
+                'currency': undefined,
+            };
+        }
         const id = this.safeString2(trade, 'trade_id', 'submission_idx');
         const order = this.safeString(trade, 'digest');
         const timestamp = this.safeTimestamp(trade, 'timestamp');
@@ -685,10 +692,6 @@ export default class vertex extends Exchange {
             const subOrder = this.safeDict(trade, 'order', {});
             price = this.convertFromX18(this.safeString(subOrder, 'priceX18'));
             amount = this.convertFromX18(this.safeString(trade, 'base_filled'));
-            fee = {
-                'cost': this.convertFromX18(this.safeString(trade, 'fee')),
-                'currency': undefined,
-            };
             if (Precise.stringLt(amount, '0')) {
                 side = 'sell';
             }

package/js/src/woo.js

@@ -610,6 +610,10 @@ export default class woo extends Exchange {
         const amount = this.safeString(trade, 'executed_quantity');
         const order_id = this.safeString(trade, 'order_id');
         const fee = this.parseTokenAndFeeTemp(trade, 'fee_asset', 'fee');
+        const feeCost = this.safeString(fee, 'cost');
+        if (feeCost !== undefined) {
+            fee['cost'] = feeCost;
+        }
         const cost = Precise.stringMul(price, amount);
         const side = this.safeStringLower(trade, 'side');
         const id = this.safeString(trade, 'id');

package/js/src/woofipro.js

@@ -683,6 +683,10 @@ export default class woofipro extends Exchange {
         const amount = this.safeString(trade, 'executed_quantity');
         const order_id = this.safeString(trade, 'order_id');
         const fee = this.parseTokenAndFeeTemp(trade, 'fee_asset', 'fee');
+        const feeCost = this.safeString(fee, 'cost');
+        if (feeCost !== undefined) {
+            fee['cost'] = feeCost;
+        }
         const cost = Precise.stringMul(price, amount);
         const side = this.safeStringLower(trade, 'side');
         const id = this.safeString(trade, 'id');

package/js/src/xt.js

@@ -2109,7 +2109,6 @@ export default class xt extends Exchange {
             'fee': {
                 'currency': this.safeCurrencyCode(this.safeString2(trade, 'feeCurrency', 'feeCoin')),
                 'cost': this.safeString(trade, 'fee'),
-                'rate': undefined,
             },
         }, market);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.3.77",
+  "version": "4.3.78",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.min.js",
   "type": "module",