ccxt 4.3.6 → 4.3.7

package/js/src/pro/coinbase.js

@@ -49,7 +49,7 @@ export default class coinbase extends coinbaseRest {
             },
         });
     }
-    async subscribe(name, symbol = undefined, params = {}) {
+    async subscribe(name, isPrivate, symbol = undefined, params = {}) {
         /**
          * @ignore
          * @method
@@ -61,7 +61,6 @@ export default class coinbase extends coinbaseRest {
          * @returns {object} subscription to a websocket channel
          */
         await this.loadMarkets();
-        this.checkRequiredCredentials();
         let market = undefined;
         let messageHash = name;
         let productIds = [];
@@ -78,8 +77,6 @@ export default class coinbase extends coinbaseRest {
         }
         const url = this.urls['api']['ws'];
         const timestamp = this.numberToString(this.seconds());
-        const isCloudAPiKey = (this.apiKey.indexOf('organizations/') >= 0) || (this.secret.startsWith('-----BEGIN'));
-        const auth = timestamp + name + productIds.join(',');
         const subscribe = {
             'type': 'subscribe',
             'product_ids': productIds,
@@ -88,25 +85,30 @@ export default class coinbase extends coinbaseRest {
             // 'timestamp': timestamp,
             // 'signature': this.hmac (this.encode (auth), this.encode (this.secret), sha256),
         };
-        if (!isCloudAPiKey) {
-            subscribe['api_key'] = this.apiKey;
-            subscribe['timestamp'] = timestamp;
-            subscribe['signature'] = this.hmac(this.encode(auth), this.encode(this.secret), sha256);
-        }
-        else {
-            if (this.apiKey.startsWith('-----BEGIN')) {
-                throw new ArgumentsRequired(this.id + ' apiKey should contain the name (eg: organizations/3b910e93....) and not the public key');
+        if (isPrivate) {
+            this.checkRequiredCredentials();
+            const isCloudAPiKey = (this.apiKey.indexOf('organizations/') >= 0) || (this.secret.startsWith('-----BEGIN'));
+            const auth = timestamp + name + productIds.join(',');
+            if (!isCloudAPiKey) {
+                subscribe['api_key'] = this.apiKey;
+                subscribe['timestamp'] = timestamp;
+                subscribe['signature'] = this.hmac(this.encode(auth), this.encode(this.secret), sha256);
             }
-            const currentToken = this.safeString(this.options, 'wsToken');
-            const tokenTimestamp = this.safeInteger(this.options, 'wsTokenTimestamp', 0);
-            const seconds = this.seconds();
-            if (currentToken === undefined || tokenTimestamp + 120 < seconds) {
-                // we should generate new token
-                const token = this.createAuthToken(seconds);
-                this.options['wsToken'] = token;
-                this.options['wsTokenTimestamp'] = seconds;
+            else {
+                if (this.apiKey.startsWith('-----BEGIN')) {
+                    throw new ArgumentsRequired(this.id + ' apiKey should contain the name (eg: organizations/3b910e93....) and not the public key');
+                }
+                const currentToken = this.safeString(this.options, 'wsToken');
+                const tokenTimestamp = this.safeInteger(this.options, 'wsTokenTimestamp', 0);
+                const seconds = this.seconds();
+                if (currentToken === undefined || tokenTimestamp + 120 < seconds) {
+                    // we should generate new token
+                    const token = this.createAuthToken(seconds);
+                    this.options['wsToken'] = token;
+                    this.options['wsTokenTimestamp'] = seconds;
+                }
+                subscribe['jwt'] = this.safeString(this.options, 'wsToken');
             }
-            subscribe['jwt'] = this.safeString(this.options, 'wsToken');
         }
         return await this.watch(url, messageHash, subscribe, messageHash);
     }
@@ -121,7 +123,7 @@ export default class coinbase extends coinbaseRest {
          * @returns {object} a [ticker structure]{@link https://docs.ccxt.com/#/?id=ticker-structure}
          */
         const name = 'ticker';
-        return await this.subscribe(name, symbol, params);
+        return await this.subscribe(name, false, symbol, params);
     }
     async watchTickers(symbols = undefined, params = {}) {
         /**
@@ -137,7 +139,7 @@ export default class coinbase extends coinbaseRest {
             symbols = this.symbols;
         }
         const name = 'ticker_batch';
-        const tickers = await this.subscribe(name, symbols, params);
+        const tickers = await this.subscribe(name, false, symbols, params);
         if (this.newUpdates) {
             return tickers;
         }
@@ -301,7 +303,7 @@ export default class coinbase extends coinbaseRest {
         await this.loadMarkets();
         symbol = this.symbol(symbol);
         const name = 'market_trades';
-        const trades = await this.subscribe(name, symbol, params);
+        const trades = await this.subscribe(name, false, symbol, params);
         if (this.newUpdates) {
             limit = trades.getLimit(symbol, limit);
         }
@@ -321,7 +323,7 @@ export default class coinbase extends coinbaseRest {
          */
         await this.loadMarkets();
         const name = 'user';
-        const orders = await this.subscribe(name, symbol, params);
+        const orders = await this.subscribe(name, true, symbol, params);
         if (this.newUpdates) {
             limit = orders.getLimit(symbol, limit);
         }
@@ -342,7 +344,7 @@ export default class coinbase extends coinbaseRest {
         const name = 'level2';
         const market = this.market(symbol);
         symbol = market['symbol'];
-        const orderbook = await this.subscribe(name, symbol, params);
+        const orderbook = await this.subscribe(name, false, symbol, params);
         return orderbook.limit();
     }
     handleTrade(client, message) {
@@ -560,8 +562,8 @@ export default class coinbase extends coinbaseRest {
                 this.orderbooks[symbol] = this.orderBook({}, limit);
                 const orderbook = this.orderbooks[symbol];
                 this.handleOrderBookHelper(orderbook, updates);
-                orderbook['timestamp'] = undefined;
-                orderbook['datetime'] = undefined;
+                orderbook['timestamp'] = this.parse8601(datetime);
+                orderbook['datetime'] = datetime;
                 orderbook['symbol'] = symbol;
                 client.resolve(orderbook, messageHash);
                 if (messageHash.endsWith('USD')) {
@@ -580,7 +582,6 @@ export default class coinbase extends coinbaseRest {
                 }
             }
         }
-        return message;
     }
     handleSubscriptionStatus(client, message) {
         //

package/js/src/probit.d.ts

@@ -45,7 +45,7 @@ export default class probit extends Exchange {
         info: any;
     }>;
     fetchDepositAddresses(codes?: string[], params?: {}): Promise<{}>;
-    withdraw(code: string, amount: number, address: any, tag?: any, params?: {}): Promise<Transaction>;
+    withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     fetchDeposits(code?: Str, since?: Int, limit?: Int, params?: {}): Promise<Transaction[]>;
     fetchWithdrawals(code?: Str, since?: Int, limit?: Int, params?: {}): Promise<Transaction[]>;
     fetchDepositsWithdrawals(code?: Str, since?: Int, limit?: Int, params?: {}): Promise<Transaction[]>;

package/js/src/probit.js

@@ -70,8 +70,11 @@ export default class probit extends Exchange {
                 'fetchOrder': true,
                 'fetchOrderBook': true,
                 'fetchPosition': false,
+                'fetchPositionHistory': false,
                 'fetchPositionMode': false,
                 'fetchPositions': false,
+                'fetchPositionsForSymbol': false,
+                'fetchPositionsHistory': false,
                 'fetchPositionsRisk': false,
                 'fetchPremiumIndexOHLCV': false,
                 'fetchTicker': true,

package/js/src/timex.js

@@ -67,8 +67,11 @@ export default class timex extends Exchange {
                 'fetchOrder': true,
                 'fetchOrderBook': true,
                 'fetchPosition': false,
+                'fetchPositionHistory': false,
                 'fetchPositionMode': false,
                 'fetchPositions': false,
+                'fetchPositionsForSymbol': false,
+                'fetchPositionsHistory': false,
                 'fetchPositionsRisk': false,
                 'fetchPremiumIndexOHLCV': false,
                 'fetchTicker': true,

package/js/src/tokocrypto.d.ts

@@ -42,7 +42,7 @@ export default class tokocrypto extends Exchange {
     fetchWithdrawals(code?: Str, since?: Int, limit?: Int, params?: {}): Promise<Transaction[]>;
     parseTransactionStatusByType(status: any, type?: any): string;
     parseTransaction(transaction: any, currency?: Currency): Transaction;
-    withdraw(code: string, amount: number, address: any, tag?: any, params?: {}): Promise<Transaction>;
+    withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     sign(path: any, api?: string, method?: string, params?: {}, headers?: any, body?: any): {
         url: any;
         method: string;

package/js/src/tradeogre.js

@@ -82,8 +82,11 @@ export default class tradeogre extends Exchange {
                 'fetchOrderTrades': false,
                 'fetchPermissions': false,
                 'fetchPosition': false,
+                'fetchPositionHistory': false,
+                'fetchPositionMode': false,
                 'fetchPositions': false,
                 'fetchPositionsForSymbol': false,
+                'fetchPositionsHistory': false,
                 'fetchPositionsRisk': false,
                 'fetchPremiumIndexOHLCV': false,
                 'fetchTicker': true,

package/js/src/upbit.d.ts

@@ -89,7 +89,7 @@ export default class upbit extends Exchange {
         network: string;
         info: any;
     }>;
-    withdraw(code: string, amount: number, address: any, tag?: any, params?: {}): Promise<Transaction>;
+    withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     nonce(): number;
     sign(path: any, api?: string, method?: string, params?: {}, headers?: any, body?: any): {
         url: any;

package/js/src/wavesexchange.d.ts

@@ -88,6 +88,6 @@ export default class wavesexchange extends Exchange {
     parseDepositWithdrawFees(response: any, codes?: Strings, currencyIdKey?: any): any;
     fetchDepositWithdrawFees(codes?: Strings, params?: {}): Promise<any>;
     handleErrors(code: any, reason: any, url: any, method: any, headers: any, body: any, response: any, requestHeaders: any, requestBody: any): any;
-    withdraw(code: string, amount: number, address: any, tag?: any, params?: {}): Promise<Transaction>;
+    withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     parseTransaction(transaction: any, currency?: Currency): Transaction;
 }

package/js/src/wavesexchange.js

@@ -69,8 +69,11 @@ export default class wavesexchange extends Exchange {
                 'fetchOrderBook': true,
                 'fetchOrders': true,
                 'fetchPosition': false,
+                'fetchPositionHistory': false,
                 'fetchPositionMode': false,
                 'fetchPositions': false,
+                'fetchPositionsForSymbol': false,
+                'fetchPositionsHistory': false,
                 'fetchPositionsRisk': false,
                 'fetchPremiumIndexOHLCV': false,
                 'fetchTicker': true,

package/js/src/wazirx.js

@@ -74,8 +74,11 @@ export default class wazirx extends Exchange {
                 'fetchOrderBook': true,
                 'fetchOrders': true,
                 'fetchPosition': false,
+                'fetchPositionHistory': false,
                 'fetchPositionMode': false,
                 'fetchPositions': false,
+                'fetchPositionsForSymbol': false,
+                'fetchPositionsHistory': false,
                 'fetchPositionsRisk': false,
                 'fetchPremiumIndexOHLCV': false,
                 'fetchStatus': true,

package/js/src/whitebit.d.ts

@@ -66,7 +66,7 @@ export default class whitebit extends Exchange {
         toAccount: any;
         status: any;
     };
-    withdraw(code: string, amount: number, address: any, tag?: any, params?: {}): Promise<any>;
+    withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<any>;
     parseTransaction(transaction: any, currency?: Currency): Transaction;
     parseTransactionStatus(status: any): string;
     fetchDeposit(id: string, code?: Str, params?: {}): Promise<Transaction>;

package/js/src/woo.d.ts

@@ -98,7 +98,7 @@ export default class woo extends Exchange {
         info: any;
     };
     parseTransferStatus(status: any): string;
-    withdraw(code: string, amount: number, address: any, tag?: any, params?: {}): Promise<Transaction>;
+    withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     repayMargin(code: string, amount: any, symbol?: Str, params?: {}): Promise<any>;
     parseMarginLoan(info: any, currency?: Currency): {
         id: any;

package/js/src/woo.js

@@ -91,8 +91,10 @@ export default class woo extends Exchange {
                 'fetchOrders': true,
                 'fetchOrderTrades': true,
                 'fetchPosition': true,
+                'fetchPositionHistory': false,
                 'fetchPositionMode': false,
                 'fetchPositions': true,
+                'fetchPositionsHistory': false,
                 'fetchPremiumIndexOHLCV': false,
                 'fetchStatus': true,
                 'fetchTicker': false,

package/js/src/yobit.d.ts

@@ -55,7 +55,7 @@ export default class yobit extends Exchange {
             rate: any;
         };
     }>;
-    withdraw(code: string, amount: number, address: any, tag?: any, params?: {}): Promise<Transaction>;
+    withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     sign(path: any, api?: string, method?: string, params?: {}, headers?: any, body?: any): {
         url: any;
         method: string;

package/js/src/yobit.js

@@ -68,8 +68,11 @@ export default class yobit extends Exchange {
                 'fetchOrderBook': true,
                 'fetchOrderBooks': true,
                 'fetchPosition': false,
+                'fetchPositionHistory': false,
                 'fetchPositionMode': false,
                 'fetchPositions': false,
+                'fetchPositionsForSymbol': false,
+                'fetchPositionsHistory': false,
                 'fetchPositionsRisk': false,
                 'fetchPremiumIndexOHLCV': false,
                 'fetchTicker': true,

package/js/src/zaif.d.ts

@@ -20,7 +20,7 @@ export default class zaif extends Exchange {
     parseOrder(order: any, market?: Market): Order;
     fetchOpenOrders(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Order[]>;
     fetchClosedOrders(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Order[]>;
-    withdraw(code: string, amount: number, address: any, tag?: any, params?: {}): Promise<Transaction>;
+    withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     parseTransaction(transaction: any, currency?: Currency): Transaction;
     customNonce(): string;
     sign(path: any, api?: string, method?: string, params?: {}, headers?: any, body?: any): {

package/js/src/zonda.d.ts

@@ -71,7 +71,7 @@ export default class zonda extends Exchange {
         status: string;
     };
     parseTransferStatus(status: any): string;
-    withdraw(code: string, amount: number, address: any, tag?: any, params?: {}): Promise<Transaction>;
+    withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     parseTransaction(transaction: any, currency?: Currency): Transaction;
     sign(path: any, api?: string, method?: string, params?: {}, headers?: any, body?: any): {
         url: any;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.3.6",
+  "version": "4.3.7",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",