ccxt 4.3.13 → 4.3.15

package/js/src/cryptocom.js

@@ -499,7 +499,8 @@ export default class cryptocom extends Exchange {
             const strike = this.safeString(market, 'strike');
             const marginBuyEnabled = this.safeValue(market, 'margin_buy_enabled');
             const marginSellEnabled = this.safeValue(market, 'margin_sell_enabled');
-            const expiry = this.omitZero(this.safeInteger(market, 'expiry_timestamp_ms'));
+            const expiryString = this.omitZero(this.safeString(market, 'expiry_timestamp_ms'));
+            const expiry = (expiryString !== undefined) ? parseInt(expiryString) : undefined;
             let symbol = base + '/' + quote;
             let type = undefined;
             let contract = undefined;

package/js/src/hitbtc.js

@@ -618,6 +618,7 @@ export default class hitbtc extends Exchange {
                 'accountsByType': {
                     'spot': 'spot',
                     'funding': 'wallet',
+                    'swap': 'derivatives',
                     'future': 'derivatives',
                 },
                 'withdraw': {

package/js/src/luno.js

@@ -150,6 +150,7 @@ export default class luno extends Exchange {
                         'withdrawals': 1,
                         'send': 1,
                         'oauth2/grant': 1,
+                        'beneficiaries': 1,
                         // POST /api/exchange/1/move
                     },
                     'put': {
@@ -157,6 +158,7 @@ export default class luno extends Exchange {
                     },
                     'delete': {
                         'withdrawals/{id}': 1,
+                        'beneficiaries/{id}': 1,
                     },
                 },
             },

package/js/src/okx.js

@@ -5578,7 +5578,7 @@ export default class okx extends Exchange {
         //    }
         //
         const marketId = this.safeString(position, 'instId');
-        market = this.safeMarket(marketId, market);
+        market = this.safeMarket(marketId, market, undefined, 'contract');
         const symbol = market['symbol'];
         const pos = this.safeString(position, 'pos'); // 'pos' field: One way mode: 0 if position is not open, 1 if open | Two way (hedge) mode: -1 if short, 1 if long, 0 if position is not open
         const contractsAbs = Precise.stringAbs(pos);

package/js/src/phemex.js

@@ -2383,7 +2383,7 @@ export default class phemex extends Exchange {
             lastTradeTimestamp = undefined;
         }
         const timeInForce = this.parseTimeInForce(this.safeString(order, 'timeInForce'));
-        const stopPrice = this.omitZero(this.safeNumber2(order, 'stopPx', 'stopPxRp'));
+        const stopPrice = this.omitZero(this.safeString2(order, 'stopPx', 'stopPxRp'));
         const postOnly = (timeInForce === 'PO');
         let reduceOnly = this.safeValue(order, 'reduceOnly');
         const execInst = this.safeString(order, 'execInst');

package/js/src/pro/hitbtc.js

@@ -1198,7 +1198,7 @@ export default class hitbtc extends hitbtcRest {
         //        "id": 1700233093414
         //    }
         //
-        const messageHash = this.safeInteger(message, 'id');
+        const messageHash = this.safeString(message, 'id');
         const result = this.safeValue(message, 'result', {});
         if (Array.isArray(result)) {
             const parsedOrders = [];

package/js/src/pro/independentreserve.js

@@ -135,9 +135,9 @@ export default class independentreserve extends independentreserveRest {
         if (limit === undefined) {
             limit = 100;
         }
-        limit = this.numberToString(limit);
-        const url = this.urls['api']['ws'] + '/orderbook/' + limit + '?subscribe=' + market['base'] + '-' + market['quote'];
-        const messageHash = 'orderbook:' + symbol + ':' + limit;
+        const limitString = this.numberToString(limit);
+        const url = this.urls['api']['ws'] + '/orderbook/' + limitString + '?subscribe=' + market['base'] + '-' + market['quote'];
+        const messageHash = 'orderbook:' + symbol + ':' + limitString;
         const subscription = {
             'receivedSnapshot': false,
         };

package/js/src/pro/poloniex.js

@@ -317,7 +317,7 @@ export default class poloniex extends poloniexRest {
         //        }]
         //    }
         //
-        const messageHash = this.safeInteger(message, 'id');
+        const messageHash = this.safeString(message, 'id');
         const data = this.safeValue(message, 'data', []);
         const orders = [];
         for (let i = 0; i < data.length; i++) {
@@ -655,8 +655,8 @@ export default class poloniex extends poloniexRest {
             'type': this.safeStringLower(trade, 'type'),
             'side': this.safeStringLower2(trade, 'takerSide', 'side'),
             'takerOrMaker': takerMaker,
-            'price': this.omitZero(this.safeNumber2(trade, 'tradePrice', 'price')),
-            'amount': this.omitZero(this.safeNumber2(trade, 'filledQuantity', 'quantity')),
+            'price': this.omitZero(this.safeString2(trade, 'tradePrice', 'price')),
+            'amount': this.omitZero(this.safeString2(trade, 'filledQuantity', 'quantity')),
             'cost': this.safeString2(trade, 'amount', 'filledAmount'),
             'fee': {
                 'rate': undefined,

package/js/src/pro/woo.d.ts

@@ -21,9 +21,11 @@ export default class woo extends wooRest {
     authenticate(params?: {}): Promise<any>;
     watchPrivate(messageHash: any, message: any, params?: {}): Promise<any>;
     watchOrders(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Order[]>;
+    watchMyTrades(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Trade[]>;
     parseWsOrder(order: any, market?: any): Order;
     handleOrderUpdate(client: Client, message: any): void;
     handleOrder(client: Client, message: any): void;
+    handleMyTrade(client: Client, message: any): void;
     watchPositions(symbols?: Strings, since?: Int, limit?: Int, params?: {}): Promise<Position[]>;
     setPositionsCache(client: Client, type: any, symbols?: Strings): void;
     loadPositionsSnapshot(client: any, messageHash: any): Promise<void>;

package/js/src/pro/woo.js

@@ -17,7 +17,7 @@ export default class woo extends wooRest {
             'has': {
                 'ws': true,
                 'watchBalance': true,
-                'watchMyTrades': false,
+                'watchMyTrades': true,
                 'watchOHLCV': true,
                 'watchOrderBook': true,
                 'watchOrders': true,
@@ -87,6 +87,7 @@ export default class woo extends wooRest {
         /**
          * @method
          * @name woo#watchOrderBook
+         * @see https://docs.woo.org/#orderbook
          * @description watches information on open orders with bid (buy) and ask (sell) prices, volumes and other data
          * @param {string} symbol unified symbol of the market to fetch the order book for
          * @param {int} [limit] the maximum amount of order book entries to return.
@@ -231,6 +232,7 @@ export default class woo extends wooRest {
         /**
          * @method
          * @name woo#watchTickers
+         * @see https://docs.woo.org/#24h-tickers
          * @description watches a price ticker, a statistical calculation with the information calculated over the past 24 hours for all markets of a specific list
          * @param {string[]} symbols unified symbol of the market to fetch the ticker for
          * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -292,6 +294,18 @@ export default class woo extends wooRest {
         client.resolve(result, topic);
     }
     async watchOHLCV(symbol, timeframe = '1m', since = undefined, limit = undefined, params = {}) {
+        /**
+         * @method
+         * @name woo#watchOHLCV
+         * @description watches historical candlestick data containing the open, high, low, and close price, and the volume of a market
+         * @see https://docs.woo.org/#k-line
+         * @param {string} symbol unified symbol of the market to fetch OHLCV data for
+         * @param {string} timeframe the length of time each candle represents
+         * @param {int} [since] timestamp in ms of the earliest candle to fetch
+         * @param {int} [limit] the maximum amount of candles to fetch
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @returns {int[][]} A list of candles ordered as timestamp, open, high, low, close, volume
+         */
         await this.loadMarkets();
         if ((timeframe !== '1m') && (timeframe !== '5m') && (timeframe !== '15m') && (timeframe !== '30m') && (timeframe !== '1h') && (timeframe !== '1d') && (timeframe !== '1w') && (timeframe !== '1M')) {
             throw new ExchangeError(this.id + ' watchOHLCV timeframe argument must be 1m, 5m, 15m, 30m, 1h, 1d, 1w, 1M');
@@ -360,6 +374,7 @@ export default class woo extends wooRest {
          * @method
          * @name woo#watchTrades
          * @description watches information on multiple trades made in a market
+         * @see https://docs.woo.org/#trade
          * @param {string} symbol unified market symbol of the market trades were made in
          * @param {int} [since] the earliest time in ms to fetch trades for
          * @param {int} [limit] the maximum number of trade structures to retrieve
@@ -421,17 +436,60 @@ export default class woo extends wooRest {
         //         "side":"BUY",
         //         "source":0
         //     }
+        // private trade
+        //    {
+        //     "msgType": 0,  // execution report
+        //     "symbol": "SPOT_BTC_USDT",
+        //     "clientOrderId": 0,
+        //     "orderId": 54774393,
+        //     "type": "MARKET",
+        //     "side": "BUY",
+        //     "quantity": 0.0,
+        //     "price": 0.0,
+        //     "tradeId": 56201985,
+        //     "executedPrice": 23534.06,
+        //     "executedQuantity": 0.00040791,
+        //     "fee": 2.1E-7,
+        //     "feeAsset": "BTC",
+        //     "totalExecutedQuantity": 0.00040791,
+        //     "avgPrice": 23534.06,
+        //     "status": "FILLED",
+        //     "reason": "",
+        //     "orderTag": "default",
+        //     "totalFee": 2.1E-7,
+        //     "feeCurrency": "BTC",
+        //     "totalRebate": 0,
+        //     "rebateCurrency": "USDT",
+        //     "visible": 0.0,
+        //     "timestamp": 1675406261689,
+        //     "reduceOnly": false,
+        //     "maker": false
+        //   }
         //
         const marketId = this.safeString(trade, 'symbol');
         market = this.safeMarket(marketId, market);
         const symbol = market['symbol'];
-        const price = this.safeString(trade, 'price');
-        const amount = this.safeString(trade, 'size');
+        const price = this.safeString(trade, 'executedPrice', 'price');
+        const amount = this.safeString2(trade, 'executedQuantity', 'size');
         const cost = Precise.stringMul(price, amount);
         const side = this.safeStringLower(trade, 'side');
         const timestamp = this.safeInteger(trade, 'timestamp');
+        const maker = this.safeBool(trade, 'marker');
+        let takerOrMaker = undefined;
+        if (maker !== undefined) {
+            takerOrMaker = maker ? 'maker' : 'taker';
+        }
+        const type = this.safeStringLower(trade, 'type');
+        let fee = undefined;
+        const feeCost = this.safeNumber(trade, 'fee');
+        if (feeCost !== undefined) {
+            fee = {
+                'cost': feeCost,
+                'currency': this.safeCurrencyCode(this.safeString(trade, 'feeCurrency')),
+            };
+        }
         return this.safeTrade({
-            'id': undefined,
+            'id': this.safeString(trade, 'tradeId'),
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
             'symbol': symbol,
@@ -439,10 +497,10 @@ export default class woo extends wooRest {
             'price': price,
             'amount': amount,
             'cost': cost,
-            'order': undefined,
-            'takerOrMaker': undefined,
-            'type': undefined,
-            'fee': undefined,
+            'order': this.safeString(trade, 'orderId'),
+            'takerOrMaker': takerOrMaker,
+            'type': type,
+            'fee': fee,
             'info': trade,
         }, market);
     }
@@ -496,6 +554,8 @@ export default class woo extends wooRest {
         /**
          * @method
          * @name woo#watchOrders
+         * @see https://docs.woo.org/#executionreport
+         * @see https://docs.woo.org/#algoexecutionreportv2
          * @description watches information on multiple orders made by the user
          * @param {string} symbol unified market symbol of the market orders were made in
          * @param {int} [since] the earliest time in ms to fetch orders for
@@ -522,6 +582,37 @@ export default class woo extends wooRest {
         }
         return this.filterBySymbolSinceLimit(orders, symbol, since, limit, true);
     }
+    async watchMyTrades(symbol = undefined, since = undefined, limit = undefined, params = {}) {
+        /**
+         * @method
+         * @name woo#watchOrders
+         * @see https://docs.woo.org/#executionreport
+         * @description watches information on multiple trades made by the user
+         * @param {string} symbol unified market symbol of the market orders were made in
+         * @param {int} [since] the earliest time in ms to fetch orders for
+         * @param {int} [limit] the maximum number of order structures to retrieve
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @returns {object[]} a list of [order structures]{@link https://docs.ccxt.com/#/?id=order-structure}
+         */
+        await this.loadMarkets();
+        const topic = 'executionreport';
+        let messageHash = 'myTrades';
+        if (symbol !== undefined) {
+            const market = this.market(symbol);
+            symbol = market['symbol'];
+            messageHash += ':' + symbol;
+        }
+        const request = {
+            'event': 'subscribe',
+            'topic': topic,
+        };
+        const message = this.extend(request, params);
+        const trades = await this.watchPrivate(messageHash, message);
+        if (this.newUpdates) {
+            limit = trades.getLimit(symbol, limit);
+        }
+        return this.filterBySymbolSinceLimit(trades, symbol, since, limit, true);
+    }
     parseWsOrder(order, market = undefined) {
         //
         //     {
@@ -630,7 +721,11 @@ export default class woo extends wooRest {
         //         }
         //     }
         //
-        const order = this.safeValue(message, 'data');
+        const order = this.safeDict(message, 'data');
+        const tradeId = this.safeString(order, 'tradeId');
+        if ((tradeId !== undefined) && (tradeId !== '0')) {
+            this.handleMyTrade(client, order);
+        }
         this.handleOrder(client, order);
     }
     handleOrder(client, message) {
@@ -665,6 +760,49 @@ export default class woo extends wooRest {
             client.resolve(this.orders, messageHashSymbol);
         }
     }
+    handleMyTrade(client, message) {
+        //
+        //    {
+        //     "msgType": 0,  // execution report
+        //     "symbol": "SPOT_BTC_USDT",
+        //     "clientOrderId": 0,
+        //     "orderId": 54774393,
+        //     "type": "MARKET",
+        //     "side": "BUY",
+        //     "quantity": 0.0,
+        //     "price": 0.0,
+        //     "tradeId": 56201985,
+        //     "executedPrice": 23534.06,
+        //     "executedQuantity": 0.00040791,
+        //     "fee": 2.1E-7,
+        //     "feeAsset": "BTC",
+        //     "totalExecutedQuantity": 0.00040791,
+        //     "avgPrice": 23534.06,
+        //     "status": "FILLED",
+        //     "reason": "",
+        //     "orderTag": "default",
+        //     "totalFee": 2.1E-7,
+        //     "feeCurrency": "BTC",
+        //     "totalRebate": 0,
+        //     "rebateCurrency": "USDT",
+        //     "visible": 0.0,
+        //     "timestamp": 1675406261689,
+        //     "reduceOnly": false,
+        //     "maker": false
+        //   }
+        //
+        let myTrades = this.myTrades;
+        if (myTrades === undefined) {
+            const limit = this.safeInteger(this.options, 'tradesLimit', 1000);
+            myTrades = new ArrayCacheBySymbolById(limit);
+        }
+        const trade = this.parseWsTrade(message);
+        myTrades.append(trade);
+        let messageHash = 'myTrades:' + trade['symbol'];
+        client.resolve(myTrades, messageHash);
+        messageHash = 'myTrades';
+        client.resolve(myTrades, messageHash);
+    }
     async watchPositions(symbols = undefined, since = undefined, limit = undefined, params = {}) {
         /**
          * @method

package/js/src/upbit.d.ts

@@ -92,7 +92,7 @@ export default class upbit extends Exchange {
     withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     nonce(): number;
     sign(path: any, api?: string, method?: string, params?: {}, headers?: any, body?: any): {
-        url: any;
+        url: string;
         method: string;
         body: any;
         headers: any;

package/js/src/woo.d.ts

@@ -111,7 +111,7 @@ export default class woo extends Exchange {
     };
     nonce(): number;
     sign(path: any, section?: string, method?: string, params?: {}, headers?: any, body?: any): {
-        url: any;
+        url: string;
         method: string;
         body: any;
         headers: any;

package/js/src/zonda.d.ts

@@ -74,7 +74,7 @@ export default class zonda extends Exchange {
     withdraw(code: string, amount: number, address: string, tag?: any, params?: {}): Promise<Transaction>;
     parseTransaction(transaction: any, currency?: Currency): Transaction;
     sign(path: any, api?: string, method?: string, params?: {}, headers?: any, body?: any): {
-        url: any;
+        url: string;
         method: string;
         body: any;
         headers: any;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.3.13",
+  "version": "4.3.15",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",