ccxt 4.2.94 → 4.2.96

package/js/src/okx.js

@@ -1120,7 +1120,7 @@ export default class okx extends Exchange {
         return super.handleMarketTypeAndParams(methodName, market, params);
     }
     convertToInstrumentType(type) {
-        const exchangeTypes = this.safeValue(this.options, 'exchangeType', {});
+        const exchangeTypes = this.safeDict(this.options, 'exchangeType', {});
         return this.safeString(exchangeTypes, type, type);
     }
     createExpiredOptionMarket(symbol) {
@@ -2924,7 +2924,7 @@ export default class okx extends Exchange {
             const side = this.safeString(rawOrder, 'side');
             const amount = this.safeValue(rawOrder, 'amount');
             const price = this.safeValue(rawOrder, 'price');
-            const orderParams = this.safeValue(rawOrder, 'params', {});
+            const orderParams = this.safeDict(rawOrder, 'params', {});
             const extendedParams = this.extend(orderParams, params); // the request does not accept extra params since it's a list, so we're extending each order with the common params
             const orderRequest = this.createOrderRequest(marketId, type, side, amount, price, extendedParams);
             ordersRequests.push(orderRequest);
@@ -3113,8 +3113,8 @@ export default class okx extends Exchange {
         //        "msg": ""
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
-        const first = this.safeValue(data, 0);
+        const data = this.safeList(response, 'data', []);
+        const first = this.safeDict(data, 0, {});
         const order = this.parseOrder(first, market);
         order['type'] = type;
         order['side'] = side;
@@ -4313,7 +4313,7 @@ export default class okx extends Exchange {
         if (paginate) {
             return await this.fetchPaginatedCallDynamic('fetchLedger', code, since, limit, params);
         }
-        const options = this.safeValue(this.options, 'fetchLedger', {});
+        const options = this.safeDict(this.options, 'fetchLedger', {});
         let method = this.safeString(options, 'method');
         method = this.safeString(params, 'method', method);
         params = this.omit(params, 'method');
@@ -4642,7 +4642,7 @@ export default class okx extends Exchange {
         //         ]
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
+        const data = this.safeList(response, 'data', []);
         const filtered = this.filterBy(data, 'selected', true);
         const parsed = this.parseDepositAddresses(filtered, [currency['code']], false);
         return this.indexBy(parsed, 'network');
@@ -4716,7 +4716,7 @@ export default class okx extends Exchange {
         };
         let network = this.safeString(params, 'network'); // this line allows the user to specify either ERC20 or ETH
         if (network !== undefined) {
-            const networks = this.safeValue(this.options, 'networks', {});
+            const networks = this.safeDict(this.options, 'networks', {});
             network = this.safeString(networks, network.toUpperCase(), network); // handle ETH>ERC20 alias
             request['chain'] = currency['id'] + '-' + network;
             params = this.omit(params, 'network');
@@ -4725,7 +4725,7 @@ export default class okx extends Exchange {
         if (fee === undefined) {
             const currencies = await this.fetchCurrencies();
             this.currencies = this.deepExtend(this.currencies, currencies);
-            const targetNetwork = this.safeValue(currency['networks'], this.networkIdToCode(network), {});
+            const targetNetwork = this.safeDict(currency['networks'], this.networkIdToCode(network), {});
             fee = this.safeString(targetNetwork, 'fee');
             if (fee === undefined) {
                 throw new ArgumentsRequired(this.id + ' withdraw() requires a "fee" string parameter, network transaction fee must be ≥ 0. Withdrawals to OKCoin or OKX are fee-free, please set "0". Withdrawing to external digital asset address requires network transaction fee.');
@@ -4747,7 +4747,7 @@ export default class okx extends Exchange {
         //         ]
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
+        const data = this.safeList(response, 'data', []);
         const transaction = this.safeDict(data, 0);
         return this.parseTransaction(transaction, currency);
     }
@@ -4972,7 +4972,7 @@ export default class okx extends Exchange {
         //        "msg": ''
         //    }
         //
-        const data = this.safeValue(response, 'data');
+        const data = this.safeList(response, 'data', []);
         const withdrawal = this.safeDict(data, 0, {});
         return this.parseTransaction(withdrawal);
     }
@@ -5259,8 +5259,8 @@ export default class okx extends Exchange {
         //         ]
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
-        const position = this.safeValue(data, 0);
+        const data = this.safeList(response, 'data', []);
+        const position = this.safeDict(data, 0);
         if (position === undefined) {
             return undefined;
         }
@@ -5296,7 +5296,7 @@ export default class okx extends Exchange {
                 request['instId'] = marketIds.join(',');
             }
         }
-        const fetchPositionsOptions = this.safeValue(this.options, 'fetchPositions', {});
+        const fetchPositionsOptions = this.safeDict(this.options, 'fetchPositions', {});
         const method = this.safeString(fetchPositionsOptions, 'method', 'privateGetAccountPositions');
         let response = undefined;
         if (method === 'privateGetAccountPositionsHistory') {
@@ -5351,7 +5351,7 @@ export default class okx extends Exchange {
         //         ]
         //     }
         //
-        const positions = this.safeValue(response, 'data', []);
+        const positions = this.safeList(response, 'data', []);
         const result = [];
         for (let i = 0; i < positions.length; i++) {
             result.push(this.parsePosition(positions[i]));
@@ -5559,7 +5559,7 @@ export default class okx extends Exchange {
          */
         await this.loadMarkets();
         const currency = this.currency(code);
-        const accountsByType = this.safeValue(this.options, 'accountsByType', {});
+        const accountsByType = this.safeDict(this.options, 'accountsByType', {});
         const fromId = this.safeString(accountsByType, fromAccount, fromAccount);
         const toId = this.safeString(accountsByType, toAccount, toAccount);
         const request = {
@@ -5601,7 +5601,7 @@ export default class okx extends Exchange {
         //         ]
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
+        const data = this.safeList(response, 'data', []);
         const rawTransfer = this.safeDict(data, 0, {});
         return this.parseTransfer(rawTransfer, currency);
     }
@@ -5664,7 +5664,7 @@ export default class okx extends Exchange {
         let amount = this.safeNumber(transfer, 'amt');
         const fromAccountId = this.safeString(transfer, 'from');
         const toAccountId = this.safeString(transfer, 'to');
-        const accountsById = this.safeValue(this.options, 'accountsById', {});
+        const accountsById = this.safeDict(this.options, 'accountsById', {});
         const timestamp = this.safeInteger(transfer, 'ts');
         const balanceChange = this.safeString(transfer, 'sz');
         if (balanceChange !== undefined) {
@@ -5715,7 +5715,7 @@ export default class okx extends Exchange {
         //         "msg": ""
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
+        const data = this.safeList(response, 'data', []);
         const transfer = this.safeDict(data, 0);
         return this.parseTransfer(transfer);
     }
@@ -5921,8 +5921,8 @@ export default class okx extends Exchange {
         //        "msg": ""
         //    }
         //
-        const data = this.safeValue(response, 'data', []);
-        const entry = this.safeValue(data, 0, {});
+        const data = this.safeList(response, 'data', []);
+        const entry = this.safeDict(data, 0, {});
         return this.parseFundingRate(entry, market);
     }
     async fetchFundingHistory(symbol = undefined, since = undefined, limit = undefined, params = {}) {
@@ -6062,7 +6062,7 @@ export default class okx extends Exchange {
         //        "type": "8"
         //    }
         //
-        const data = this.safeValue(response, 'data', []);
+        const data = this.safeList(response, 'data', []);
         const result = [];
         for (let i = 0; i < data.length; i++) {
             const entry = data[i];
@@ -6254,7 +6254,7 @@ export default class okx extends Exchange {
         //        ],
         //    }
         //
-        const data = this.safeValue(response, 'data', []);
+        const data = this.safeList(response, 'data', []);
         const rates = [];
         for (let i = 0; i < data.length; i++) {
             rates.push(this.parseBorrowRate(data[i]));
@@ -6290,8 +6290,8 @@ export default class okx extends Exchange {
         //        "msg": ""
         //    }
         //
-        const data = this.safeValue(response, 'data');
-        const rate = this.safeValue(data, 0);
+        const data = this.safeList(response, 'data', []);
+        const rate = this.safeDict(data, 0, {});
         return this.parseBorrowRate(rate);
     }
     parseBorrowRate(info, currency = undefined) {
@@ -6395,7 +6395,7 @@ export default class okx extends Exchange {
         //         "msg": ""
         //     }
         //
-        const data = this.safeValue(response, 'data');
+        const data = this.safeList(response, 'data', []);
         return this.parseBorrowRateHistories(data, codes, since, limit);
     }
     async fetchBorrowRateHistory(code, since = undefined, limit = undefined, params = {}) {
@@ -6439,7 +6439,7 @@ export default class okx extends Exchange {
         //         "msg": ""
         //     }
         //
-        const data = this.safeValue(response, 'data');
+        const data = this.safeList(response, 'data', []);
         return this.parseBorrowRateHistory(data, code, since, limit);
     }
     async modifyMarginHelper(symbol, amount, type, params = {}) {
@@ -6631,7 +6631,7 @@ export default class okx extends Exchange {
         //        ]
         //    }
         //
-        const data = this.safeValue(response, 'data');
+        const data = this.safeList(response, 'data', []);
         return this.parseMarketLeverageTiers(data, market);
     }
     parseMarketLeverageTiers(info, market = undefined) {
@@ -6733,7 +6733,7 @@ export default class okx extends Exchange {
         //        "msg": ""
         //    }
         //
-        const data = this.safeValue(response, 'data');
+        const data = this.safeList(response, 'data', []);
         const interest = this.parseBorrowInterests(data);
         return this.filterByCurrencySinceLimit(interest, code, since, limit);
     }
@@ -6789,8 +6789,8 @@ export default class okx extends Exchange {
         //         "msg": ""
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
-        const loan = this.safeValue(data, 0);
+        const data = this.safeList(response, 'data', []);
+        const loan = this.safeDict(data, 0, {});
         return this.parseMarginLoan(loan, currency);
     }
     async repayCrossMargin(code, amount, params = {}) {
@@ -6834,8 +6834,8 @@ export default class okx extends Exchange {
         //         "msg": ""
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
-        const loan = this.safeValue(data, 0);
+        const data = this.safeList(response, 'data', []);
+        const loan = this.safeDict(data, 0, {});
         return this.parseMarginLoan(loan, currency);
     }
     parseMarginLoan(info, currency = undefined) {
@@ -6917,8 +6917,8 @@ export default class okx extends Exchange {
          * @param {int} [params.until] The time in ms of the latest record to retrieve as a unix timestamp
          * @returns An array of [open interest structures]{@link https://docs.ccxt.com/#/?id=open-interest-structure}
          */
-        const options = this.safeValue(this.options, 'fetchOpenInterestHistory', {});
-        const timeframes = this.safeValue(options, 'timeframes', {});
+        const options = this.safeDict(this.options, 'fetchOpenInterestHistory', {});
+        const timeframes = this.safeDict(options, 'timeframes', {});
         timeframe = this.safeString(timeframes, timeframe, timeframe);
         if (timeframe !== '5m' && timeframe !== '1H' && timeframe !== '1D') {
             throw new BadRequest(this.id + ' fetchOpenInterestHistory cannot only use the 5m, 1h, and 1d timeframe');
@@ -7208,7 +7208,7 @@ export default class okx extends Exchange {
         //         "msg": ""
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
+        const data = this.safeList(response, 'data', []);
         const settlements = this.parseSettlements(data, market);
         const sorted = this.sortBy(settlements, 'timestamp');
         return this.filterBySymbolSinceLimit(sorted, market['symbol'], since, limit);
@@ -7247,7 +7247,7 @@ export default class okx extends Exchange {
         for (let i = 0; i < settlements.length; i++) {
             const entry = settlements[i];
             const timestamp = this.safeInteger(entry, 'ts');
-            const details = this.safeValue(entry, 'details', []);
+            const details = this.safeList(entry, 'details', []);
             for (let j = 0; j < details.length; j++) {
                 const settlement = this.parseSettlement(details[j], market);
                 result.push(this.extend(settlement, {
@@ -7293,7 +7293,7 @@ export default class okx extends Exchange {
         //         "msg": ""
         //     }
         //
-        const underlyings = this.safeValue(response, 'data', []);
+        const underlyings = this.safeList(response, 'data', []);
         return underlyings[0];
     }
     async fetchGreeks(symbol, params = {}) {
@@ -7345,7 +7345,7 @@ export default class okx extends Exchange {
         //         "msg": ""
         //     }
         //
-        const data = this.safeValue(response, 'data', []);
+        const data = this.safeList(response, 'data', []);
         for (let i = 0; i < data.length; i++) {
             const entry = data[i];
             const entryMarketId = this.safeString(entry, 'instId');
@@ -7468,7 +7468,7 @@ export default class okx extends Exchange {
         //        "outTime": "1701877077102579"
         //    }
         //
-        const data = this.safeValue(response, 'data');
+        const data = this.safeList(response, 'data', []);
         const order = this.safeDict(data, 0);
         return this.parseOrder(order, market);
     }
@@ -7787,7 +7787,7 @@ export default class okx extends Exchange {
         const code = this.safeString(response, 'code');
         if ((code !== '0') && (code !== '2')) { // 2 means that bulk operation partially succeeded
             const feedback = this.id + ' ' + body;
-            const data = this.safeValue(response, 'data', []);
+            const data = this.safeList(response, 'data', []);
             for (let i = 0; i < data.length; i++) {
                 const error = data[i];
                 const errorCode = this.safeString(error, 'sCode');

package/js/src/pro/coinbase.js

@@ -143,6 +143,11 @@ export default class coinbase extends coinbaseRest {
         //                        "low_52_w": "15460",
         //                        "high_52_w": "48240",
         //                        "price_percent_chg_24_h": "-4.15775596190603"
+        // new as of 2024-04-12
+        //                        "best_bid":"21835.29",
+        //                        "best_bid_quantity": "0.02000000",
+        //                        "best_ask":"23011.18",
+        //                        "best_ask_quantity": "0.01500000"
         //                    }
         //                ]
         //            }
@@ -168,6 +173,11 @@ export default class coinbase extends coinbaseRest {
         //                        "low_52_w": "0.04908",
         //                        "high_52_w": "0.1801",
         //                        "price_percent_chg_24_h": "0.50177456859626"
+        // new as of 2024-04-12
+        //                        "best_bid":"0.07989",
+        //                        "best_bid_quantity": "500.0",
+        //                        "best_ask":"0.08308",
+        //                        "best_ask_quantity": "300.0"
         //                    }
         //                ]
         //            }
@@ -189,6 +199,9 @@ export default class coinbase extends coinbaseRest {
                 const messageHash = channel + '::' + wsMarketId;
                 newTickers.push(result);
                 client.resolve(result, messageHash);
+                if (messageHash.endsWith('USD')) {
+                    client.resolve(result, messageHash + 'C'); // sometimes we subscribe to BTC/USDC and coinbase returns BTC/USD
+                }
             }
         }
         const messageHashes = this.findMessageHashes(client, 'ticker_batch::');
@@ -200,6 +213,9 @@ export default class coinbase extends coinbaseRest {
             const tickers = this.filterByArray(newTickers, 'symbol', symbols);
             if (!this.isEmpty(tickers)) {
                 client.resolve(tickers, messageHash);
+                if (messageHash.endsWith('USD')) {
+                    client.resolve(tickers, messageHash + 'C'); // sometimes we subscribe to BTC/USDC and coinbase returns BTC/USD
+                }
             }
         }
         return message;
@@ -216,6 +232,11 @@ export default class coinbase extends coinbaseRest {
         //         "low_52_w": "0.04908",
         //         "high_52_w": "0.1801",
         //         "price_percent_chg_24_h": "0.50177456859626"
+        // new as of 2024-04-12
+        //         "best_bid":"0.07989",
+        //         "best_bid_quantity": "500.0",
+        //         "best_ask":"0.08308",
+        //         "best_ask_quantity": "300.0"
         //     }
         //
         const marketId = this.safeString(ticker, 'product_id');
@@ -228,10 +249,10 @@ export default class coinbase extends coinbaseRest {
             'datetime': this.iso8601(timestamp),
             'high': this.safeString(ticker, 'high_24_h'),
             'low': this.safeString(ticker, 'low_24_h'),
-            'bid': undefined,
-            'bidVolume': undefined,
-            'ask': undefined,
-            'askVolume': undefined,
+            'bid': this.safeString(ticker, 'best_bid'),
+            'bidVolume': this.safeString(ticker, 'best_bid_quantity'),
+            'ask': this.safeString(ticker, 'best_ask'),
+            'askVolume': this.safeString(ticker, 'best_ask_quantity'),
             'vwap': undefined,
             'open': undefined,
             'close': last,
@@ -349,6 +370,9 @@ export default class coinbase extends coinbaseRest {
             }
         }
         client.resolve(tradesArray, messageHash);
+        if (marketId.endsWith('USD')) {
+            client.resolve(tradesArray, messageHash + 'C'); // sometimes we subscribe to BTC/USDC and coinbase returns BTC/USD
+        }
         return message;
     }
     handleOrder(client, message) {
@@ -404,6 +428,9 @@ export default class coinbase extends coinbaseRest {
             const marketId = marketIds[i];
             const messageHash = 'user::' + marketId;
             client.resolve(this.orders, messageHash);
+            if (messageHash.endsWith('USD')) {
+                client.resolve(this.orders, messageHash + 'C'); // sometimes we subscribe to BTC/USDC and coinbase returns BTC/USD
+            }
         }
         client.resolve(this.orders, 'user');
         return message;
@@ -516,6 +543,9 @@ export default class coinbase extends coinbaseRest {
                 orderbook['datetime'] = undefined;
                 orderbook['symbol'] = symbol;
                 client.resolve(orderbook, messageHash);
+                if (messageHash.endsWith('USD')) {
+                    client.resolve(orderbook, messageHash + 'C'); // sometimes we subscribe to BTC/USDC and coinbase returns BTC/USD
+                }
             }
             else if (type === 'update') {
                 const orderbook = this.orderbooks[symbol];
@@ -524,6 +554,9 @@ export default class coinbase extends coinbaseRest {
                 orderbook['timestamp'] = this.parse8601(datetime);
                 orderbook['symbol'] = symbol;
                 client.resolve(orderbook, messageHash);
+                if (messageHash.endsWith('USD')) {
+                    client.resolve(orderbook, messageHash + 'C'); // sometimes we subscribe to BTC/USDC and coinbase returns BTC/USD
+                }
             }
         }
         return message;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.2.94",
+  "version": "4.2.96",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",

package/skip-tests.json

@@ -1041,6 +1041,7 @@
     "latoken": {
         "skipMethods":{
             "loadMarkets": {
+                "precision": "messed just for one pair https://app.travis-ci.com/github/ccxt/ccxt/builds/269924468#L4006",
                 "currency": "messed",
                 "currencyIdAndCode": "messed"
             },
@@ -1247,6 +1248,7 @@
                 "currencyIdAndCode": "some currencies does not exist in currencies"
             },
             "fetchCurrencies": {
+                "currencyIdAndCode": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269956260#L4357",
                 "withdraw": "undefined",
                 "deposit": "undefined",
                 "networks": "networks key is missing",