ccxt 4.2.90 → 4.2.91

package/dist/cjs/src/pro/kucoinfutures.js

@@ -12,6 +12,8 @@ class kucoinfutures extends kucoinfutures$1 {
             'has': {
                 'ws': true,
                 'watchTicker': true,
+                'watchTickers': true,
+                'watchBidsAsks': true,
                 'watchTrades': true,
                 'watchOrderBook': true,
                 'watchOrders': true,
@@ -41,9 +43,6 @@ class kucoinfutures extends kucoinfutures$1 {
                     'snapshotDelay': 20,
                     'snapshotMaxRetries': 3,
                 },
-                'watchTicker': {
-                    'name': 'contractMarket/tickerV2', // market/ticker
-                },
                 'watchPosition': {
                     'fetchPositionSnapshot': true,
                     'awaitPositionSnapshot': true, // whether to wait for the position snapshot before providing updates
@@ -146,7 +145,7 @@ class kucoinfutures extends kucoinfutures$1 {
         }
         return await this.watch(url, messageHash, message, subscriptionHash, subscription);
     }
-    async subscribeMultiple(url, messageHashes, topic, subscriptionHashes, subscription, params = {}) {
+    async subscribeMultiple(url, messageHashes, topic, subscriptionHashes, subscriptionArgs, params = {}) {
         const requestId = this.requestId().toString();
         const request = {
             'id': requestId,
@@ -154,24 +153,14 @@ class kucoinfutures extends kucoinfutures$1 {
             'topic': topic,
             'response': true,
         };
-        const message = this.extend(request, params);
-        const subscriptionRequest = {
-            'id': requestId,
-        };
-        if (subscription === undefined) {
-            subscription = subscriptionRequest;
-        }
-        else {
-            subscription = this.extend(subscriptionRequest, subscription);
-        }
-        return await this.watchMultiple(url, messageHashes, message, subscriptionHashes, subscription);
+        return await this.watchMultiple(url, messageHashes, this.extend(request, params), subscriptionHashes, subscriptionArgs);
     }
     async watchTicker(symbol, params = {}) {
         /**
          * @method
          * @name kucoinfutures#watchTicker
          * @description watches a price ticker, a statistical calculation with the information calculated over the past 24 hours for a specific market
-         * @see https://docs.kucoin.com/futures/#get-real-time-symbol-ticker-v2
+         * @see https://www.kucoin.com/docs/websocket/futures-trading/public-channels/get-ticker
          * @param {string} symbol unified symbol of the market to fetch the ticker for
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a [ticker structure]{@link https://docs.ccxt.com/#/?id=ticker-structure}
@@ -179,30 +168,48 @@ class kucoinfutures extends kucoinfutures$1 {
         await this.loadMarkets();
         const market = this.market(symbol);
         symbol = market['symbol'];
-        const url = await this.negotiate(false);
-        const options = this.safeValue(this.options, 'watchTicker', {});
-        const channel = this.safeString(options, 'name', 'contractMarket/tickerV2');
-        const topic = '/' + channel + ':' + market['id'];
-        const messageHash = 'ticker:' + symbol;
-        return await this.subscribe(url, messageHash, topic, undefined, params);
+        params['callerMethodName'] = 'watchTicker';
+        const tickers = await this.watchTickers([symbol], params);
+        return tickers[symbol];
+    }
+    async watchTickers(symbols = undefined, params = {}) {
+        /**
+         * @method
+         * @name kucoinfutures#watchTickers
+         * @description watches a price ticker, a statistical calculation with the information calculated over the past 24 hours for all markets of a specific list
+         * @param {string[]} symbols unified symbol of the market to fetch the ticker for
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @returns {object} a [ticker structure]{@link https://docs.ccxt.com/#/?id=ticker-structure}
+         */
+        await this.loadMarkets();
+        const ticker = await this.watchMultiRequest('watchTickers', '/contractMarket/ticker:', symbols, params);
+        if (this.newUpdates) {
+            const tickers = {};
+            tickers[ticker['symbol']] = ticker;
+            return tickers;
+        }
+        return this.filterByArray(this.tickers, 'symbol', symbols);
     }
     handleTicker(client, message) {
         //
-        // market/tickerV2
+        // ticker (v1)
         //
         //    {
-        //        "type": "message",
-        //        "topic": "/contractMarket/tickerV2:ADAUSDTM",
-        //        "subject": "tickerV2",
-        //        "data": {
-        //            "symbol": "ADAUSDTM",
-        //            "sequence": 1668007800439,
-        //            "bestBidSize": 178,
-        //            "bestBidPrice": "0.35959",
-        //            "bestAskPrice": "0.35981",
-        //            "ts": "1668141430037124460",
-        //            "bestAskSize": 134
-        //        }
+        //     "subject": "ticker",
+        //     "topic": "/contractMarket/ticker:XBTUSDM",
+        //     "data": {
+        //         "symbol": "XBTUSDM", //Market of the symbol
+        //         "sequence": 45, //Sequence number which is used to judge the continuity of the pushed messages
+        //         "side": "sell", //Transaction side of the last traded taker order
+        //         "price": "3600.0", //Filled price
+        //         "size": 16, //Filled quantity
+        //         "tradeId": "5c9dcf4170744d6f5a3d32fb", //Order ID
+        //         "bestBidSize": 795, //Best bid size
+        //         "bestBidPrice": "3200.0", //Best bid
+        //         "bestAskPrice": "3600.0", //Best ask size
+        //         "bestAskSize": 284, //Best ask
+        //         "ts": 1553846081210004941 //Filled time - nanosecond
+        //     }
         //    }
         //
         const data = this.safeValue(message, 'data', {});
@@ -210,9 +217,95 @@ class kucoinfutures extends kucoinfutures$1 {
         const market = this.safeMarket(marketId, undefined, '-');
         const ticker = this.parseTicker(data, market);
         this.tickers[market['symbol']] = ticker;
-        const messageHash = 'ticker:' + market['symbol'];
-        client.resolve(ticker, messageHash);
-        return message;
+        client.resolve(ticker, this.getMessageHash('ticker', market['symbol']));
+    }
+    async watchBidsAsks(symbols = undefined, params = {}) {
+        /**
+         * @method
+         * @name kucoinfutures#watchBidsAsks
+         * @see https://www.kucoin.com/docs/websocket/futures-trading/public-channels/get-ticker-v2
+         * @description watches best bid & ask for symbols
+         * @param {string[]} symbols unified symbol of the market to fetch the ticker for
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @returns {object} a [ticker structure]{@link https://docs.ccxt.com/#/?id=ticker-structure}
+         */
+        const ticker = await this.watchMultiRequest('watchBidsAsks', '/contractMarket/tickerV2:', symbols, params);
+        if (this.newUpdates) {
+            const tickers = {};
+            tickers[ticker['symbol']] = ticker;
+            return tickers;
+        }
+        return this.filterByArray(this.bidsasks, 'symbol', symbols);
+    }
+    async watchMultiRequest(methodName, channelName, symbols = undefined, params = {}) {
+        await this.loadMarkets();
+        [methodName, params] = this.handleParamString(params, 'callerMethodName', methodName);
+        const isBidsAsks = (methodName === 'watchBidsAsks');
+        symbols = this.marketSymbols(symbols, undefined, false, true, false);
+        const length = symbols.length;
+        if (length > 100) {
+            throw new errors.ArgumentsRequired(this.id + ' ' + methodName + '() accepts a maximum of 100 symbols');
+        }
+        const messageHashes = [];
+        for (let i = 0; i < symbols.length; i++) {
+            const symbol = symbols[i];
+            const market = this.market(symbol);
+            const prefix = isBidsAsks ? 'bidask' : 'ticker';
+            messageHashes.push(this.getMessageHash(prefix, market['symbol']));
+        }
+        const url = await this.negotiate(false);
+        const marketIds = this.marketIds(symbols);
+        const joined = marketIds.join(',');
+        const requestId = this.requestId().toString();
+        const request = {
+            'id': requestId,
+            'type': 'subscribe',
+            'topic': channelName + joined,
+            'response': true,
+        };
+        const subscription = {
+            'id': requestId,
+        };
+        return await this.watchMultiple(url, messageHashes, this.extend(request, params), messageHashes, subscription);
+    }
+    handleBidAsk(client, message) {
+        //
+        // arrives one symbol dict
+        //
+        // {
+        //   "subject": "tickerV2",
+        //   "topic": "/contractMarket/tickerV2:XBTUSDM",
+        //   "data": {
+        //     "symbol": "XBTUSDM", //Market of the symbol
+        //     "bestBidSize": 795, // Best bid size
+        //     "bestBidPrice": 3200.0, // Best bid
+        //     "bestAskPrice": 3600.0, // Best ask
+        //     "bestAskSize": 284, // Best ask size
+        //     "ts": 1553846081210004941 // Filled time - nanosecond
+        //   }
+        // }
+        //
+        const parsedTicker = this.parseWsBidAsk(message);
+        const symbol = parsedTicker['symbol'];
+        this.bidsasks[symbol] = parsedTicker;
+        client.resolve(parsedTicker, this.getMessageHash('bidask', symbol));
+    }
+    parseWsBidAsk(ticker, market = undefined) {
+        const data = this.safeDict(ticker, 'data', {});
+        const marketId = this.safeString(data, 'symbol');
+        market = this.safeMarket(marketId, market);
+        const symbol = this.safeString(market, 'symbol');
+        const timestamp = this.safeIntegerProduct(data, 'ts', 0.000001);
+        return this.safeTicker({
+            'symbol': symbol,
+            'timestamp': timestamp,
+            'datetime': this.iso8601(timestamp),
+            'ask': this.safeNumber(data, 'bestAskPrice'),
+            'askVolume': this.safeNumber(data, 'bestAskSize'),
+            'bid': this.safeNumber(data, 'bestBidPrice'),
+            'bidVolume': this.safeNumber(data, 'bestBidSize'),
+            'info': ticker,
+        }, market);
     }
     async watchPosition(symbol = undefined, params = {}) {
         /**
@@ -431,7 +524,7 @@ class kucoinfutures extends kucoinfutures$1 {
             messageHashes.push('trades:' + symbol);
             subscriptionHashes.push('/contractMarket/execution:' + marketId);
         }
-        const trades = await this.subscribeMultiple(url, messageHashes, topic, subscriptionHashes, params);
+        const trades = await this.subscribeMultiple(url, messageHashes, topic, subscriptionHashes, undefined, params);
         if (this.newUpdates) {
             const first = this.safeValue(trades, 0);
             const tradeSymbol = this.safeString(first, 'symbol');
@@ -517,9 +610,7 @@ class kucoinfutures extends kucoinfutures$1 {
         const marketIds = this.marketIds(symbols);
         const url = await this.negotiate(false);
         const topic = '/contractMarket/level2:' + marketIds.join(',');
-        const subscription = {
-            'method': this.handleOrderBookSubscription,
-            'symbols': symbols,
+        const subscriptionArgs = {
             'limit': limit,
         };
         const subscriptionHashes = [];
@@ -530,7 +621,7 @@ class kucoinfutures extends kucoinfutures$1 {
             messageHashes.push('orderbook:' + symbol);
             subscriptionHashes.push('/contractMarket/level2:' + marketId);
         }
-        const orderbook = await this.subscribeMultiple(url, messageHashes, topic, subscriptionHashes, subscription, params);
+        const orderbook = await this.subscribeMultiple(url, messageHashes, topic, subscriptionHashes, subscriptionArgs, params);
         return orderbook.limit();
     }
     handleDelta(orderbook, delta) {
@@ -581,11 +672,13 @@ class kucoinfutures extends kucoinfutures$1 {
         const marketId = this.safeString(topicParts, 1);
         const symbol = this.safeSymbol(marketId, undefined, '-');
         const messageHash = 'orderbook:' + symbol;
-        const storedOrderBook = this.safeValue(this.orderbooks, symbol);
-        const nonce = this.safeInteger(storedOrderBook, 'nonce');
-        if (storedOrderBook === undefined) {
-            return; // this shouldn't be needed, but for some reason sometimes this runs before handleOrderBookSubscription in c#
+        if (!(symbol in this.orderbooks)) {
+            const subscriptionArgs = this.safeDict(client.subscriptions, topic, {});
+            const limit = this.safeInteger(subscriptionArgs, 'limit');
+            this.orderbooks[symbol] = this.orderBook({}, limit);
         }
+        const storedOrderBook = this.orderbooks[symbol];
+        const nonce = this.safeInteger(storedOrderBook, 'nonce');
         const deltaEnd = this.safeInteger(data, 'sequence');
         if (nonce === undefined) {
             const cacheLength = storedOrderBook.cache.length;
@@ -631,39 +724,6 @@ class kucoinfutures extends kucoinfutures$1 {
         }
         return cache.length;
     }
-    handleOrderBookSubscription(client, message, subscription) {
-        const limit = this.safeInteger(subscription, 'limit');
-        const symbols = this.safeValue(subscription, 'symbols');
-        if (symbols === undefined) {
-            const symbol = this.safeString(subscription, 'symbol');
-            this.orderbooks[symbol] = this.orderBook({}, limit);
-        }
-        else {
-            for (let i = 0; i < symbols.length; i++) {
-                const symbol = symbols[i];
-                this.orderbooks[symbol] = this.orderBook({}, limit);
-            }
-        }
-        // moved snapshot initialization to handleOrderBook to fix
-        // https://github.com/ccxt/ccxt/issues/6820
-        // the general idea is to fetch the snapshot after the first delta
-        // but not before, because otherwise we cannot synchronize the feed
-    }
-    handleSubscriptionStatus(client, message) {
-        //
-        //     {
-        //         "id": "1578090438322",
-        //         "type": "ack"
-        //     }
-        //
-        const id = this.safeString(message, 'id');
-        const subscriptionsById = this.indexBy(client.subscriptions, 'id');
-        const subscription = this.safeValue(subscriptionsById, id, {});
-        const method = this.safeValue(subscription, 'method');
-        if (method !== undefined) {
-            method.call(this, client, message, subscription);
-        }
-    }
     handleSystemStatus(client, message) {
         //
         // todo: answer the question whether handleSystemStatus should be renamed
@@ -922,7 +982,8 @@ class kucoinfutures extends kucoinfutures$1 {
         const subject = this.safeString(message, 'subject');
         const methods = {
             'level2': this.handleOrderBook,
-            'tickerV2': this.handleTicker,
+            'ticker': this.handleTicker,
+            'tickerV2': this.handleBidAsk,
             'availableBalance.change': this.handleBalance,
             'match': this.handleTrade,
             'orderChange': this.handleOrder,
@@ -936,6 +997,15 @@ class kucoinfutures extends kucoinfutures$1 {
             method.call(this, client, message);
         }
     }
+    getMessageHash(elementName, symbol = undefined) {
+        // elementName can be 'ticker', 'bidask', ...
+        if (symbol !== undefined) {
+            return elementName + '@' + symbol;
+        }
+        else {
+            return elementName + 's@all';
+        }
+    }
     ping(client) {
         // kucoin does not support built-in ws protocol-level ping-pong
         // instead it requires a custom json-based text ping-pong
@@ -975,7 +1045,6 @@ class kucoinfutures extends kucoinfutures$1 {
         const methods = {
             // 'heartbeat': this.handleHeartbeat,
             'welcome': this.handleSystemStatus,
-            'ack': this.handleSubscriptionStatus,
             'message': this.handleSubject,
             'pong': this.handlePong,
             'error': this.handleErrorMessage,

package/js/ccxt.d.ts

@@ -4,7 +4,7 @@ import * as functions from './src/base/functions.js';
 import * as errors from './src/base/errors.js';
 import type { Market, Trade, Fee, Ticker, OrderBook, Order, Transaction, Tickers, Currency, Balance, DepositAddress, WithdrawalResponse, DepositAddressResponse, OHLCV, Balances, PartialBalances, Dictionary, MinMax, Position, FundingRateHistory, Liquidation, FundingHistory, MarginMode, Greeks, Leverage, Leverages, Option, OptionChain } from './src/base/types.js';
 import { BaseError, ExchangeError, AuthenticationError, PermissionDenied, AccountNotEnabled, AccountSuspended, ArgumentsRequired, BadRequest, BadSymbol, OperationRejected, NoChange, MarginModeAlreadySet, BadResponse, NullResponse, InsufficientFunds, InvalidAddress, AddressPending, InvalidOrder, OrderNotFound, OrderNotCached, CancelPending, OrderImmediatelyFillable, OrderNotFillable, DuplicateOrderId, ContractUnavailable, NotSupported, ProxyError, OperationFailed, NetworkError, DDoSProtection, RateLimitExceeded, ExchangeNotAvailable, OnMaintenance, InvalidNonce, RequestTimeout, ExchangeClosedByUser } from './src/base/errors.js';
-declare const version = "4.2.89";
+declare const version = "4.2.90";
 import ace from './src/ace.js';
 import alpaca from './src/alpaca.js';
 import ascendex from './src/ascendex.js';

package/js/ccxt.js

@@ -38,7 +38,7 @@ import * as errors from './src/base/errors.js';
 import { BaseError, ExchangeError, AuthenticationError, PermissionDenied, AccountNotEnabled, AccountSuspended, ArgumentsRequired, BadRequest, BadSymbol, OperationRejected, NoChange, MarginModeAlreadySet, BadResponse, NullResponse, InsufficientFunds, InvalidAddress, AddressPending, InvalidOrder, OrderNotFound, OrderNotCached, CancelPending, OrderImmediatelyFillable, OrderNotFillable, DuplicateOrderId, ContractUnavailable, NotSupported, ProxyError, OperationFailed, NetworkError, DDoSProtection, RateLimitExceeded, ExchangeNotAvailable, OnMaintenance, InvalidNonce, RequestTimeout, ExchangeClosedByUser } from './src/base/errors.js';
 //-----------------------------------------------------------------------------
 // this is updated by vss.js when building
-const version = '4.2.90';
+const version = '4.2.91';
 Exchange.ccxtVersion = version;
 //-----------------------------------------------------------------------------
 import ace from './src/ace.js';

package/js/src/base/Exchange.js

@@ -2082,7 +2082,7 @@ export default class Exchange {
     parseToInt(number) {
         // Solve Common parseInt misuse ex: parseInt ((since / 1000).toString ())
         // using a number as parameter which is not valid in ts
-        const stringifiedNumber = number.toString();
+        const stringifiedNumber = this.numberToString(number);
         const convertedNumber = parseFloat(stringifiedNumber);
         return parseInt(convertedNumber);
     }
@@ -4575,13 +4575,6 @@ export default class Exchange {
         if (!this.substituteCommonCurrencyCodes) {
             return code;
         }
-        // if the provided code already exists as a value in commonCurrencies dict, then we should not again transform it
-        // more details at: https://github.com/ccxt/ccxt/issues/21112#issuecomment-2031293691
-        const commonCurrencies = Object.values(this.commonCurrencies);
-        const exists = this.inArray(code, commonCurrencies);
-        if (exists) {
-            return code;
-        }
         return this.safeString(this.commonCurrencies, code, code);
     }
     currency(code) {
@@ -5232,7 +5225,6 @@ export default class Exchange {
          * @returns {object} objects with withdraw and deposit fees, indexed by currency codes
          */
         const depositWithdrawFees = {};
-        codes = this.marketCodes(codes);
         const isArray = Array.isArray(response);
         let responseKeys = response;
         if (!isArray) {

package/js/src/coinbase.js

@@ -331,6 +331,7 @@ export default class coinbase extends Exchange {
                 'CGLD': 'CELO',
             },
             'options': {
+                'brokerId': 'ccxt',
                 'stablePairs': ['BUSD-USD', 'CBETH-ETH', 'DAI-USD', 'GUSD-USD', 'GYEN-USD', 'PAX-USD', 'PAX-USDT', 'USDC-EUR', 'USDC-GBP', 'USDT-EUR', 'USDT-GBP', 'USDT-USD', 'USDT-USDC', 'WBTC-BTC'],
                 'fetchCurrencies': {
                     'expires': 5000,
@@ -2341,8 +2342,9 @@ export default class coinbase extends Exchange {
          */
         await this.loadMarkets();
         const market = this.market(symbol);
+        const id = this.safeString(this.options, 'brokerId', 'ccxt');
         let request = {
-            'client_order_id': this.uuid(),
+            'client_order_id': id + '-' + this.uuid(),
             'product_id': market['id'],
             'side': side.toUpperCase(),
         };

package/js/src/gemini.js

@@ -446,7 +446,8 @@ export default class gemini extends Exchange {
             //         '<td>0.01 USD', // quote currency price increment
             //         '</tr>'
             //     ]
-            const marketId = cells[0].replace('<td>', '');
+            let marketId = cells[0].replace('<td>', '');
+            marketId = marketId.replace('*', '');
             // const base = this.safeCurrencyCode (baseId);
             const minAmountString = cells[1].replace('<td>', '');
             const minAmountParts = minAmountString.split(' ');

package/js/src/kraken.js

@@ -599,10 +599,7 @@ export default class kraken extends Exchange {
         if (currencyId !== undefined) {
             if (currencyId.length > 3) {
                 if ((currencyId.indexOf('X') === 0) || (currencyId.indexOf('Z') === 0)) {
-                    if (currencyId.indexOf('.') > 0) {
-                        return super.safeCurrency(currencyId, currency);
-                    }
-                    else {
+                    if (!(currencyId.indexOf('.') > 0)) {
                         currencyId = currencyId.slice(1);
                     }
                 }
@@ -651,8 +648,13 @@ export default class kraken extends Exchange {
         //     {
         //         "error": [],
         //         "result": {
-        //             "ADA": { "aclass": "currency", "altname": "ADA", "decimals": 8, "display_decimals": 6 },
-        //             "BCH": { "aclass": "currency", "altname": "BCH", "decimals": 10, "display_decimals": 5 },
+        //             "BCH": {
+        //                 "aclass": "currency",
+        //                 "altname": "BCH",
+        //                 "decimals": 10,
+        //                 "display_decimals": 5
+        //                 "status": "enabled",
+        //             },
         //             ...
         //         },
         //     }
@@ -667,15 +669,15 @@ export default class kraken extends Exchange {
             // see: https://support.kraken.com/hc/en-us/articles/201893608-What-are-the-withdrawal-fees-
             // to add support for multiple withdrawal/deposit methods and
             // differentiated fees for each particular method
-            const code = this.safeCurrencyCode(this.safeString(currency, 'altname'));
+            const code = this.safeCurrencyCode(id);
             const precision = this.parseNumber(this.parsePrecision(this.safeString(currency, 'decimals')));
             // assumes all currencies are active except those listed above
-            const active = !this.inArray(code, this.options['inactiveCurrencies']);
+            const active = this.safeString(currency, 'status') === 'enabled';
             result[code] = {
                 'id': id,
                 'code': code,
                 'info': currency,
-                'name': code,
+                'name': this.safeString(currency, 'altname'),
                 'active': active,
                 'deposit': undefined,
                 'withdraw': undefined,