ccxt 4.2.68 → 4.2.69

package/js/src/bitstamp.js

@@ -88,6 +88,7 @@ export default class bitstamp extends Exchange {
                 'setLeverage': false,
                 'setMarginMode': false,
                 'setPositionMode': false,
+                'transfer': true,
                 'withdraw': true,
             },
             'urls': {
@@ -2122,6 +2123,73 @@ export default class bitstamp extends Exchange {
         const response = await this[method](this.extend(request, params));
         return this.parseTransaction(response, currency);
     }
+    async transfer(code, amount, fromAccount, toAccount, params = {}) {
+        /**
+         * @method
+         * @name bitstamp#transfer
+         * @description transfer currency internally between wallets on the same account
+         * @see https://www.bitstamp.net/api/#tag/Sub-account/operation/TransferFromMainToSub
+         * @see https://www.bitstamp.net/api/#tag/Sub-account/operation/TransferFromSubToMain
+         * @param {string} code unified currency code
+         * @param {float} amount amount to transfer
+         * @param {string} fromAccount account to transfer from
+         * @param {string} toAccount account to transfer to
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @returns {object} a [transfer structure]{@link https://docs.ccxt.com/#/?id=transfer-structure}
+         */
+        await this.loadMarkets();
+        const currency = this.currency(code);
+        amount = this.currencyToPrecision(code, amount);
+        amount = this.parseToNumeric(amount);
+        const request = {
+            'amount': amount,
+            'currency': currency['id'].toUpperCase(),
+        };
+        let response = undefined;
+        if (fromAccount === 'main') {
+            request['subAccount'] = toAccount;
+            response = await this.privatePostTransferFromMain(this.extend(request, params));
+        }
+        else if (toAccount === 'main') {
+            request['subAccount'] = fromAccount;
+            response = await this.privatePostTransferToMain(this.extend(request, params));
+        }
+        else {
+            throw new BadRequest(this.id + ' transfer() only supports from or to main');
+        }
+        //
+        //    { status: 'ok' }
+        //
+        const transfer = this.parseTransfer(response, currency);
+        transfer['amount'] = amount;
+        transfer['fromAccount'] = fromAccount;
+        transfer['toAccount'] = toAccount;
+        return transfer;
+    }
+    parseTransfer(transfer, currency = undefined) {
+        //
+        //    { status: 'ok' }
+        //
+        const status = this.safeString(transfer, 'status');
+        return {
+            'info': transfer,
+            'id': undefined,
+            'timestamp': undefined,
+            'datetime': undefined,
+            'currency': currency['code'],
+            'amount': undefined,
+            'fromAccount': undefined,
+            'toAccount': undefined,
+            'status': this.parseTransferStatus(status),
+        };
+    }
+    parseTransferStatus(status) {
+        const statuses = {
+            'ok': 'ok',
+            'error': 'failed',
+        };
+        return this.safeString(statuses, status, status);
+    }
     nonce() {
         return this.milliseconds();
     }

package/js/src/gate.js

@@ -4483,7 +4483,10 @@ export default class gate extends Exchange {
         if (lastTradeTimestamp === undefined) {
             lastTradeTimestamp = this.safeTimestamp2(order, 'update_time', 'finish_time');
         }
-        const marketType = ('currency_pair' in order) ? 'spot' : 'contract';
+        let marketType = 'contract';
+        if (('currency_pair' in order) || ('market' in order)) {
+            marketType = 'spot';
+        }
         const exchangeSymbol = this.safeString2(order, 'currency_pair', 'market', contract);
         const symbol = this.safeSymbol(exchangeSymbol, market, '_', marketType);
         // Everything below this(above return) is related to fees

package/js/src/gemini.d.ts

@@ -12,7 +12,7 @@ export default class gemini extends Exchange {
     fetchMarketsFromWeb(params?: {}): Promise<any[]>;
     parseMarketActive(status: any): boolean;
     fetchUSDTMarkets(params?: {}): Promise<any[]>;
-    fetchMarketsFromAPI(params?: {}): Promise<unknown[]>;
+    fetchMarketsFromAPI(params?: {}): Promise<any[]>;
     parseMarket(response: any): Market;
     fetchOrderBook(symbol: string, limit?: Int, params?: {}): Promise<OrderBook>;
     fetchTickerV1(symbol: string, params?: {}): Promise<Ticker>;

package/js/src/gemini.js

@@ -30,7 +30,7 @@ export default class gemini extends Exchange {
                 'CORS': undefined,
                 'spot': true,
                 'margin': false,
-                'swap': false,
+                'swap': true,
                 'future': false,
                 'option': false,
                 'addMargin': false,
@@ -255,11 +255,11 @@ export default class gemini extends Exchange {
                 },
             },
             'options': {
-                'fetchMarketsMethod': 'fetch_markets_from_web',
+                'fetchMarketsMethod': 'fetch_markets_from_api',
                 'fetchMarketFromWebRetries': 10,
                 'fetchMarketsFromAPI': {
                     'fetchDetailsForAllSymbols': false,
-                    'fetchDetailsForMarketIds': [],
+                    'quoteCurrencies': ['USDT', 'GUSD', 'USD', 'DAI', 'EUR', 'GBP', 'SGD', 'BTC', 'ETH', 'LTC', 'BCH'],
                 },
                 'fetchMarkets': {
                     'webApiEnable': true,
@@ -315,10 +315,7 @@ export default class gemini extends Exchange {
         }
         //
         //    {
-        //        "tradingPairs": [
-        //            [ "BTCAUD", 2, 8, "0.00001", 10, true ],
-        //            ...
-        //        ],
+        //        "tradingPairs": [ [ 'BTCUSD', 2, 8, '0.00001', 10, true ],  ... ],
         //        "currencies": [
         //            [ "ORCA", "Orca", 204, 6, 0, 6, 8, false, null, "solana" ], // as confirmed, precisions seem to be the 5th index
         //            [ "ATOM", "Cosmos", 44, 6, 0, 6, 8, false, null, "cosmos" ],
@@ -337,6 +334,7 @@ export default class gemini extends Exchange {
         //    }
         //
         const result = {};
+        this.options['tradingPairs'] = this.safeList(data, 'tradingPairs');
         const currenciesArray = this.safeValue(data, 'currencies', []);
         for (let i = 0; i < currenciesArray.length; i++) {
             const currency = currenciesArray[i];
@@ -546,7 +544,7 @@ export default class gemini extends Exchange {
         return result;
     }
     async fetchMarketsFromAPI(params = {}) {
-        const response = await this.publicGetV1Symbols(params);
+        const marketIdsRaw = await this.publicGetV1Symbols(params);
         //
         //     [
         //         "btcusd",
@@ -554,93 +552,185 @@ export default class gemini extends Exchange {
         //         ...
         //     ]
         //
-        const result = {};
-        for (let i = 0; i < response.length; i++) {
-            const marketId = response[i];
-            const market = {
-                'symbol': marketId,
-            };
-            result[marketId] = this.parseMarket(market);
+        const result = [];
+        const options = this.safeDict(this.options, 'fetchMarketsFromAPI', {});
+        const bugSymbol = 'efilfil'; // we skip this inexistent test symbol, which bugs other functions
+        const marketIds = [];
+        for (let i = 0; i < marketIdsRaw.length; i++) {
+            if (marketIdsRaw[i] !== bugSymbol) {
+                marketIds.push(marketIdsRaw[i]);
+            }
         }
-        const options = this.safeValue(this.options, 'fetchMarketsFromAPI', {});
-        const fetchDetailsForAllSymbols = this.safeBool(options, 'fetchDetailsForAllSymbols', false);
-        const fetchDetailsForMarketIds = this.safeValue(options, 'fetchDetailsForMarketIds', []);
-        let promises = [];
-        let marketIds = [];
-        if (fetchDetailsForAllSymbols) {
-            marketIds = response;
+        if (this.safeBool(options, 'fetchDetailsForAllSymbols', false)) {
+            const promises = [];
+            for (let i = 0; i < marketIds.length; i++) {
+                const marketId = marketIds[i];
+                const request = {
+                    'symbol': marketId,
+                };
+                promises.push(this.publicGetV1SymbolsDetailsSymbol(this.extend(request, params)));
+                //
+                //     {
+                //         "symbol": "BTCUSD",
+                //         "base_currency": "BTC",
+                //         "quote_currency": "USD",
+                //         "tick_size": 1E-8,
+                //         "quote_increment": 0.01,
+                //         "min_order_size": "0.00001",
+                //         "status": "open",
+                //         "wrap_enabled": false
+                //     }
+                //
+            }
+            const responses = await Promise.all(promises);
+            for (let i = 0; i < responses.length; i++) {
+                result.push(this.parseMarket(responses[i]));
+            }
         }
         else {
-            marketIds = fetchDetailsForMarketIds;
-        }
-        for (let i = 0; i < marketIds.length; i++) {
-            const marketId = marketIds[i];
-            const request = {
-                'symbol': marketId,
-            };
-            promises.push(this.publicGetV1SymbolsDetailsSymbol(this.extend(request, params)));
-            //
-            //     {
-            //         "symbol": "BTCUSD",
-            //         "base_currency": "BTC",
-            //         "quote_currency": "USD",
-            //         "tick_size": 1E-8,
-            //         "quote_increment": 0.01,
-            //         "min_order_size": "0.00001",
-            //         "status": "open",
-            //         "wrap_enabled": false
-            //     }
-            //
-        }
-        promises = await Promise.all(promises);
-        for (let i = 0; i < promises.length; i++) {
-            const responseInner = promises[i];
-            const marketId = this.safeStringLower(responseInner, 'symbol');
-            result[marketId] = this.parseMarket(responseInner);
+            // use trading-pairs info, if it was fetched
+            const tradingPairs = this.safeList(this.options, 'tradingPairs');
+            if (tradingPairs !== undefined) {
+                const indexedTradingPairs = this.indexBy(tradingPairs, 0);
+                for (let i = 0; i < marketIds.length; i++) {
+                    const marketId = marketIds[i];
+                    const tradingPair = this.safeList(indexedTradingPairs, marketId.toUpperCase());
+                    if (tradingPair !== undefined) {
+                        result.push(this.parseMarket(tradingPair));
+                    }
+                }
+            }
+            else {
+                for (let i = 0; i < marketIds.length; i++) {
+                    result.push(this.parseMarket(marketIds[i]));
+                }
+            }
         }
-        return this.toArray(result);
+        return result;
     }
     parseMarket(response) {
-        const marketId = this.safeStringLower(response, 'symbol');
-        let baseId = this.safeString(response, 'base_currency');
-        let quoteId = this.safeString(response, 'quote_currency');
-        if (baseId === undefined) {
-            const idLength = marketId.length - 0;
-            const isUSDT = marketId.indexOf('usdt') >= 0;
-            const quoteSize = isUSDT ? 4 : 3;
-            baseId = marketId.slice(0, idLength - quoteSize); // Not true for all markets
-            quoteId = marketId.slice(idLength - quoteSize, idLength);
+        //
+        // response might be:
+        //
+        //     btcusd
+        //
+        // or
+        //
+        //     [
+        //         'BTCUSD',   // symbol
+        //         2,          // priceTickDecimalPlaces
+        //         8,          // quantityTickDecimalPlaces
+        //         '0.00001',  // quantityMinimum
+        //         10,         // quantityRoundDecimalPlaces
+        //         true        // minimumsAreInclusive
+        //     ],
+        //
+        // or
+        //
+        //     {
+        //         "symbol": "BTCUSD", // perpetuals have 'PERP' suffix, i.e. DOGEUSDPERP
+        //         "base_currency": "BTC",
+        //         "quote_currency": "USD",
+        //         "tick_size": 1E-8,
+        //         "quote_increment": 0.01,
+        //         "min_order_size": "0.00001",
+        //         "status": "open",
+        //         "wrap_enabled": false
+        //         "product_type": "swap", // only in perps
+        //         "contract_type": "linear", // only in perps
+        //         "contract_price_currency": "GUSD" // only in perps
+        //     }
+        //
+        let marketId = undefined;
+        let baseId = undefined;
+        let quoteId = undefined;
+        let settleId = undefined;
+        let tickSize = undefined;
+        let increment = undefined;
+        let minSize = undefined;
+        let status = undefined;
+        let swap = false;
+        let contractSize = undefined;
+        let linear = undefined;
+        let inverse = undefined;
+        const isString = (typeof response === 'string');
+        const isArray = (Array.isArray(response));
+        if (!isString && !isArray) {
+            marketId = this.safeStringLower(response, 'symbol');
+            minSize = this.safeNumber(response, 'min_order_size');
+            tickSize = this.safeNumber(response, 'tick_size');
+            increment = this.safeNumber(response, 'quote_increment');
+            status = this.parseMarketActive(this.safeString(response, 'status'));
+            baseId = this.safeString(response, 'base_currency');
+            quoteId = this.safeString(response, 'quote_currency');
+            settleId = this.safeString(response, 'contract_price_currency');
+        }
+        else {
+            // if no detailed API was called, then parse either string or array
+            if (isString) {
+                marketId = response;
+            }
+            else {
+                marketId = this.safeStringLower(response, 0);
+                minSize = this.safeNumber(response, 3);
+                tickSize = this.parseNumber(this.parsePrecision(this.safeString(response, 1)));
+                increment = this.parseNumber(this.parsePrecision(this.safeString(response, 2)));
+            }
+            const marketIdUpper = marketId.toUpperCase();
+            const isPerp = (marketIdUpper.indexOf('PERP') >= 0);
+            const marketIdWithoutPerp = marketIdUpper.replace('PERP', '');
+            const quoteQurrencies = this.handleOption('fetchMarketsFromAPI', 'quoteCurrencies', []);
+            for (let i = 0; i < quoteQurrencies.length; i++) {
+                const quoteCurrency = quoteQurrencies[i];
+                if (marketIdWithoutPerp.endsWith(quoteCurrency)) {
+                    baseId = marketIdWithoutPerp.replace(quoteCurrency, '');
+                    quoteId = quoteCurrency;
+                    if (isPerp) {
+                        settleId = quoteCurrency; // always same
+                    }
+                    break;
+                }
+            }
         }
         const base = this.safeCurrencyCode(baseId);
         const quote = this.safeCurrencyCode(quoteId);
-        const status = this.safeString(response, 'status');
+        const settle = this.safeCurrencyCode(settleId);
+        let symbol = base + '/' + quote;
+        if (settleId !== undefined) {
+            symbol = symbol + ':' + settle;
+            swap = true;
+            contractSize = tickSize; // always same
+            linear = true; // always linear
+            inverse = false;
+        }
+        const type = swap ? 'swap' : 'spot';
         return {
             'id': marketId,
-            'symbol': base + '/' + quote,
+            'symbol': symbol,
             'base': base,
             'quote': quote,
-            'settle': undefined,
+            'settle': settle,
             'baseId': baseId,
             'quoteId': quoteId,
-            'settleId': undefined,
-            'type': 'spot',
-            'spot': true,
+            'settleId': settleId,
+            'type': type,
+            'spot': !swap,
             'margin': false,
-            'swap': false,
+            'swap': swap,
             'future': false,
             'option': false,
-            'active': this.parseMarketActive(status),
-            'contract': false,
-            'linear': undefined,
-            'inverse': undefined,
-            'contractSize': undefined,
+            'active': status,
+            'contract': swap,
+            'linear': linear,
+            'inverse': inverse,
+            'contractSize': contractSize,
             'expiry': undefined,
             'expiryDatetime': undefined,
             'strike': undefined,
             'optionType': undefined,
             'precision': {
-                'price': this.safeNumber(response, 'quote_increment'),
-                'amount': this.safeNumber(response, 'tick_size'),
+                'price': increment,
+                'amount': tickSize,
             },
             'limits': {
                 'leverage': {
@@ -648,7 +738,7 @@ export default class gemini extends Exchange {
                     'max': undefined,
                 },
                 'amount': {
-                    'min': this.safeNumber(response, 'min_order_size'),
+                    'min': minSize,
                     'max': undefined,
                 },
                 'price': {

package/js/src/hitbtc.js

@@ -318,6 +318,7 @@ export default class hitbtc extends Exchange {
                     '2012': BadRequest,
                     '2020': BadRequest,
                     '2022': BadRequest,
+                    '2024': InvalidOrder,
                     '10001': BadRequest,
                     '10021': AccountSuspended,
                     '10022': BadRequest,
@@ -335,6 +336,7 @@ export default class hitbtc extends Exchange {
                     '20012': ExchangeError,
                     '20014': ExchangeError,
                     '20016': ExchangeError,
+                    '20018': ExchangeError,
                     '20031': ExchangeError,
                     '20032': ExchangeError,
                     '20033': ExchangeError,
@@ -345,10 +347,15 @@ export default class hitbtc extends Exchange {
                     '20043': ExchangeError,
                     '20044': PermissionDenied,
                     '20045': InvalidOrder,
+                    '20047': InvalidOrder,
+                    '20048': InvalidOrder,
+                    '20049': InvalidOrder,
                     '20080': ExchangeError,
                     '21001': ExchangeError,
                     '21003': AccountSuspended,
                     '21004': AccountSuspended,
+                    '22004': ExchangeError,
+                    '22008': ExchangeError, // Gateway timeout exceeded.
                 },
                 'broad': {},
             },

package/js/src/htx.js

@@ -470,6 +470,7 @@ export default class htx extends Exchange {
                             'v2/sub-user/api-key-modification': 1,
                             'v2/sub-user/api-key-deletion': 1,
                             'v1/subuser/transfer': 10,
+                            'v1/trust/user/active/credit': 10,
                             // Trading
                             'v1/order/orders/place': 0.2,
                             'v1/order/batch-orders': 0.4,

package/js/src/kucoin.js

@@ -413,6 +413,7 @@ export default class kucoin extends Exchange {
                 '12h': '12hour',
                 '1d': '1day',
                 '1w': '1week',
+                '1M': '1month',
             },
             'precisionMode': TICK_SIZE,
             'exceptions': {
@@ -4462,7 +4463,7 @@ export default class kucoin extends Exchange {
         url = url + endpoint;
         const isFuturePrivate = (api === 'futuresPrivate');
         const isPrivate = (api === 'private');
-        const isBroker = (api === 'private');
+        const isBroker = (api === 'broker');
         if (isPrivate || isFuturePrivate || isBroker) {
             this.checkRequiredCredentials();
             const timestamp = this.nonce().toString();
@@ -4494,7 +4495,9 @@ export default class kucoin extends Exchange {
             }
             if (isBroker) {
                 const brokerName = this.safeString(partner, 'name');
-                headers['KC-BROKER-NAME'] = brokerName;
+                if (brokerName !== undefined) {
+                    headers['KC-BROKER-NAME'] = brokerName;
+                }
             }
         }
         return { 'url': url, 'method': method, 'body': body, 'headers': headers };

package/js/src/pro/lbank.js

@@ -429,7 +429,7 @@ export default class lbank extends lbankRest {
         //             "volume":6.3607,
         //             "amount":77148.9303,
         //             "price":12129,
-        //             "direction":"sell",
+        //             "direction":"sell", // or "sell_market"
         //             "TS":"2019-06-28T19:55:49.460"
         //         },
         //         "type":"trade",
@@ -469,7 +469,7 @@ export default class lbank extends lbankRest {
         //        "volume":6.3607,
         //        "amount":77148.9303,
         //        "price":12129,
-        //        "direction":"sell",
+        //        "direction":"sell", // or "sell_market"
         //        "TS":"2019-06-28T19:55:49.460"
         //    }
         //
@@ -478,6 +478,8 @@ export default class lbank extends lbankRest {
         if (timestamp === undefined) {
             timestamp = this.parse8601(datetime);
         }
+        let side = this.safeString2(trade, 'direction', 3);
+        side = side.replace('_market', '');
         return this.safeTrade({
             'timestamp': timestamp,
             'datetime': datetime,
@@ -486,7 +488,7 @@ export default class lbank extends lbankRest {
             'order': undefined,
             'type': undefined,
             'takerOrMaker': undefined,
-            'side': this.safeString2(trade, 'direction', 3),
+            'side': side,
             'price': this.safeString2(trade, 'price', 1),
             'amount': this.safeString2(trade, 'volume', 2),
             'cost': this.safeString(trade, 'amount'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.2.68",
+  "version": "4.2.69",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",

package/skip-tests.json

@@ -887,6 +887,7 @@
         }
     },
     "gemini": {
+        "skipWs": "fixes needed",
         "skipMethods": {
             "loadMarkets": {
                 "currencyIdAndCode": "messed codes",