ccxt 4.2.64 → 4.2.66

package/js/src/pro/bitfinex2.js

@@ -323,11 +323,12 @@ export default class bitfinex2 extends bitfinex2Rest {
         const messageLength = message.length;
         if (messageLength === 2) {
             // initial snapshot
-            let trades = this.safeList(message, 1, []);
+            const trades = this.safeList(message, 1, []);
             // needs to be reversed to make chronological order
-            trades = trades.reverse();
-            for (let i = 0; i < trades.length; i++) {
-                const parsed = this.parseWsTrade(trades[i], market);
+            const length = trades.length;
+            for (let i = 0; i < length; i++) {
+                const index = length - i - 1;
+                const parsed = this.parseWsTrade(trades[index], market);
                 stored.append(parsed);
             }
         }

package/js/src/pro/bitget.js

@@ -674,10 +674,10 @@ export default class bitget extends bitgetRest {
         }
         const data = this.safeList(message, 'data', []);
         const length = data.length;
-        const maxLength = Math.max(length - 1, 0);
         // fix chronological order by reversing
-        for (let i = maxLength; i >= 0; i--) {
-            const rawTrade = data[i];
+        for (let i = 0; i < length; i++) {
+            const index = length - i - 1;
+            const rawTrade = data[index];
             const parsed = this.parseWsTrade(rawTrade, market);
             stored.append(parsed);
         }

package/js/src/pro/bitmart.js

@@ -830,9 +830,9 @@ export default class bitmart extends bitmartRest {
         const isSwap = ('group' in message);
         if (isSwap) {
             // in swap, chronologically decreasing: 1709536849322, 1709536848954,
-            const maxLen = Math.max(length - 1, 0);
-            for (let i = maxLen; i >= 0; i--) {
-                symbol = this.handleTradeLoop(data[i]);
+            for (let i = 0; i < length; i++) {
+                const index = length - i - 1;
+                symbol = this.handleTradeLoop(data[index]);
             }
         }
         else {
@@ -1474,7 +1474,17 @@ export default class bitmart extends bitmartRest {
         }
         //
         //     {"event":"error","message":"Unrecognized request: {\"event\":\"subscribe\",\"channel\":\"spot/depth:BTC-USDT\"}","errorCode":30039}
-        //     {"event":"subscribe","channel":"spot/depth:BTC-USDT"}
+        //
+        // subscribe events on spot:
+        //
+        //     {"event":"subscribe", "topic":"spot/kline1m:BTC_USDT" }
+        //
+        // subscribe on contracts:
+        //
+        //     {"action":"subscribe", "group":"futures/klineBin1m:BTCUSDT", "success":true, "request":{"action":"subscribe", "args":[ "futures/klineBin1m:BTCUSDT" ] } }
+        //
+        // regular updates - spot
+        //
         //     {
         //         "table": "spot/depth",
         //         "action": "partial",
@@ -1495,10 +1505,21 @@ export default class bitmart extends bitmartRest {
         //         ]
         //     }
         //
+        // regular updates - contracts
+        //
+        //     {
+        //         group: "futures/klineBin1m:BTCUSDT",
+        //         data: {
+        //           symbol: "BTCUSDT",
+        //           items: [ { o: "67944.7", "h": .... } ],
+        //         },
+        //       }
+        //
         //     { data: '', table: "spot/user/order" }
         //
-        const channel = this.safeString2(message, 'table', 'group');
-        if (channel === undefined) {
+        // the only realiable way (for both spot & swap) is to check 'data' key
+        const isDataUpdate = ('data' in message);
+        if (!isDataUpdate) {
             const event = this.safeString2(message, 'event', 'action');
             if (event !== undefined) {
                 const methods = {
@@ -1514,6 +1535,7 @@ export default class bitmart extends bitmartRest {
             }
         }
         else {
+            const channel = this.safeString2(message, 'table', 'group');
             const methods = {
                 'depth': this.handleOrderBook,
                 'ticker': this.handleTicker,

package/js/src/pro/currencycom.d.ts

@@ -26,7 +26,7 @@ export default class currencycom extends currencycomRest {
         cost: number;
         fee: any;
     };
-    handleTrades(client: Client, message: any, subscription: any): void;
+    handleTrades(client: Client, message: any): void;
     findTimeframe(timeframe: any, defaultTimeframes?: any): string;
     handleOHLCV(client: Client, message: any): void;
     requestId(): any;

package/js/src/pro/currencycom.js

@@ -194,7 +194,7 @@ export default class currencycom extends currencycomRest {
             'fee': undefined,
         };
     }
-    handleTrades(client, message, subscription) {
+    handleTrades(client, message) {
         //
         //     {
         //         "status": "OK",

package/js/src/woo.d.ts

@@ -173,5 +173,5 @@ export default class woo extends Exchange {
     fetchPositions(symbols?: Strings, params?: {}): Promise<import("./base/types.js").Position[]>;
     parsePosition(position: any, market?: Market): import("./base/types.js").Position;
     defaultNetworkCodeForCurrency(code: any): any;
-    setSandboxMode(enable: any): void;
+    setSandboxMode(enable: boolean): void;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.2.64",
+  "version": "4.2.66",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",
@@ -36,7 +36,7 @@
     "build-docs": "node jsdoc2md.js && node examples2md.js",
     "serve-docs": "docsify serve ./wiki",
     "tsBuildFile": "tsc --skipLibCheck --strictNullChecks false --strict --noImplicitAny false --esModuleInterop --isolatedModules false --forceConsistentCasingInFileNames --removeComments false --target ES2020 --declaration --allowJs --checkJs false --moduleResolution Node --module ES2022 --outDir ./js/src --lib ES2020.BigInt --lib dom ",
-    "tsBuild": "tsc || true",
+    "tsBuild": "tsc || echo \"\"",
     "tsBuildExamples": "tsc -p ./examples/tsconfig.json",
     "emitAPI": "node build/generateImplicitAPI.js",
     "build": "npm run pre-transpile && npm run transpile && npm run post-transpile && npm run update-badges && npm run build-docs",

package/skip-tests.json

@@ -82,6 +82,18 @@
             }
         }
     },
+    "binanceusdm ": {
+        "httpsProxy": "http://5.75.153.75:8002",
+        "wsProxy": "http://5.75.153.75:8002",
+        "skipMethods": {
+            "watchOrderBook": {
+                "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269352042#L3463"
+            },
+            "watchOrderBookForSymbols": {
+                "spread": "same"
+            }
+        }
+    },
     "binanceus": {
         "skipMethods": {
             "loadMarkets": {
@@ -320,15 +332,17 @@
             },
             "fetchTickers": {
                 "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269177564#L3615",
-                "quoteVolume": "quoteVolume >= baseVolume * low is failing"
+                "quoteVolume": "quoteVolume >= baseVolume * low is failing",
+                "ask": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269331129#L3609"
             },
             "fetchTicker": {
-                "spread": "same",
-                "quoteVolume": "same"
+                "spread": "same", "quoteVolume": "same", "ask": "same"
             },
             "watchTickers": {
-                "spread": "same",
-                "quoteVolume": "same"
+                "spread": "same", "quoteVolume": "same", "ask": "same"
+            },
+            "watchTicker": {
+                "spread": "same", "quoteVolume": "same", "ask": "same"
             },
             "fetchOrderBook": {
                 "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269177564#L3946"
@@ -601,7 +615,13 @@
             "fetchOpenInterestHistory": {
                 "openInterestAmount": "openInterestAmount is not provided"
             },
-            "fetchBorrowRate": "does not work with unified account"
+            "fetchBorrowRate": "does not work with unified account",
+            "watchOrderBook": {
+                "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269352042#L3669"
+            },
+            "watchOrderBookForSymbols": {
+                "spread": "same"
+            }
         }
     },
     "bigone": {
@@ -1163,9 +1183,7 @@
             "watchTrades": {
                 "timestamp": "ts several hours ahead in in future :)"
             },
-            "watchOHLCV": {
-                "0": "ts several hours ahead in in future :)"
-            }
+            "watchOHLCV": "some timestamp issues"
         }
     },
     "lykke": {
@@ -1356,12 +1374,16 @@
                 "deposit":"not provided"
             },
             "fetchTickers": {
-                "quoteVolume": "quoteVolume >= baseVolume * low is failing",
-                "baseVolume": "quoteVolume >= baseVolume * low is failing"
+                "quoteVolume": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269352042#L3690"
             },
             "fetchTicker": {
-                "quoteVolume": "quoteVolume >= baseVolume * low is failing",
-                "baseVolume": "quoteVolume >= baseVolume * low is failing"
+                "quoteVolume": "same"
+            },
+            "watchTickers": {
+                "quoteVolume": "same"
+            },
+            "watchTicker": {
+                "quoteVolume": "same"
             },
             "watchOrderBook": {
                 "nonce": "missing https://app.travis-ci.com/github/ccxt/ccxt/builds/267900037#L4807"