ccxt 4.2.63 → 4.2.65

package/js/src/yobit.js

@@ -284,15 +284,15 @@ export default class yobit extends Exchange {
         });
     }
     parseBalance(response) {
-        const balances = this.safeValue(response, 'return', {});
+        const balances = this.safeDict(response, 'return', {});
         const timestamp = this.safeInteger(balances, 'server_time');
         const result = {
             'info': response,
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
         };
-        const free = this.safeValue(balances, 'funds', {});
-        const total = this.safeValue(balances, 'funds_incl_orders', {});
+        const free = this.safeDict(balances, 'funds', {});
+        const total = this.safeDict(balances, 'funds_incl_orders', {});
         const currencyIds = Object.keys(this.extend(free, total));
         for (let i = 0; i < currencyIds.length; i++) {
             const currencyId = currencyIds[i];
@@ -370,7 +370,7 @@ export default class yobit extends Exchange {
         //         },
         //     }
         //
-        const markets = this.safeValue(response, 'pairs', {});
+        const markets = this.safeDict(response, 'pairs', {});
         const keys = Object.keys(markets);
         const result = [];
         for (let i = 0; i < keys.length; i++) {
@@ -658,7 +658,7 @@ export default class yobit extends Exchange {
                 'currency': feeCurrencyCode,
             };
         }
-        const isYourOrder = this.safeValue(trade, 'is_your_order');
+        const isYourOrder = this.safeString(trade, 'is_your_order');
         if (isYourOrder !== undefined) {
             if (fee === undefined) {
                 const feeInNumbers = this.calculateFee(symbol, type, side, amount, price, 'taker');
@@ -725,7 +725,7 @@ export default class yobit extends Exchange {
                 return [];
             }
         }
-        const result = this.safeValue(response, market['id'], []);
+        const result = this.safeList(response, market['id'], []);
         return this.parseTrades(result, market, since, limit);
     }
     async fetchTradingFees(params = {}) {
@@ -758,12 +758,12 @@ export default class yobit extends Exchange {
         //         },
         //     }
         //
-        const pairs = this.safeValue(response, 'pairs', {});
+        const pairs = this.safeDict(response, 'pairs', {});
         const marketIds = Object.keys(pairs);
         const result = {};
         for (let i = 0; i < marketIds.length; i++) {
             const marketId = marketIds[i];
-            const pair = this.safeValue(pairs, marketId, {});
+            const pair = this.safeDict(pairs, marketId, {});
             const symbol = this.safeSymbol(marketId, undefined, '_');
             const takerString = this.safeString(pair, 'fee_buyer');
             const makerString = this.safeString(pair, 'fee_seller');
@@ -827,7 +827,7 @@ export default class yobit extends Exchange {
         //           }
         //       }
         //
-        const result = this.safeValue(response, 'return');
+        const result = this.safeDict(response, 'return');
         return this.parseOrder(result, market);
     }
     async cancelOrder(id, symbol = undefined, params = {}) {
@@ -865,7 +865,7 @@ export default class yobit extends Exchange {
         //          }
         //      }
         //
-        const result = this.safeValue(response, 'return', {});
+        const result = this.safeDict(response, 'return', {});
         return this.parseOrder(result);
     }
     parseOrderStatus(status) {
@@ -996,7 +996,7 @@ export default class yobit extends Exchange {
         };
         const response = await this.privatePostOrderInfo(this.extend(request, params));
         id = id.toString();
-        const orders = this.safeValue(response, 'return', {});
+        const orders = this.safeDict(response, 'return', {});
         //
         //      {
         //          "success":1,
@@ -1061,7 +1061,7 @@ export default class yobit extends Exchange {
         //          }
         //      }
         //
-        const result = this.safeValue(response, 'return', {});
+        const result = this.safeDict(response, 'return', {});
         return this.parseOrders(result, market, since, limit);
     }
     async fetchMyTrades(symbol = undefined, since = undefined, limit = undefined, params = {}) {
@@ -1115,7 +1115,7 @@ export default class yobit extends Exchange {
         //          }
         //      }
         //
-        const trades = this.safeValue(response, 'return', {});
+        const trades = this.safeDict(response, 'return', {});
         const ids = Object.keys(trades);
         const result = [];
         for (let i = 0; i < ids.length; i++) {
@@ -1163,7 +1163,7 @@ export default class yobit extends Exchange {
         await this.loadMarkets();
         const currency = this.currency(code);
         let currencyId = currency['id'];
-        const networks = this.safeValue(this.options, 'networks', {});
+        const networks = this.safeDict(this.options, 'networks', {});
         let network = this.safeStringUpper(params, 'network'); // this line allows the user to specify either ERC20 or ETH
         network = this.safeString(networks, network, network); // handle ERC20>ETH alias
         if (network !== undefined) {
@@ -1330,7 +1330,7 @@ export default class yobit extends Exchange {
             //
             // To cover points 1, 2, 3 and 4 combined this handler should work like this:
             //
-            let success = this.safeBool(response, 'success', false);
+            let success = this.safeValue(response, 'success'); // don't replace with safeBool here
             if (typeof success === 'string') {
                 if ((success === 'true') || (success === '1')) {
                     success = true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.2.63",
+  "version": "4.2.65",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",
@@ -36,7 +36,7 @@
     "build-docs": "node jsdoc2md.js && node examples2md.js",
     "serve-docs": "docsify serve ./wiki",
     "tsBuildFile": "tsc --skipLibCheck --strictNullChecks false --strict --noImplicitAny false --esModuleInterop --isolatedModules false --forceConsistentCasingInFileNames --removeComments false --target ES2020 --declaration --allowJs --checkJs false --moduleResolution Node --module ES2022 --outDir ./js/src --lib ES2020.BigInt --lib dom ",
-    "tsBuild": "tsc || true",
+    "tsBuild": "tsc || echo \"\"",
     "tsBuildExamples": "tsc -p ./examples/tsconfig.json",
     "emitAPI": "node build/generateImplicitAPI.js",
     "build": "npm run pre-transpile && npm run transpile && npm run post-transpile && npm run update-badges && npm run build-docs",

package/skip-tests.json

@@ -82,6 +82,18 @@
             }
         }
     },
+    "binanceusdm ": {
+        "httpsProxy": "http://5.75.153.75:8002",
+        "wsProxy": "http://5.75.153.75:8002",
+        "skipMethods": {
+            "watchOrderBook": {
+                "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269352042#L3463"
+            },
+            "watchOrderBookForSymbols": {
+                "spread": "same"
+            }
+        }
+    },
     "binanceus": {
         "skipMethods": {
             "loadMarkets": {
@@ -220,22 +232,20 @@
                 "deposit": "not provided"
             },
             "fetchTicker": {
-                "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269273148#L3651"
+                "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269273148#L3651",
+                "ask": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269327874#L3234",
+                "open": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269177570#L3624",
+                "bidVolume": "sometimes negative",
+                "askVolume": "sometimes negative"
             },
             "fetchTickers": {
-                "spread": "same as above",
-                "open": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269177570#L3624",
-                "bidVolume": "same",
-                "askVolume": "same"
+                "spread": "same", "ask": "same", "open": "same", "bidVolume": "same", "askVolume": "same"
             },
             "watchTicker": {
-                "spread": "same as above"
+                "spread": "same", "ask": "same", "open": "same", "bidVolume": "same", "askVolume": "same"
             },
             "watchTickers": {
-                "spread": "same as above",
-                "open": "same",
-                "bidVolume": "same",
-                "askVolume": "same"
+                "spread": "same", "ask": "same", "open": "same", "bidVolume": "same", "askVolume": "same"
             },
             "fetchOrderBook": {
                 "bid": "multiple bids might have same value"
@@ -322,15 +332,17 @@
             },
             "fetchTickers": {
                 "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269177564#L3615",
-                "quoteVolume": "quoteVolume >= baseVolume * low is failing"
+                "quoteVolume": "quoteVolume >= baseVolume * low is failing",
+                "ask": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269331129#L3609"
             },
             "fetchTicker": {
-                "spread": "same",
-                "quoteVolume": "same"
+                "spread": "same", "quoteVolume": "same", "ask": "same"
             },
             "watchTickers": {
-                "spread": "same",
-                "quoteVolume": "same"
+                "spread": "same", "quoteVolume": "same", "ask": "same"
+            },
+            "watchTicker": {
+                "spread": "same", "quoteVolume": "same", "ask": "same"
             },
             "fetchOrderBook": {
                 "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269177564#L3946"
@@ -603,7 +615,13 @@
             "fetchOpenInterestHistory": {
                 "openInterestAmount": "openInterestAmount is not provided"
             },
-            "fetchBorrowRate": "does not work with unified account"
+            "fetchBorrowRate": "does not work with unified account",
+            "watchOrderBook": {
+                "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269352042#L3669"
+            },
+            "watchOrderBookForSymbols": {
+                "spread": "same"
+            }
         }
     },
     "bigone": {
@@ -1152,7 +1170,6 @@
         }
     },
     "lbank": {
-        "skipWs": true,
         "skipMethods": {
             "loadMarkets": "settle must be defined when contract is true",
             "fetchTickers": {
@@ -1162,7 +1179,11 @@
             "fetchTicker": {
                 "quoteVolume": "quoteVolume >= baseVolume * low is failing",
                 "baseVolume": "quoteVolume >= baseVolume * low is failing"
-            }
+            },
+            "watchTrades": {
+                "timestamp": "ts several hours ahead in in future :)"
+            },
+            "watchOHLCV": "some timestamp issues"
         }
     },
     "lykke": {
@@ -1353,12 +1374,16 @@
                 "deposit":"not provided"
             },
             "fetchTickers": {
-                "quoteVolume": "quoteVolume >= baseVolume * low is failing",
-                "baseVolume": "quoteVolume >= baseVolume * low is failing"
+                "quoteVolume": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269352042#L3690"
             },
             "fetchTicker": {
-                "quoteVolume": "quoteVolume >= baseVolume * low is failing",
-                "baseVolume": "quoteVolume >= baseVolume * low is failing"
+                "quoteVolume": "same"
+            },
+            "watchTickers": {
+                "quoteVolume": "same"
+            },
+            "watchTicker": {
+                "quoteVolume": "same"
             },
             "watchOrderBook": {
                 "nonce": "missing https://app.travis-ci.com/github/ccxt/ccxt/builds/267900037#L4807"