ccxt 4.2.51 → 4.2.53

package/js/src/pro/binance.js

@@ -41,9 +41,11 @@ export default class binance extends binanceRest {
                 'fetchDepositsWs': false,
                 'fetchMarketsWs': false,
                 'fetchMyTradesWs': true,
+                'fetchOHLCVWs': true,
                 'fetchOpenOrdersWs': true,
                 'fetchOrderWs': true,
                 'fetchOrdersWs': true,
+                'fetchTradesWs': true,
                 'fetchTradingFeesWs': false,
                 'fetchWithdrawalsWs': false,
             },
@@ -840,6 +842,94 @@ export default class binance extends binanceRest {
         stored.append(parsed);
         client.resolve(stored, messageHash);
     }
+    async fetchOHLCVWs(symbol, timeframe = '1m', since = undefined, limit = undefined, params = {}) {
+        /**
+         * @method
+         * @name binance#fetchOHLCVWs
+         * @see https://binance-docs.github.io/apidocs/websocket_api/en/#klines
+         * @description query historical candlestick data containing the open, high, low, and close price, and the volume of a market
+         * @param {string} symbol unified symbol of the market to query OHLCV data for
+         * @param {string} timeframe the length of time each candle represents
+         * @param {int} since timestamp in ms of the earliest candle to fetch
+         * @param {int} limit the maximum amount of candles to fetch
+         * @param {object} params extra parameters specific to the exchange API endpoint
+         * @param {int} params.until timestamp in ms of the earliest candle to fetch
+         *
+         * EXCHANGE SPECIFIC PARAMETERS
+         * @param {string} params.timeZone default=0 (UTC)
+         * @returns {int[][]} A list of candles ordered as timestamp, open, high, low, close, volume
+         */
+        await this.loadMarkets();
+        this.checkIsSpot('fetchOHLCVWs', symbol, params);
+        const url = this.urls['api']['ws']['ws'];
+        const requestId = this.requestId(url);
+        const messageHash = requestId.toString();
+        let returnRateLimits = false;
+        [returnRateLimits, params] = this.handleOptionAndParams(params, 'fetchOHLCVWs', 'returnRateLimits', false);
+        const payload = {
+            'symbol': this.marketId(symbol),
+            'returnRateLimits': returnRateLimits,
+            'interval': this.timeframes[timeframe],
+        };
+        const until = this.safeInteger(params, 'until');
+        params = this.omit(params, 'until');
+        if (since !== undefined) {
+            payload['startTime'] = since;
+        }
+        if (limit !== undefined) {
+            payload['limit'] = limit;
+        }
+        if (until !== undefined) {
+            payload['endTime'] = until;
+        }
+        const message = {
+            'id': messageHash,
+            'method': 'klines',
+            'params': this.extend(payload, params),
+        };
+        const subscription = {
+            'method': this.handleFetchOHLCV,
+        };
+        return await this.watch(url, messageHash, message, messageHash, subscription);
+    }
+    handleFetchOHLCV(client, message) {
+        //
+        //    {
+        //        "id": "1dbbeb56-8eea-466a-8f6e-86bdcfa2fc0b",
+        //        "status": 200,
+        //        "result": [
+        //            [
+        //                1655971200000,      // Kline open time
+        //                "0.01086000",       // Open price
+        //                "0.01086600",       // High price
+        //                "0.01083600",       // Low price
+        //                "0.01083800",       // Close price
+        //                "2290.53800000",    // Volume
+        //                1655974799999,      // Kline close time
+        //                "24.85074442",      // Quote asset volume
+        //                2283,               // Number of trades
+        //                "1171.64000000",    // Taker buy base asset volume
+        //                "12.71225884",      // Taker buy quote asset volume
+        //                "0"                 // Unused field, ignore
+        //            ]
+        //        ],
+        //        "rateLimits": [
+        //            {
+        //                "rateLimitType": "REQUEST_WEIGHT",
+        //                "interval": "MINUTE",
+        //                "intervalNum": 1,
+        //                "limit": 6000,
+        //                "count": 2
+        //            }
+        //        ]
+        //    }
+        //
+        const result = this.safeList(message, 'result');
+        const parsed = this.parseOHLCVs(result);
+        // use a reverse lookup in a static map instead
+        const messageHash = this.safeString(message, 'id');
+        client.resolve(parsed, messageHash);
+    }
     async watchTicker(symbol, params = {}) {
         /**
          * @method
@@ -2541,12 +2631,58 @@ export default class binance extends binanceRest {
         const trades = await this.watch(url, messageHash, message, messageHash, subscription);
         return this.filterBySymbolSinceLimit(trades, symbol, since, limit);
     }
+    async fetchTradesWs(symbol = undefined, since = undefined, limit = undefined, params = {}) {
+        /**
+         * @method
+         * @name binance#fetchTradesWs
+         * @see https://binance-docs.github.io/apidocs/websocket_api/en/#recent-trades
+         * @description fetch all trades made by the user
+         * @param {string} symbol unified market symbol
+         * @param {int} [since] the earliest time in ms to fetch trades for
+         * @param {int} [limit] the maximum number of trades structures to retrieve, default=500, max=1000
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         *
+         * EXCHANGE SPECIFIC PARAMETERS
+         * @param {int} [params.fromId] trade ID to begin at
+         * @returns {object[]} a list of [trade structures]{@link https://docs.ccxt.com/#/?id=trade-structure}
+         */
+        await this.loadMarkets();
+        if (symbol === undefined) {
+            throw new BadRequest(this.id + ' fetchTradesWs () requires a symbol argument');
+        }
+        this.checkIsSpot('fetchTradesWs', symbol, params);
+        const url = this.urls['api']['ws']['ws'];
+        const requestId = this.requestId(url);
+        const messageHash = requestId.toString();
+        let returnRateLimits = false;
+        [returnRateLimits, params] = this.handleOptionAndParams(params, 'fetchTradesWs', 'returnRateLimits', false);
+        const payload = {
+            'symbol': this.marketId(symbol),
+            'returnRateLimits': returnRateLimits,
+        };
+        if (limit !== undefined) {
+            payload['limit'] = limit;
+        }
+        const message = {
+            'id': messageHash,
+            'method': 'trades.historical',
+            'params': this.extend(payload, params),
+        };
+        const subscription = {
+            'method': this.handleTradesWs,
+        };
+        const trades = await this.watch(url, messageHash, message, messageHash, subscription);
+        return this.filterBySinceLimit(trades, since, limit);
+    }
     handleTradesWs(client, message) {
+        //
+        // fetchMyTradesWs
         //
         //    {
         //        "id": "f4ce6a53-a29d-4f70-823b-4ab59391d6e8",
         //        "status": 200,
-        //        "result": [{
+        //        "result": [
+        //            {
         //                "symbol": "BTCUSDT",
         //                "id": 1650422481,
         //                "orderId": 12569099453,
@@ -2565,6 +2701,25 @@ export default class binance extends binanceRest {
         //        ],
         //    }
         //
+        // fetchTradesWs
+        //
+        //    {
+        //        "id": "f4ce6a53-a29d-4f70-823b-4ab59391d6e8",
+        //        "status": 200,
+        //        "result": [
+        //            {
+        //                "id": 0,
+        //                "price": "0.00005000",
+        //                "qty": "40.00000000",
+        //                "quoteQty": "0.00200000",
+        //                "time": 1500004800376,
+        //                "isBuyerMaker": true,
+        //                "isBestMatch": true
+        //            }
+        //            ...
+        //        ],
+        //    }
+        //
         const messageHash = this.safeString(message, 'id');
         const result = this.safeValue(message, 'result', []);
         const trades = this.parseTrades(result);

package/js/src/pro/bingx.js

@@ -8,7 +8,7 @@
 import bingxRest from '../bingx.js';
 import { BadRequest, NetworkError } from '../base/errors.js';
 import { ArrayCache, ArrayCacheByTimestamp, ArrayCacheBySymbolById } from '../base/ws/Cache.js';
-import Precise from '../base/Precise.js';
+import { Precise } from '../base/Precise.js';
 //  ---------------------------------------------------------------------------
 export default class bingx extends bingxRest {
     describe() {

package/js/src/pro/bitfinex2.js

@@ -323,7 +323,9 @@ export default class bitfinex2 extends bitfinex2Rest {
         const messageLength = message.length;
         if (messageLength === 2) {
             // initial snapshot
-            const trades = this.safeValue(message, 1, []);
+            let trades = this.safeList(message, 1, []);
+            // needs to be reversed to make chronological order
+            trades = trades.reverse();
             for (let i = 0; i < trades.length; i++) {
                 const parsed = this.parseWsTrade(trades[i], market);
                 stored.append(parsed);

package/js/src/pro/bitvavo.js

@@ -105,7 +105,7 @@ export default class bitvavo extends bitvavoRest {
         //                 "volume": "3587.05020246",
         //                 "volumeQuote": "708030.17",
         //                 "bid": "199.56",
-        //                 "bidSize": "4.14730803",
+        //                 "bidSize": "4.14730802",
         //                 "ask": "199.57",
         //                 "askSize": "6.13642074",
         //                 "timestamp": 1590770885217

package/js/src/pro/blockchaincom.d.ts

@@ -21,7 +21,6 @@ export default class blockchaincom extends blockchaincomRest {
     handleOrderBook(client: Client, message: any): void;
     handleDelta(bookside: any, delta: any): void;
     handleDeltas(bookside: any, deltas: any): void;
-    checkSequenceNumber(client: Client, message: any): void;
     handleMessage(client: Client, message: any): void;
     handleAuthenticationMessage(client: Client, message: any): void;
     authenticate(params?: {}): Promise<any>;

package/js/src/pro/blockchaincom.js

@@ -37,7 +37,6 @@ export default class blockchaincom extends blockchaincomRest {
                     },
                     'noOriginHeader': false,
                 },
-                'sequenceNumbers': {},
             },
             'streaming': {},
             'exceptions': {},
@@ -681,21 +680,20 @@ export default class blockchaincom extends blockchaincomRest {
         //     }
         //
         const event = this.safeString(message, 'event');
+        if (event === 'subscribed') {
+            return;
+        }
         const type = this.safeString(message, 'channel');
         const marketId = this.safeString(message, 'symbol');
         const symbol = this.safeSymbol(marketId);
         const messageHash = 'orderbook:' + symbol + ':' + type;
         const datetime = this.safeString(message, 'timestamp');
         const timestamp = this.parse8601(datetime);
-        let orderbook = this.safeValue(this.orderbooks, symbol);
-        if (orderbook === undefined) {
-            orderbook = this.countedOrderBook({});
-            this.orderbooks[symbol] = orderbook;
-        }
-        if (event === 'subscribed') {
-            return;
+        if (this.safeValue(this.orderbooks, symbol) === undefined) {
+            this.orderbooks[symbol] = this.countedOrderBook();
         }
-        else if (event === 'snapshot') {
+        const orderbook = this.orderbooks[symbol];
+        if (event === 'snapshot') {
             const snapshot = this.parseOrderBook(message, symbol, timestamp, 'bids', 'asks', 'px', 'qty', 'num');
             orderbook.reset(snapshot);
         }
@@ -721,23 +719,7 @@ export default class blockchaincom extends blockchaincomRest {
             this.handleDelta(bookside, deltas[i]);
         }
     }
-    checkSequenceNumber(client, message) {
-        const seqnum = this.safeInteger(message, 'seqnum', 0);
-        const channel = this.safeString(message, 'channel', '');
-        const sequenceNumbersByChannel = this.safeValue(this.options, 'sequenceNumbers', {});
-        const lastSeqnum = this.safeInteger(sequenceNumbersByChannel, channel);
-        if (lastSeqnum === undefined) {
-            this.options['sequenceNumbers'][channel] = seqnum;
-        }
-        else {
-            if (seqnum !== lastSeqnum + 1) {
-                throw new ExchangeError(this.id + ' ' + channel + ' seqnum ' + seqnum + ' is not the expected ' + (lastSeqnum + 1));
-            }
-            this.options['sequenceNumbers'][channel] = seqnum;
-        }
-    }
     handleMessage(client, message) {
-        this.checkSequenceNumber(client, message);
         const channel = this.safeString(message, 'channel');
         const handlers = {
             'ticker': this.handleTicker,

package/js/src/pro/deribit.js

@@ -180,7 +180,7 @@ export default class deribit extends deribitRest {
         //         "params": {
         //             "channel": "ticker.BTC_USDC-PERPETUAL.raw",
         //             "data": {
-        //                 "timestamp": 1655393725041,
+        //                 "timestamp": 1655393725040,
         //                 "stats": [Object],
         //                 "state": "open",
         //                 "settlement_price": 21729.5891,
@@ -663,7 +663,7 @@ export default class deribit extends deribitRest {
         const symbol = this.safeSymbol(marketId);
         const ohlcv = this.safeValue(params, 'data', {});
         const parsed = [
-            this.safeNumber(ohlcv, 'tick'),
+            this.safeInteger(ohlcv, 'tick'),
             this.safeNumber(ohlcv, 'open'),
             this.safeNumber(ohlcv, 'high'),
             this.safeNumber(ohlcv, 'low'),

package/js/src/pro/gate.js

@@ -386,8 +386,9 @@ export default class gate extends gateRest {
         const parts = channel.split('.');
         const rawMarketType = this.safeString(parts, 0);
         const marketType = (rawMarketType === 'futures') ? 'contract' : 'spot';
+        const result = this.safeValue(message, 'result');
         let results = [];
-        if (marketType === 'contract') {
+        if (Array.isArray(result)) {
             results = this.safeList(message, 'result', []);
         }
         else {

package/js/src/pro/gemini.js

@@ -206,7 +206,7 @@ export default class gemini extends geminiRest {
         //                 "time_ms": 1655323185000,
         //                 "result": "failure",
         //                 "highest_bid_price": "21661.90",
-        //                 "lowest_ask_price": "21663.79",
+        //                 "lowest_ask_price": "21663.78",
         //                 "collar_price": "21662.845"
         //             },
         //         ]

package/js/src/pro/okx.js

@@ -910,9 +910,6 @@ export default class okx extends okxRest {
          * @param {object} params extra parameters specific to the exchange API endpoint
          * @returns {object[]} a list of [position structure]{@link https://docs.ccxt.com/en/latest/manual.html#position-structure}
          */
-        if (this.isEmpty(symbols)) {
-            throw new ArgumentsRequired(this.id + ' watchPositions requires a list of symbols');
-        }
         await this.loadMarkets();
         await this.authenticate(params);
         symbols = this.marketSymbols(symbols);
@@ -920,7 +917,23 @@ export default class okx extends okxRest {
             'instType': 'ANY',
         };
         const channel = 'positions';
-        const newPositions = await this.subscribeMultiple('private', channel, symbols, this.extend(request, params));
+        let newPositions = undefined;
+        if (symbols === undefined) {
+            const arg = {
+                'channel': 'positions',
+                'instType': 'ANY',
+            };
+            const args = [arg];
+            const nonSymbolRequest = {
+                'op': 'subscribe',
+                'args': args,
+            };
+            const url = this.getUrl(channel, 'private');
+            newPositions = await this.watch(url, channel, nonSymbolRequest, channel);
+        }
+        else {
+            newPositions = await this.subscribeMultiple('private', channel, symbols, this.extend(request, params));
+        }
         if (this.newUpdates) {
             return newPositions;
         }
@@ -1018,6 +1031,7 @@ export default class okx extends okxRest {
                 client.resolve(positions, messageHash);
             }
         }
+        client.resolve(newPositions, channel);
     }
     async watchOrders(symbol = undefined, since = undefined, limit = undefined, params = {}) {
         /**

package/js/src/woo.js

@@ -6,7 +6,7 @@
 
 // ---------------------------------------------------------------------------
 import Exchange from './abstract/woo.js';
-import { AuthenticationError, RateLimitExceeded, BadRequest, ExchangeError, InvalidOrder, ArgumentsRequired, NotSupported } from './base/errors.js';
+import { AuthenticationError, RateLimitExceeded, BadRequest, ExchangeError, InvalidOrder, ArgumentsRequired, NotSupported, OnMaintenance } from './base/errors.js';
 import { Precise } from './base/Precise.js';
 import { TICK_SIZE } from './base/functions/number.js';
 import { sha256 } from './static_dependencies/noble-hashes/sha256.js';
@@ -298,7 +298,6 @@ export default class woo extends Exchange {
                     '-1007': BadRequest,
                     '-1008': InvalidOrder,
                     '-1009': BadRequest,
-                    '-1011': ExchangeError,
                     '-1012': BadRequest,
                     '-1101': InvalidOrder,
                     '-1102': InvalidOrder,
@@ -307,6 +306,8 @@ export default class woo extends Exchange {
                     '-1105': InvalidOrder, // { "code": -1105,  "message": "Price is X% too high or X% too low from the mid price." }
                 },
                 'broad': {
+                    'Can not place': ExchangeError,
+                    'maintenance': OnMaintenance,
                     'symbol must not be blank': BadRequest,
                     'The token is not supported': BadRequest,
                     'Your order and symbol are not valid or already canceled': BadRequest,
@@ -2383,6 +2384,7 @@ export default class woo extends Exchange {
         }
         //
         //     400 Bad Request {"success":false,"code":-1012,"message":"Amount is required for buy market orders when margin disabled."}
+        //                     {"code":"-1011","message":"The system is under maintenance.","success":false}
         //
         const success = this.safeValue(response, 'success');
         const errorCode = this.safeString(response, 'code');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.2.51",
+  "version": "4.2.53",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",
@@ -35,6 +35,7 @@
     "force-build": "npm run pre-transpile && npm run force-transpile-fast && npm run csharp && npm run post-transpile && npm run update-badges",
     "build-docs": "node jsdoc2md.js && node examples2md.js",
     "serve-docs": "docsify serve ./wiki",
+    "tsBuildFile": "tsc --skipLibCheck --strictNullChecks false --strict --noImplicitAny false --esModuleInterop --isolatedModules false --forceConsistentCasingInFileNames --removeComments false --target ES2020 --declaration --allowJs --checkJs false --moduleResolution Node --module ES2022 --outDir ./js/src --lib ES2020.BigInt --lib dom ",
     "tsBuild": "tsc || true",
     "tsBuildExamples": "tsc -p ./examples/tsconfig.json",
     "emitAPI": "node build/generateImplicitAPI.js",

package/skip-tests.json

@@ -48,6 +48,18 @@
             "fetchTickers": {
                 "bid":"broken bid-ask",
                 "ask":"broken bid-ask"
+            },
+            "fetchOrderBook": {
+                "spread": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269129438#L3841"
+            },
+            "fetchL2OrderBook": {
+                "spread": "same"
+            },
+            "watchOrderBook": {
+                "spread": "same" 
+            },
+            "watchOrderBookForSymbols": {
+                "spread": "same"
             }
         }
     },
@@ -199,7 +211,6 @@
         }
     },
     "bitfinex2": {
-        "skipWs": true,
         "skipMethods": {
             "loadMarkets": {
                 "currencyIdAndCode": "broken currencies"
@@ -208,9 +219,18 @@
                 "withdraw": "not provided",
                 "deposit": "not provided"
             },
-            "fetchOrderBook": "multiple bids might have same value",
-            "fetchL2OrderBook": "same",
-            "fetchTickers": "negative values"
+            "fetchOrderBook": {
+                "bid": "multiple bids might have same value"
+            },
+            "fetchL2OrderBook": {
+                "bid": "same"
+            },
+            "watchOrderBook": {
+                "bid": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269129438#L3999"  
+            },
+            "watchOrderBookForSymbols": {
+                "bid": "same"  
+            }
         }
     },
     "bitflyer": {
@@ -371,7 +391,6 @@
         }
     },
     "bitrue": {
-        "skipWs": true,
         "skipMethods": {
             "loadMarkets": {
                 "currencyIdAndCode": "broken currencies",
@@ -391,15 +410,19 @@
         }
     },
     "bitso": {
+        "skipWs": true,
         "skipMethods": {
             "loadMarkets": {
                 "active": "not provided"
             },
+            "fetchOrderBook": "https://app.travis-ci.com/github/ccxt/ccxt/builds/269129438#L4148",
             "fetchOHLCV": "randomly failing with 404 not found"
         }
     },
+    "bitforex": {
+        "skipWs": true
+    },
     "bitstamp": {
-        "skipWs": true,
         "skipMethods": {
             "fetchOrderBook": "bid/ask might be 0",
             "fetchL2OrderBook": "same",
@@ -450,9 +473,6 @@
         }
     },
     "bitvavo": {
-        "skip": "temp",
-        "skipWs": "temp",
-        "httpsProxy": "http://51.83.140.52:11230",
         "skipMethods": {
             "fetchCurrencies": {
                 "precision": "not provided",
@@ -471,7 +491,6 @@
         }
     },
     "blockchaincom": {
-        "skipWs": "https://app.travis-ci.com/github/ccxt/ccxt/builds/265225134#L2304",
         "skipMethods": {
             "loadMarkets": {
                 "taker":"not provided",
@@ -765,7 +784,6 @@
         }
     },
     "cryptocom": {
-        "skipWs": "timeout",
         "skipMethods": {
             "proxies": "probably they do not permit our proxy",
             "loadMarkets": {
@@ -849,7 +867,6 @@
         }
     },
     "deribit": {
-        "skipWs": "timeouts",
         "skipMethods": {
             "fetchCurrencies": "deposit/withdraw not provided",
             "loadMarkets": "strike is set when option is not true",
@@ -896,7 +913,6 @@
         }
     },
     "gemini": {
-        "skipWs": "temporary",
         "skipMethods": {
             "loadMarkets": {
                 "currencyIdAndCode": "messed codes",

package/dist/cjs/src/abstract/bitforex.js

@@ -1,9 +0,0 @@
-'use strict';
-
-var Exchange$1 = require('../base/Exchange.js');
-
-// -------------------------------------------------------------------------------
-class Exchange extends Exchange$1["default"] {
-}
-
-module.exports = Exchange;