ccxt 4.2.47 → 4.2.49

package/js/src/upbit.js

@@ -44,6 +44,7 @@ export default class upbit extends Exchange {
                 'fetchBalance': true,
                 'fetchCanceledOrders': true,
                 'fetchClosedOrders': true,
+                'fetchDeposit': true,
                 'fetchDepositAddress': true,
                 'fetchDepositAddresses': true,
                 'fetchDeposits': true,
@@ -71,6 +72,7 @@ export default class upbit extends Exchange {
                 'fetchTradingFee': true,
                 'fetchTradingFees': false,
                 'fetchTransactions': false,
+                'fetchWithdrawal': true,
                 'fetchWithdrawals': true,
                 'transfer': false,
                 'withdraw': true,
@@ -1028,6 +1030,7 @@ export default class upbit extends Exchange {
          * @name upbit#createOrder
          * @description create a trade order
          * @see https://docs.upbit.com/reference/%EC%A3%BC%EB%AC%B8%ED%95%98%EA%B8%B0
+         * @see https://global-docs.upbit.com/reference/order
          * @param {string} symbol unified symbol of the market to create an order in
          * @param {string} type 'market' or 'limit'
          * @param {string} side 'buy' or 'sell'
@@ -1035,6 +1038,7 @@ export default class upbit extends Exchange {
          * @param {float} [price] the price at which the order is to be fullfilled, in units of the quote currency, ignored in market orders
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @param {float} [params.cost] for market buy orders, the quote quantity that can be used as an alternative for the amount
+         * @param {string} [params.timeInForce] 'IOC' or 'FOK'
          * @returns {object} an [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
          */
         await this.loadMarkets();
@@ -1091,6 +1095,13 @@ export default class upbit extends Exchange {
         if (clientOrderId !== undefined) {
             request['identifier'] = clientOrderId;
         }
+        if (type !== 'market') {
+            const timeInForce = this.safeStringLower2(params, 'timeInForce', 'time_in_force');
+            params = this.omit(params, 'timeInForce');
+            if (timeInForce !== undefined) {
+                request['time_in_force'] = timeInForce;
+            }
+        }
         params = this.omit(params, ['clientOrderId', 'identifier']);
         const response = await this.privatePostOrders(this.extend(request, params));
         //
@@ -1196,6 +1207,45 @@ export default class upbit extends Exchange {
         //
         return this.parseTransactions(response, currency, since, limit);
     }
+    async fetchDeposit(id, code = undefined, params = {}) {
+        /**
+         * @method
+         * @name upbit#fetchDeposit
+         * @description fetch information on a deposit
+         * @see https://global-docs.upbit.com/reference/individual-deposit-inquiry
+         * @param {string} id the unique id for the deposit
+         * @param {string} [code] unified currency code of the currency deposited
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @param {string} [params.txid] withdrawal transaction id, the id argument is reserved for uuid
+         * @returns {object} a [transaction structure]{@link https://docs.ccxt.com/#/?id=transaction-structure}
+         */
+        await this.loadMarkets();
+        const request = {
+            'uuid': id,
+        };
+        let currency = undefined;
+        if (code !== undefined) {
+            currency = this.currency(code);
+            request['currency'] = currency['id'];
+        }
+        const response = await this.privateGetDeposit(this.extend(request, params));
+        //
+        //     {
+        //         "type": "deposit",
+        //         "uuid": "7f54527e-2eee-4268-860e-fd8b9d7fe3c7",
+        //         "currency": "ADA",
+        //         "net_type": "ADA",
+        //         "txid": "99795bbfeca91eaa071068bb659b33eeb65d8aaff2551fdf7c78f345d188952b",
+        //         "state": "ACCEPTED",
+        //         "created_at": "2023-12-12T04:58:41Z",
+        //         "done_at": "2023-12-12T05:31:50Z",
+        //         "amount": "35.72344",
+        //         "fee": "0.0",
+        //         "transaction_type": "default"
+        //     }
+        //
+        return this.parseTransaction(response, currency);
+    }
     async fetchWithdrawals(code = undefined, since = undefined, limit = undefined, params = {}) {
         /**
          * @method
@@ -1240,13 +1290,52 @@ export default class upbit extends Exchange {
         //
         return this.parseTransactions(response, currency, since, limit);
     }
+    async fetchWithdrawal(id, code = undefined, params = {}) {
+        /**
+         * @method
+         * @name upbit#fetchWithdrawal
+         * @description fetch data on a currency withdrawal via the withdrawal id
+         * @see https://global-docs.upbit.com/reference/individual-withdrawal-inquiry
+         * @param {string} id the unique id for the withdrawal
+         * @param {string} [code] unified currency code of the currency withdrawn
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @param {string} [params.txid] withdrawal transaction id, the id argument is reserved for uuid
+         * @returns {object} a [transaction structure]{@link https://docs.ccxt.com/#/?id=transaction-structure}
+         */
+        await this.loadMarkets();
+        const request = {
+            'uuid': id,
+        };
+        let currency = undefined;
+        if (code !== undefined) {
+            currency = this.currency(code);
+            request['currency'] = currency['id'];
+        }
+        const response = await this.privateGetWithdraw(this.extend(request, params));
+        //
+        //     {
+        //         "type": "withdraw",
+        //         "uuid": "95ef274b-23a6-4de4-95b0-5cbef4ca658f",
+        //         "currency": "ADA",
+        //         "net_type": "ADA",
+        //         "txid": "b1528f149297a71671b86636f731f8fdb0ff53da0f1d8c19093d59df96f34583",
+        //         "state": "DONE",
+        //         "created_at": "2023-12-14T02:46:52Z",
+        //         "done_at": "2023-12-14T03:10:11Z",
+        //         "amount": "35.22344",
+        //         "fee": "0.5",
+        //         "transaction_type": "default"
+        //     }
+        //
+        return this.parseTransaction(response, currency);
+    }
     parseTransactionStatus(status) {
         const statuses = {
             'submitting': 'pending',
             'submitted': 'pending',
             'almost_accepted': 'pending',
             'rejected': 'failed',
-            'accepted': 'pending',
+            'accepted': 'ok',
             'processing': 'pending',
             'done': 'ok',
             'canceled': 'canceled', // 취소됨
@@ -1255,7 +1344,7 @@ export default class upbit extends Exchange {
     }
     parseTransaction(transaction, currency = undefined) {
         //
-        // fetchDeposits
+        // fetchDeposits, fetchDeposit
         //
         //     {
         //         "type": "deposit",
@@ -1269,7 +1358,7 @@ export default class upbit extends Exchange {
         //         "fee": "0.0"
         //     }
         //
-        // fetchWithdrawals
+        // fetchWithdrawals, fetchWithdrawal
         //
         //     {
         //         "type": "withdraw",
@@ -1284,27 +1373,21 @@ export default class upbit extends Exchange {
         //         "krw_amount": "80420.0"
         //     }
         //
-        const id = this.safeString(transaction, 'uuid');
-        const amount = this.safeNumber(transaction, 'amount');
         const address = undefined; // not present in the data structure received from the exchange
         const tag = undefined; // not present in the data structure received from the exchange
-        const txid = this.safeString(transaction, 'txid');
         const updatedRaw = this.safeString(transaction, 'done_at');
-        const updated = this.parse8601(updatedRaw);
         const timestamp = this.parse8601(this.safeString(transaction, 'created_at', updatedRaw));
         let type = this.safeString(transaction, 'type');
         if (type === 'withdraw') {
             type = 'withdrawal';
         }
         const currencyId = this.safeString(transaction, 'currency');
-        const code = this.safeCurrencyCode(currencyId);
-        const status = this.parseTransactionStatus(this.safeStringLower(transaction, 'state'));
-        const feeCost = this.safeNumber(transaction, 'fee');
+        const code = this.safeCurrencyCode(currencyId, currency);
         return {
             'info': transaction,
-            'id': id,
+            'id': this.safeString(transaction, 'uuid'),
             'currency': code,
-            'amount': amount,
+            'amount': this.safeNumber(transaction, 'amount'),
             'network': undefined,
             'address': address,
             'addressTo': undefined,
@@ -1312,17 +1395,17 @@ export default class upbit extends Exchange {
             'tag': tag,
             'tagTo': undefined,
             'tagFrom': undefined,
-            'status': status,
+            'status': this.parseTransactionStatus(this.safeStringLower(transaction, 'state')),
             'type': type,
-            'updated': updated,
-            'txid': txid,
+            'updated': this.parse8601(updatedRaw),
+            'txid': this.safeString(transaction, 'txid'),
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
             'internal': undefined,
             'comment': undefined,
             'fee': {
                 'currency': code,
-                'cost': feeCost,
+                'cost': this.safeNumber(transaction, 'fee'),
             },
         };
     }
@@ -1802,7 +1885,7 @@ export default class upbit extends Exchange {
         }
         if (api === 'private') {
             this.checkRequiredCredentials();
-            const nonce = this.nonce();
+            const nonce = this.uuid();
             const request = {
                 'access_key': this.apiKey,
                 'nonce': nonce,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.2.47",
+  "version": "4.2.49",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",
@@ -56,6 +56,8 @@
     "test-py-ws": "node run-tests --ws --python --useProxy",
     "test-php": "node run-tests --php --useProxy",
     "test-php-ws": "node run-tests --ws --php --useProxy",
+    "test-csharp": "npm run commonjs-test && node run-tests --csharp --useProxy",
+    "test-csharp-ws": "node run-tests --ws --csharp --useProxy",
     "test-js-base": "node ./js/src/test/base/test.base.js",
     "test-js-base-ws": "npm run test-js-cache && npm run test-js-orderbook",
     "test-python-base": "python3 python/ccxt/test/base/test_number.py && python3 python/ccxt/test/base/test_crypto.py",

package/skip-tests.json

@@ -1,7 +1,6 @@
 {
     "ace": {
         "skip": "temp",
-        "skipWs": true,
         "skipMethods": {
             "loadMarkets": {
                 "currencyIdAndCode": "temporary skip, because ids are numeric and we are in wip for numeric id tests",
@@ -22,7 +21,6 @@
         "skipWs": "private endpoints"
     },
     "ascendex": {
-        "skipWs": "unknown https://app.travis-ci.com/github/ccxt/ccxt/builds/267900037#L2416",
         "skipMethods": {
             "loadMarkets": {
                 "currencyIdAndCode": "broken currencies"
@@ -35,6 +33,10 @@
                 "low":"16 Aug - happened weird negative 24hr low",
                 "bid":"messed bid-ask",
                 "ask":"messed bid-ask"
+            },
+            "watchOrderBook": {
+                "bid":"messed bid-ask",
+                "ask":"messed bid-ask"
             }
         }
     },