ccxt 4.2.47 → 4.2.48

package/dist/cjs/ccxt.js

@@ -177,7 +177,7 @@ var woo$1 = require('./src/pro/woo.js');
 
 //-----------------------------------------------------------------------------
 // this is updated by vss.js when building
-const version = '4.2.47';
+const version = '4.2.48';
 Exchange["default"].ccxtVersion = version;
 const exchanges = {
     'ace': ace,

package/dist/cjs/src/binance.js

@@ -5771,12 +5771,14 @@ class binance extends binance$1 {
         const trailingDelta = this.safeString(params, 'trailingDelta');
         const trailingTriggerPrice = this.safeString2(params, 'trailingTriggerPrice', 'activationPrice', this.numberToString(price));
         const trailingPercent = this.safeString2(params, 'trailingPercent', 'callbackRate');
+        const priceMatch = this.safeString(params, 'priceMatch');
         const isTrailingPercentOrder = trailingPercent !== undefined;
         const isStopLoss = stopLossPrice !== undefined || trailingDelta !== undefined;
         const isTakeProfit = takeProfitPrice !== undefined;
         const isTriggerOrder = triggerPrice !== undefined;
         const isConditional = isTriggerOrder || isTrailingPercentOrder || isStopLoss || isTakeProfit;
         const isPortfolioMarginConditional = (isPortfolioMargin && isConditional);
+        const isPriceMatch = priceMatch !== undefined;
         let uppercaseType = type.toUpperCase();
         let stopPrice = undefined;
         if (isTrailingPercentOrder) {
@@ -5957,7 +5959,7 @@ class binance extends binance$1 {
                 request['quantity'] = this.amountToPrecision(symbol, amount);
             }
         }
-        if (priceIsRequired) {
+        if (priceIsRequired && !isPriceMatch) {
             if (price === undefined) {
                 throw new errors.InvalidOrder(this.id + ' createOrder() requires a price argument for a ' + type + ' order');
             }

package/dist/cjs/src/idex.js

@@ -81,8 +81,10 @@ class idex extends idex$1 {
                 'fetchPositions': false,
                 'fetchPositionsRisk': false,
                 'fetchPremiumIndexOHLCV': false,
+                'fetchStatus': true,
                 'fetchTicker': true,
                 'fetchTickers': true,
+                'fetchTime': true,
                 'fetchTrades': true,
                 'fetchTradingFee': false,
                 'fetchTradingFees': true,
@@ -196,6 +198,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchMarkets
          * @description retrieves data on all markets for idex
+         * @see https://api-docs-v3.idex.io/#get-markets
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object[]} an array of objects representing market data
          */
@@ -326,6 +329,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchTicker
          * @description fetches a price ticker, a statistical calculation with the information calculated over the past 24 hours for a specific market
+         * @see https://api-docs-v3.idex.io/#get-tickers
          * @param {string} symbol unified symbol of the market to fetch the ticker for
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a [ticker structure]{@link https://docs.ccxt.com/#/?id=ticker-structure}
@@ -362,6 +366,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchTickers
          * @description fetches price tickers for multiple markets, statistical information calculated over the past 24 hours for each market
+         * @see https://api-docs-v3.idex.io/#get-tickers
          * @param {string[]|undefined} symbols unified symbols of the markets to fetch the ticker for, all market tickers are returned if not assigned
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a dictionary of [ticker structures]{@link https://docs.ccxt.com/#/?id=ticker-structure}
@@ -438,6 +443,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchOHLCV
          * @description fetches historical candlestick data containing the open, high, low, and close price, and the volume of a market
+         * @see https://api-docs-v3.idex.io/#get-candles
          * @param {string} symbol unified symbol of the market to fetch OHLCV data for
          * @param {string} timeframe the length of time each candle represents
          * @param {int} [since] timestamp in ms of the earliest candle to fetch
@@ -500,6 +506,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchTrades
          * @description get the list of most recent trades for a particular symbol
+         * @see https://api-docs-v3.idex.io/#get-trades
          * @param {string} symbol unified symbol of the market to fetch trades for
          * @param {int} [since] timestamp in ms of the earliest trade to fetch
          * @param {int} [limit] the maximum amount of trades to fetch
@@ -613,6 +620,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchTradingFees
          * @description fetch the trading fees for multiple markets
+         * @see https://api-docs-v3.idex.io/#get-api-account
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a dictionary of [fee structures]{@link https://docs.ccxt.com/#/?id=fee-structure} indexed by market symbols
          */
@@ -658,6 +666,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchOrderBook
          * @description fetches information on open orders with bid (buy) and ask (sell) prices, volumes and other data
+         * @see https://api-docs-v3.idex.io/#get-order-books
          * @param {string} symbol unified symbol of the market to fetch the order book for
          * @param {int} [limit] the maximum amount of order book entries to return
          * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -721,6 +730,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchCurrencies
          * @description fetches all available currencies on an exchange
+         * @see https://api-docs-v3.idex.io/#get-assets
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} an associative dictionary of currencies
          */
@@ -786,6 +796,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchBalance
          * @description query for balance and get the amount of funds available for trading or funds locked in orders
+         * @see https://api-docs-v3.idex.io/#get-balances
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a [balance structure]{@link https://docs.ccxt.com/#/?id=balance-structure}
          */
@@ -830,6 +841,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchMyTrades
          * @description fetch all trades made by the user
+         * @see https://api-docs-v3.idex.io/#get-fills
          * @param {string} symbol unified market symbol
          * @param {int} [since] the earliest time in ms to fetch trades for
          * @param {int} [limit] the maximum number of trades structures to retrieve
@@ -898,6 +910,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchOrder
          * @description fetches information on an order made by the user
+         * @see https://api-docs-v3.idex.io/#get-orders
          * @param {string} symbol unified symbol of the market the order was made in
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} An [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
@@ -912,6 +925,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchOpenOrders
          * @description fetch all unfilled currently open orders
+         * @see https://api-docs-v3.idex.io/#get-orders
          * @param {string} symbol unified market symbol
          * @param {int} [since] the earliest time in ms to fetch open orders for
          * @param {int} [limit] the maximum number of  open orders structures to retrieve
@@ -928,6 +942,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchClosedOrders
          * @description fetches information on multiple closed orders made by the user
+         * @see https://api-docs-v3.idex.io/#get-orders
          * @param {string} symbol unified market symbol of the market orders were made in
          * @param {int} [since] the earliest time in ms to fetch orders for
          * @param {int} [limit] the maximum number of order structures to retrieve
@@ -1139,16 +1154,20 @@ class idex extends idex$1 {
          * @method
          * @name idex#createOrder
          * @description create a trade order, https://docs.idex.io/#create-order
+         * @see https://api-docs-v3.idex.io/#create-order
          * @param {string} symbol unified symbol of the market to create an order in
          * @param {string} type 'market' or 'limit'
          * @param {string} side 'buy' or 'sell'
          * @param {float} amount how much of currency you want to trade in units of base currency
          * @param {float} [price] the price at which the order is to be fullfilled, in units of the quote currency, ignored in market orders
          * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @param {bool} [params.test] set to true to test an order, no order will be created but the request will be validated
          * @returns {object} an [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
          */
         this.checkRequiredCredentials();
         await this.loadMarkets();
+        const testOrder = this.safeBool(params, 'test', false);
+        params = this.omit(params, 'test');
         const market = this.market(symbol);
         const nonce = this.uuidv1();
         let typeEnum = undefined;
@@ -1329,7 +1348,13 @@ class idex extends idex$1 {
         //   "avgExecutionPrice": "0.09905990"
         // }
         // we don't use extend here because it is a signed endpoint
-        const response = await this.privatePostOrders(request);
+        let response = undefined;
+        if (testOrder) {
+            response = await this.privatePostOrdersTest(request);
+        }
+        else {
+            response = await this.privatePostOrders(request);
+        }
         return this.parseOrder(response, market);
     }
     async withdraw(code, amount, address, tag = undefined, params = {}) {
@@ -1337,6 +1362,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#withdraw
          * @description make a withdrawal
+         * @see https://api-docs-v3.idex.io/#withdraw-funds
          * @param {string} code unified currency code
          * @param {float} amount the amount to withdraw
          * @param {string} address the address to withdraw to
@@ -1390,6 +1416,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#cancelAllOrders
          * @description cancel all open orders
+         * @see https://api-docs-v3.idex.io/#cancel-order
          * @param {string} symbol unified market symbol, only orders in the market of this symbol are cancelled when symbol is not undefined
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object[]} a list of [order structures]{@link https://docs.ccxt.com/#/?id=order-structure}
@@ -1429,6 +1456,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#cancelOrder
          * @description cancels an open order
+         * @see https://api-docs-v3.idex.io/#cancel-order
          * @param {string} id order id
          * @param {string} symbol unified symbol of the market the order was made in
          * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -1480,6 +1508,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchDeposit
          * @description fetch information on a deposit
+         * @see https://api-docs-v3.idex.io/#get-deposits
          * @param {string} id deposit id
          * @param {string} code not used by idex fetchDeposit ()
          * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -1500,6 +1529,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchDeposits
          * @description fetch all deposits made to an account
+         * @see https://api-docs-v3.idex.io/#get-deposits
          * @param {string} code unified currency code
          * @param {int} [since] the earliest time in ms to fetch deposits for
          * @param {int} [limit] the maximum number of deposits structures to retrieve
@@ -1511,11 +1541,30 @@ class idex extends idex$1 {
         }, params);
         return await this.fetchTransactionsHelper(code, since, limit, params);
     }
+    async fetchStatus(params = {}) {
+        /**
+         * @method
+         * @name idex#fetchStatus
+         * @description the latest known information on the availability of the exchange API
+         * @see https://api-docs-v3.idex.io/#get-ping
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @returns {object} a [status structure]{@link https://docs.ccxt.com/#/?id=exchange-status-structure}
+         */
+        const response = await this.publicGetPing(params);
+        return {
+            'status': 'ok',
+            'updated': undefined,
+            'eta': undefined,
+            'url': undefined,
+            'info': response,
+        };
+    }
     async fetchTime(params = {}) {
         /**
          * @method
          * @name idex#fetchTime
          * @description fetches the current integer timestamp in milliseconds from the exchange server
+         * @see https://api-docs-v3.idex.io/#get-time
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {int} the current integer timestamp in milliseconds from the exchange server
          */
@@ -1530,6 +1579,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchWithdrawal
          * @description fetch data on a currency withdrawal via the withdrawal id
+         * @see https://api-docs-v3.idex.io/#get-withdrawals
          * @param {string} id withdrawal id
          * @param {string} code not used by idex.fetchWithdrawal
          * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -1550,6 +1600,7 @@ class idex extends idex$1 {
          * @method
          * @name idex#fetchWithdrawals
          * @description fetch all withdrawals made from an account
+         * @see https://api-docs-v3.idex.io/#get-withdrawals
          * @param {string} code unified currency code
          * @param {int} [since] the earliest time in ms to fetch withdrawals for
          * @param {int} [limit] the maximum number of withdrawals structures to retrieve

package/dist/cjs/src/indodax.js

@@ -97,7 +97,7 @@ class indodax extends indodax$1 {
             'urls': {
                 'logo': 'https://user-images.githubusercontent.com/51840849/87070508-9358c880-c221-11ea-8dc5-5391afbbb422.jpg',
                 'api': {
-                    'public': 'https://indodax.com/api',
+                    'public': 'https://indodax.com',
                     'private': 'https://indodax.com/tapi',
                 },
                 'www': 'https://www.indodax.com',
@@ -107,14 +107,15 @@ class indodax extends indodax$1 {
             'api': {
                 'public': {
                     'get': {
-                        'server_time': 5,
-                        'pairs': 5,
-                        'price_increments': 5,
-                        'summaries': 5,
-                        'ticker_all': 5,
-                        '{pair}/ticker': 5,
-                        '{pair}/trades': 5,
-                        '{pair}/depth': 5,
+                        'api/server_time': 5,
+                        'api/pairs': 5,
+                        'api/price_increments': 5,
+                        'api/summaries': 5,
+                        'api/ticker/{pair}': 5,
+                        'api/ticker_all': 5,
+                        'api/trades/{pair}': 5,
+                        'api/depth/{pair}': 5,
+                        'tradingview/history_v2': 5,
                     },
                 },
                 'private': {
@@ -179,6 +180,16 @@ class indodax extends indodax$1 {
                     // 'ETH': 'eth'
                     // 'BASE': 'base'
                 },
+                'timeframes': {
+                    '1m': '1',
+                    '15m': '15',
+                    '30m': '30',
+                    '1h': '60',
+                    '4h': '240',
+                    '1d': '1D',
+                    '3d': '3D',
+                    '1w': '1W',
+                },
             },
             'commonCurrencies': {
                 'STR': 'XLM',
@@ -198,10 +209,11 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchTime
          * @description fetches the current integer timestamp in milliseconds from the exchange server
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Public-RestAPI.md#server-time
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {int} the current integer timestamp in milliseconds from the exchange server
          */
-        const response = await this.publicGetServerTime(params);
+        const response = await this.publicGetApiServerTime(params);
         //
         //     {
         //         "timezone": "UTC",
@@ -215,10 +227,11 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchMarkets
          * @description retrieves data on all markets for indodax
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Public-RestAPI.md#pairs
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object[]} an array of objects representing market data
          */
-        const response = await this.publicGetPairs(params);
+        const response = await this.publicGetApiPairs(params);
         //
         //     [
         //         {
@@ -335,6 +348,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchBalance
          * @description query for balance and get the amount of funds available for trading or funds locked in orders
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#get-info-endpoint
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a [balance structure]{@link https://docs.ccxt.com/#/?id=balance-structure}
          */
@@ -377,6 +391,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchOrderBook
          * @description fetches information on open orders with bid (buy) and ask (sell) prices, volumes and other data
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Public-RestAPI.md#depth
          * @param {string} symbol unified symbol of the market to fetch the order book for
          * @param {int} [limit] the maximum amount of order book entries to return
          * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -385,9 +400,9 @@ class indodax extends indodax$1 {
         await this.loadMarkets();
         const market = this.market(symbol);
         const request = {
-            'pair': market['id'],
+            'pair': market['base'] + market['quote'],
         };
-        const orderbook = await this.publicGetPairDepth(this.extend(request, params));
+        const orderbook = await this.publicGetApiDepthPair(this.extend(request, params));
         return this.parseOrderBook(orderbook, market['symbol'], undefined, 'buy', 'sell');
     }
     parseTicker(ticker, market = undefined) {
@@ -436,6 +451,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchTicker
          * @description fetches a price ticker, a statistical calculation with the information calculated over the past 24 hours for a specific market
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Public-RestAPI.md#ticker
          * @param {string} symbol unified symbol of the market to fetch the ticker for
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a [ticker structure]{@link https://docs.ccxt.com/#/?id=ticker-structure}
@@ -443,9 +459,9 @@ class indodax extends indodax$1 {
         await this.loadMarkets();
         const market = this.market(symbol);
         const request = {
-            'pair': market['id'],
+            'pair': market['base'] + market['quote'],
         };
-        const response = await this.publicGetPairTicker(this.extend(request, params));
+        const response = await this.publicGetApiTickerPair(this.extend(request, params));
         //
         //     {
         //         "ticker": {
@@ -490,7 +506,7 @@ class indodax extends indodax$1 {
         //     }
         // }
         //
-        const response = await this.publicGetTickerAll(params);
+        const response = await this.publicGetApiTickerAll(params);
         const tickers = this.safeValue(response, 'tickers');
         return this.parseTickers(tickers, symbols);
     }
@@ -517,6 +533,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchTrades
          * @description get the list of most recent trades for a particular symbol
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Public-RestAPI.md#trades
          * @param {string} symbol unified symbol of the market to fetch trades for
          * @param {int} [since] timestamp in ms of the earliest trade to fetch
          * @param {int} [limit] the maximum amount of trades to fetch
@@ -526,11 +543,81 @@ class indodax extends indodax$1 {
         await this.loadMarkets();
         const market = this.market(symbol);
         const request = {
-            'pair': market['id'],
+            'pair': market['base'] + market['quote'],
         };
-        const response = await this.publicGetPairTrades(this.extend(request, params));
+        const response = await this.publicGetApiTradesPair(this.extend(request, params));
         return this.parseTrades(response, market, since, limit);
     }
+    parseOHLCV(ohlcv, market = undefined) {
+        //
+        //     {
+        //         "Time": 1708416900,
+        //         "Open": 51707.52,
+        //         "High": 51707.52,
+        //         "Low": 51707.52,
+        //         "Close": 51707.52,
+        //         "Volume": "0"
+        //     }
+        //
+        return [
+            this.safeTimestamp(ohlcv, 'Time'),
+            this.safeNumber(ohlcv, 'Open'),
+            this.safeNumber(ohlcv, 'High'),
+            this.safeNumber(ohlcv, 'Low'),
+            this.safeNumber(ohlcv, 'Close'),
+            this.safeNumber(ohlcv, 'Volume'),
+        ];
+    }
+    async fetchOHLCV(symbol, timeframe = '1m', since = undefined, limit = undefined, params = {}) {
+        /**
+         * @method
+         * @name indodax#fetchOHLCV
+         * @description fetches historical candlestick data containing the open, high, low, and close price, and the volume of a market
+         * @param {string} symbol unified symbol of the market to fetch OHLCV data for
+         * @param {string} timeframe the length of time each candle represents
+         * @param {int} [since] timestamp in ms of the earliest candle to fetch
+         * @param {int} [limit] the maximum amount of candles to fetch
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @param {int} [params.until] timestamp in ms of the latest candle to fetch
+         * @returns {int[][]} A list of candles ordered as timestamp, open, high, low, close, volume
+         */
+        await this.loadMarkets();
+        const market = this.market(symbol);
+        const timeframes = this.options['timeframes'];
+        const selectedTimeframe = this.safeString(timeframes, timeframe, timeframe);
+        const now = this.seconds();
+        const until = this.safeInteger2(params, 'until', 'till', now);
+        params = this.omit(params, ['until', 'till']);
+        const request = {
+            'to': until,
+            'tf': selectedTimeframe,
+            'symbol': market['base'] + market['quote'],
+        };
+        if (limit === undefined) {
+            limit = 1000;
+        }
+        if (since !== undefined) {
+            request['from'] = Math.floor(since / 1000);
+        }
+        else {
+            const duration = this.parseTimeframe(timeframe);
+            request['from'] = now - limit * duration - 1;
+        }
+        const response = await this.publicGetTradingviewHistoryV2(this.extend(request, params));
+        //
+        //     [
+        //         {
+        //             "Time": 1708416900,
+        //             "Open": 51707.52,
+        //             "High": 51707.52,
+        //             "Low": 51707.52,
+        //             "Close": 51707.52,
+        //             "Volume": "0"
+        //         }
+        //     ]
+        //
+        return this.parseOHLCVs(response, market, timeframe, since, limit);
+    }
     parseOrderStatus(status) {
         const statuses = {
             'open': 'open',
@@ -622,6 +709,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchOrder
          * @description fetches information on an order made by the user
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#get-order-endpoints
          * @param {string} symbol unified symbol of the market the order was made in
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} An [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
@@ -646,6 +734,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchOpenOrders
          * @description fetch all unfilled currently open orders
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#open-orders-endpoints
          * @param {string} symbol unified market symbol
          * @param {int} [since] the earliest time in ms to fetch open orders for
          * @param {int} [limit] the maximum number of  open orders structures to retrieve
@@ -686,6 +775,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchClosedOrders
          * @description fetches information on multiple closed orders made by the user
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#order-history
          * @param {string} symbol unified market symbol of the market orders were made in
          * @param {int} [since] the earliest time in ms to fetch orders for
          * @param {int} [limit] the maximum number of order structures to retrieve
@@ -710,6 +800,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#createOrder
          * @description create a trade order
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#trade-endpoints
          * @param {string} symbol unified symbol of the market to create an order in
          * @param {string} type 'market' or 'limit'
          * @param {string} side 'buy' or 'sell'
@@ -749,6 +840,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#cancelOrder
          * @description cancels an open order
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#cancel-order-endpoints
          * @param {string} id order id
          * @param {string} symbol unified symbol of the market the order was made in
          * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -775,6 +867,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchTransactionFee
          * @description fetch the fee for a transaction
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#withdraw-fee-endpoints
          * @param {string} code unified currency code
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a [fee structure]{@link https://docs.ccxt.com/#/?id=fee-structure}
@@ -808,6 +901,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchDepositsWithdrawals
          * @description fetch history of deposits and withdrawals
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#transaction-history-endpoints
          * @param {string} [code] unified currency code for the currency of the deposit/withdrawals, default is undefined
          * @param {int} [since] timestamp in ms of the earliest deposit/withdrawal, default is undefined
          * @param {int} [limit] max number of deposit/withdrawals to return, default is undefined
@@ -909,6 +1003,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#withdraw
          * @description make a withdrawal
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#withdraw-coin-endpoints
          * @param {string} code unified currency code
          * @param {float} amount the amount to withdraw
          * @param {string} address the address to withdraw to
@@ -1042,6 +1137,7 @@ class indodax extends indodax$1 {
          * @method
          * @name indodax#fetchDepositAddresses
          * @description fetch deposit addresses for multiple currencies and chain types
+         * @see https://github.com/btcid/indodax-official-api-docs/blob/master/Private-RestAPI.md#general-information-on-endpoints
          * @param {string[]} [codes] list of unified currency codes, default is undefined
          * @param {object} [params] extra parameters specific to the exchange API endpoint
          * @returns {object} a list of [address structures]{@link https://docs.ccxt.com/#/?id=address-structure}
@@ -1124,7 +1220,12 @@ class indodax extends indodax$1 {
     sign(path, api = 'public', method = 'GET', params = {}, headers = undefined, body = undefined) {
         let url = this.urls['api'][api];
         if (api === 'public') {
-            url += '/' + this.implodeParams(path, params);
+            const query = this.omit(params, this.extractParams(path));
+            const requestPath = '/' + this.implodeParams(path, params);
+            url = url + requestPath;
+            if (Object.keys(query).length) {
+                url += '?' + this.urlencodeWithArrayRepeat(query);
+            }
         }
         else {
             this.checkRequiredCredentials();

package/dist/cjs/src/okx.js

@@ -5228,6 +5228,7 @@ class okx extends okx$1 {
          * @method
          * @name okx#fetchPositions
          * @see https://www.okx.com/docs-v5/en/#rest-api-account-get-positions
+         * @see https://www.okx.com/docs-v5/en/#trading-account-rest-api-get-positions-history history
          * @description fetch all open positions
          * @param {string[]|undefined} symbols list of unified market symbols
          * @param {object} [params] extra parameters specific to the exchange API endpoint
@@ -5368,13 +5369,38 @@ class okx extends okx$1 {
         //        "vegaBS": "",
         //        "vegaPA": ""
         //    }
+        // history
+        //    {
+        //        "cTime":"1708351230102",
+        //        "ccy":"USDT",
+        //        "closeAvgPx":"1.2567",
+        //        "closeTotalPos":"40",
+        //        "direction":"short",
+        //        "fee":"-0.0351036",
+        //        "fundingFee":"0",
+        //        "instId":"SUSHI-USDT-SWAP",
+        //        "instType":"SWAP",
+        //        "lever":"10.0",
+        //        "liqPenalty":"0",
+        //        "mgnMode":"isolated",
+        //        "openAvgPx":"1.2462",
+        //        "openMaxPos":"40",
+        //        "pnl":"-0.42",
+        //        "pnlRatio":"-0.0912982667308618",
+        //        "posId":"666159086676836352",
+        //        "realizedPnl":"-0.4551036",
+        //        "triggerPx":"",
+        //        "type":"2",
+        //        "uTime":"1708354805699",
+        //        "uly":"SUSHI-USDT"
+        //    }
         //
         const marketId = this.safeString(position, 'instId');
         market = this.safeMarket(marketId, market);
         const symbol = market['symbol'];
         const pos = this.safeString(position, 'pos'); // 'pos' field: One way mode: 0 if position is not open, 1 if open | Two way (hedge) mode: -1 if short, 1 if long, 0 if position is not open
         const contractsAbs = Precise["default"].stringAbs(pos);
-        let side = this.safeString(position, 'posSide');
+        let side = this.safeString2(position, 'posSide', 'direction');
         const hedged = side !== 'net';
         const contracts = this.parseNumber(contractsAbs);
         if (market['margin']) {
@@ -5415,7 +5441,7 @@ class okx extends okx$1 {
         const notional = this.parseNumber(notionalString);
         const marginMode = this.safeString(position, 'mgnMode');
         let initialMarginString = undefined;
-        const entryPriceString = this.safeString(position, 'avgPx');
+        const entryPriceString = this.safeString2(position, 'avgPx', 'openAvgPx');
         const unrealizedPnlString = this.safeString(position, 'upl');
         const leverageString = this.safeString(position, 'lever');
         let initialMarginPercentage = undefined;
@@ -5446,23 +5472,24 @@ class okx extends okx$1 {
         const marginRatio = this.parseNumber(Precise["default"].stringDiv(maintenanceMarginString, collateralString, 4));
         return this.safePosition({
             'info': position,
-            'id': undefined,
+            'id': this.safeString(position, 'posId'),
             'symbol': symbol,
             'notional': notional,
             'marginMode': marginMode,
             'liquidationPrice': liquidationPrice,
             'entryPrice': this.parseNumber(entryPriceString),
             'unrealizedPnl': this.parseNumber(unrealizedPnlString),
+            'realizedPnl': this.safeNumber(position, 'realizedPnl'),
             'percentage': percentage,
             'contracts': contracts,
             'contractSize': contractSize,
             'markPrice': this.parseNumber(markPriceString),
-            'lastPrice': undefined,
+            'lastPrice': this.safeNumber(position, 'closeAvgPx'),
             'side': side,
             'hedged': hedged,
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
-            'lastUpdateTimestamp': undefined,
+            'lastUpdateTimestamp': this.safeInteger(position, 'uTime'),
             'maintenanceMargin': maintenanceMargin,
             'maintenanceMarginPercentage': maintenanceMarginPercentage,
             'collateral': this.parseNumber(collateralString),