ccxt 4.2.45 → 4.2.47

package/js/src/indodax.js

@@ -49,6 +49,9 @@ export default class indodax extends Exchange {
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
                 'fetchDeposit': false,
+                'fetchDepositAddress': 'emulated',
+                'fetchDepositAddresses': true,
+                'fetchDepositAddressesByNetwork': false,
                 'fetchDeposits': false,
                 'fetchDepositsWithdrawals': true,
                 'fetchFundingHistory': false,
@@ -160,7 +163,25 @@ export default class indodax extends Exchange {
             'options': {
                 'recvWindow': 5 * 1000,
                 'timeDifference': 0,
-                'adjustForTimeDifference': false, // controls the adjustment logic upon instantiation
+                'adjustForTimeDifference': false,
+                'networks': {
+                    'XLM': 'Stellar Token',
+                    'BSC': 'bep20',
+                    'TRC20': 'trc20',
+                    'MATIC': 'polygon',
+                    // 'BEP2': 'bep2',
+                    // 'ARB': 'arb',
+                    // 'ERC20': 'erc20',
+                    // 'KIP7': 'kip7',
+                    // 'MAINNET': 'mainnet',  // TODO: does mainnet just mean the default?
+                    // 'OEP4': 'oep4',
+                    // 'OP': 'op',
+                    // 'SPL': 'spl',
+                    // 'TRC10': 'trc10',
+                    // 'ZRC2': 'zrc2'
+                    // 'ETH': 'eth'
+                    // 'BASE': 'base'
+                },
             },
             'commonCurrencies': {
                 'STR': 'XLM',
@@ -1019,6 +1040,90 @@ export default class indodax extends Exchange {
         };
         return this.safeString(statuses, status, status);
     }
+    async fetchDepositAddresses(codes = undefined, params = {}) {
+        /**
+         * @method
+         * @name indodax#fetchDepositAddresses
+         * @description fetch deposit addresses for multiple currencies and chain types
+         * @param {string[]} [codes] list of unified currency codes, default is undefined
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @returns {object} a list of [address structures]{@link https://docs.ccxt.com/#/?id=address-structure}
+         */
+        await this.loadMarkets();
+        const response = await this.privatePostGetInfo(params);
+        //
+        //    {
+        //        success: '1',
+        //        return: {
+        //            server_time: '1708031570',
+        //            balance: {
+        //                idr: '29952',
+        //                ...
+        //            },
+        //            balance_hold: {
+        //                idr: '0',
+        //                ...
+        //            },
+        //            address: {
+        //                btc: '1KMntgzvU7iTSgMBWc11nVuJjAyfW3qJyk',
+        //                ...
+        //            },
+        //            memo_is_required: {
+        //                btc: { mainnet: false },
+        //                ...
+        //            },
+        //            network: {
+        //                btc: 'mainnet',
+        //                ...
+        //            },
+        //            user_id: '276011',
+        //            name: '',
+        //            email: 'testbitcoincoid@mailforspam.com',
+        //            profile_picture: null,
+        //            verification_status: 'unverified',
+        //            gauth_enable: true,
+        //            withdraw_status: '0'
+        //        }
+        //    }
+        //
+        const data = this.safeDict(response, 'return');
+        const addresses = this.safeDict(data, 'address', {});
+        const networks = this.safeDict(data, 'network', {});
+        const addressKeys = Object.keys(addresses);
+        const result = {
+            'info': data,
+        };
+        for (let i = 0; i < addressKeys.length; i++) {
+            const marketId = addressKeys[i];
+            const code = this.safeCurrencyCode(marketId);
+            const address = this.safeString(addresses, marketId);
+            if ((address !== undefined) && ((codes === undefined) || (this.inArray(code, codes)))) {
+                this.checkAddress(address);
+                let network = undefined;
+                if (marketId in networks) {
+                    const networkId = this.safeString(networks, marketId);
+                    if (networkId.indexOf(',') >= 0) {
+                        network = [];
+                        const networkIds = networkId.split(',');
+                        for (let j = 0; j < networkIds.length; j++) {
+                            network.push(this.networkIdToCode(networkIds[j]).toUpperCase());
+                        }
+                    }
+                    else {
+                        network = this.networkIdToCode(networkId).toUpperCase();
+                    }
+                }
+                result[code] = {
+                    'info': {},
+                    'currency': code,
+                    'address': address,
+                    'network': network,
+                    'tag': undefined,
+                };
+            }
+        }
+        return result;
+    }
     sign(path, api = 'public', method = 'GET', params = {}, headers = undefined, body = undefined) {
         let url = this.urls['api'][api];
         if (api === 'public') {

package/js/src/latoken.js

@@ -44,6 +44,9 @@ export default class latoken extends Exchange {
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
                 'fetchCurrencies': true,
+                'fetchDepositAddress': false,
+                'fetchDepositAddresses': false,
+                'fetchDepositAddressesByNetwork': false,
                 'fetchDepositsWithdrawals': true,
                 'fetchDepositWithdrawFees': false,
                 'fetchIsolatedBorrowRate': false,

package/js/src/mercado.js

@@ -43,6 +43,9 @@ export default class mercado extends Exchange {
                 'fetchBorrowRateHistory': false,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchDepositAddress': false,
+                'fetchDepositAddresses': false,
+                'fetchDepositAddressesByNetwork': false,
                 'fetchFundingHistory': false,
                 'fetchFundingRate': false,
                 'fetchFundingRateHistory': false,

package/js/src/oceanex.js

@@ -50,6 +50,9 @@ export default class oceanex extends Exchange {
                 'fetchClosedOrders': true,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchDepositAddress': false,
+                'fetchDepositAddresses': false,
+                'fetchDepositAddressesByNetwork': false,
                 'fetchIsolatedBorrowRate': false,
                 'fetchIsolatedBorrowRates': false,
                 'fetchMarkets': true,

package/js/src/okx.js

@@ -447,6 +447,7 @@ export default class okx extends Exchange {
                         'account/quick-margin-borrow-repay': 4,
                         'account/borrow-repay': 5 / 3,
                         'account/simulated_margin': 10,
+                        'account/position-builder': 10,
                         'account/set-riskOffset-type': 2,
                         'account/activate-option': 4,
                         'account/set-auto-loan': 4,

package/js/src/pro/bitget.js

@@ -521,13 +521,15 @@ export default class bitget extends bitgetRest {
         const rawOrderBook = this.safeValue(data, 0);
         const timestamp = this.safeInteger(rawOrderBook, 'ts');
         const incrementalBook = channel === 'books';
-        let storedOrderBook = undefined;
         if (incrementalBook) {
-            storedOrderBook = this.safeValue(this.orderbooks, symbol);
-            if (storedOrderBook === undefined) {
-                storedOrderBook = this.countedOrderBook({});
-                storedOrderBook['symbol'] = symbol;
+            // storedOrderBook = this.safeValue (this.orderbooks, symbol);
+            if (!(symbol in this.orderbooks)) {
+                // const ob = this.orderBook ({});
+                const ob = this.countedOrderBook({});
+                ob['symbol'] = symbol;
+                this.orderbooks[symbol] = ob;
             }
+            const storedOrderBook = this.orderbooks[symbol];
             const asks = this.safeValue(rawOrderBook, 'asks', []);
             const bids = this.safeValue(rawOrderBook, 'bids', []);
             this.handleDeltas(storedOrderBook['asks'], asks);
@@ -562,10 +564,12 @@ export default class bitget extends bitgetRest {
             }
         }
         else {
-            storedOrderBook = this.parseOrderBook(rawOrderBook, symbol, timestamp);
+            const orderbook = this.orderBook({});
+            const parsedOrderbook = this.parseOrderBook(rawOrderBook, symbol, timestamp);
+            orderbook.reset(parsedOrderbook);
+            this.orderbooks[symbol] = orderbook;
         }
-        this.orderbooks[symbol] = storedOrderBook;
-        client.resolve(storedOrderBook, messageHash);
+        client.resolve(this.orderbooks[symbol], messageHash);
     }
     handleDelta(bookside, delta) {
         const bidAsk = this.parseBidAsk(delta, 0, 1);

package/js/src/pro/bitmart.js

@@ -1320,13 +1320,13 @@ export default class bitmart extends bitmartRest {
                 const update = datas[i];
                 const marketId = this.safeString(update, 'symbol');
                 const symbol = this.safeSymbol(marketId);
-                let orderbook = this.safeDict(this.orderbooks, symbol);
-                if (orderbook === undefined) {
-                    orderbook = this.orderBook({}, limit);
-                    orderbook['symbol'] = symbol;
-                    this.orderbooks[symbol] = orderbook;
+                if (!(symbol in this.orderbooks)) {
+                    const ob = this.orderBook({}, limit);
+                    ob['symbol'] = symbol;
+                    this.orderbooks[symbol] = ob;
                 }
-                const type = this.safeValue(update, 'type');
+                const orderbook = this.orderbooks[symbol];
+                const type = this.safeString(update, 'type');
                 if ((type === 'snapshot') || (!(channelName.indexOf('increase') >= 0))) {
                     orderbook.reset({});
                 }
@@ -1350,12 +1350,12 @@ export default class bitmart extends bitmartRest {
             const depths = data['depths'];
             const marketId = this.safeString(data, 'symbol');
             const symbol = this.safeSymbol(marketId);
-            let orderbook = this.safeDict(this.orderbooks, symbol);
-            if (orderbook === undefined) {
-                orderbook = this.orderBook({}, limit);
-                orderbook['symbol'] = symbol;
-                this.orderbooks[symbol] = orderbook;
+            if (!(symbol in this.orderbooks)) {
+                const ob = this.orderBook({}, limit);
+                ob['symbol'] = symbol;
+                this.orderbooks[symbol] = ob;
             }
+            const orderbook = this.orderbooks[symbol];
             const way = this.safeNumber(data, 'way');
             const side = (way === 1) ? 'bids' : 'asks';
             if (way === 1) {

package/js/src/pro/bitmex.js

@@ -351,11 +351,11 @@ export default class bitmex extends bitmexRest {
             const market = this.safeMarket(marketId);
             const symbol = market['symbol'];
             const messageHash = table + ':' + marketId;
-            let ticker = this.safeDict(this.tickers, symbol, {});
+            const ticker = this.safeDict(this.tickers, symbol, {});
             const info = this.safeDict(ticker, 'info', {});
-            ticker = this.parseTicker(this.extend(info, update), market);
-            tickers[symbol] = ticker;
-            this.tickers[symbol] = ticker;
+            const parsedTicker = this.parseTicker(this.extend(info, update), market);
+            tickers[symbol] = parsedTicker;
+            this.tickers[symbol] = parsedTicker;
             client.resolve(ticker, messageHash);
         }
         client.resolve(tickers, 'instrument');

package/js/src/pro/cex.js

@@ -174,7 +174,7 @@ export default class cex extends cexRest {
             stored.append(parsed);
         }
         const messageHash = 'trades';
-        this.trades = stored;
+        this.trades = stored; // trades don't have symbol
         client.resolve(this.trades, messageHash);
     }
     parseWsOldTrade(trade, market = undefined) {
@@ -218,7 +218,7 @@ export default class cex extends cexRest {
         //     }
         //
         const data = this.safeValue(message, 'data', []);
-        const stored = this.trades;
+        const stored = this.trades; // to do fix this, this.trades is not meant to be used like this
         for (let i = 0; i < data.length; i++) {
             const rawTrade = data[i];
             const parsed = this.parseWsOldTrade(rawTrade);

package/js/src/pro/gemini.js

@@ -463,10 +463,11 @@ export default class gemini extends geminiRest {
         const market = this.safeMarket(marketId.toLowerCase());
         const symbol = market['symbol'];
         const messageHash = 'orderbook:' + symbol;
-        let orderbook = this.safeDict(this.orderbooks, symbol);
-        if (orderbook === undefined) {
-            orderbook = this.orderBook();
+        if (!(symbol in this.orderbooks)) {
+            const ob = this.orderBook();
+            this.orderbooks[symbol] = ob;
         }
+        const orderbook = this.orderbooks[symbol];
         const bids = orderbook['bids'];
         const asks = orderbook['asks'];
         for (let i = 0; i < rawOrderBookChanges.length; i++) {

package/js/src/timex.d.ts

@@ -67,6 +67,20 @@ export default class timex extends Exchange {
     parseTrade(trade: any, market?: Market): Trade;
     parseOHLCV(ohlcv: any, market?: Market): OHLCV;
     parseOrder(order: any, market?: Market): Order;
+    fetchDepositAddress(code: string, params?: {}): Promise<{
+        info: any;
+        currency: string;
+        address: string;
+        tag: any;
+        network: any;
+    }>;
+    parseDepositAddress(depositAddress: any, currency?: Currency): {
+        info: any;
+        currency: string;
+        address: string;
+        tag: any;
+        network: any;
+    };
     sign(path: any, api?: string, method?: string, params?: {}, headers?: any, body?: any): {
         url: string;
         method: string;

package/js/src/timex.js

@@ -44,6 +44,9 @@ export default class timex extends Exchange {
                 'fetchCrossBorrowRates': false,
                 'fetchCurrencies': true,
                 'fetchDeposit': false,
+                'fetchDepositAddress': true,
+                'fetchDepositAddresses': false,
+                'fetchDepositAddressesByNetwork': false,
                 'fetchDeposits': true,
                 'fetchFundingHistory': false,
                 'fetchFundingRate': false,
@@ -1524,7 +1527,69 @@ export default class timex extends Exchange {
             'trades': rawTrades,
         }, market);
     }
+    async fetchDepositAddress(code, params = {}) {
+        /**
+         * @method
+         * @name timex#fetchDepositAddress
+         * @description fetch the deposit address for a currency associated with this account, does not accept params["network"]
+         * @param {string} code unified currency code
+         * @param {object} [params] extra parameters specific to the exchange API endpoint
+         * @returns {object} an [address structure]{@link https://docs.ccxt.com/#/?id=address-structure}
+         */
+        await this.loadMarkets();
+        const currency = this.currency(code);
+        const request = {
+            'symbol': currency['code'],
+        };
+        const response = await this.currenciesGetSSymbol(this.extend(request, params));
+        //
+        //    {
+        //        id: '1',
+        //        currency: {
+        //            symbol: 'BTC',
+        //            name: 'Bitcoin',
+        //            address: '0x8370fbc6ddec1e18b4e41e72ed943e238458487c',
+        //            decimals: '8',
+        //            tradeDecimals: '20',
+        //            fiatSymbol: 'BTC',
+        //            depositEnabled: true,
+        //            withdrawalEnabled: true,
+        //            transferEnabled: true,
+        //            active: true
+        //        }
+        //    }
+        //
+        const data = this.safeDict(response, 'currency', {});
+        return this.parseDepositAddress(data, currency);
+    }
+    parseDepositAddress(depositAddress, currency = undefined) {
+        //
+        //    {
+        //        symbol: 'BTC',
+        //        name: 'Bitcoin',
+        //        address: '0x8370fbc6ddec1e18b4e41e72ed943e238458487c',
+        //        decimals: '8',
+        //        tradeDecimals: '20',
+        //        fiatSymbol: 'BTC',
+        //        depositEnabled: true,
+        //        withdrawalEnabled: true,
+        //        transferEnabled: true,
+        //        active: true
+        //    }
+        //
+        const currencyId = this.safeString(depositAddress, 'symbol');
+        return {
+            'info': depositAddress,
+            'currency': this.safeCurrencyCode(currencyId, currency),
+            'address': this.safeString(depositAddress, 'address'),
+            'tag': undefined,
+            'network': undefined,
+        };
+    }
     sign(path, api = 'public', method = 'GET', params = {}, headers = undefined, body = undefined) {
+        const paramsToExtract = this.extractParams(path);
+        path = this.implodeParams(path, params);
+        params = this.omit(params, paramsToExtract);
         let url = this.urls['api']['rest'] + '/' + api + '/' + path;
         if (Object.keys(params).length) {
             url += '?' + this.urlencodeWithArrayRepeat(params);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.2.45",
+  "version": "4.2.47",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",

package/skip-tests.json

@@ -356,6 +356,8 @@
         }
     },
     "onetrading": {
+        "skip": true,
+        "until": "2024-02-28",
         "skipWs": true,
         "skipMethods": {
             "fetchOrderBook": "some bid might be lower than next bid",
@@ -707,6 +709,8 @@
         }
     },
     "coinsph": {
+        "skip": true,
+        "until": "2024-02-20",
         "skipMethods": {
             "loadMarkets": {
                 "taker":"messed",