ccxt 4.2.31 → 4.2.34

package/js/src/pro/bitfinex.js

@@ -135,7 +135,6 @@ export default class bitfinex extends bitfinexRest {
             stored.append(trade);
         }
         client.resolve(stored, messageHash);
-        return message;
     }
     parseTrade(trade, market = undefined) {
         //
@@ -325,8 +324,9 @@ export default class bitfinex extends bitfinexRest {
                     const delta = deltas[i];
                     const id = this.safeString(delta, 0);
                     const price = this.safeFloat(delta, 1);
-                    const size = (delta[2] < 0) ? -delta[2] : delta[2];
-                    const side = (delta[2] < 0) ? 'asks' : 'bids';
+                    const delta2Value = delta[2];
+                    const size = (delta2Value < 0) ? -delta2Value : delta2Value;
+                    const side = (delta2Value < 0) ? 'asks' : 'bids';
                     const bookside = orderbook[side];
                     bookside.store(price, size, id);
                 }
@@ -335,10 +335,11 @@ export default class bitfinex extends bitfinexRest {
                 const deltas = message[1];
                 for (let i = 0; i < deltas.length; i++) {
                     const delta = deltas[i];
-                    const size = (delta[2] < 0) ? -delta[2] : delta[2];
-                    const side = (delta[2] < 0) ? 'asks' : 'bids';
-                    const bookside = orderbook[side];
-                    bookside.store(delta[0], size, delta[1]);
+                    const delta2 = delta[2];
+                    const size = (delta2 < 0) ? -delta2 : delta2;
+                    const side = (delta2 < 0) ? 'asks' : 'bids';
+                    const countedBookSide = orderbook[side];
+                    countedBookSide.store(delta[0], size, delta[1]);
                 }
             }
             client.resolve(orderbook, messageHash);
@@ -348,18 +349,20 @@ export default class bitfinex extends bitfinexRest {
             if (isRaw) {
                 const id = this.safeString(message, 1);
                 const price = this.safeString(message, 2);
-                const size = (message[3] < 0) ? -message[3] : message[3];
-                const side = (message[3] < 0) ? 'asks' : 'bids';
+                const message3 = message[3];
+                const size = (message3 < 0) ? -message3 : message3;
+                const side = (message3 < 0) ? 'asks' : 'bids';
                 const bookside = orderbook[side];
                 // price = 0 means that you have to remove the order from your book
                 const amount = Precise.stringGt(price, '0') ? size : '0';
                 bookside.store(this.parseNumber(price), this.parseNumber(amount), id);
             }
             else {
-                const size = (message[3] < 0) ? -message[3] : message[3];
-                const side = (message[3] < 0) ? 'asks' : 'bids';
-                const bookside = orderbook[side];
-                bookside.store(message[1], size, message[2]);
+                const message3Value = message[3];
+                const size = (message3Value < 0) ? -message3Value : message3Value;
+                const side = (message3Value < 0) ? 'asks' : 'bids';
+                const countedBookSide = orderbook[side];
+                countedBookSide.store(message[1], size, message[2]);
             }
             client.resolve(orderbook, messageHash);
         }
@@ -620,7 +623,7 @@ export default class bitfinex extends bitfinexRest {
             //     ]
             //
             if (message[1] === 'hb') {
-                return message; // skip heartbeats within subscription channels for now
+                return; // skip heartbeats within subscription channels for now
             }
             const subscription = this.safeValue(client.subscriptions, channelId, {});
             const channel = this.safeString(subscription, 'channel');
@@ -635,11 +638,8 @@ export default class bitfinex extends bitfinexRest {
                 'oc': this.handleOrders,
             };
             const method = this.safeValue2(methods, channel, name);
-            if (method === undefined) {
-                return message;
-            }
-            else {
-                return method.call(this, client, message, subscription);
+            if (method !== undefined) {
+                method.call(this, client, message, subscription);
             }
         }
         else {
@@ -661,11 +661,8 @@ export default class bitfinex extends bitfinexRest {
                     'auth': this.handleAuthenticationMessage,
                 };
                 const method = this.safeValue(methods, event);
-                if (method === undefined) {
-                    return message;
-                }
-                else {
-                    return method.call(this, client, message);
+                if (method !== undefined) {
+                    method.call(this, client, message);
                 }
             }
         }

package/js/src/pro/bitfinex2.d.ts

@@ -11,7 +11,7 @@ export default class bitfinex2 extends bitfinex2Rest {
     watchMyTrades(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Trade[]>;
     watchTicker(symbol: string, params?: {}): Promise<Ticker>;
     handleMyTrade(client: Client, message: any, subscription?: {}): void;
-    handleTrades(client: Client, message: any, subscription: any): any;
+    handleTrades(client: Client, message: any, subscription: any): void;
     parseWsTrade(trade: any, market?: any): Trade;
     handleTicker(client: Client, message: any, subscription: any): void;
     parseWsTicker(ticker: any, market?: any): Ticker;
@@ -29,5 +29,5 @@ export default class bitfinex2 extends bitfinex2Rest {
     handleOrders(client: Client, message: any, subscription: any): void;
     parseWsOrderStatus(status: any): string;
     parseWsOrder(order: any, market?: any): Order;
-    handleMessage(client: Client, message: any): any;
+    handleMessage(client: Client, message: any): void;
 }

package/js/src/pro/bitfinex2.js

@@ -342,7 +342,6 @@ export default class bitfinex2 extends bitfinex2Rest {
             stored.append(parsed);
         }
         client.resolve(stored, messageHash);
-        return message;
     }
     parseWsTrade(trade, market = undefined) {
         //
@@ -594,8 +593,9 @@ export default class bitfinex2 extends bitfinex2Rest {
                 const deltas = message[1];
                 for (let i = 0; i < deltas.length; i++) {
                     const delta = deltas[i];
-                    const size = (delta[2] < 0) ? -delta[2] : delta[2];
-                    const side = (delta[2] < 0) ? 'asks' : 'bids';
+                    const delta2 = delta[2];
+                    const size = (delta2 < 0) ? -delta2 : delta2;
+                    const side = (delta2 < 0) ? 'asks' : 'bids';
                     const bookside = orderbook[side];
                     const idString = this.safeString(delta, 0);
                     const price = this.safeFloat(delta, 1);
@@ -623,8 +623,9 @@ export default class bitfinex2 extends bitfinex2Rest {
             const orderbookItem = this.orderbooks[symbol];
             if (isRaw) {
                 const price = this.safeString(deltas, 1);
-                const size = (deltas[2] < 0) ? -deltas[2] : deltas[2];
-                const side = (deltas[2] < 0) ? 'asks' : 'bids';
+                const deltas2 = deltas[2];
+                const size = (deltas2 < 0) ? -deltas2 : deltas2;
+                const side = (deltas2 < 0) ? 'asks' : 'bids';
                 const bookside = orderbookItem[side];
                 // price = 0 means that you have to remove the order from your book
                 const amount = Precise.stringGt(price, '0') ? size : '0';
@@ -672,7 +673,8 @@ export default class bitfinex2 extends bitfinex2Rest {
             }
             if (ask !== undefined) {
                 stringArray.push(this.numberToString(asks[i][idToCheck]));
-                stringArray.push(this.numberToString(-asks[i][1]));
+                const aski1 = asks[i][1];
+                stringArray.push(this.numberToString(-aski1));
             }
         }
         const payload = stringArray.join(':');
@@ -1104,7 +1106,7 @@ export default class bitfinex2 extends bitfinex2Rest {
         //
         if (Array.isArray(message)) {
             if (message[1] === 'hb') {
-                return message; // skip heartbeats within subscription channels for now
+                return; // skip heartbeats within subscription channels for now
             }
             const subscription = this.safeValue(client.subscriptions, channelId, {});
             const channel = this.safeString(subscription, 'channel');
@@ -1132,11 +1134,8 @@ export default class bitfinex2 extends bitfinex2Rest {
             else {
                 method = this.safeValue2(publicMethods, name, channel);
             }
-            if (method === undefined) {
-                return message;
-            }
-            else {
-                return method.call(this, client, message, subscription);
+            if (method !== undefined) {
+                method.call(this, client, message, subscription);
             }
         }
         else {
@@ -1148,11 +1147,8 @@ export default class bitfinex2 extends bitfinex2Rest {
                     'auth': this.handleAuthenticationMessage,
                 };
                 const method = this.safeValue(methods, event);
-                if (method === undefined) {
-                    return message;
-                }
-                else {
-                    return method.call(this, client, message);
+                if (method !== undefined) {
+                    method.call(this, client, message);
                 }
             }
         }

package/js/src/pro/bitget.js

@@ -98,7 +98,9 @@ export default class bitget extends bitgetRest {
         else {
             instType = 'SPOT';
         }
-        [instType, params] = this.handleOptionAndParams(params, 'getInstType', 'instType', instType);
+        let instypeAux = undefined;
+        [instypeAux, params] = this.handleOptionAndParams(params, 'getInstType', 'instType', instType);
+        instType = instypeAux;
         return [instType, params];
     }
     async watchTicker(symbol, params = {}) {

package/js/src/pro/bitmart.d.ts

@@ -19,9 +19,9 @@ export default class bitmart extends bitmartRest {
     watchPositions(symbols?: Strings, since?: Int, limit?: Int, params?: {}): Promise<Position[]>;
     handlePositions(client: Client, message: any): void;
     parseWsPosition(position: any, market?: Market): Position;
-    handleTrade(client: Client, message: any): any;
+    handleTrade(client: Client, message: any): void;
     parseWsTrade(trade: any, market?: Market): Trade;
-    handleTicker(client: Client, message: any): any;
+    handleTicker(client: Client, message: any): void;
     resolveMessageHashesForSymbol(client: any, symbol: any, result: any, prexif: any): void;
     parseWsSwapTicker(ticker: any, market?: Market): Ticker;
     watchOHLCV(symbol: string, timeframe?: string, since?: Int, limit?: Int, params?: {}): Promise<OHLCV[]>;
@@ -35,5 +35,5 @@ export default class bitmart extends bitmartRest {
     handleSubscriptionStatus(client: Client, message: any): any;
     handleAuthenticate(client: Client, message: any): void;
     handleErrorMessage(client: Client, message: any): boolean;
-    handleMessage(client: Client, message: any): any;
+    handleMessage(client: Client, message: any): void;
 }

package/js/src/pro/bitmart.js

@@ -819,7 +819,6 @@ export default class bitmart extends bitmartRest {
             messageHash += ':' + this.safeString(data[0], 'symbol');
         }
         client.resolve(stored, messageHash);
-        return message;
     }
     parseWsTrade(trade, market = undefined) {
         // spot
@@ -921,7 +920,6 @@ export default class bitmart extends bitmartRest {
             client.resolve(ticker, 'tickers::swap');
             this.resolveMessageHashesForSymbol(client, symbol, ticker, 'tickers::');
         }
-        return message;
     }
     resolveMessageHashesForSymbol(client, symbol, result, prexif) {
         const prefixSeparator = '::';
@@ -1455,11 +1453,8 @@ export default class bitmart extends bitmartRest {
                     'subscribe': this.handleSubscriptionStatus,
                 };
                 const method = this.safeValue(methods, event);
-                if (method === undefined) {
-                    return message;
-                }
-                else {
-                    return method.call(this, client, message);
+                if (method !== undefined) {
+                    method.call(this, client, message);
                 }
             }
         }
@@ -1479,7 +1474,7 @@ export default class bitmart extends bitmartRest {
                 const key = keys[i];
                 if (channel.indexOf(key) >= 0) {
                     const method = this.safeValue(methods, key);
-                    return method.call(this, client, message);
+                    method.call(this, client, message);
                 }
             }
         }

package/js/src/pro/bitmex.d.ts

@@ -27,5 +27,5 @@ export default class bitmex extends bitmexRest {
     handleSystemStatus(client: Client, message: any): any;
     handleSubscriptionStatus(client: Client, message: any): any;
     handleErrorMessage(client: Client, message: any): boolean;
-    handleMessage(client: Client, message: any): any;
+    handleMessage(client: Client, message: any): void;
 }

package/js/src/pro/bitmex.js

@@ -1527,7 +1527,7 @@ export default class bitmex extends bitmexRest {
         //
         //     { "error": "Rate limit exceeded, retry in 29 seconds." }
         //
-        const error = this.safeValue(message, 'error');
+        const error = this.safeString(message, 'error');
         if (error !== undefined) {
             const request = this.safeValue(message, 'request', {});
             const args = this.safeValue(request, 'args', []);
@@ -1538,7 +1538,7 @@ export default class bitmex extends bitmexRest {
                 const broadKey = this.findBroadlyMatchedKey(broad, error);
                 let exception = undefined;
                 if (broadKey === undefined) {
-                    exception = new ExchangeError(error);
+                    exception = new ExchangeError(error); // c# requirement for now
                 }
                 else {
                     exception = new broad[broadKey](error);
@@ -1606,14 +1606,11 @@ export default class bitmex extends bitmexRest {
                 const request = this.safeValue(message, 'request', {});
                 const op = this.safeValue(request, 'op');
                 if (op === 'authKeyExpires') {
-                    return this.handleAuthenticationMessage.call(this, client, message);
-                }
-                else {
-                    return message;
+                    this.handleAuthenticationMessage(client, message);
                 }
             }
             else {
-                return method.call(this, client, message);
+                method.call(this, client, message);
             }
         }
     }

package/js/src/pro/bitopro.d.ts

@@ -16,5 +16,5 @@ export default class bitopro extends bitoproRest {
     authenticate(url: any): void;
     watchBalance(params?: {}): Promise<Balances>;
     handleBalance(client: Client, message: any): void;
-    handleMessage(client: Client, message: any): any;
+    handleMessage(client: Client, message: any): void;
 }

package/js/src/pro/bitopro.js

@@ -467,11 +467,8 @@ export default class bitopro extends bitoproRest {
         };
         const event = this.safeString(message, 'event');
         const method = this.safeValue(methods, event);
-        if (method === undefined) {
-            return message;
-        }
-        else {
-            return method.call(this, client, message);
+        if (method !== undefined) {
+            method.call(this, client, message);
         }
     }
 }

package/js/src/pro/bitrue.js

@@ -422,7 +422,7 @@ export default class bitrue extends bitrueRest {
             catch (error) {
                 this.options['listenKey'] = undefined;
                 this.options['listenKeyUrl'] = undefined;
-                return;
+                return undefined;
             }
             //
             //     {

package/js/src/pro/bitstamp.d.ts

@@ -19,6 +19,6 @@ export default class bitstamp extends bitstampRest {
     handleSubject(client: Client, message: any): void;
     handleErrorMessage(client: Client, message: any): any;
     handleMessage(client: Client, message: any): void;
-    authenticate(params?: {}): Promise<any>;
+    authenticate(params?: {}): Promise<void>;
     subscribePrivate(subscription: any, messageHash: any, params?: {}): Promise<any>;
 }

package/js/src/pro/bitstamp.js

@@ -501,10 +501,10 @@ export default class bitstamp extends bitstampRest {
         //
         const event = this.safeString(message, 'event');
         if (event === 'bts:subscription_succeeded') {
-            return this.handleSubscriptionStatus(client, message);
+            this.handleSubscriptionStatus(client, message);
         }
         else {
-            return this.handleSubject(client, message);
+            this.handleSubject(client, message);
         }
     }
     async authenticate(params = {}) {
@@ -527,7 +527,6 @@ export default class bitstamp extends bitstampRest {
                 this.options['expiresIn'] = this.sum(time, validity);
                 this.options['userId'] = userId;
                 this.options['wsSessionToken'] = sessionToken;
-                return response;
             }
         }
     }

package/js/src/pro/bitvavo.d.ts

@@ -17,12 +17,12 @@ export default class bitvavo extends bitvavoRest {
     handleOrderBookMessage(client: Client, message: any, orderbook: any): any;
     handleOrderBook(client: Client, message: any): void;
     watchOrderBookSnapshot(client: any, message: any, subscription: any): Promise<any>;
-    handleOrderBookSnapshot(client: Client, message: any): any;
+    handleOrderBookSnapshot(client: Client, message: any): void;
     handleOrderBookSubscription(client: Client, message: any, subscription: any): void;
     handleOrderBookSubscriptions(client: Client, message: any, marketIds: any): void;
     watchOrders(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Order[]>;
     watchMyTrades(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Trade[]>;
-    createOrderWs(symbol: string, type: OrderType, side: OrderSide, amount: any, price?: any, params?: {}): Promise<Order>;
+    createOrderWs(symbol: string, type: OrderType, side: OrderSide, amount: number, price?: number, params?: {}): Promise<Order>;
     editOrderWs(id: string, symbol: any, type: any, side: any, amount?: any, price?: any, params?: {}): Promise<Order>;
     cancelOrderWs(id: string, symbol?: string, params?: {}): Promise<any>;
     cancelAllOrdersWs(symbol?: string, params?: {}): Promise<any>;
@@ -56,7 +56,7 @@ export default class bitvavo extends bitvavoRest {
     handleOrder(client: Client, message: any): void;
     handleMyTrade(client: Client, message: any): void;
     handleSubscriptionStatus(client: Client, message: any): any;
-    authenticate(params?: {}): any;
+    authenticate(params?: {}): Promise<any>;
     handleAuthenticationMessage(client: Client, message: any): void;
     handleErrorMessage(client: Client, message: any): void;
     handleMessage(client: Client, message: any): void;

package/js/src/pro/bitvavo.js

@@ -415,7 +415,7 @@ export default class bitvavo extends bitvavoRest {
         //
         const response = this.safeValue(message, 'response');
         if (response === undefined) {
-            return message;
+            return;
         }
         const marketId = this.safeString(response, 'market');
         const symbol = this.safeSymbol(marketId, undefined, '-');
@@ -1197,7 +1197,7 @@ export default class bitvavo extends bitvavoRest {
         }
         return message;
     }
-    authenticate(params = {}) {
+    async authenticate(params = {}) {
         const url = this.urls['api']['ws'];
         const client = this.client(url);
         const messageHash = 'authenticated';
@@ -1342,9 +1342,16 @@ export default class bitvavo extends bitvavoRest {
             'getCandles': this.handleFetchOHLCV,
             'getMarkets': this.handleMarkets,
         };
-        const event = this.safeString2(message, 'event', 'action');
-        const method = this.safeValue(methods, event);
-        if (method !== undefined) {
+        const event = this.safeString(message, 'event');
+        let method = this.safeValue(methods, event);
+        if (method === undefined) {
+            const action = this.safeString(message, 'action');
+            method = this.safeValue(methods, action);
+            if (method !== undefined) {
+                method.call(this, client, message);
+            }
+        }
+        else {
             method.call(this, client, message);
         }
     }

package/js/src/pro/blockchaincom.d.ts

@@ -4,25 +4,25 @@ import Client from '../base/ws/Client.js';
 export default class blockchaincom extends blockchaincomRest {
     describe(): any;
     watchBalance(params?: {}): Promise<Balances>;
-    handleBalance(client: Client, message: any): any;
+    handleBalance(client: Client, message: any): void;
     watchOHLCV(symbol: string, timeframe?: string, since?: Int, limit?: Int, params?: {}): Promise<OHLCV[]>;
-    handleOHLCV(client: Client, message: any): any;
+    handleOHLCV(client: Client, message: any): void;
     watchTicker(symbol: string, params?: {}): Promise<Ticker>;
-    handleTicker(client: Client, message: any): any;
+    handleTicker(client: Client, message: any): void;
     parseWsUpdatedTicker(ticker: any, lastTicker?: any, market?: any): Ticker;
     watchTrades(symbol: string, since?: Int, limit?: Int, params?: {}): Promise<Trade[]>;
-    handleTrades(client: Client, message: any): any;
+    handleTrades(client: Client, message: any): void;
     parseWsTrade(trade: any, market?: any): Trade;
     watchOrders(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Order[]>;
-    handleOrders(client: Client, message: any): any;
+    handleOrders(client: Client, message: any): void;
     parseWsOrder(order: any, market?: any): Order;
     parseWsOrderStatus(status: any): string;
     watchOrderBook(symbol: string, limit?: Int, params?: {}): Promise<OrderBook>;
-    handleOrderBook(client: Client, message: any): any;
+    handleOrderBook(client: Client, message: any): void;
     handleDelta(bookside: any, delta: any): void;
     handleDeltas(bookside: any, deltas: any): void;
     checkSequenceNumber(client: Client, message: any): void;
-    handleMessage(client: Client, message: any): any;
+    handleMessage(client: Client, message: any): void;
     handleAuthenticationMessage(client: Client, message: any): void;
-    authenticate(params?: {}): any;
+    authenticate(params?: {}): Promise<any>;
 }

package/js/src/pro/blockchaincom.js

@@ -102,7 +102,7 @@ export default class blockchaincom extends blockchaincomRest {
         //
         const event = this.safeString(message, 'event');
         if (event === 'subscribed') {
-            return message;
+            return;
         }
         const result = { 'info': message };
         const balances = this.safeValue(message, 'balances', []);
@@ -172,11 +172,9 @@ export default class blockchaincom extends blockchaincomRest {
         //     }
         //
         const event = this.safeString(message, 'event');
-        if (event === 'subscribed') {
-            return message;
-        }
-        else if (event === 'rejected') {
-            throw new ExchangeError(this.id + ' ' + this.json(message));
+        if (event === 'rejected') {
+            const jsonMessage = this.json(message);
+            throw new ExchangeError(this.id + ' ' + jsonMessage);
         }
         else if (event === 'updated') {
             const marketId = this.safeString(message, 'symbol');
@@ -196,7 +194,7 @@ export default class blockchaincom extends blockchaincomRest {
             stored.append(ohlcv);
             client.resolve(stored, messageHash);
         }
-        else {
+        else if (event !== 'subscribed') {
             throw new NotSupported(this.id + ' ' + this.json(message));
         }
     }
@@ -258,7 +256,7 @@ export default class blockchaincom extends blockchaincomRest {
         const symbol = market['symbol'];
         let ticker = undefined;
         if (event === 'subscribed') {
-            return message;
+            return;
         }
         else if (event === 'snapshot') {
             ticker = this.parseTicker(message, market);
@@ -357,7 +355,7 @@ export default class blockchaincom extends blockchaincomRest {
         //
         const event = this.safeString(message, 'event');
         if (event !== 'updated') {
-            return message;
+            return;
         }
         const marketId = this.safeString(message, 'symbol');
         const symbol = this.safeSymbol(marketId);
@@ -519,7 +517,7 @@ export default class blockchaincom extends blockchaincomRest {
             this.orders = new ArrayCacheBySymbolById(limit);
         }
         if (event === 'subscribed') {
-            return message;
+            return;
         }
         else if (event === 'rejected') {
             throw new ExchangeError(this.id + ' ' + this.json(message));
@@ -689,30 +687,30 @@ export default class blockchaincom extends blockchaincomRest {
         const messageHash = 'orderbook:' + symbol + ':' + type;
         const datetime = this.safeString(message, 'timestamp');
         const timestamp = this.parse8601(datetime);
-        let storedOrderBook = this.safeValue(this.orderbooks, symbol);
-        if (storedOrderBook === undefined) {
-            storedOrderBook = this.countedOrderBook({});
-            this.orderbooks[symbol] = storedOrderBook;
+        let orderbook = this.safeValue(this.orderbooks, symbol);
+        if (orderbook === undefined) {
+            orderbook = this.countedOrderBook({});
+            this.orderbooks[symbol] = orderbook;
         }
         if (event === 'subscribed') {
-            return message;
+            return;
         }
         else if (event === 'snapshot') {
             const snapshot = this.parseOrderBook(message, symbol, timestamp, 'bids', 'asks', 'px', 'qty', 'num');
-            storedOrderBook.reset(snapshot);
+            orderbook.reset(snapshot);
         }
         else if (event === 'updated') {
             const asks = this.safeValue(message, 'asks', []);
             const bids = this.safeValue(message, 'bids', []);
-            this.handleDeltas(storedOrderBook['asks'], asks);
-            this.handleDeltas(storedOrderBook['bids'], bids);
-            storedOrderBook['timestamp'] = timestamp;
-            storedOrderBook['datetime'] = datetime;
+            this.handleDeltas(orderbook['asks'], asks);
+            this.handleDeltas(orderbook['bids'], bids);
+            orderbook['timestamp'] = timestamp;
+            orderbook['datetime'] = datetime;
         }
         else {
             throw new NotSupported(this.id + ' watchOrderBook() does not support ' + event + ' yet');
         }
-        client.resolve(storedOrderBook, messageHash);
+        client.resolve(orderbook, messageHash);
     }
     handleDelta(bookside, delta) {
         const bookArray = this.parseBidAsk(delta, 'px', 'qty', 'num');
@@ -753,7 +751,8 @@ export default class blockchaincom extends blockchaincomRest {
         };
         const handler = this.safeValue(handlers, channel);
         if (handler !== undefined) {
-            return handler.call(this, client, message);
+            handler.call(this, client, message);
+            return;
         }
         throw new NotSupported(this.id + ' received an unsupported message: ' + this.json(message));
     }
@@ -775,7 +774,7 @@ export default class blockchaincom extends blockchaincomRest {
             future.resolve(true);
         }
     }
-    authenticate(params = {}) {
+    async authenticate(params = {}) {
         const url = this.urls['api']['ws'];
         const client = this.client(url);
         const messageHash = 'authenticated';

package/js/src/pro/bybit.d.ts

@@ -25,11 +25,11 @@ export default class bybit extends bybitRest {
     watchMyTrades(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Trade[]>;
     handleMyTrades(client: Client, message: any): void;
     watchPositions(symbols?: Strings, since?: Int, limit?: Int, params?: {}): Promise<Position[]>;
-    setPositionsCache(client: Client, symbols?: Strings): any;
+    setPositionsCache(client: Client, symbols?: Strings): void;
     loadPositionsSnapshot(client: any, messageHash: any): Promise<void>;
     handlePositions(client: any, message: any): void;
     watchOrders(symbol?: Str, since?: Int, limit?: Int, params?: {}): Promise<Order[]>;
-    handleOrder(client: Client, message: any, subscription?: any): void;
+    handleOrder(client: Client, message: any): void;
     parseWsSpotOrder(order: any, market?: any): Order;
     watchBalance(params?: {}): Promise<Balances>;
     handleBalance(client: Client, message: any): void;

package/js/src/pro/bybit.js

@@ -909,7 +909,7 @@ export default class bybit extends bybitRest {
          * @name bybit#watchPositions
          * @see https://bybit-exchange.github.io/docs/v5/websocket/private/position
          * @description watch all open positions
-         * @param {string[]|undefined} symbols list of unified market symbols
+         * @param {string[]} [symbols] list of unified market symbols
          * @param {object} params extra parameters specific to the exchange API endpoint
          * @returns {object[]} a list of [position structure]{@link https://docs.ccxt.com/en/latest/manual.html#position-structure}
          */
@@ -942,7 +942,7 @@ export default class bybit extends bybitRest {
     }
     setPositionsCache(client, symbols = undefined) {
         if (this.positions !== undefined) {
-            return this.positions;
+            return;
         }
         const fetchPositionsSnapshot = this.handleOption('watchPositions', 'fetchPositionsSnapshot', true);
         if (fetchPositionsSnapshot) {
@@ -1075,7 +1075,7 @@ export default class bybit extends bybitRest {
         }
         return this.filterBySymbolSinceLimit(orders, symbol, since, limit, true);
     }
-    handleOrder(client, message, subscription = undefined) {
+    handleOrder(client, message) {
         //
         //     spot
         //     {
@@ -1641,7 +1641,7 @@ export default class bybit extends bybitRest {
         const authenticated = this.safeValue(client.subscriptions, messageHash);
         if (authenticated === undefined) {
             const expiresInt = this.milliseconds() + 10000;
-            const expires = expiresInt.toString();
+            const expires = this.numberToString(expiresInt);
             const path = 'GET/realtime';
             const auth = path + expires;
             const signature = this.hmac(this.encode(auth), this.encode(this.secret), sha256, 'hex');
@@ -1654,7 +1654,7 @@ export default class bybit extends bybitRest {
             const message = this.extend(request, params);
             this.watch(url, messageHash, message, messageHash);
         }
-        return future;
+        return await future;
     }
     handleErrorMessage(client, message) {
         //