ccxt 4.2.29 → 4.2.31

package/js/src/bitforex.js

@@ -44,6 +44,9 @@ export default class bitforex extends Exchange {
                 'fetchClosedOrders': true,
                 'fetchCrossBorrowRate': false,
                 'fetchCrossBorrowRates': false,
+                'fetchDepositAddress': false,
+                'fetchDepositAddresses': false,
+                'fetchDepositAddressesByNetwork': false,
                 'fetchFundingHistory': false,
                 'fetchFundingRate': false,
                 'fetchFundingRateHistory': false,

package/js/src/bitget.js

@@ -69,6 +69,7 @@ export default class bitget extends Exchange {
                 'fetchCrossBorrowRate': true,
                 'fetchCrossBorrowRates': false,
                 'fetchCurrencies': true,
+                'fetchDeposit': false,
                 'fetchDepositAddress': true,
                 'fetchDepositAddresses': false,
                 'fetchDeposits': true,
@@ -98,6 +99,7 @@ export default class bitget extends Exchange {
                 'fetchOpenOrders': true,
                 'fetchOrder': true,
                 'fetchOrderBook': true,
+                'fetchOrderBooks': false,
                 'fetchOrders': false,
                 'fetchOrderTrades': false,
                 'fetchPosition': true,
@@ -105,6 +107,7 @@ export default class bitget extends Exchange {
                 'fetchPositions': true,
                 'fetchPositionsRisk': false,
                 'fetchPremiumIndexOHLCV': false,
+                'fetchStatus': false,
                 'fetchTicker': true,
                 'fetchTickers': true,
                 'fetchTime': true,
@@ -121,6 +124,7 @@ export default class bitget extends Exchange {
                 'repayCrossMargin': true,
                 'repayIsolatedMargin': true,
                 'setLeverage': true,
+                'setMargin': false,
                 'setMarginMode': true,
                 'setPositionMode': true,
                 'signIn': false,
@@ -2238,7 +2242,7 @@ export default class bitget extends Exchange {
             'fee': undefined,
         };
         const withdrawOptions = this.safeValue(this.options, 'withdraw', {});
-        const fillResponseFromRequest = this.safeValue(withdrawOptions, 'fillResponseFromRequest', true);
+        const fillResponseFromRequest = this.safeBool(withdrawOptions, 'fillResponseFromRequest', true);
         if (fillResponseFromRequest) {
             result['currency'] = code;
             result['timestamp'] = this.milliseconds();
@@ -3123,7 +3127,7 @@ export default class bitget extends Exchange {
         [marginMode, params] = this.handleMarginModeAndParams('fetchTradingFees', params);
         [marketType, params] = this.handleMarketTypeAndParams('fetchTradingFees', undefined, params);
         if (marketType === 'spot') {
-            const margin = this.safeValue(params, 'margin', false);
+            const margin = this.safeBool(params, 'margin', false);
             params = this.omit(params, 'margin');
             if ((marginMode !== undefined) || margin) {
                 response = await this.publicMarginGetV2MarginCurrencies(params);
@@ -4144,7 +4148,7 @@ export default class bitget extends Exchange {
             request['price'] = this.priceToPrecision(symbol, price);
         }
         const triggerType = this.safeString(params, 'triggerType', 'mark_price');
-        const reduceOnly = this.safeValue(params, 'reduceOnly', false);
+        const reduceOnly = this.safeBool(params, 'reduceOnly', false);
         const clientOrderId = this.safeString2(params, 'clientOid', 'clientOrderId');
         const exchangeSpecificTifParam = this.safeString2(params, 'force', 'timeInForce');
         let postOnly = undefined;
@@ -4240,7 +4244,7 @@ export default class bitget extends Exchange {
                 }
                 const marginModeRequest = (marginMode === 'cross') ? 'crossed' : 'isolated';
                 request['marginMode'] = marginModeRequest;
-                const oneWayMode = this.safeValue(params, 'oneWayMode', false);
+                const oneWayMode = this.safeBool(params, 'oneWayMode', false);
                 params = this.omit(params, 'oneWayMode');
                 let requestSide = side;
                 if (reduceOnly) {

package/js/src/bitmart.js

@@ -1939,7 +1939,7 @@ export default class bitmart extends Exchange {
         let marketType = undefined;
         [marketType, params] = this.handleMarketTypeAndParams('fetchBalance', undefined, params);
         const marginMode = this.safeString(params, 'marginMode');
-        const isMargin = this.safeValue(params, 'margin', false);
+        const isMargin = this.safeBool(params, 'margin', false);
         params = this.omit(params, ['margin', 'marginMode']);
         if (marginMode !== undefined || isMargin) {
             marketType = 'margin';
@@ -2813,7 +2813,7 @@ export default class bitmart extends Exchange {
                 response = await this.privateGetContractPrivateCurrentPlanOrder(this.extend(request, params));
             }
             else {
-                const trailing = this.safeValue(params, 'trailing', false);
+                const trailing = this.safeBool(params, 'trailing', false);
                 let orderType = this.safeString(params, 'orderType');
                 params = this.omit(params, ['orderType', 'trailing']);
                 if (trailing) {
@@ -2993,7 +2993,7 @@ export default class bitmart extends Exchange {
             if (symbol === undefined) {
                 throw new ArgumentsRequired(this.id + ' fetchOrder() requires a symbol argument');
             }
-            const trailing = this.safeValue(params, 'trailing', false);
+            const trailing = this.safeBool(params, 'trailing', false);
             let orderType = this.safeString(params, 'orderType');
             params = this.omit(params, ['orderType', 'trailing']);
             if (trailing) {

package/js/src/bitmex.js

@@ -342,8 +342,8 @@ export default class bitmex extends Exchange {
                 const network = this.networkIdToCode(networkId);
                 const withdrawalFeeRaw = this.safeString(chain, 'withdrawalFee');
                 const withdrawalFee = this.parseNumber(Precise.stringMul(withdrawalFeeRaw, precisionString));
-                const isDepositEnabled = this.safeValue(chain, 'depositEnabled', false);
-                const isWithdrawEnabled = this.safeValue(chain, 'withdrawalEnabled', false);
+                const isDepositEnabled = this.safeBool(chain, 'depositEnabled', false);
+                const isWithdrawEnabled = this.safeBool(chain, 'withdrawalEnabled', false);
                 const active = (isDepositEnabled && isWithdrawEnabled);
                 if (isDepositEnabled) {
                     depositEnabled = true;
@@ -1719,7 +1719,7 @@ export default class bitmex extends Exchange {
             isInverse = (defaultSubType === 'inverse');
         }
         else {
-            isInverse = this.safeValue(market, 'inverse', false);
+            isInverse = this.safeBool(market, 'inverse', false);
         }
         if (isInverse) {
             cost = this.convertFromRawQuantity(symbol, qty);
@@ -2426,7 +2426,7 @@ export default class bitmex extends Exchange {
             const item = response[i];
             const marketId = this.safeString(item, 'symbol');
             const market = this.safeMarket(marketId);
-            const swap = this.safeValue(market, 'swap', false);
+            const swap = this.safeBool(market, 'swap', false);
             if (swap) {
                 filteredResponse.push(item);
             }

package/js/src/bitrue.js

@@ -3191,7 +3191,7 @@ export default class bitrue extends Exchange {
         }
         // check success value for wapi endpoints
         // response in format {'msg': 'The coin does not exist.', 'success': true/false}
-        const success = this.safeValue(response, 'success', true);
+        const success = this.safeBool(response, 'success', true);
         if (!success) {
             const messageInner = this.safeString(response, 'msg');
             let parsedMessage = undefined;

package/js/src/bitso.d.ts

@@ -23,7 +23,7 @@ export default class bitso extends Exchange {
         after: number;
         status: string;
         fee: any;
-        info: any;
+        info: import("./base/types.js").Dictionary<any>;
     };
     fetchMarkets(params?: {}): Promise<any[]>;
     parseBalance(response: any): Balances;

package/js/src/bitso.js

@@ -1729,7 +1729,7 @@ export default class bitso extends Exchange {
             //
             //     {"success":false,"error":{"code":104,"message":"Cannot perform request - nonce must be higher than 1520307203724237"}}
             //
-            let success = this.safeValue(response, 'success', false);
+            let success = this.safeBool(response, 'success', false);
             if (typeof success === 'string') {
                 if ((success === 'true') || (success === '1')) {
                     success = true;

package/js/src/bitteam.js

@@ -356,7 +356,7 @@ export default class bitteam extends Exchange {
         const created = this.parse8601(timeStart);
         let minCost = undefined;
         const currenciesValuedInUsd = this.safeValue(this.options, 'currenciesValuedInUsd', {});
-        const quoteInUsd = this.safeValue(currenciesValuedInUsd, quote, false);
+        const quoteInUsd = this.safeBool(currenciesValuedInUsd, quote, false);
         if (quoteInUsd) {
             const settings = this.safeValue(market, 'settings', {});
             minCost = this.safeNumber(settings, 'limit_usd');
@@ -543,7 +543,7 @@ export default class bitteam extends Exchange {
             const id = this.safeString(currency, 'symbol');
             const numericId = this.safeInteger(currency, 'id');
             const code = this.safeCurrencyCode(id);
-            const active = this.safeValue(currency, 'active', false);
+            const active = this.safeBool(currency, 'active', false);
             const precision = this.safeInteger(currency, 'precision');
             const txLimits = this.safeValue(currency, 'txLimits', {});
             const minWithdraw = this.safeString(txLimits, 'minWithdraw');

package/js/src/btcalpha.js

@@ -680,7 +680,7 @@ export default class btcalpha extends Exchange {
         const marketId = this.safeString(order, 'pair');
         market = this.safeMarket(marketId, market, '_');
         const symbol = market['symbol'];
-        const success = this.safeValue(order, 'success', false);
+        const success = this.safeBool(order, 'success', false);
         let timestamp = undefined;
         if (success) {
             timestamp = this.safeTimestamp(order, 'date');

package/js/src/bybit.js

@@ -299,8 +299,6 @@ export default class bybit extends Exchange {
                         // account
                         'v5/account/wallet-balance': 1,
                         'v5/account/borrow-history': 1,
-                        'v5/account/set-collateral-switch': 5,
-                        'v5/account/set-collateral-switch-batch': 5,
                         'v5/account/collateral-info': 1,
                         'v5/asset/coin-greeks': 1,
                         'v5/account/fee-rate': 10,
@@ -493,6 +491,8 @@ export default class bybit extends Exchange {
                         'v5/lending/purchase': 5,
                         'v5/lending/redeem': 5,
                         'v5/lending/redeem-cancel': 5,
+                        'v5/account/set-collateral-switch': 5,
+                        'v5/account/set-collateral-switch-batch': 5,
                     },
                 },
             },
@@ -3462,7 +3462,7 @@ export default class bybit extends Exchange {
         const result = await this.fetchOrders(symbol, undefined, undefined, this.extend(request, params));
         const length = result.length;
         if (length === 0) {
-            const isTrigger = this.safeValueN(params, ['trigger', 'stop'], false);
+            const isTrigger = this.safeBoolN(params, ['trigger', 'stop'], false);
             const extra = isTrigger ? '' : 'If you are trying to fetch SL/TP conditional order, you might try setting params["trigger"] = true';
             throw new OrderNotFound('Order ' + id.toString() + ' was not found.' + extra);
         }

package/js/src/coinbase.js

@@ -207,6 +207,13 @@ export default class coinbase extends Exchange {
                             'brokerage/best_bid_ask',
                             'brokerage/convert/trade/{trade_id}',
                             'brokerage/time',
+                            'brokerage/cfm/balance_summary',
+                            'brokerage/cfm/positions',
+                            'brokerage/cfm/positions/{product_id}',
+                            'brokerage/cfm/sweeps',
+                            'brokerage/intx/portfolio/{portfolio_uuid}',
+                            'brokerage/intx/positions/{portfolio_uuid}',
+                            'brokerage/intx/positions/{portfolio_uuid}/{symbol}',
                         ],
                         'post': [
                             'brokerage/orders',
@@ -217,12 +224,15 @@ export default class coinbase extends Exchange {
                             'brokerage/portfolios/move_funds',
                             'brokerage/convert/quote',
                             'brokerage/convert/trade/{trade_id}',
+                            'brokerage/cfm/sweeps/schedule',
+                            'brokerage/intx/allocate',
                         ],
                         'put': [
                             'brokerage/portfolios/{portfolio_uuid}',
                         ],
                         'delete': [
                             'brokerage/portfolios/{portfolio_uuid}',
+                            'brokerage/cfm/sweeps',
                         ],
                     },
                 },
@@ -1364,7 +1374,11 @@ export default class coinbase extends Exchange {
     async fetchTickersV3(symbols = undefined, params = {}) {
         await this.loadMarkets();
         symbols = this.marketSymbols(symbols);
-        const response = await this.v3PrivateGetBrokerageProducts(params);
+        const request = {};
+        if (symbols !== undefined) {
+            request['product_ids'] = this.marketIds(symbols);
+        }
+        const response = await this.v3PrivateGetBrokerageProducts(this.extend(request, params));
         //
         //     {
         //         "products": [
@@ -1682,7 +1696,7 @@ export default class coinbase extends Exchange {
             'limit': 250,
         };
         let response = undefined;
-        const isV3 = this.safeValue(params, 'v3', false);
+        const isV3 = this.safeBool(params, 'v3', false);
         params = this.omit(params, 'v3');
         const method = this.safeString(this.options, 'fetchBalance', 'v3PrivateGetBrokerageAccounts');
         if ((isV3) || (method === 'v3PrivateGetBrokerageAccounts')) {
@@ -3198,8 +3212,11 @@ export default class coinbase extends Exchange {
          */
         await this.loadMarkets();
         symbols = this.marketSymbols(symbols);
-        // the 'product_ids' param isn't working properly and returns {"pricebooks":[]} when defined
-        const response = await this.v3PrivateGetBrokerageBestBidAsk(params);
+        const request = {};
+        if (symbols !== undefined) {
+            request['product_ids'] = this.marketIds(symbols);
+        }
+        const response = await this.v3PrivateGetBrokerageBestBidAsk(this.extend(request, params));
         //
         //     {
         //         "pricebooks": [
@@ -3328,7 +3345,7 @@ export default class coinbase extends Exchange {
         const savedPath = fullPath;
         if (method === 'GET') {
             if (Object.keys(query).length) {
-                fullPath += '?' + this.urlencode(query);
+                fullPath += '?' + this.urlencodeWithArrayRepeat(query);
             }
         }
         const url = this.urls['api']['rest'] + fullPath;

package/js/src/coincheck.js

@@ -832,7 +832,7 @@ export default class coincheck extends Exchange {
         //     {"success":false,"error":"disabled API Key"}'
         //     {"success":false,"error":"invalid authentication"}
         //
-        const success = this.safeValue(response, 'success', true);
+        const success = this.safeBool(response, 'success', true);
         if (!success) {
             const error = this.safeString(response, 'error');
             const feedback = this.id + ' ' + this.json(response);

package/js/src/coinex.js

@@ -3327,7 +3327,7 @@ export default class coinex extends Exchange {
         const data = this.safeValue(response, 'data', {});
         const depositAddress = this.parseDepositAddress(data, currency);
         const options = this.safeValue(this.options, 'fetchDepositAddress', {});
-        const fillResponseFromRequest = this.safeValue(options, 'fillResponseFromRequest', true);
+        const fillResponseFromRequest = this.safeBool(options, 'fillResponseFromRequest', true);
         if (fillResponseFromRequest) {
             depositAddress['network'] = this.safeNetworkCode(network, currency);
         }
@@ -5354,7 +5354,7 @@ export default class coinex extends Exchange {
          * @returns {Array} the marginMode in lowercase
          */
         const defaultType = this.safeString(this.options, 'defaultType');
-        const isMargin = this.safeValue(params, 'margin', false);
+        const isMargin = this.safeBool(params, 'margin', false);
         let marginMode = undefined;
         [marginMode, params] = super.handleMarginModeAndParams(methodName, params, defaultValue);
         if (marginMode === undefined) {

package/js/src/coinlist.js

@@ -364,7 +364,7 @@ export default class coinlist extends Exchange {
             const currency = currencies[i];
             const id = this.safeString(currency, 'asset');
             const code = this.safeCurrencyCode(id);
-            const isTransferable = this.safeValue(currency, 'is_transferable', false);
+            const isTransferable = this.safeBool(currency, 'is_transferable', false);
             const withdrawEnabled = isTransferable;
             const depositEnabled = isTransferable;
             const active = isTransferable;

package/js/src/coinmate.js

@@ -544,7 +544,7 @@ export default class coinmate extends Exchange {
         //
         const data = this.safeValue(response, 'data');
         const transaction = this.parseTransaction(data, currency);
-        const fillResponseFromRequest = this.safeValue(withdrawOptions, 'fillResponseFromRequest', true);
+        const fillResponseFromRequest = this.safeBool(withdrawOptions, 'fillResponseFromRequest', true);
         if (fillResponseFromRequest) {
             transaction['amount'] = amount;
             transaction['currency'] = code;

package/js/src/coinmetro.d.ts

@@ -45,7 +45,7 @@ export default class coinmetro extends Exchange {
         after: number;
         status: string;
         fee: any;
-        info: any;
+        info: import("./base/types.js").Dictionary<any>;
     };
     parseLedgerEntryDescription(description: any): any[];
     parseLedgerEntryType(type: any): string;

package/js/src/coinmetro.js

@@ -380,7 +380,7 @@ export default class coinmetro extends Exchange {
         const quote = this.safeCurrencyCode(quoteId);
         const basePrecisionAndLimits = this.parseMarketPrecisionAndLimits(baseId);
         const quotePrecisionAndLimits = this.parseMarketPrecisionAndLimits(quoteId);
-        const margin = this.safeValue(market, 'margin', false);
+        const margin = this.safeBool(market, 'margin', false);
         const tradingFees = this.safeValue(this.fees, 'trading', {});
         return this.safeMarketStructure({
             'id': id,
@@ -1339,7 +1339,7 @@ export default class coinmetro extends Exchange {
         };
         const marginMode = undefined;
         [params, params] = this.handleMarginModeAndParams('cancelOrder', params);
-        const isMargin = this.safeValue(params, 'margin', false);
+        const isMargin = this.safeBool(params, 'margin', false);
         params = this.omit(params, 'margin');
         let response = undefined;
         if (isMargin || (marginMode !== undefined)) {

package/js/src/coinsph.js

@@ -1562,7 +1562,7 @@ export default class coinsph extends Exchange {
          * @returns {object} a [transaction structure]{@link https://docs.ccxt.com/#/?id=transaction-structure}
          */
         const options = this.safeValue(this.options, 'withdraw');
-        const warning = this.safeValue(options, 'warning', true);
+        const warning = this.safeBool(options, 'warning', true);
         if (warning) {
             throw new InvalidAddress(this.id + " withdraw() makes a withdrawals only to coins_ph account, add .options['withdraw']['warning'] = false to make a withdrawal to your coins_ph account");
         }

package/js/src/cryptocom.js

@@ -1057,7 +1057,7 @@ export default class cryptocom extends Exchange {
                 request['time_in_force'] = timeInForce;
             }
         }
-        const postOnly = this.safeValue(params, 'postOnly', false);
+        const postOnly = this.safeBool(params, 'postOnly', false);
         if ((postOnly) || (timeInForce === 'PO')) {
             request['exec_inst'] = ['POST_ONLY'];
             request['time_in_force'] = 'GOOD_TILL_CANCEL';
@@ -1278,7 +1278,7 @@ export default class cryptocom extends Exchange {
                 request['time_in_force'] = timeInForce;
             }
         }
-        const postOnly = this.safeValue(params, 'postOnly', false);
+        const postOnly = this.safeBool(params, 'postOnly', false);
         if ((postOnly) || (timeInForce === 'PO')) {
             request['exec_inst'] = ['POST_ONLY'];
             request['time_in_force'] = 'GOOD_TILL_CANCEL';
@@ -2249,7 +2249,7 @@ export default class cryptocom extends Exchange {
          * @returns {Array} the marginMode in lowercase
          */
         const defaultType = this.safeString(this.options, 'defaultType');
-        const isMargin = this.safeValue(params, 'margin', false);
+        const isMargin = this.safeBool(params, 'margin', false);
         params = this.omit(params, 'margin');
         let marginMode = undefined;
         [marginMode, params] = this.handleMarginModeAndParams(methodName, params);

package/js/src/deribit.js

@@ -1346,6 +1346,7 @@ export default class deribit extends Exchange {
             request['end_timestamp'] = now;
         }
         else {
+            since = Math.max(since - 1, 0);
             request['start_timestamp'] = since;
             if (limit === undefined) {
                 request['end_timestamp'] = now;

package/js/src/digifinex.js

@@ -1162,9 +1162,11 @@ export default class digifinex extends Exchange {
         //         "timestamp": 1663221614998
         //     }
         //
+        const indexPrice = this.safeNumber(ticker, 'index_price');
+        const marketType = (indexPrice !== undefined) ? 'contract' : 'spot';
         const marketId = this.safeStringUpper2(ticker, 'symbol', 'instrument_id');
-        const symbol = this.safeSymbol(marketId, market);
-        market = this.safeMarket(marketId);
+        const symbol = this.safeSymbol(marketId, market, undefined, marketType);
+        market = this.safeMarket(marketId, market, undefined, marketType);
         let timestamp = this.safeTimestamp(ticker, 'date');
         if (market['swap']) {
             timestamp = this.safeInteger(ticker, 'timestamp');
@@ -1751,7 +1753,7 @@ export default class digifinex extends Exchange {
         let postOnly = this.isPostOnly(isMarketOrder, false, params);
         let postOnlyParsed = undefined;
         if (swap) {
-            const reduceOnly = this.safeValue(params, 'reduceOnly', false);
+            const reduceOnly = this.safeBool(params, 'reduceOnly', false);
             const timeInForce = this.safeString(params, 'timeInForce');
             let orderType = undefined;
             if (side === 'buy') {
@@ -3951,7 +3953,7 @@ export default class digifinex extends Exchange {
          * @returns {Array} the marginMode in lowercase
          */
         const defaultType = this.safeString(this.options, 'defaultType');
-        const isMargin = this.safeValue(params, 'margin', false);
+        const isMargin = this.safeBool(params, 'margin', false);
         let marginMode = undefined;
         [marginMode, params] = super.handleMarginModeAndParams(methodName, params, defaultValue);
         if (marginMode !== undefined) {

package/js/src/exmo.js

@@ -252,7 +252,7 @@ export default class exmo extends Exchange {
         //
         const margin = this.parseMarginModification(response, market);
         const options = this.safeValue(this.options, 'margin', {});
-        const fillResponseFromRequest = this.safeValue(options, 'fillResponseFromRequest', true);
+        const fillResponseFromRequest = this.safeBool(options, 'fillResponseFromRequest', true);
         if (fillResponseFromRequest) {
             margin['type'] = type;
             margin['amount'] = amount;
@@ -2616,7 +2616,7 @@ export default class exmo extends Exchange {
             //     {"result":false,"error":"Error 50052: Insufficient funds"}
             //     {"s":"error","errmsg":"strconv.ParseInt: parsing \"\": invalid syntax"}
             //
-            let success = this.safeValue(response, 'result', false);
+            let success = this.safeBool(response, 'result', false);
             if (typeof success === 'string') {
                 if ((success === 'true') || (success === '1')) {
                     success = true;

package/js/src/gate.js

@@ -1592,9 +1592,9 @@ export default class gate extends Exchange {
             const networkId = this.safeString(entry, 'chain');
             const networkCode = this.networkIdToCode(networkId, code);
             const delisted = this.safeValue(entry, 'delisted');
-            const withdrawDisabled = this.safeValue(entry, 'withdraw_disabled', false);
-            const depositDisabled = this.safeValue(entry, 'deposit_disabled', false);
-            const tradeDisabled = this.safeValue(entry, 'trade_disabled', false);
+            const withdrawDisabled = this.safeBool(entry, 'withdraw_disabled', false);
+            const depositDisabled = this.safeBool(entry, 'deposit_disabled', false);
+            const tradeDisabled = this.safeBool(entry, 'trade_disabled', false);
             const withdrawEnabled = !withdrawDisabled;
             const depositEnabled = !depositDisabled;
             const tradeEnabled = !tradeDisabled;
@@ -4051,7 +4051,7 @@ export default class gate extends Exchange {
                 }
             }
             let clientOrderId = this.safeString2(params, 'text', 'clientOrderId');
-            const textIsRequired = this.safeValue(params, 'textIsRequired', false);
+            const textIsRequired = this.safeBool(params, 'textIsRequired', false);
             if (clientOrderId !== undefined) {
                 // user-defined, must follow the rules if not empty
                 //     prefixed with t-
@@ -4423,7 +4423,7 @@ export default class gate extends Exchange {
         //        "message": "Not enough balance"
         //    }
         //
-        const succeeded = this.safeValue(order, 'succeeded', true);
+        const succeeded = this.safeBool(order, 'succeeded', true);
         if (!succeeded) {
             // cancelOrders response
             return this.safeOrder({

package/js/src/gemini.d.ts

@@ -10,7 +10,7 @@ export default class gemini extends Exchange {
     fetchCurrenciesFromWeb(params?: {}): Promise<{}>;
     fetchMarkets(params?: {}): Promise<any>;
     fetchMarketsFromWeb(params?: {}): Promise<any[]>;
-    parseMarketActive(status: any): any;
+    parseMarketActive(status: any): boolean;
     fetchUSDTMarkets(params?: {}): Promise<any[]>;
     fetchMarketsFromAPI(params?: {}): Promise<unknown[]>;
     parseMarket(response: any): Market;

package/js/src/gemini.js

@@ -515,7 +515,7 @@ export default class gemini extends Exchange {
             'post_only': true,
             'limit_only': true,
         };
-        return this.safeValue(statuses, status, true);
+        return this.safeBool(statuses, status, true);
     }
     async fetchUSDTMarkets(params = {}) {
         // these markets can't be scrapped and fetchMarketsFrom api does an extra call
@@ -554,7 +554,7 @@ export default class gemini extends Exchange {
             result[marketId] = this.parseMarket(market);
         }
         const options = this.safeValue(this.options, 'fetchMarketsFromAPI', {});
-        const fetchDetailsForAllSymbols = this.safeValue(options, 'fetchDetailsForAllSymbols', false);
+        const fetchDetailsForAllSymbols = this.safeBool(options, 'fetchDetailsForAllSymbols', false);
         const fetchDetailsForMarketIds = this.safeValue(options, 'fetchDetailsForMarketIds', []);
         let promises = [];
         let marketIds = [];
@@ -1371,7 +1371,7 @@ export default class gemini extends Exchange {
                     request['options'] = ['maker-or-cancel'];
                 }
             }
-            const postOnly = this.safeValue(params, 'postOnly', false);
+            const postOnly = this.safeBool(params, 'postOnly', false);
             params = this.omit(params, 'postOnly');
             if (postOnly) {
                 request['options'] = ['maker-or-cancel'];

package/js/src/hitbtc.js

@@ -693,7 +693,7 @@ export default class hitbtc extends Exchange {
             const expiry = this.safeInteger(market, 'expiry');
             const contract = (marketType === 'futures');
             const spot = (marketType === 'spot');
-            const marginTrading = this.safeValue(market, 'margin_trading', false);
+            const marginTrading = this.safeBool(market, 'margin_trading', false);
             const margin = spot && marginTrading;
             const future = (expiry !== undefined);
             const swap = (contract && !future);
@@ -828,9 +828,9 @@ export default class hitbtc extends Exchange {
             const entry = response[currencyId];
             const name = this.safeString(entry, 'full_name');
             const precision = this.safeNumber(entry, 'precision_transfer');
-            const payinEnabled = this.safeValue(entry, 'payin_enabled', false);
-            const payoutEnabled = this.safeValue(entry, 'payout_enabled', false);
-            const transferEnabled = this.safeValue(entry, 'transfer_enabled', false);
+            const payinEnabled = this.safeBool(entry, 'payin_enabled', false);
+            const payoutEnabled = this.safeBool(entry, 'payout_enabled', false);
+            const transferEnabled = this.safeBool(entry, 'transfer_enabled', false);
             const active = payinEnabled && payoutEnabled && transferEnabled;
             const rawNetworks = this.safeValue(entry, 'networks', []);
             const networks = {};
@@ -843,8 +843,8 @@ export default class hitbtc extends Exchange {
                 const network = this.safeNetwork(networkId);
                 fee = this.safeNumber(rawNetwork, 'payout_fee');
                 const networkPrecision = this.safeNumber(rawNetwork, 'precision_payout');
-                const payinEnabledNetwork = this.safeValue(entry, 'payin_enabled', false);
-                const payoutEnabledNetwork = this.safeValue(entry, 'payout_enabled', false);
+                const payinEnabledNetwork = this.safeBool(entry, 'payin_enabled', false);
+                const payoutEnabledNetwork = this.safeBool(entry, 'payout_enabled', false);
                 const activeNetwork = payinEnabledNetwork && payoutEnabledNetwork;
                 if (payinEnabledNetwork && !depositEnabled) {
                     depositEnabled = true;
@@ -2708,7 +2708,7 @@ export default class hitbtc extends Exchange {
             params = this.omit(params, 'network');
         }
         const withdrawOptions = this.safeValue(this.options, 'withdraw', {});
-        const includeFee = this.safeValue(withdrawOptions, 'includeFee', false);
+        const includeFee = this.safeBool(withdrawOptions, 'includeFee', false);
         if (includeFee) {
             request['include_fee'] = true;
         }
@@ -3230,7 +3230,7 @@ export default class hitbtc extends Exchange {
         await this.loadMarkets();
         const market = this.market(symbol);
         const leverage = this.safeString(params, 'leverage');
-        if (market['type'] === 'swap') {
+        if (market['swap']) {
             if (leverage === undefined) {
                 throw new ArgumentsRequired(this.id + ' modifyMarginHelper() requires a leverage parameter for swap markets');
             }
@@ -3254,21 +3254,15 @@ export default class hitbtc extends Exchange {
         let marginMode = undefined;
         [marketType, params] = this.handleMarketTypeAndParams('modifyMarginHelper', market, params);
         [marginMode, params] = this.handleMarginModeAndParams('modifyMarginHelper', params);
-        params = this.omit(params, ['marginMode', 'margin']);
         let response = undefined;
-        if (marginMode !== undefined) {
+        if (marketType === 'swap') {
+            response = await this.privatePutFuturesAccountIsolatedSymbol(this.extend(request, params));
+        }
+        else if ((marketType === 'margin') || (marketType === 'spot') || (marginMode === 'isolated')) {
             response = await this.privatePutMarginAccountIsolatedSymbol(this.extend(request, params));
         }
         else {
-            if (marketType === 'swap') {
-                response = await this.privatePutFuturesAccountIsolatedSymbol(this.extend(request, params));
-            }
-            else if (marketType === 'margin') {
-                response = await this.privatePutMarginAccountIsolatedSymbol(this.extend(request, params));
-            }
-            else {
-                throw new NotSupported(this.id + ' modifyMarginHelper() not support this market type');
-            }
+            throw new NotSupported(this.id + ' modifyMarginHelper() not support this market type');
         }
         //
         //     {
@@ -3580,7 +3574,7 @@ export default class hitbtc extends Exchange {
          * @returns {Array} the marginMode in lowercase
          */
         const defaultType = this.safeString(this.options, 'defaultType');
-        const isMargin = this.safeValue(params, 'margin', false);
+        const isMargin = this.safeBool(params, 'margin', false);
         let marginMode = undefined;
         [marginMode, params] = super.handleMarginModeAndParams(methodName, params, defaultValue);
         if (marginMode === undefined) {