ccxt 4.2.29 → 4.2.30

package/js/src/pro/probit.js

@@ -100,7 +100,7 @@ export default class probit extends probitRest {
         //         }
         //     }
         //
-        const reset = this.safeValue(message, 'reset', false);
+        const reset = this.safeBool(message, 'reset', false);
         const data = this.safeValue(message, 'data', {});
         const currencyIds = Object.keys(data);
         if (reset) {
@@ -206,7 +206,7 @@ export default class probit extends probitRest {
         const symbol = this.safeSymbol(marketId);
         const market = this.safeMarket(marketId);
         const trades = this.safeValue(message, 'recent_trades', []);
-        const reset = this.safeValue(message, 'reset', false);
+        const reset = this.safeBool(message, 'reset', false);
         const messageHash = 'trades:' + symbol;
         let stored = this.safeValue(this.trades, symbol);
         if (stored === undefined || reset) {
@@ -279,7 +279,7 @@ export default class probit extends probitRest {
         if (length === 0) {
             return;
         }
-        const reset = this.safeValue(message, 'reset', false);
+        const reset = this.safeBool(message, 'reset', false);
         const messageHash = 'myTrades';
         let stored = this.myTrades;
         if ((stored === undefined) || reset) {
@@ -367,7 +367,7 @@ export default class probit extends probitRest {
             return;
         }
         const messageHash = 'orders';
-        const reset = this.safeValue(message, 'reset', false);
+        const reset = this.safeBool(message, 'reset', false);
         let stored = this.orders;
         if (stored === undefined || reset) {
             const limit = this.safeInteger(this.options, 'ordersLimit', 1000);
@@ -459,7 +459,7 @@ export default class probit extends probitRest {
             storedOrderBook = this.orderBook({});
             this.orderbooks[symbol] = storedOrderBook;
         }
-        const reset = this.safeValue(message, 'reset', false);
+        const reset = this.safeBool(message, 'reset', false);
         if (reset) {
             const snapshot = this.parseOrderBook(dataBySide, symbol, undefined, 'buy', 'sell', 'price', 'quantity');
             storedOrderBook.reset(snapshot);

package/js/src/pro/whitebit.js

@@ -741,7 +741,7 @@ export default class whitebit extends whitebitRest {
             let hasSymbolSubscription = true;
             const market = this.market(symbol);
             const marketId = market['id'];
-            const isSubscribed = this.safeValue(subscription, marketId, false);
+            const isSubscribed = this.safeBool(subscription, marketId, false);
             if (!isSubscribed) {
                 subscription[marketId] = true;
                 hasSymbolSubscription = false;

package/js/src/probit.js

@@ -287,7 +287,7 @@ export default class probit extends Exchange {
         const quoteId = this.safeString(market, 'quote_currency_id');
         const base = this.safeCurrencyCode(baseId);
         const quote = this.safeCurrencyCode(quoteId);
-        const closed = this.safeValue(market, 'closed', false);
+        const closed = this.safeBool(market, 'closed', false);
         const takerFeeRate = this.safeString(market, 'taker_fee_rate');
         const taker = Precise.stringDiv(takerFeeRate, '100');
         const makerFeeRate = this.safeString(market, 'maker_fee_rate');

package/js/src/timex.js

@@ -724,7 +724,7 @@ export default class timex extends Exchange {
         const market = this.market(symbol);
         const uppercaseSide = side.toUpperCase();
         let uppercaseType = type.toUpperCase();
-        const postOnly = this.safeValue(params, 'postOnly', false);
+        const postOnly = this.safeBool(params, 'postOnly', false);
         if (postOnly) {
             uppercaseType = 'POST_ONLY';
             params = this.omit(params, ['postOnly']);

package/js/src/tokocrypto.js

@@ -692,7 +692,7 @@ export default class tokocrypto extends Exchange {
                     break;
                 }
             }
-            const isMarginTradingAllowed = this.safeValue(market, 'isMarginTradingAllowed', false);
+            const isMarginTradingAllowed = this.safeBool(market, 'isMarginTradingAllowed', false);
             const entry = {
                 'id': id,
                 'lowercaseId': lowercaseId,
@@ -1591,7 +1591,7 @@ export default class tokocrypto extends Exchange {
         await this.loadMarkets();
         const market = this.market(symbol);
         const clientOrderId = this.safeString2(params, 'clientOrderId', 'clientId');
-        const postOnly = this.safeValue(params, 'postOnly', false);
+        const postOnly = this.safeBool(params, 'postOnly', false);
         // only supported for spot/margin api
         if (postOnly) {
             type = 'LIMIT_MAKER';
@@ -2465,7 +2465,7 @@ export default class tokocrypto extends Exchange {
         }
         // check success value for wapi endpoints
         // response in format {'msg': 'The coin does not exist.', 'success': true/false}
-        const success = this.safeValue(response, 'success', true);
+        const success = this.safeBool(response, 'success', true);
         if (!success) {
             const messageInner = this.safeString(response, 'msg');
             let parsedMessage = undefined;

package/js/src/wavesexchange.js

@@ -398,7 +398,7 @@ export default class wavesexchange extends Exchange {
         //        "matcherFee":"4077612"
         //     }
         //  }
-        const isDiscountFee = this.safeValue(params, 'isDiscountFee', false);
+        const isDiscountFee = this.safeBool(params, 'isDiscountFee', false);
         let mode = undefined;
         if (isDiscountFee) {
             mode = this.safeValue(response, 'discount');
@@ -2415,7 +2415,7 @@ export default class wavesexchange extends Exchange {
     }
     handleErrors(code, reason, url, method, headers, body, response, requestHeaders, requestBody) {
         const errorCode = this.safeString(response, 'error');
-        const success = this.safeValue(response, 'success', true);
+        const success = this.safeBool(response, 'success', true);
         const Exception = this.safeValue(this.exceptions, errorCode);
         if (Exception !== undefined) {
             const messageInner = this.safeString(response, 'message');

package/js/src/whitebit.js

@@ -425,8 +425,8 @@ export default class whitebit extends Exchange {
             const currency = response[id];
             // breaks down in Python due to utf8 encoding issues on the exchange side
             // const name = this.safeString (currency, 'name');
-            const canDeposit = this.safeValue(currency, 'can_deposit', true);
-            const canWithdraw = this.safeValue(currency, 'can_withdraw', true);
+            const canDeposit = this.safeBool(currency, 'can_deposit', true);
+            const canWithdraw = this.safeBool(currency, 'can_withdraw', true);
             const active = canDeposit && canWithdraw;
             const code = this.safeCurrencyCode(id);
             result[code] = {

package/js/src/woo.js

@@ -1136,7 +1136,7 @@ export default class woo extends Exchange {
          * @param {boolean} [params.stop] whether the order is a stop/algo order
          * @returns {object} An [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
          */
-        const stop = this.safeValue(params, 'stop', false);
+        const stop = this.safeBool(params, 'stop', false);
         params = this.omit(params, 'stop');
         if (!stop && (symbol === undefined)) {
             throw new ArgumentsRequired(this.id + ' cancelOrder() requires a symbol argument');
@@ -1304,7 +1304,7 @@ export default class woo extends Exchange {
         const request = {};
         let market = undefined;
         const stop = this.safeValue(params, 'stop');
-        const trailing = this.safeValue(params, 'trailing', false);
+        const trailing = this.safeBool(params, 'trailing', false);
         params = this.omit(params, ['stop', 'trailing']);
         if (symbol !== undefined) {
             market = this.market(symbol);
@@ -2086,7 +2086,7 @@ export default class woo extends Exchange {
         //
         const transfer = this.parseTransfer(response, currency);
         const transferOptions = this.safeValue(this.options, 'transfer', {});
-        const fillResponseFromRequest = this.safeValue(transferOptions, 'fillResponseFromRequest', true);
+        const fillResponseFromRequest = this.safeBool(transferOptions, 'fillResponseFromRequest', true);
         if (fillResponseFromRequest) {
             transfer['amount'] = amount;
             transfer['fromAccount'] = fromAccount;

package/js/src/yobit.js

@@ -1291,7 +1291,7 @@ export default class yobit extends Exchange {
             //
             // To cover points 1, 2, 3 and 4 combined this handler should work like this:
             //
-            let success = this.safeValue(response, 'success', false);
+            let success = this.safeBool(response, 'success', false);
             if (typeof success === 'string') {
                 if ((success === 'true') || (success === '1')) {
                     success = true;

package/js/src/zaif.js

@@ -728,7 +728,7 @@ export default class zaif extends Exchange {
             this.throwBroadlyMatchedException(this.exceptions['broad'], error, feedback);
             throw new ExchangeError(feedback); // unknown message
         }
-        const success = this.safeValue(response, 'success', true);
+        const success = this.safeBool(response, 'success', true);
         if (!success) {
             throw new ExchangeError(feedback);
         }

package/js/src/zonda.d.ts

@@ -42,7 +42,7 @@ export default class zonda extends Exchange {
     fetchTrades(symbol: string, since?: Int, limit?: Int, params?: {}): Promise<Trade[]>;
     createOrder(symbol: string, type: OrderType, side: OrderSide, amount: any, price?: any, params?: {}): Promise<Order>;
     cancelOrder(id: string, symbol?: Str, params?: {}): Promise<any>;
-    isFiat(currency: any): any;
+    isFiat(currency: any): boolean;
     parseDepositAddress(depositAddress: any, currency?: Currency): {
         currency: string;
         address: string;

package/js/src/zonda.js

@@ -1439,7 +1439,7 @@ export default class zonda extends Exchange {
         //     }
         //
         const id = this.safeString2(response, 'offerId', 'stopOfferId');
-        const completed = this.safeValue(response, 'completed', false);
+        const completed = this.safeBool(response, 'completed', false);
         const status = completed ? 'closed' : 'open';
         const transactions = this.safeValue(response, 'transactions');
         return this.safeOrder({
@@ -1501,7 +1501,7 @@ export default class zonda extends Exchange {
             'EUR': true,
             'PLN': true,
         };
-        return this.safeValue(fiatCurrencies, currency, false);
+        return this.safeBool(fiatCurrencies, currency, false);
     }
     parseDepositAddress(depositAddress, currency = undefined) {
         //
@@ -1638,7 +1638,7 @@ export default class zonda extends Exchange {
         //
         const transfer = this.parseTransfer(response, currency);
         const transferOptions = this.safeValue(this.options, 'transfer', {});
-        const fillResponseFromRequest = this.safeValue(transferOptions, 'fillResponseFromRequest', true);
+        const fillResponseFromRequest = this.safeBool(transferOptions, 'fillResponseFromRequest', true);
         if (fillResponseFromRequest) {
             transfer['amount'] = amount;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.2.29",
+  "version": "4.2.30",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 100+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",

package/skip-tests.json

@@ -380,16 +380,8 @@
             "fetchTrades": {
                 "side": "not set"
             },
-            "fetchTickers": {
-                "quoteVolume": "quoteVolume >= baseVolume * low is failing",
-                "baseVolume": "quoteVolume >= baseVolume * low is failing",
-                "bid": "bid ask crossed",
-                "ask": "bid ask crossed"
-            },
-            "fetchTicker": {
-                "quoteVolume": "quoteVolume >= baseVolume * low is failing",
-                "baseVolume": "quoteVolume >= baseVolume * low is failing"
-            }
+            "fetchTickers": "skip",
+            "fetchTicker": "skip"
         }
     },
     "bitso": {
@@ -1324,6 +1316,7 @@
     },
     "p2b": {
         "skip": "temp issues",
+        "skipWs": "flaky",
         "httpsProxy": "http://51.83.140.52:11230",
         "skipMethods": {
             "loadMarkets": "invalid URL",