ccxt 4.1.51 → 4.1.52

package/js/src/coinlist.d.ts

@@ -1,5 +1,5 @@
 import Exchange from './abstract/coinlist.js';
-import { Balances, Int, OHLCV, Order, OrderBook, OrderSide, OrderType, Ticker, Tickers, Trade, Transaction } from './base/types.js';
+import { Balances, Int, Market, OHLCV, Order, OrderBook, OrderSide, OrderType, Ticker, Tickers, Trade, Transaction } from './base/types.js';
 /**
  * @class coinlist
  * @extends Exchange
@@ -9,7 +9,8 @@ export default class coinlist extends Exchange {
     calculateRateLimiterCost(api: any, method: any, path: any, params: any, config?: {}): number;
     fetchTime(params?: {}): Promise<number>;
     fetchCurrencies(params?: {}): Promise<{}>;
-    fetchMarkets(params?: {}): Promise<any[]>;
+    fetchMarkets(params?: {}): Promise<Market[]>;
+    parseMarket(market: any): Market;
     fetchTickers(symbols?: string[], params?: {}): Promise<Tickers>;
     fetchTicker(symbol: string, params?: {}): Promise<Ticker>;
     parseTicker(ticker: any, market?: any): Ticker;

package/js/src/coinlist.js

@@ -415,68 +415,66 @@ export default class coinlist extends Exchange {
         //     }
         //
         const markets = this.safeValue(response, 'symbols', []);
-        const result = [];
-        for (let i = 0; i < markets.length; i++) {
-            const market = markets[i];
-            const id = this.safeString(market, 'symbol');
-            const baseId = this.safeString(market, 'base_currency');
-            const quoteId = this.safeString(market, 'quote_currency');
-            const base = this.safeCurrencyCode(baseId);
-            const quote = this.safeCurrencyCode(quoteId);
-            const amountPrecision = this.safeString(market, 'minimum_size_increment');
-            const pricePrecision = this.safeString(market, 'minimum_price_increment');
-            const created = this.safeString(market, 'list_time');
-            result.push({
-                'id': id,
-                'symbol': base + '/' + quote,
-                'base': base,
-                'quote': quote,
-                'settle': undefined,
-                'baseId': baseId,
-                'quoteId': quoteId,
-                'settleId': undefined,
-                'type': 'spot',
-                'spot': true,
-                'margin': false,
-                'swap': false,
-                'future': false,
-                'option': false,
-                'active': true,
-                'contract': false,
-                'linear': undefined,
-                'inverse': undefined,
-                'contractSize': undefined,
-                'expiry': undefined,
-                'expiryDatetime': undefined,
-                'strike': undefined,
-                'optionType': undefined,
-                'precision': {
-                    'amount': this.parseNumber(amountPrecision),
-                    'price': this.parseNumber(pricePrecision),
+        return this.parseMarkets(markets);
+    }
+    parseMarket(market) {
+        const id = this.safeString(market, 'symbol');
+        const baseId = this.safeString(market, 'base_currency');
+        const quoteId = this.safeString(market, 'quote_currency');
+        const base = this.safeCurrencyCode(baseId);
+        const quote = this.safeCurrencyCode(quoteId);
+        const amountPrecision = this.safeString(market, 'minimum_size_increment');
+        const pricePrecision = this.safeString(market, 'minimum_price_increment');
+        const created = this.safeString(market, 'list_time');
+        return {
+            'id': id,
+            'symbol': base + '/' + quote,
+            'base': base,
+            'quote': quote,
+            'settle': undefined,
+            'baseId': baseId,
+            'quoteId': quoteId,
+            'settleId': undefined,
+            'type': 'spot',
+            'spot': true,
+            'margin': false,
+            'swap': false,
+            'future': false,
+            'option': false,
+            'active': true,
+            'contract': false,
+            'linear': undefined,
+            'inverse': undefined,
+            'contractSize': undefined,
+            'expiry': undefined,
+            'expiryDatetime': undefined,
+            'strike': undefined,
+            'optionType': undefined,
+            'precision': {
+                'amount': this.parseNumber(amountPrecision),
+                'price': this.parseNumber(pricePrecision),
+            },
+            'limits': {
+                'leverage': {
+                    'min': undefined,
+                    'max': undefined,
                 },
-                'limits': {
-                    'leverage': {
-                        'min': undefined,
-                        'max': undefined,
-                    },
-                    'amount': {
-                        'min': undefined,
-                        'max': undefined,
-                    },
-                    'price': {
-                        'min': undefined,
-                        'max': undefined,
-                    },
-                    'cost': {
-                        'min': undefined,
-                        'max': undefined,
-                    },
+                'amount': {
+                    'min': undefined,
+                    'max': undefined,
                 },
-                'created': this.parse8601(created),
-                'info': market,
-            });
-        }
-        return result;
+                'price': {
+                    'min': undefined,
+                    'max': undefined,
+                },
+                'cost': {
+                    'min': undefined,
+                    'max': undefined,
+                },
+            },
+            'created': this.parse8601(created),
+            'info': market,
+        };
     }
     async fetchTickers(symbols = undefined, params = {}) {
         /**
@@ -2039,6 +2037,8 @@ export default class coinlist extends Exchange {
             'status': undefined,
             'updated': undefined,
             'fee': fee,
+            'comment': this.safeString(transaction, 'description'),
+            'internal': undefined,
         };
     }
     parseTransactionType(type) {

package/js/src/coinmate.js

@@ -491,6 +491,7 @@ export default class coinmate extends Exchange {
             'tagTo': undefined,
             'updated': undefined,
             'comment': undefined,
+            'internal': undefined,
             'fee': {
                 'cost': this.safeNumber(transaction, 'fee'),
                 'currency': code,

package/js/src/coinsph.js

@@ -1764,11 +1764,8 @@ export default class coinsph extends Exchange {
         if (feeCost !== undefined) {
             fee = { 'currency': code, 'cost': feeCost };
         }
-        let internal = this.safeInteger(transaction, 'transferType');
-        if (internal !== undefined) {
-            internal = internal ? true : false;
-        }
         const network = this.safeString(transaction, 'network');
+        const internal = network === 'Internal';
         return {
             'info': transaction,
             'id': id,
@@ -1788,6 +1785,7 @@ export default class coinsph extends Exchange {
             'status': status,
             'updated': updated,
             'internal': internal,
+            'comment': undefined,
             'fee': fee,
         };
     }

package/js/src/cryptocom.js

@@ -2413,6 +2413,7 @@ export default class cryptocom extends Exchange {
             'status': status,
             'updated': this.safeInteger(transaction, 'update_time'),
             'internal': undefined,
+            'comment': this.safeString(transaction, 'client_wid'),
             'fee': fee,
         };
     }

package/js/src/currencycom.js

@@ -1616,7 +1616,7 @@ export default class currencycom extends Exchange {
             fee['currency'] = code;
             fee['cost'] = feeCost;
         }
-        const result = {
+        return {
             'info': transaction,
             'id': this.safeString(transaction, 'id'),
             'txid': this.safeString(transaction, 'blockchainTransactionHash'),
@@ -1634,10 +1634,10 @@ export default class currencycom extends Exchange {
             'tagFrom': undefined,
             'tagTo': undefined,
             'updated': undefined,
+            'internal': undefined,
             'comment': undefined,
             'fee': fee,
         };
-        return result;
     }
     parseTransactionStatus(status) {
         const statuses = {

package/js/src/deribit.js

@@ -2315,6 +2315,8 @@ export default class deribit extends Exchange {
             'status': status,
             'updated': updated,
             'network': undefined,
+            'internal': undefined,
+            'comment': undefined,
             'fee': fee,
         };
     }

package/js/src/digifinex.js

@@ -1636,7 +1636,7 @@ export default class digifinex extends Exchange {
             const amount = this.safeValue(rawOrder, 'amount');
             const price = this.safeValue(rawOrder, 'price');
             const orderParams = this.safeValue(rawOrder, 'params', {});
-            const marginResult = this.handleMarginModeAndParams('createOrders', params);
+            const marginResult = this.handleMarginModeAndParams('createOrders', orderParams);
             const currentMarginMode = marginResult[0];
             if (currentMarginMode !== undefined) {
                 if (marginMode === undefined) {
@@ -1648,7 +1648,8 @@ export default class digifinex extends Exchange {
                     }
                 }
             }
-            const orderRequest = this.createOrderRequest(marketId, type, side, amount, price, orderParams);
+            let orderRequest = this.createOrderRequest(marketId, type, side, amount, price, orderParams);
+            orderRequest = this.omit(orderRequest, 'marginMode');
             ordersRequests.push(orderRequest);
         }
         const market = this.market(symbol);
@@ -2812,6 +2813,8 @@ export default class digifinex extends Exchange {
             'currency': code,
             'status': status,
             'updated': updated,
+            'internal': undefined,
+            'comment': undefined,
             'fee': fee,
         };
     }

package/js/src/exmo.js

@@ -2297,6 +2297,7 @@ export default class exmo extends Exchange {
             'tagTo': undefined,
             'updated': this.safeTimestamp(transaction, 'updated'),
             'comment': comment,
+            'internal': undefined,
             'fee': fee,
         };
     }

package/js/src/gate.js

@@ -3643,6 +3643,8 @@ export default class gate extends Exchange {
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
             'updated': undefined,
+            'internal': undefined,
+            'comment': undefined,
             'fee': {
                 'currency': code,
                 'cost': this.parseNumber(feeCostString),

package/js/src/gemini.js

@@ -1601,6 +1601,8 @@ export default class gemini extends Exchange {
             'currency': code,
             'status': this.parseTransactionStatus(statusRaw),
             'updated': undefined,
+            'internal': undefined,
+            'comment': this.safeString(transaction, 'message'),
             'fee': fee,
         };
     }

package/js/src/hitbtc.js

@@ -1443,6 +1443,9 @@ export default class hitbtc extends Exchange {
         const sender = this.safeValue(native, 'senders');
         const addressFrom = this.safeString(sender, 0);
         const amount = this.safeNumber(native, 'amount');
+        const subType = this.safeString(transaction, 'subtype');
+        const internal = subType === 'OFFCHAIN';
+        // https://api.hitbtc.com/#check-if-offchain-is-available
         const fee = {
             'currency': undefined,
             'cost': undefined,
@@ -1472,6 +1475,7 @@ export default class hitbtc extends Exchange {
             'tagTo': tagTo,
             'updated': updated,
             'comment': undefined,
+            'internal': internal,
             'fee': fee,
         };
     }

package/js/src/hollaex.js

@@ -1654,6 +1654,8 @@ export default class hollaex extends Exchange {
             'currency': currency['code'],
             'status': status,
             'updated': updated,
+            'comment': this.safeString(transaction, 'message'),
+            'internal': undefined,
             'fee': fee,
         };
     }

package/js/src/htx.js

@@ -6072,6 +6072,8 @@ export default class htx extends Exchange {
         if (networkId === 'ETH' && txHash.indexOf('0x') < 0) {
             txHash = '0x' + txHash;
         }
+        const subType = this.safeString(transaction, 'sub-type');
+        const internal = subType === 'FAST';
         return {
             'info': transaction,
             'id': this.safeString2(transaction, 'id', 'data'),
@@ -6090,6 +6092,8 @@ export default class htx extends Exchange {
             'currency': code,
             'status': this.parseTransactionStatus(this.safeString(transaction, 'state')),
             'updated': this.safeInteger(transaction, 'updated-at'),
+            'comment': undefined,
+            'internal': internal,
             'fee': {
                 'currency': code,
                 'cost': this.parseNumber(feeCost),

package/js/src/huobijp.js

@@ -1732,6 +1732,8 @@ export default class huobijp extends Exchange {
             'currency': code,
             'status': this.parseTransactionStatus(this.safeString(transaction, 'state')),
             'updated': this.safeInteger(transaction, 'updated-at'),
+            'comment': undefined,
+            'internal': undefined,
             'fee': {
                 'currency': code,
                 'cost': this.parseNumber(feeCost),

package/js/src/idex.js

@@ -1677,6 +1677,8 @@ export default class idex extends Exchange {
             'currency': code,
             'status': status,
             'updated': updated,
+            'comment': undefined,
+            'internal': undefined,
             'fee': fee,
         };
     }

package/js/src/indodax.js

@@ -1002,6 +1002,7 @@ export default class indodax extends Exchange {
             'tag': undefined,
             'tagTo': undefined,
             'comment': this.safeString(transaction, 'withdraw_memo'),
+            'internal': undefined,
             'fee': fee,
             'info': transaction,
         };

package/js/src/kraken.js

@@ -1713,9 +1713,7 @@ export default class kraken extends Exchange {
         if (!(id in result)) {
             throw new OrderNotFound(this.id + ' fetchOrder() could not find order id ' + id);
         }
-        const order = this.parseOrder(this.extend({ 'id': id }, result[id]));
-        order['info'] = order;
-        return order;
+        return this.parseOrder(this.extend({ 'id': id }, result[id]));
     }
     async fetchOrderTrades(id, symbol = undefined, since = undefined, limit = undefined, params = {}) {
         /**
@@ -2162,6 +2160,8 @@ export default class kraken extends Exchange {
             'txid': txid,
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
+            'comment': undefined,
+            'internal': undefined,
             'fee': {
                 'currency': code,
                 'cost': feeCost,

package/js/src/kucoin.js

@@ -1760,8 +1760,8 @@ export default class kucoin extends Exchange {
          * @method
          * @name kucoin#fetchOrderBook
          * @description fetches information on open orders with bid (buy) and ask (sell) prices, volumes and other data
-         * @see https://docs.kucoin.com/#get-part-order-book-aggregated
-         * @see https://docs.kucoin.com/#get-full-order-book-aggregated
+         * @see https://www.kucoin.com/docs/rest/spot-trading/market-data/get-part-order-book-aggregated-
+         * @see https://www.kucoin.com/docs/rest/spot-trading/market-data/get-full-order-book-aggregated-
          * @param {string} symbol unified symbol of the market to fetch the order book for
          * @param {int} [limit] the maximum amount of order book entries to return
          * @param {object} [params] extra parameters specific to the kucoin api endpoint
@@ -1771,7 +1771,6 @@ export default class kucoin extends Exchange {
         const market = this.market(symbol);
         const level = this.safeInteger(params, 'level', 2);
         const request = { 'symbol': market['id'] };
-        let method = 'publicGetMarketOrderbookLevelLevelLimit';
         const isAuthenticated = this.checkRequiredCredentials(false);
         let response = undefined;
         if (!isAuthenticated || limit !== undefined) {
@@ -1787,11 +1786,11 @@ export default class kucoin extends Exchange {
                 }
                 request['limit'] = limit ? limit : 100;
             }
+            response = await this.publicGetMarketOrderbookLevelLevelLimit(this.extend(request, params));
         }
         else {
-            method = 'privateGetMarketOrderbookLevel2'; // recommended (v3)
+            response = await this.privateGetMarketOrderbookLevel2(this.extend(request, params));
         }
-        response = await this[method](this.extend(request, params));
         //
         // public (v1) market/orderbook/level2_20 and market/orderbook/level2_100
         //
@@ -3163,6 +3162,7 @@ export default class kucoin extends Exchange {
                 updated = updated * 1000;
             }
         }
+        const internal = this.safeValue(transaction, 'isInner');
         const tag = this.safeString(transaction, 'memo');
         return {
             'info': transaction,
@@ -3182,6 +3182,7 @@ export default class kucoin extends Exchange {
             'type': type,
             'status': this.parseTransactionStatus(rawStatus),
             'comment': this.safeString(transaction, 'remark'),
+            'internal': internal,
             'fee': fee,
             'updated': updated,
         };

package/js/src/kuna.js

@@ -1773,6 +1773,7 @@ export default class kuna extends Exchange {
         const type = this.safeStringLower(transaction, 'type');
         const address = this.safeString(transaction, 'address');
         const isDeposit = (type === 'deposit');
+        const parsedType = isDeposit ? type : 'withdrawal';
         return {
             'info': transaction,
             'id': this.safeString(transaction, 'id'),
@@ -1785,13 +1786,14 @@ export default class kuna extends Exchange {
             'address': address,
             'addressTo': address,
             'amount': this.safeNumber(transaction, 'amount'),
-            'type': !isDeposit ? 'withdrawal' : type,
+            'type': parsedType,
             'status': this.parseTransactionStatus(this.safeString(transaction, 'status')),
             'updated': this.parse8601(this.safeString(transaction, 'updatedAt')),
             'tagFrom': undefined,
             'tag': undefined,
             'tagTo': undefined,
             'comment': this.safeString(transaction, 'memo'),
+            'internal': undefined,
             'fee': {
                 'cost': this.safeNumber(transaction, 'fee'),
                 'currency': code,

package/js/src/latoken.js

@@ -1495,6 +1495,7 @@ export default class latoken extends Exchange {
             'status': status,
             'updated': undefined,
             'comment': undefined,
+            'internal': undefined,
             'fee': fee,
         };
     }

package/js/src/lbank.js

@@ -782,6 +782,7 @@ export default class lbank extends Exchange {
             'tag': undefined,
             'tagTo': undefined,
             'comment': undefined,
+            'internal': undefined,
             'fee': undefined,
             'info': transaction,
         };

package/js/src/lykke.js

@@ -1165,6 +1165,8 @@ export default class lykke extends Exchange {
             'currency': code,
             'status': undefined,
             'updated': undefined,
+            'internal': undefined,
+            'comment': undefined,
             'fee': fee,
         };
     }

package/js/src/mercado.js

@@ -713,6 +713,7 @@ export default class mercado extends Exchange {
             'tag': undefined,
             'tagTo': undefined,
             'comment': undefined,
+            'internal': undefined,
             'fee': undefined,
             'info': transaction,
         };

package/js/src/mexc.js

@@ -4542,6 +4542,8 @@ export default class mexc extends Exchange {
             'currency': code,
             'status': status,
             'updated': undefined,
+            'comment': undefined,
+            'internal': undefined,
             'fee': fee,
         };
     }

package/js/src/ndax.js

@@ -2267,6 +2267,8 @@ export default class ndax extends Exchange {
             'status': this.parseTransactionStatusByType(transactionStatus, type),
             'updated': updated,
             'fee': fee,
+            'internal': undefined,
+            'comment': undefined,
             'network': undefined,
         };
     }

package/js/src/novadax.js

@@ -1424,6 +1424,7 @@ export default class novadax extends Exchange {
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
             'comment': undefined,
+            'internal': undefined,
             'fee': {
                 'currency': undefined,
                 'cost': undefined,

package/js/src/okcoin.js

@@ -2714,6 +2714,8 @@ export default class okcoin extends Exchange {
             'txid': txid,
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
+            'comment': undefined,
+            'internal': undefined,
             'fee': {
                 'currency': code,
                 'cost': feeCost,

package/js/src/okx.js

@@ -4892,6 +4892,8 @@ export default class okx extends Exchange {
             'txid': txid,
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
+            'internal': undefined,
+            'comment': undefined,
             'fee': {
                 'currency': code,
                 'cost': feeCost,

package/js/src/phemex.js

@@ -3325,6 +3325,8 @@ export default class phemex extends Exchange {
             'currency': code,
             'status': status,
             'updated': undefined,
+            'comment': undefined,
+            'internal': undefined,
             'fee': fee,
         };
     }

package/js/src/poloniex.js

@@ -2253,6 +2253,7 @@ export default class poloniex extends Exchange {
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
             'comment': undefined,
+            'internal': undefined,
             'fee': {
                 'currency': code,
                 'cost': this.parseNumber(feeCostString),

package/js/src/pro/binance.js

@@ -2362,8 +2362,10 @@ export default class binance extends binanceRest {
             market = this.getMarketFromSymbols(symbols);
             messageHash = '::' + symbols.join(',');
         }
-        const defaultType = this.safeString2(this.options, 'watchPositions', 'defaultType', 'future');
-        let type = this.safeString(params, 'type', defaultType);
+        let type = this.handleMarketTypeAndParams('watchPositions', market, params);
+        if (type === 'spot' || type === 'margin') {
+            type = 'future';
+        }
         let subType = undefined;
         [subType, params] = this.handleSubTypeAndParams('watchPositions', market, params);
         if (this.isLinear(type, subType)) {
@@ -2508,7 +2510,7 @@ export default class binance extends binanceRest {
         return this.safePosition({
             'info': position,
             'id': undefined,
-            'symbol': this.safeSymbol(marketId),
+            'symbol': this.safeSymbol(marketId, undefined, undefined, 'future'),
             'notional': undefined,
             'marginMode': this.safeString(position, 'mt'),
             'liquidationPrice': undefined,

package/js/src/pro/coinbase.js

@@ -15,14 +15,23 @@ export default class coinbase extends coinbaseRest {
         return this.deepExtend(super.describe(), {
             'has': {
                 'ws': true,
+                'cancelAllOrdersWs': false,
+                'cancelOrdersWs': false,
+                'cancelOrderWs': false,
+                'createOrderWs': false,
+                'editOrderWs': false,
+                'fetchBalanceWs': false,
+                'fetchOpenOrdersWs': false,
+                'fetchOrderWs': false,
+                'fetchTradesWs': false,
+                'watchBalance': false,
+                'watchMyTrades': false,
                 'watchOHLCV': false,
                 'watchOrderBook': true,
+                'watchOrders': true,
                 'watchTicker': true,
                 'watchTickers': true,
                 'watchTrades': true,
-                'watchBalance': false,
-                'watchOrders': true,
-                'watchMyTrades': false,
             },
             'urls': {
                 'api': {