ccxt 4.1.40 → 4.1.43

package/js/src/okx.js

@@ -570,9 +570,12 @@ export default class okx extends Exchange {
                     '51028': ContractUnavailable,
                     '51029': ContractUnavailable,
                     '51030': ContractUnavailable,
+                    '51031': InvalidOrder,
                     '51046': InvalidOrder,
                     '51047': InvalidOrder,
-                    '51031': InvalidOrder,
+                    '51072': InvalidOrder,
+                    '51073': InvalidOrder,
+                    '51074': InvalidOrder,
                     '51100': InvalidOrder,
                     '51101': InvalidOrder,
                     '51102': InvalidOrder,
@@ -617,6 +620,7 @@ export default class okx extends Exchange {
                     '51163': InvalidOrder,
                     '51166': InvalidOrder,
                     '51174': InvalidOrder,
+                    '51185': InvalidOrder,
                     '51201': InvalidOrder,
                     '51202': InvalidOrder,
                     '51203': InvalidOrder,
@@ -764,6 +768,8 @@ export default class okx extends Exchange {
                     '59200': InsufficientFunds,
                     '59201': InsufficientFunds,
                     '59216': BadRequest,
+                    '59260': PermissionDenied,
+                    '59262': PermissionDenied,
                     '59300': ExchangeError,
                     '59301': ExchangeError,
                     '59313': ExchangeError,
@@ -777,6 +783,8 @@ export default class okx extends Exchange {
                     '59506': ExchangeError,
                     '59507': ExchangeError,
                     '59508': AccountSuspended,
+                    '59642': BadRequest,
+                    '59643': ExchangeError,
                     // WebSocket error Codes from 60000-63999
                     '60001': AuthenticationError,
                     '60002': AuthenticationError,

package/js/src/pro/binance.js

@@ -1237,10 +1237,11 @@ export default class binance extends binanceRest {
     }
     async authenticate(params = {}) {
         const time = this.milliseconds();
-        let type = this.safeString2(this.options, 'defaultType', 'authenticate', 'spot');
-        type = this.safeString(params, 'type', type);
+        let query = undefined;
+        let type = undefined;
+        [type, query] = this.handleMarketTypeAndParams('authenticate', undefined, params);
         let subType = undefined;
-        [subType, params] = this.handleSubTypeAndParams('authenticate', undefined, params);
+        [subType, query] = this.handleSubTypeAndParams('authenticate', undefined, query);
         if (this.isLinear(type, subType)) {
             type = 'future';
         }
@@ -1248,11 +1249,11 @@ export default class binance extends binanceRest {
             type = 'delivery';
         }
         let marginMode = undefined;
-        [marginMode, params] = this.handleMarginModeAndParams('authenticate', params);
+        [marginMode, query] = this.handleMarginModeAndParams('authenticate', query);
         const isIsolatedMargin = (marginMode === 'isolated');
         const isCrossMargin = (marginMode === 'cross') || (marginMode === undefined);
-        const symbol = this.safeString(params, 'symbol');
-        params = this.omit(params, 'symbol');
+        const symbol = this.safeString(query, 'symbol');
+        query = this.omit(query, 'symbol');
         const options = this.safeValue(this.options, type, {});
         const lastAuthenticatedTime = this.safeInteger(options, 'lastAuthenticatedTime', 0);
         const listenKeyRefreshRate = this.safeInteger(this.options, 'listenKeyRefreshRate', 1200000);
@@ -1274,9 +1275,9 @@ export default class binance extends binanceRest {
                     throw new ArgumentsRequired(this.id + ' authenticate() requires a symbol argument for isolated margin mode');
                 }
                 const marketId = this.marketId(symbol);
-                params = this.extend(params, { 'symbol': marketId });
+                query = this.extend(query, { 'symbol': marketId });
             }
-            const response = await this[method](params);
+            const response = await this[method](query);
             this.options[type] = this.extend(options, {
                 'listenKey': this.safeString(response, 'listenKey'),
                 'lastAuthenticatedTime': time,
@@ -1288,8 +1289,8 @@ export default class binance extends binanceRest {
         // https://binance-docs.github.io/apidocs/spot/en/#listen-key-spot
         let type = this.safeString2(this.options, 'defaultType', 'authenticate', 'spot');
         type = this.safeString(params, 'type', type);
-        let subType = undefined;
-        [subType, params] = this.handleSubTypeAndParams('keepAliveListenKey', undefined, params);
+        const subTypeInfo = this.handleSubTypeAndParams('keepAliveListenKey', undefined, params);
+        const subType = subTypeInfo[0];
         if (this.isLinear(type, subType)) {
             type = 'future';
         }
@@ -2066,7 +2067,7 @@ export default class binance extends binanceRest {
             market = this.market(symbol);
             symbol = market['symbol'];
             messageHash += ':' + symbol;
-            params = this.extend(params, { 'symbol': symbol }); // needed inside authenticate for isolated margin
+            params = this.extend(params, { 'type': market['type'], 'symbol': symbol }); // needed inside authenticate for isolated margin
         }
         await this.authenticate(params);
         let type = undefined;
@@ -2079,7 +2080,11 @@ export default class binance extends binanceRest {
         else if (this.isInverse(type, subType)) {
             type = 'delivery';
         }
-        const url = this.urls['api']['ws'][type] + '/' + this.options[type]['listenKey'];
+        let urlType = type;
+        if (type === 'margin') {
+            urlType = 'spot'; // spot-margin shares the same stream as regular spot
+        }
+        const url = this.urls['api']['ws'][urlType] + '/' + this.options[type]['listenKey'];
         const client = this.client(url);
         this.setBalanceCache(client, type);
         const message = undefined;
@@ -2419,10 +2424,15 @@ export default class binance extends binanceRest {
          * @returns {object[]} a list of [trade structures]{@link https://github.com/ccxt/ccxt/wiki/Manual#trade-structure
          */
         await this.loadMarkets();
-        const defaultType = this.safeString2(this.options, 'watchMyTrades', 'defaultType', 'spot');
-        let type = this.safeString(params, 'type', defaultType);
+        let type = undefined;
+        let market = undefined;
+        if (symbol !== undefined) {
+            market = this.market(symbol);
+            symbol = market['symbol'];
+        }
+        [type, params] = this.handleMarketTypeAndParams('watchMyTrades', market, params);
         let subType = undefined;
-        [subType, params] = this.handleSubTypeAndParams('watchMyTrades', undefined, params);
+        [subType, params] = this.handleSubTypeAndParams('watchMyTrades', market, params);
         if (this.isLinear(type, subType)) {
             type = 'future';
         }
@@ -2433,10 +2443,14 @@ export default class binance extends binanceRest {
         if (symbol !== undefined) {
             symbol = this.symbol(symbol);
             messageHash += ':' + symbol;
-            params = this.extend(params, { 'symbol': symbol });
+            params = this.extend(params, { 'type': market['type'], 'symbol': symbol });
         }
         await this.authenticate(params);
-        const url = this.urls['api']['ws'][type] + '/' + this.options[type]['listenKey'];
+        let urlType = type; // we don't change type because the listening key is different
+        if (type === 'margin') {
+            urlType = 'spot'; // spot-margin shares the same stream as regular spot
+        }
+        const url = this.urls['api']['ws'][urlType] + '/' + this.options[type]['listenKey'];
         const client = this.client(url);
         this.setBalanceCache(client, type);
         const message = undefined;

package/js/src/probit.d.ts

@@ -48,7 +48,7 @@ export default class probit extends Exchange {
         id: string;
         currency: any;
         amount: number;
-        network: any;
+        network: string;
         addressFrom: any;
         address: string;
         addressTo: string;
@@ -71,7 +71,7 @@ export default class probit extends Exchange {
         id: string;
         currency: any;
         amount: number;
-        network: any;
+        network: string;
         addressFrom: any;
         address: string;
         addressTo: string;

package/js/src/probit.js

@@ -1484,6 +1484,7 @@ export default class probit extends Exchange {
          * @param {string} code unified currency code
          * @param {int} [since] the earliest time in ms to fetch transactions for
          * @param {int} [limit] the maximum number of transaction structures to retrieve
+         * @param {int} [params.until] the latest time in ms to fetch transactions for
          * @param {object} [params] extra parameters specific to the probit api endpoint
          * @returns {object[]} a list of [transaction structures]{@link https://github.com/ccxt/ccxt/wiki/Manual#transaction-structure}
          */
@@ -1497,6 +1498,17 @@ export default class probit extends Exchange {
         if (since !== undefined) {
             request['start_time'] = this.iso8601(since);
         }
+        else {
+            request['start_time'] = this.iso8601(1);
+        }
+        const until = this.safeInteger2(params, 'till', 'until');
+        if (until !== undefined) {
+            request['end_time'] = this.iso8601(until);
+            params = this.omit(params, ['until', 'till']);
+        }
+        else {
+            request['end_time'] = this.iso8601(this.milliseconds());
+        }
         if (limit !== undefined) {
             request['limit'] = limit;
         }
@@ -1532,7 +1544,29 @@ export default class probit extends Exchange {
         return this.parseTransactions(data, currency, since, limit);
     }
     parseTransaction(transaction, currency = undefined) {
+        //
+        //     {
+        //         "id": "01211d4b-0e68-41d6-97cb-298bfe2cab67",
+        //         "type": "deposit",
+        //         "status": "done",
+        //         "amount": "0.01",
+        //         "address": "0x9e7430fc0bdd14745bd00a1b92ed25133a7c765f",
+        //         "time": "2023-06-14T12:03:11.000Z",
+        //         "hash": "0x0ff5bedc9e378f9529acc6b9840fa8c2ef00fd0275e0bac7fa0589a9b5d1712e",
+        //         "currency_id": "ETH",
+        //         "confirmations":0,
+        //         "fee": "0",
+        //         "destination_tag": null,
+        //         "platform_id": "ETH",
+        //         "fee_currency_id": "ETH",
+        //         "payment_service_name":null,
+        //         "payment_service_display_name":null,
+        //         "crypto":null
+        //     }
+        //
         const id = this.safeString(transaction, 'id');
+        const networkId = this.safeString(transaction, 'platform_id');
+        const networkCode = this.networkIdToCode(networkId);
         const amount = this.safeNumber(transaction, 'amount');
         const address = this.safeString(transaction, 'address');
         const tag = this.safeString(transaction, 'destination_tag');
@@ -1554,7 +1588,7 @@ export default class probit extends Exchange {
             'id': id,
             'currency': code,
             'amount': amount,
-            'network': undefined,
+            'network': networkCode,
             'addressFrom': undefined,
             'address': address,
             'addressTo': address,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.1.40",
+  "version": "4.1.43",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 130+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",

package/skip-tests.json

@@ -1368,6 +1368,7 @@
         }
     },
     "tidex": {
+        "skip": "exchange unavailable, probably api upgrade needed"
     },
     "kraken": {
         "skipWs": true,
@@ -1567,5 +1568,16 @@
                 "liquidationPrice": "undefined"
             }
         }
+    },
+    "coinlist": {
+        "skipMethods": {
+            "fetchTicker": {
+                "quoteVolume": "quoteVolume >= baseVolume * low  is failing"
+            },
+            "fetchTickers": {
+                "quoteVolume": "quoteVolume >= baseVolume * low  is failing",
+                "ask": "invalid"
+            }
+        }
     }
 }