ccxt 4.1.1 → 4.1.3

package/js/src/bingx.js

@@ -1528,6 +1528,8 @@ export default class bingx extends Exchange {
          * @param {float} [price] the price at which the order is to be fullfilled, in units of the quote currency, ignored in market orders
          * @param {object} [params] extra parameters specific to the bingx api endpoint
          * @param {bool} [params.postOnly] true to place a post only order
+         * @param {string} [params.timeInForce] spot supports 'PO' and 'IOC', swap supports 'PO', 'GTC', 'IOC' and 'FOK'
+         * @param {bool} [params.reduceOnly] *swap only* true or false whether the order is reduce only
          * @param {float} [params.triggerPrice] *swap only* triggerPrice at which the attached take profit / stop loss order will be triggered
          * @param {float} [params.stopLossPrice] *swap only* stop loss trigger price
          * @param {float} [params.takeProfitPrice] *swap only* take profit trigger price
@@ -1535,8 +1537,10 @@ export default class bingx extends Exchange {
          */
         await this.loadMarkets();
         const market = this.market(symbol);
+        let postOnly = undefined;
         let response = undefined;
-        const [marketType, query] = this.handleMarketTypeAndParams('createOrder', market, params);
+        let marketType = undefined;
+        [marketType, params] = this.handleMarketTypeAndParams('createOrder', market, params);
         type = type.toUpperCase();
         const request = {
             'symbol': market['id'],
@@ -1544,51 +1548,16 @@ export default class bingx extends Exchange {
             'side': side.toUpperCase(),
         };
         const isMarketOrder = type === 'MARKET';
-        const isSpotMarket = marketType === 'spot';
-        let stopPriceRaw = undefined;
-        let stopPrice = undefined;
-        let stopLossPrice = undefined;
-        let takeProfitPrice = undefined;
-        if (!isSpotMarket) {
-            stopPriceRaw = this.safeValue2(params, 'stopPrice', 'triggerPrice');
-            if (stopPriceRaw !== undefined) {
-                stopPrice = this.priceToPrecision(symbol, stopPriceRaw);
-            }
-            stopLossPrice = this.safeValue(params, 'stopLossPrice');
-            takeProfitPrice = this.safeValue(params, 'takeProfitPrice');
-        }
-        if ((stopLossPrice !== undefined) && (takeProfitPrice !== undefined)) {
-            throw new InvalidOrder('Order is either a takeProfit order or a stopLoss order');
-        }
-        if ((type === 'LIMIT') || (type === 'TRIGGER_LIMIT')) {
-            request['price'] = this.priceToPrecision(symbol, price);
-            if ((stopPrice !== undefined)) {
-                request['type'] = 'TRIGGER_LIMIT';
-                request['stopPrice'] = stopPrice;
-            }
-            if (type === 'TRIGGER_LIMIT') {
-                if (stopPrice === undefined) {
-                    throw new InvalidOrder('TRIGGER_LIMIT requires a triggerPrice / stopPrice');
-                }
-                request['stopPrice'] = stopPrice;
-            }
-        }
-        if (isMarketOrder || (type === 'TRIGGER_MARKET')) {
-            if ((stopPrice !== undefined)) {
-                request['type'] = 'TRIGGER_MARKET';
-                request['stopPrice'] = stopPrice;
+        const isSpot = marketType === 'spot';
+        const timeInForce = this.safeStringUpper(params, 'timeInForce');
+        if (timeInForce === 'IOC') {
+            request['timeInForce'] = 'IOC';
+        }
+        if (isSpot) {
+            [postOnly, params] = this.handlePostOnly(isMarketOrder, timeInForce === 'POC', params);
+            if (postOnly || (timeInForce === 'POC')) {
+                request['timeInForce'] = 'POC';
             }
-            if (type === 'TRIGGER_MARKET') {
-                if (stopPrice === undefined) {
-                    throw new InvalidOrder('TRIGGER_MARKET requires a triggerPrice / stopPrice');
-                }
-                request['stopPrice'] = stopPrice;
-            }
-        }
-        const exchangeSpecificTifParam = this.safeStringUpperN(params, ['force', 'timeInForce']);
-        let postOnly = undefined;
-        [postOnly, params] = this.handlePostOnly(isMarketOrder, exchangeSpecificTifParam === 'POC', params);
-        if (isSpotMarket) {
             const createMarketBuyOrderRequiresPrice = this.safeValue(this.options, 'createMarketBuyOrderRequiresPrice', true);
             if (createMarketBuyOrderRequiresPrice && isMarketOrder && (side === 'buy')) {
                 if (price === undefined) {
@@ -1604,35 +1573,77 @@ export default class bingx extends Exchange {
             else {
                 request['quantity'] = this.amountToPrecision(symbol, amount);
             }
+            if (!isMarketOrder) {
+                request['price'] = this.priceToPrecision(symbol, price);
+            }
+            response = await this.spotV1PrivatePostTradeOrder(this.extend(request, params));
         }
         else {
+            [postOnly, params] = this.handlePostOnly(isMarketOrder, timeInForce === 'PostOnly', params);
+            if (postOnly || (timeInForce === 'PostOnly')) {
+                request['timeInForce'] = 'PostOnly';
+            }
+            else if (timeInForce === 'GTC') {
+                request['timeInForce'] = 'GTC';
+            }
+            else if (timeInForce === 'FOK') {
+                request['timeInForce'] = 'FOK';
+            }
+            if ((type === 'LIMIT') || (type === 'TRIGGER_LIMIT') || (type === 'STOP') || (type === 'TAKE_PROFIT')) {
+                request['price'] = this.priceToPrecision(symbol, price);
+            }
+            const triggerPrice = this.safeNumber2(params, 'stopPrice', 'triggerPrice');
+            const stopLossPrice = this.safeNumber(params, 'stopLossPrice');
+            const takeProfitPrice = this.safeNumber(params, 'takeProfitPrice');
+            const isTriggerOrder = triggerPrice !== undefined;
+            const isStopLossPriceOrder = stopLossPrice !== undefined;
+            const isTakeProfitPriceOrder = takeProfitPrice !== undefined;
+            if (isTriggerOrder) {
+                request['stopPrice'] = this.priceToPrecision(symbol, triggerPrice);
+                if (isMarketOrder || (type === 'TRIGGER_MARKET')) {
+                    request['type'] = 'TRIGGER_MARKET';
+                }
+                else if ((type === 'LIMIT') || (type === 'TRIGGER_LIMIT')) {
+                    request['type'] = 'TRIGGER_LIMIT';
+                }
+            }
+            else if (isStopLossPriceOrder || isTakeProfitPriceOrder) {
+                // This can be used to set the stop loss and take profit, but the position needs to be opened first
+                if (isStopLossPriceOrder) {
+                    request['stopPrice'] = this.priceToPrecision(symbol, stopLossPrice);
+                    if (isMarketOrder || (type === 'STOP_MARKET')) {
+                        request['type'] = 'STOP_MARKET';
+                    }
+                    else if ((type === 'LIMIT') || (type === 'STOP')) {
+                        request['type'] = 'STOP';
+                    }
+                }
+                else if (isTakeProfitPriceOrder) {
+                    request['stopPrice'] = this.priceToPrecision(symbol, takeProfitPrice);
+                    if (isMarketOrder || (type === 'TAKE_PROFIT_MARKET')) {
+                        request['type'] = 'TAKE_PROFIT_MARKET';
+                    }
+                    else if ((type === 'LIMIT') || (type === 'TAKE_PROFIT')) {
+                        request['type'] = 'TAKE_PROFIT';
+                    }
+                }
+            }
+            const reduceOnly = this.safeValue(params, 'reduceOnly', false);
+            let positionSide = undefined;
+            if (reduceOnly) {
+                positionSide = (side === 'buy') ? 'SHORT' : 'LONG';
+            }
+            else {
+                positionSide = (side === 'buy') ? 'LONG' : 'SHORT';
+            }
+            request['positionSide'] = positionSide;
             request['quantity'] = this.amountToPrecision(symbol, amount);
-        }
-        if ((stopLossPrice !== undefined)) {
-            request['type'] = 'STOP_MARKET';
-            request['stopPrice'] = this.priceToPrecision(symbol, stopLossPrice);
-        }
-        if ((takeProfitPrice !== undefined)) {
-            request['type'] = 'TAKE_PROFIT_MARKET';
-            request['stopPrice'] = this.priceToPrecision(symbol, takeProfitPrice);
-        }
-        if (postOnly) {
-            request['timeInForce'] = 'POC';
-        }
-        else if (exchangeSpecificTifParam === 'POC') {
-            request['timeInForce'] = 'POC';
-        }
-        else if (!isSpotMarket) {
-            request['timeInForce'] = 'GTC';
-        }
-        if (isSpotMarket) {
-            response = await this.spotV1PrivatePostTradeOrder(this.extend(request, query));
-        }
-        else {
-            response = await this.swapV2PrivatePostTradeOrder(this.extend(request, query));
+            params = this.omit(params, ['reduceOnly', 'triggerPrice', 'stopLossPrice', 'takeProfitPrice']);
+            response = await this.swapV2PrivatePostTradeOrder(this.extend(request, params));
         }
         //
         // spot
+        //
         //    {
         //        "code": 0,
         //        "msg": "",
@@ -1652,23 +1663,25 @@ export default class bingx extends Exchange {
         //
         // swap
         //
-        //    {
-        //        "code": 0,
-        //        "msg": "",
-        //        "data": {
-        //          "order": {
-        //            "symbol": "BTC-USDT",
-        //            "orderId": 1590973236294713344,
-        //            "side": "BUY",
-        //            "positionSide": "LONG",
-        //            "type": "LIMIT"
-        //          }
-        //        }
-        //    }
+        //     {
+        //         "code": 0,
+        //         "msg": "",
+        //         "data": {
+        //             "order": {
+        //                 "symbol": "BTC-USDT",
+        //                 "orderId": 1709036527545438208,
+        //                 "side": "BUY",
+        //                 "positionSide": "LONG",
+        //                 "type": "TRIGGER_LIMIT",
+        //                 "clientOrderID": "",
+        //                 "workingType": ""
+        //             }
+        //         }
+        //     }
         //
-        const data = this.safeValue(response, 'data');
-        const first = this.safeValue(data, 'order', data);
-        return this.parseOrder(first, market);
+        const data = this.safeValue(response, 'data', {});
+        const order = this.safeValue(data, 'order', data);
+        return this.parseOrder(order, market);
     }
     parseOrder(order, market = undefined) {
         //
@@ -1738,65 +1751,68 @@ export default class bingx extends Exchange {
         //
         // fetchOrder, fetchOpenOrders, fetchClosedOrders
         //
-        //    {
-        //        "symbol": "LINK-USDT",
-        //        "orderId": 1585839271162413056,
-        //        "side": "BUY",
-        //        "positionSide": "LONG",
-        //        "type": "TRIGGER_MARKET",
-        //        "origQty": "5.0",
-        //        "price": "9",
-        //        "executedQty": "0.0",
-        //        "avgPrice": "0",
-        //        "cumQuote": "0",
-        //        "stopPrice": "5",
-        //        "profit": "0.0000",
-        //        "commission": "0.000000",
-        //        "status": "CANCELLED",
-        //        "time": 1667631605000,
-        //        "updateTime": 1667631605000
-        //    }
+        //     {
+        //         "symbol": "BTC-USDT",
+        //         "orderId": 1709036527545438208,
+        //         "side": "BUY",
+        //         "positionSide": "LONG",
+        //         "type": "TRIGGER_LIMIT",
+        //         "origQty": "0.0010",
+        //         "price": "22000.0",
+        //         "executedQty": "0.0000",
+        //         "avgPrice": "0.0",
+        //         "cumQuote": "",
+        //         "stopPrice": "23000.0",
+        //         "profit": "",
+        //         "commission": "",
+        //         "status": "NEW",
+        //         "time": 1696301035187,
+        //         "updateTime": 1696301035187,
+        //         "clientOrderId": "",
+        //         "leverage": "",
+        //         "takeProfit": "",
+        //         "stopLoss": "",
+        //         "advanceAttr": 0,
+        //         "positionID": 0,
+        //         "takeProfitEntrustPrice": 0,
+        //         "stopLossEntrustPrice": 0,
+        //         "orderType": "",
+        //         "workingType": "MARK_PRICE"
+        //     }
         //
         const positionSide = this.safeString(order, 'positionSide');
         const marketType = (positionSide === undefined) ? 'spot' : 'swap';
         const marketId = this.safeString(order, 'symbol');
         const symbol = this.safeSymbol(marketId, market, '-', marketType);
-        const orderId = this.safeString(order, 'orderId');
-        const side = this.safeStringLower(order, 'side');
-        const type = this.safeStringLower(order, 'type');
         const timestamp = this.safeInteger2(order, 'time', 'transactTime');
-        const lastTradeTimestamp = this.safeInteger(order, 'updateTime');
-        const price = this.safeString(order, 'price');
-        const average = this.safeString(order, 'avgPrice');
-        const amount = this.safeString(order, 'origQty');
-        const filled = this.safeString(order, 'executedQty');
-        const statusId = this.safeString(order, 'status');
         const fee = {
             'currency': this.safeString(order, 'feeAsset'),
             'rate': this.safeString2(order, 'fee', 'commission'),
         };
-        const clientOrderId = this.safeString(order, 'clientOrderId');
         return this.safeOrder({
             'info': order,
-            'id': orderId,
-            'clientOrderId': clientOrderId,
+            'id': this.safeString(order, 'orderId'),
+            'clientOrderId': this.safeString(order, 'clientOrderId'),
             'timestamp': timestamp,
             'datetime': this.iso8601(timestamp),
-            'lastTradeTimestamp': lastTradeTimestamp,
+            'lastTradeTimestamp': this.safeInteger(order, 'updateTime'),
+            'lastUpdateTimestamp': this.safeInteger(order, 'updateTime'),
             'symbol': symbol,
-            'type': type,
+            'type': this.safeStringLower(order, 'type'),
             'timeInForce': undefined,
             'postOnly': undefined,
-            'side': side,
-            'price': price,
-            'stopPrice': this.safeNumber(order, 'triggerPrice'),
-            'triggerPrice': this.safeNumber(order, 'triggerPrice'),
-            'average': average,
+            'side': this.safeStringLower(order, 'side'),
+            'price': this.safeString(order, 'price'),
+            'stopPrice': this.safeNumber(order, 'stopPrice'),
+            'triggerPrice': this.safeNumber(order, 'stopPrice'),
+            'stopLossPrice': this.safeNumber(order, 'stopLoss'),
+            'takeProfitPrice': this.safeNumber(order, 'takeProfit'),
+            'average': this.safeString(order, 'avgPrice'),
             'cost': undefined,
-            'amount': amount,
-            'filled': filled,
+            'amount': this.safeString(order, 'origQty'),
+            'filled': this.safeString(order, 'executedQty'),
             'remaining': undefined,
-            'status': this.parseOrderStatus(statusId),
+            'status': this.parseOrderStatus(this.safeString(order, 'status')),
             'fee': fee,
             'trades': undefined,
         }, market);

package/js/src/bitget.js

@@ -3805,7 +3805,7 @@ export default class bitget extends Exchange {
         //
         const data = this.safeValue(response, 'data');
         if (data !== undefined) {
-            return this.safeValue2(data, 'orderList', 'data', []);
+            return this.safeValue(data, 'orderList', data);
         }
         const parsedData = JSON.parse(response);
         return this.safeValue(parsedData, 'data', []);

package/js/src/bitmart.d.ts

@@ -267,6 +267,9 @@ export default class bitmart extends Exchange {
         previousFundingTimestamp: any;
         previousFundingDatetime: any;
     };
+    fetchPosition(symbol: string, params?: {}): Promise<import("./base/types.js").Position>;
+    fetchPositions(symbols?: string[], params?: {}): Promise<import("./base/types.js").Position[]>;
+    parsePosition(position: any, market?: any): import("./base/types.js").Position;
     nonce(): number;
     sign(path: any, api?: string, method?: string, params?: {}, headers?: any, body?: any): {
         url: string;

package/js/src/bitmart.js

@@ -74,7 +74,9 @@ export default class bitmart extends Exchange {
                 'fetchOrderBook': true,
                 'fetchOrders': false,
                 'fetchOrderTrades': true,
+                'fetchPosition': true,
                 'fetchPositionMode': false,
+                'fetchPositions': true,
                 'fetchStatus': true,
                 'fetchTicker': true,
                 'fetchTickers': true,
@@ -3759,6 +3761,180 @@ export default class bitmart extends Exchange {
             'previousFundingDatetime': undefined,
         };
     }
+    async fetchPosition(symbol, params = {}) {
+        /**
+         * @method
+         * @name bitmart#fetchPosition
+         * @description fetch data on a single open contract trade position
+         * @see https://developer-pro.bitmart.com/en/futures/#get-current-position-keyed
+         * @param {string} symbol unified market symbol of the market the position is held in
+         * @param {object} [params] extra parameters specific to the bitmart api endpoint
+         * @returns {object} a [position structure]{@link https://github.com/ccxt/ccxt/wiki/Manual#position-structure}
+         */
+        await this.loadMarkets();
+        const market = this.market(symbol);
+        const request = {
+            'symbol': market['id'],
+        };
+        const response = await this.privateGetContractPrivatePosition(this.extend(request, params));
+        //
+        //     {
+        //         "code": 1000,
+        //         "message": "Ok",
+        //         "data": [
+        //             {
+        //                 "symbol": "BTCUSDT",
+        //                 "leverage": "10",
+        //                 "timestamp": 1696392515269,
+        //                 "current_fee": "0.0014250028",
+        //                 "open_timestamp": 1696392256998,
+        //                 "current_value": "27.4039",
+        //                 "mark_price": "27.4039",
+        //                 "position_value": "27.4079",
+        //                 "position_cross": "3.75723474",
+        //                 "maintenance_margin": "0.1370395",
+        //                 "close_vol": "0",
+        //                 "close_avg_price": "0",
+        //                 "open_avg_price": "27407.9",
+        //                 "entry_price": "27407.9",
+        //                 "current_amount": "1",
+        //                 "unrealized_value": "-0.004",
+        //                 "realized_value": "-0.01644474",
+        //                 "position_type": 1
+        //             }
+        //         ],
+        //         "trace":"4cad855074664097ac5ba5257c47305d.67.16963925142065945"
+        //     }
+        //
+        const data = this.safeValue(response, 'data', []);
+        const first = this.safeValue(data, 0, {});
+        return this.parsePosition(first, market);
+    }
+    async fetchPositions(symbols = undefined, params = {}) {
+        /**
+         * @method
+         * @name bitmart#fetchPositions
+         * @description fetch all open contract positions
+         * @see https://developer-pro.bitmart.com/en/futures/#get-current-position-keyed
+         * @param {string[]|undefined} symbols list of unified market symbols
+         * @param {object} [params] extra parameters specific to the bitmart api endpoint
+         * @returns {object[]} a list of [position structures]{@link https://github.com/ccxt/ccxt/wiki/Manual#position-structure}
+         */
+        await this.loadMarkets();
+        let market = undefined;
+        let symbolsLength = undefined;
+        if (symbols !== undefined) {
+            symbolsLength = symbols.length;
+            const first = this.safeString(symbols, 0);
+            market = this.market(first);
+        }
+        const request = {};
+        if (symbolsLength === 1) {
+            // only supports symbols as undefined or sending one symbol
+            request['symbol'] = market['id'];
+        }
+        const response = await this.privateGetContractPrivatePosition(this.extend(request, params));
+        //
+        //     {
+        //         "code": 1000,
+        //         "message": "Ok",
+        //         "data": [
+        //             {
+        //                 "symbol": "BTCUSDT",
+        //                 "leverage": "10",
+        //                 "timestamp": 1696392515269,
+        //                 "current_fee": "0.0014250028",
+        //                 "open_timestamp": 1696392256998,
+        //                 "current_value": "27.4039",
+        //                 "mark_price": "27.4039",
+        //                 "position_value": "27.4079",
+        //                 "position_cross": "3.75723474",
+        //                 "maintenance_margin": "0.1370395",
+        //                 "close_vol": "0",
+        //                 "close_avg_price": "0",
+        //                 "open_avg_price": "27407.9",
+        //                 "entry_price": "27407.9",
+        //                 "current_amount": "1",
+        //                 "unrealized_value": "-0.004",
+        //                 "realized_value": "-0.01644474",
+        //                 "position_type": 1
+        //             },
+        //         ],
+        //         "trace":"4cad855074664097ac5ba5257c47305d.67.16963925142065945"
+        //     }
+        //
+        const positions = this.safeValue(response, 'data', []);
+        const result = [];
+        for (let i = 0; i < positions.length; i++) {
+            result.push(this.parsePosition(positions[i]));
+        }
+        symbols = this.marketSymbols(symbols);
+        return this.filterByArrayPositions(result, 'symbol', symbols, false);
+    }
+    parsePosition(position, market = undefined) {
+        //
+        //     {
+        //         "symbol": "BTCUSDT",
+        //         "leverage": "10",
+        //         "timestamp": 1696392515269,
+        //         "current_fee": "0.0014250028",
+        //         "open_timestamp": 1696392256998,
+        //         "current_value": "27.4039",
+        //         "mark_price": "27.4039",
+        //         "position_value": "27.4079",
+        //         "position_cross": "3.75723474",
+        //         "maintenance_margin": "0.1370395",
+        //         "close_vol": "0",
+        //         "close_avg_price": "0",
+        //         "open_avg_price": "27407.9",
+        //         "entry_price": "27407.9",
+        //         "current_amount": "1",
+        //         "unrealized_value": "-0.004",
+        //         "realized_value": "-0.01644474",
+        //         "position_type": 1
+        //     }
+        //
+        const marketId = this.safeString(position, 'symbol');
+        market = this.safeMarket(marketId, market);
+        const symbol = market['symbol'];
+        const timestamp = this.safeInteger(position, 'timestamp');
+        const side = this.safeInteger(position, 'position_type');
+        const maintenanceMargin = this.safeString(position, 'maintenance_margin');
+        const notional = this.safeString(position, 'current_value');
+        const collateral = this.safeString(position, 'position_cross');
+        const maintenanceMarginPercentage = Precise.stringDiv(maintenanceMargin, notional);
+        const marginRatio = Precise.stringDiv(maintenanceMargin, collateral);
+        return this.safePosition({
+            'info': position,
+            'id': undefined,
+            'symbol': symbol,
+            'timestamp': timestamp,
+            'datetime': this.iso8601(timestamp),
+            'lastUpdateTimestamp': undefined,
+            'hedged': undefined,
+            'side': (side === 1) ? 'long' : 'short',
+            'contracts': this.safeNumber(position, 'current_amount'),
+            'contractSize': this.safeNumber(market, 'contractSize'),
+            'entryPrice': this.safeNumber(position, 'entry_price'),
+            'markPrice': this.safeNumber(position, 'mark_price'),
+            'lastPrice': undefined,
+            'notional': this.parseNumber(notional),
+            'leverage': this.safeNumber(position, 'leverage'),
+            'collateral': this.parseNumber(collateral),
+            'initialMargin': undefined,
+            'initialMarginPercentage': undefined,
+            'maintenanceMargin': this.parseNumber(maintenanceMargin),
+            'maintenanceMarginPercentage': this.parseNumber(maintenanceMarginPercentage),
+            'unrealizedPnl': this.safeNumber(position, 'unrealized_value'),
+            'realizedPnl': this.safeNumber(position, 'realized_value'),
+            'liquidationPrice': undefined,
+            'marginMode': undefined,
+            'percentage': undefined,
+            'marginRatio': this.parseNumber(marginRatio),
+            'stopLossPrice': undefined,
+            'takeProfitPrice': undefined,
+        });
+    }
     nonce() {
         return this.milliseconds();
     }

package/js/src/bitrue.js

@@ -832,7 +832,7 @@ export default class bitrue extends Exchange {
             'last': last,
             'previousClose': undefined,
             'change': undefined,
-            'percentage': this.safeString(ticker, 'percentChange'),
+            'percentage': Precise.stringMul(this.safeString(ticker, 'percentChange'), '10000'),
             'average': undefined,
             'baseVolume': this.safeString(ticker, 'baseVolume'),
             'quoteVolume': this.safeString(ticker, 'quoteVolume'),

package/js/src/bybit.js

@@ -4011,6 +4011,16 @@ export default class bybit extends Exchange {
          * @param {float} amount how much of currency you want to trade in units of base currency
          * @param {float} price the price at which the order is to be fullfilled, in units of the base currency, ignored in market orders
          * @param {object} [params] extra parameters specific to the bybit api endpoint
+         * @param {float} [params.triggerPrice] The price that a trigger order is triggered at
+         * @param {float} [params.stopLossPrice] The price that a stop loss order is triggered at
+         * @param {float} [params.takeProfitPrice] The price that a take profit order is triggered at
+         * @param {object} [params.takeProfit] *takeProfit object in params* containing the triggerPrice that the attached take profit order will be triggered
+         * @param {float} [params.takeProfit.triggerPrice] take profit trigger price
+         * @param {object} [params.stopLoss] *stopLoss object in params* containing the triggerPrice that the attached stop loss order will be triggered
+         * @param {float} [params.stopLoss.triggerPrice] stop loss trigger price
+         * @param {string} [params.triggerBy] 'IndexPrice', 'MarkPrice' or 'LastPrice', default is 'LastPrice', required if no initial value for triggerPrice
+         * @param {string} [params.slTriggerBy] 'IndexPrice', 'MarkPrice' or 'LastPrice', default is 'LastPrice', required if no initial value for stopLoss
+         * @param {string} [params.tpTriggerby] 'IndexPrice', 'MarkPrice' or 'LastPrice', default is 'LastPrice', required if no initial value for takeProfit
          * @returns {object} an [order structure]{@link https://docs.ccxt.com/#/?id=order-structure}
          */
         this.checkRequiredSymbol('editOrder', symbol);
@@ -4053,9 +4063,9 @@ export default class bybit extends Exchange {
         if (amount !== undefined) {
             request['qty'] = this.amountToPrecision(symbol, amount);
         }
-        let triggerPrice = this.safeValue2(params, 'triggerPrice', 'stopPrice');
-        const stopLossTriggerPrice = this.safeValue(params, 'stopLossPrice');
-        const takeProfitTriggerPrice = this.safeValue(params, 'takeProfitPrice');
+        let triggerPrice = this.safeString2(params, 'triggerPrice', 'stopPrice');
+        const stopLossTriggerPrice = this.safeString(params, 'stopLossPrice');
+        const takeProfitTriggerPrice = this.safeString(params, 'takeProfitPrice');
         const stopLoss = this.safeValue(params, 'stopLoss');
         const takeProfit = this.safeValue(params, 'takeProfit');
         const isStopLossTriggerOrder = stopLossTriggerPrice !== undefined;
@@ -4066,16 +4076,25 @@ export default class bybit extends Exchange {
             triggerPrice = isStopLossTriggerOrder ? stopLossTriggerPrice : takeProfitTriggerPrice;
         }
         if (triggerPrice !== undefined) {
-            request['triggerPrice'] = triggerPrice;
+            const triggerPriceRequest = (triggerPrice === '0') ? triggerPrice : this.priceToPrecision(symbol, triggerPrice);
+            request['triggerPrice'] = triggerPriceRequest;
+            const triggerBy = this.safeString(params, 'triggerBy', 'LastPrice');
+            request['triggerBy'] = triggerBy;
         }
         if (isStopLoss || isTakeProfit) {
             if (isStopLoss) {
-                const slTriggerPrice = this.safeValue2(stopLoss, 'triggerPrice', 'stopPrice', stopLoss);
-                request['stopLoss'] = slTriggerPrice;
+                const slTriggerPrice = this.safeString2(stopLoss, 'triggerPrice', 'stopPrice', stopLoss);
+                const stopLossRequest = (slTriggerPrice === '0') ? slTriggerPrice : this.priceToPrecision(symbol, slTriggerPrice);
+                request['stopLoss'] = stopLossRequest;
+                const slTriggerBy = this.safeString(params, 'slTriggerBy', 'LastPrice');
+                request['slTriggerBy'] = slTriggerBy;
             }
             if (isTakeProfit) {
-                const tpTriggerPrice = this.safeValue2(takeProfit, 'triggerPrice', 'stopPrice', takeProfit);
-                request['takeProfit'] = tpTriggerPrice;
+                const tpTriggerPrice = this.safeString2(takeProfit, 'triggerPrice', 'stopPrice', takeProfit);
+                const takeProfitRequest = (tpTriggerPrice === '0') ? tpTriggerPrice : this.priceToPrecision(symbol, tpTriggerPrice);
+                request['takeProfit'] = takeProfitRequest;
+                const tpTriggerBy = this.safeString(params, 'tpTriggerBy', 'LastPrice');
+                request['tpTriggerBy'] = tpTriggerBy;
             }
         }
         const clientOrderId = this.safeString(params, 'clientOrderId');

package/js/src/coinbasepro.js

@@ -114,6 +114,7 @@ export default class coinbasepro extends Exchange {
                 },
                 'private': {
                     'get': [
+                        'address-book',
                         'accounts',
                         'accounts/{id}',
                         'accounts/{id}/holds',

package/js/src/deribit.js

@@ -493,7 +493,7 @@ export default class deribit extends Exchange {
         const defaultCode = this.safeValue(this.options, 'code', 'BTC');
         const options = this.safeValue(this.options, methodName, {});
         const code = this.safeValue(options, 'code', defaultCode);
-        return this.safeValue(params, 'code', code);
+        return this.safeValue2(params, 'code', code);
     }
     async fetchStatus(params = {}) {
         /**