ccxt 4.0.99 → 4.0.101

package/dist/cjs/src/pro/kucoin.js

@@ -14,7 +14,7 @@ class kucoin extends kucoin$1 {
                 'watchOrderBook': true,
                 'watchOrders': true,
                 'watchMyTrades': true,
-                'watchTickers': false,
+                'watchTickers': true,
                 'watchTicker': true,
                 'watchTrades': true,
                 'watchTradesForSymbols': true,
@@ -132,6 +132,29 @@ class kucoin extends kucoin$1 {
         const messageHash = 'ticker:' + symbol;
         return await this.subscribe(url, messageHash, topic, query);
     }
+    async watchTickers(symbols = undefined, params = {}) {
+        /**
+         * @method
+         * @name kucoin#watchTickers
+         * @description watches a price ticker, a statistical calculation with the information calculated over the past 24 hours for all markets of a specific list
+         * @param {string[]} symbols unified symbol of the market to fetch the ticker for
+         * @param {object} [params] extra parameters specific to the kucoin api endpoint
+         * @returns {object} a [ticker structure]{@link https://github.com/ccxt/ccxt/wiki/Manual#ticker-structure}
+         */
+        await this.loadMarkets();
+        symbols = this.marketSymbols(symbols);
+        let messageHash = 'tickers';
+        if (symbols !== undefined) {
+            messageHash = 'tickers::' + symbols.join(',');
+        }
+        const url = await this.negotiate(false);
+        const topic = '/market/ticker:all';
+        const tickers = await this.subscribe(url, messageHash, topic, params);
+        if (this.newUpdates) {
+            return tickers;
+        }
+        return this.filterByArray(this.tickers, 'symbol', symbols);
+    }
     handleTicker(client, message) {
         //
         // market/snapshot
@@ -191,7 +214,14 @@ class kucoin extends kucoin$1 {
         let market = undefined;
         if (topic !== undefined) {
             const parts = topic.split(':');
-            const marketId = this.safeString(parts, 1);
+            const first = this.safeString(parts, 1);
+            let marketId = undefined;
+            if (first === 'all') {
+                marketId = this.safeString(message, 'subject');
+            }
+            else {
+                marketId = first;
+            }
             market = this.safeMarket(marketId, market, '-');
         }
         const data = this.safeValue(message, 'data', {});
@@ -201,6 +231,21 @@ class kucoin extends kucoin$1 {
         this.tickers[symbol] = ticker;
         const messageHash = 'ticker:' + symbol;
         client.resolve(ticker, messageHash);
+        // watchTickers
+        client.resolve(ticker, 'tickers');
+        const messageHashes = this.findMessageHashes(client, 'tickers::');
+        for (let i = 0; i < messageHashes.length; i++) {
+            const messageHash = messageHashes[i];
+            const parts = messageHash.split('::');
+            const symbolsString = parts[1];
+            const symbols = symbolsString.split(',');
+            const tickers = this.filterByArray(this.tickers, 'symbol', symbols);
+            const tickersSymbols = Object.keys(tickers);
+            const numTickers = tickersSymbols.length;
+            if (numTickers > 0) {
+                client.resolve(tickers, messageHash);
+            }
+        }
     }
     async watchOHLCV(symbol, timeframe = '1m', since = undefined, limit = undefined, params = {}) {
         /**
@@ -880,6 +925,10 @@ class kucoin extends kucoin$1 {
         //         }
         //     }
         //
+        const topic = this.safeString(message, 'topic');
+        if (topic === '/market/ticker:all') {
+            return this.handleTicker(client, message);
+        }
         const subject = this.safeString(message, 'subject');
         const methods = {
             'trade.l2update': this.handleOrderBook,

package/dist/cjs/src/pro/kucoinfutures.js

@@ -389,9 +389,9 @@ class kucoinfutures extends kucoinfutures$1 {
         const deltaEnd = this.safeInteger(data, 'sequence');
         if (nonce === undefined) {
             const cacheLength = storedOrderBook.cache.length;
-            const topicParts = topic.split(':');
-            const topicSymbol = this.safeString(topicParts, 1);
-            const topicChannel = this.safeString(topicParts, 0);
+            const topicPartsNew = topic.split(':');
+            const topicSymbol = this.safeString(topicPartsNew, 1);
+            const topicChannel = this.safeString(topicPartsNew, 0);
             const subscriptions = Object.keys(client.subscriptions);
             let subscription = undefined;
             for (let i = 0; i < subscriptions.length; i++) {

package/dist/cjs/src/pro/phemex.js

@@ -1123,8 +1123,8 @@ class phemex extends phemex$1 {
         }
         const keys = Object.keys(marketIds);
         for (let i = 0; i < keys.length; i++) {
-            const messageHash = 'orders' + ':' + keys[i];
-            client.resolve(this.orders, messageHash);
+            const currentMessageHash = 'orders' + ':' + keys[i];
+            client.resolve(this.orders, currentMessageHash);
         }
         // resolve generic subscription (spot or swap)
         const messageHash = 'orders:' + type;
@@ -1406,8 +1406,8 @@ class phemex extends phemex$1 {
                 return method.call(this, client, message);
             }
         }
-        const method = this.safeString(message, 'method', '');
-        if (('market24h' in message) || ('spot_market24h' in message) || (method.indexOf('perp_market24h_pack_p') >= 0)) {
+        const methodName = this.safeString(message, 'method', '');
+        if (('market24h' in message) || ('spot_market24h' in message) || (methodName.indexOf('perp_market24h_pack_p') >= 0)) {
             return this.handleTicker(client, message);
         }
         else if (('trades' in message) || ('trades_p' in message)) {

package/dist/cjs/src/pro/poloniex.js

@@ -620,8 +620,8 @@ class poloniex extends poloniex$1 {
                     let totalCost = '0';
                     let totalAmount = '0';
                     const previousOrderTrades = previousOrder['trades'];
-                    for (let i = 0; i < previousOrderTrades.length; i++) {
-                        const previousOrderTrade = previousOrderTrades[i];
+                    for (let j = 0; j < previousOrderTrades.length; j++) {
+                        const previousOrderTrade = previousOrderTrades[j];
                         const cost = this.numberToString(previousOrderTrade['cost']);
                         const amount = this.numberToString(previousOrderTrade['amount']);
                         totalCost = Precise["default"].stringAdd(totalCost, cost);
@@ -861,16 +861,16 @@ class poloniex extends poloniex$1 {
                 }
                 const orderbook = this.orderbooks[symbol];
                 if (bids !== undefined) {
-                    for (let i = 0; i < bids.length; i++) {
-                        const bid = this.safeValue(bids, i);
+                    for (let j = 0; j < bids.length; j++) {
+                        const bid = this.safeValue(bids, j);
                         const price = this.safeNumber(bid, 0);
                         const amount = this.safeNumber(bid, 1);
                         orderbook['bids'].store(price, amount);
                     }
                 }
                 if (asks !== undefined) {
-                    for (let i = 0; i < asks.length; i++) {
-                        const ask = this.safeValue(asks, i);
+                    for (let j = 0; j < asks.length; j++) {
+                        const ask = this.safeValue(asks, j);
                         const price = this.safeNumber(ask, 0);
                         const amount = this.safeNumber(ask, 1);
                         orderbook['asks'].store(price, amount);

package/dist/cjs/src/pro/whitebit.js

@@ -280,8 +280,8 @@ class whitebit extends whitebit$1 {
         // watchTickers
         const messageHashes = Object.keys(client.futures);
         for (let i = 0; i < messageHashes.length; i++) {
-            const messageHash = messageHashes[i];
-            if (messageHash.indexOf('tickers') >= 0 && messageHash.indexOf(symbol) >= 0) {
+            const currentMessageHash = messageHashes[i];
+            if (currentMessageHash.indexOf('tickers') >= 0 && currentMessageHash.indexOf(symbol) >= 0) {
                 // Example: user calls watchTickers with ['LTC/USDT', 'ETH/USDT']
                 // the associated messagehash will be: 'tickers:LTC/USDT:ETH/USDT'
                 // since we only have access to a single symbol at a time
@@ -291,7 +291,7 @@ class whitebit extends whitebit$1 {
                 // user might have multiple watchTickers promises
                 // watchTickers ( ['LTC/USDT', 'ETH/USDT'] ), watchTickers ( ['ETC/USDT', 'DOGE/USDT'] )
                 // and we want to make sure we resolve only the correct ones
-                client.resolve(ticker, messageHash);
+                client.resolve(ticker, currentMessageHash);
             }
         }
         return message;
@@ -749,15 +749,15 @@ class whitebit extends whitebit$1 {
             }
             else {
                 // resubscribe
-                let marketIds = [];
-                marketIds = Object.keys(subscription);
+                let marketIdsNew = [];
+                marketIdsNew = Object.keys(subscription);
                 if (isNested) {
-                    marketIds = [marketIds];
+                    marketIdsNew = [marketIdsNew];
                 }
                 const resubRequest = {
                     'id': id,
                     'method': method,
-                    'params': marketIds,
+                    'params': marketIdsNew,
                 };
                 if (method in client.subscriptions) {
                     delete client.subscriptions[method];

package/dist/cjs/src/probit.js

@@ -431,14 +431,14 @@ class probit extends probit$1 {
                 }
                 const precision = this.parsePrecision(this.safeString(network, 'precision'));
                 const withdrawFee = this.safeValue(network, 'withdrawal_fee', []);
-                const fee = this.safeValue(withdrawFee, 0, {});
+                const networkfee = this.safeValue(withdrawFee, 0, {});
                 networkList[networkCode] = {
                     'id': networkId,
                     'network': networkCode,
                     'active': currentActive,
                     'deposit': currentDeposit,
                     'withdraw': currentWithdraw,
-                    'fee': this.safeNumber(fee, 'amount'),
+                    'fee': this.safeNumber(networkfee, 'amount'),
                     'precision': this.parseNumber(precision),
                     'limits': {
                         'withdraw': {

package/js/ccxt.d.ts

@@ -4,7 +4,7 @@ import * as functions from './src/base/functions.js';
 import * as errors from './src/base/errors.js';
 import { Market, Trade, Fee, Ticker, OrderBook, Order, Transaction, Tickers, Currency, Balance, DepositAddress, WithdrawalResponse, DepositAddressResponse, OHLCV, Balances, PartialBalances, Dictionary, MinMax, Position } from './src/base/types.js';
 import { BaseError, ExchangeError, PermissionDenied, AccountNotEnabled, AccountSuspended, ArgumentsRequired, BadRequest, BadSymbol, MarginModeAlreadySet, BadResponse, NullResponse, InsufficientFunds, InvalidAddress, InvalidOrder, OrderNotFound, OrderNotCached, CancelPending, OrderImmediatelyFillable, OrderNotFillable, DuplicateOrderId, NotSupported, NetworkError, DDoSProtection, RateLimitExceeded, ExchangeNotAvailable, OnMaintenance, InvalidNonce, RequestTimeout, AuthenticationError, AddressPending } from './src/base/errors.js';
-declare const version = "4.0.98";
+declare const version = "4.0.100";
 import ace from './src/ace.js';
 import alpaca from './src/alpaca.js';
 import ascendex from './src/ascendex.js';

package/js/ccxt.js

@@ -38,7 +38,7 @@ import * as errors from './src/base/errors.js';
 import { BaseError, ExchangeError, PermissionDenied, AccountNotEnabled, AccountSuspended, ArgumentsRequired, BadRequest, BadSymbol, MarginModeAlreadySet, BadResponse, NullResponse, InsufficientFunds, InvalidAddress, InvalidOrder, OrderNotFound, OrderNotCached, CancelPending, OrderImmediatelyFillable, OrderNotFillable, DuplicateOrderId, NotSupported, NetworkError, DDoSProtection, RateLimitExceeded, ExchangeNotAvailable, OnMaintenance, InvalidNonce, RequestTimeout, AuthenticationError, AddressPending } from './src/base/errors.js';
 //-----------------------------------------------------------------------------
 // this is updated by vss.js when building
-const version = '4.0.99';
+const version = '4.0.101';
 Exchange.ccxtVersion = version;
 //-----------------------------------------------------------------------------
 import ace from './src/ace.js';

package/js/src/base/Exchange.js

@@ -1661,7 +1661,12 @@ export default class Exchange {
             const oldNumber = this.number;
             // we parse trades as strings here!
             this.number = String;
-            trades = this.parseTrades(rawTrades, market);
+            const firstTrade = this.safeValue(rawTrades, 0);
+            // parse trades if they haven't already been parsed
+            const tradesAreParsed = ((firstTrade !== undefined) && ('info' in firstTrade) && ('id' in firstTrade));
+            if (!tradesAreParsed) {
+                trades = this.parseTrades(rawTrades, market);
+            }
             this.number = oldNumber;
             let tradesLength = 0;
             const isArray = Array.isArray(trades);

package/js/src/binance.js

@@ -3423,6 +3423,18 @@ export default class binance extends Exchange {
         //         "M": true           // Was the trade the best price match?
         //     }
         //
+        // REST: aggregate trades for swap & future (both linear and inverse)
+        //
+        //     {
+        //         "a": "269772814",
+        //         "p": "25864.1",
+        //         "q": "3",
+        //         "f": "662149354",
+        //         "l": "662149355",
+        //         "T": "1694209776022",
+        //         "m": false,
+        //     }
+        //
         // recent public trades and old public trades
         // https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md#recent-trades-list
         // https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md#old-trade-lookup-market_data
@@ -3676,7 +3688,8 @@ export default class binance extends Exchange {
             }
         }
         if (limit !== undefined) {
-            request['limit'] = limit; // default = 500, maximum = 1000
+            const isFutureOrSwap = (market['swap'] || market['future']);
+            request['limit'] = isFutureOrSwap ? Math.min(limit, 1000) : limit; // default = 500, maximum = 1000
         }
         params = this.omit(params, ['until', 'fetchTradesMethod']);
         //
@@ -3705,6 +3718,20 @@ export default class binance extends Exchange {
         //         }
         //     ]
         //
+        // inverse (swap & future)
+        //
+        //     [
+        //      {
+        //         "a": "269772814",
+        //         "p": "25864.1",
+        //         "q": "3",
+        //         "f": "662149354",
+        //         "l": "662149355",
+        //         "T": "1694209776022",
+        //         "m": false,
+        //      },
+        //     ]
+        //
         // recent public trades and historical public trades
         //
         //     [

package/js/src/bitbank.js

@@ -319,6 +319,17 @@ export default class bitbank extends Exchange {
         return this.parseOrderBook(orderbook, market['symbol'], timestamp);
     }
     parseTrade(trade, market = undefined) {
+        //
+        // fetchTrades
+        //
+        //    {
+        //        "transaction_id": "1143247037",
+        //        "side": "buy",
+        //        "price": "3836025",
+        //        "amount": "0.0005",
+        //        "executed_at": "1694249441593"
+        //    }
+        //
         const timestamp = this.safeInteger(trade, 'executed_at');
         market = this.safeMarket(undefined, market);
         const priceString = this.safeString(trade, 'price');

package/js/src/bitfinex.js

@@ -922,14 +922,6 @@ export default class bitfinex extends Exchange {
         //          "type":"sell"
         //     }
         //
-        //     {    "timestamp":1637258238,
-        //          "tid":894452800,
-        //          "price":"0.99958",
-        //          "amount":"261.90514",
-        //          "exchange":"bitfinex",
-        //          "type":"buy"
-        //     }
-        //
         // fetchMyTrades (private) v1
         //
         //     {
@@ -1008,6 +1000,18 @@ export default class bitfinex extends Exchange {
             request['timestamp'] = this.parseToInt(since / 1000);
         }
         const response = await this.publicGetTradesSymbol(this.extend(request, params));
+        //
+        //    [
+        //        {
+        //            "timestamp": "1694284565",
+        //            "tid": "1415415034",
+        //            "price": "25862.0",
+        //            "amount": "0.00020685",
+        //            "exchange": "bitfinex",
+        //            "type": "buy"
+        //        },
+        //    ]
+        //
         return this.parseTrades(response, market, since, limit);
     }
     async fetchMyTrades(symbol = undefined, since = undefined, limit = undefined, params = {}) {

package/js/src/bitflyer.js

@@ -409,7 +409,7 @@ export default class bitflyer extends Exchange {
         //
         // fetchTrades (public) v1
         //
-        //     {
+        //      {
         //          "id":2278466664,
         //          "side":"SELL",
         //          "price":56810.7,
@@ -419,16 +419,18 @@ export default class bitflyer extends Exchange {
         //          "sell_child_order_acceptance_id":"JRF20211119-114639-236919"
         //      }
         //
-        //      {
-        //          "id":2278463423,
-        //          "side":"BUY",
-        //          "price":56757.83,
-        //          "size":0.6003,"exec_date":"2021-11-19T11:28:00.523",
-        //          "buy_child_order_acceptance_id":"JRF20211119-112800-236526",
-        //          "sell_child_order_acceptance_id":"JRF20211119-112734-062017"
-        //      }
-        //
+        // fetchMyTrades
         //
+        //      {
+        //          "id": 37233,
+        //          "side": "BUY",
+        //          "price": 33470,
+        //          "size": 0.01,
+        //          "exec_date": "2015-07-07T09:57:40.397",
+        //          "child_order_id": "JOR20150707-060559-021935",
+        //          "child_order_acceptance_id": "JRF20150707-060559-396699"
+        //          "commission": 0,
+        //      },
         //
         let side = this.safeStringLower(trade, 'side');
         if (side !== undefined) {
@@ -487,6 +489,19 @@ export default class bitflyer extends Exchange {
             request['count'] = limit;
         }
         const response = await this.publicGetGetexecutions(this.extend(request, params));
+        //
+        //    [
+        //     {
+        //       "id": 39287,
+        //       "side": "BUY",
+        //       "price": 31690,
+        //       "size": 27.04,
+        //       "exec_date": "2015-07-08T02:43:34.823",
+        //       "buy_child_order_acceptance_id": "JRF20150707-200203-452209",
+        //       "sell_child_order_acceptance_id": "JRF20150708-024334-060234"
+        //     },
+        //    ]
+        //
         return this.parseTrades(response, market, since, limit);
     }
     async fetchTradingFee(symbol, params = {}) {
@@ -723,6 +738,20 @@ export default class bitflyer extends Exchange {
             request['count'] = limit;
         }
         const response = await this.privateGetGetexecutions(this.extend(request, params));
+        //
+        //    [
+        //     {
+        //       "id": 37233,
+        //       "side": "BUY",
+        //       "price": 33470,
+        //       "size": 0.01,
+        //       "exec_date": "2015-07-07T09:57:40.397",
+        //       "child_order_id": "JOR20150707-060559-021935",
+        //       "child_order_acceptance_id": "JRF20150707-060559-396699"
+        //       "commission": 0,
+        //     },
+        //    ]
+        //
         return this.parseTrades(response, market, since, limit);
     }
     async fetchPositions(symbols = undefined, params = {}) {

package/js/src/bitforex.js

@@ -249,14 +249,6 @@ export default class bitforex extends Exchange {
         //          "tid":"1131019666"
         //      }
         //
-        //      {
-        //          "price":57591.33,
-        //          "amount":0.002,
-        //          "time":1637329685322,
-        //          "direction":1,
-        //          "tid":"1131019639"
-        //      }
-        //
         // fetchMyTrades (private)
         //
         //     {

package/js/src/bitget.js

@@ -2152,7 +2152,7 @@ export default class bitget extends Exchange {
         //         "fillTime": "1692073691000"
         //     }
         //
-        // swap
+        // swap (public trades)
         //
         //     {
         //         "tradeId": "1075199767891652609",
@@ -2284,6 +2284,16 @@ export default class bitget extends Exchange {
             params = this.omit(params, 'method');
             if (swapMethod === 'publicMixGetMarketFillsHistory') {
                 response = await this.publicMixGetMarketFillsHistory(this.extend(request, params));
+                //
+                //     {
+                //         "tradeId": "1084459062491590657",
+                //         "price": "25874",
+                //         "size": "1.624",
+                //         "side": "Buy",
+                //         "timestamp": "1694281109000",
+                //         "symbol": "BTCUSDT_UMCBL",
+                //     }
+                //
             }
             else if (swapMethod === 'publicMixGetMarketFills') {
                 response = await this.publicMixGetMarketFills(this.extend(request, params));
@@ -2984,12 +2994,12 @@ export default class bitget extends Exchange {
             }
             else if (isStopLossOrTakeProfit) {
                 if (isStopLoss) {
-                    const stopLossTriggerPrice = this.safeValue2(stopLoss, 'triggerPrice', 'stopPrice');
-                    request['presetStopLossPrice'] = this.priceToPrecision(symbol, stopLossTriggerPrice);
+                    const slTriggerPrice = this.safeValue2(stopLoss, 'triggerPrice', 'stopPrice');
+                    request['presetStopLossPrice'] = this.priceToPrecision(symbol, slTriggerPrice);
                 }
                 if (isTakeProfit) {
-                    const takeProfitTriggerPrice = this.safeValue2(takeProfit, 'triggerPrice', 'stopPrice');
-                    request['presetTakeProfitPrice'] = this.priceToPrecision(symbol, takeProfitTriggerPrice);
+                    const tpTriggerPrice = this.safeValue2(takeProfit, 'triggerPrice', 'stopPrice');
+                    request['presetTakeProfitPrice'] = this.priceToPrecision(symbol, tpTriggerPrice);
                 }
             }
         }

package/js/src/bitstamp1.js

@@ -218,6 +218,17 @@ export default class bitstamp1 extends Exchange {
         return this.parseTicker(ticker, market);
     }
     parseTrade(trade, market = undefined) {
+        //
+        // public trade
+        //
+        //        {
+        //            "amount": "0.00114000",
+        //            "date": "1694287856",
+        //            "price": "25865",
+        //            "tid": 298730788,
+        //            "type": 0
+        //        }
+        //
         const timestamp = this.safeTimestamp2(trade, 'date', 'datetime');
         const side = (trade['type'] === 0) ? 'buy' : 'sell';
         const orderId = this.safeString(trade, 'order_id');
@@ -262,6 +273,17 @@ export default class bitstamp1 extends Exchange {
             'time': 'minute',
         };
         const response = await this.publicGetTransactions(this.extend(request, params));
+        //
+        //    [
+        //        {
+        //            "amount": "0.00114000",
+        //            "date": "1694287856",
+        //            "price": "25865",
+        //            "tid": 298730788,
+        //            "type": 0
+        //        },
+        //    ]
+        //
         return this.parseTrades(response, market, since, limit);
     }
     parseBalance(response) {

package/js/src/bl3p.js

@@ -244,6 +244,16 @@ export default class bl3p extends Exchange {
         return this.parseTicker(ticker, market);
     }
     parseTrade(trade, market = undefined) {
+        //
+        // fetchTrades
+        //
+        //     {
+        //         "trade_id": "2518789",
+        //         "date": "1694348697745",
+        //         "amount_int": "2959153",
+        //         "price_int": "2416231440"
+        //     }
+        //
         const id = this.safeString(trade, 'trade_id');
         const timestamp = this.safeInteger(trade, 'date');
         const price = this.safeString(trade, 'price_int');
@@ -280,6 +290,20 @@ export default class bl3p extends Exchange {
         const response = await this.publicGetMarketTrades(this.extend({
             'market': market['id'],
         }, params));
+        //
+        //    {
+        //        "result": "success",
+        //        "data": {
+        //            "trades": [
+        //                {
+        //                    "trade_id": "2518789",
+        //                    "date": "1694348697745",
+        //                    "amount_int": "2959153",
+        //                    "price_int": "2416231440"
+        //                },
+        //            ]
+        //        }
+        //     }
         const result = this.parseTrades(response['data']['trades'], market, since, limit);
         return result;
     }