ccxt 4.0.80 → 4.0.82

package/js/src/kucoin.js

@@ -495,6 +495,7 @@ export default class kucoin extends Exchange {
                 'versions': {
                     'public': {
                         'GET': {
+                            'currencies': 'v3',
                             'currencies/{currency}': 'v2',
                             'status': 'v1',
                             'market/orderbook/level2_20': 'v1',
@@ -1000,19 +1001,34 @@ export default class kucoin extends Exchange {
         const promises = [];
         promises.push(this.publicGetCurrencies(params));
         //
-        //     {
-        //         "currency": "OMG",
-        //         "name": "OMG",
-        //         "fullName": "OmiseGO",
-        //         "precision": 8,
-        //         "confirms": 12,
-        //         "withdrawalMinSize": "4",
-        //         "withdrawalMinFee": "1.25",
-        //         "isWithdrawEnabled": false,
-        //         "isDepositEnabled": false,
-        //         "isMarginEnabled": false,
-        //         "isDebitEnabled": false
-        //     }
+        //    {
+        //        "code":"200000",
+        //        "data":[
+        //           {
+        //              "currency":"CSP",
+        //              "name":"CSP",
+        //              "fullName":"Caspian",
+        //              "precision":8,
+        //              "confirms":null,
+        //              "contractAddress":null,
+        //              "isMarginEnabled":false,
+        //              "isDebitEnabled":false,
+        //              "chains":[
+        //                 {
+        //                    "chainName":"ERC20",
+        //                    "chain":"eth",
+        //                    "withdrawalMinSize":"2999",
+        //                    "withdrawalMinFee":"2999",
+        //                    "isWithdrawEnabled":false,
+        //                    "isDepositEnabled":false,
+        //                    "confirms":12,
+        //                    "preConfirms":12,
+        //                    "contractAddress":"0xa6446d655a0c34bc4f05042ee88170d056cbaf45",
+        //                    "depositFeeRate": "0.001", // present for some currencies/networks
+        //                 }
+        //              ]
+        //           },
+        //    }
         //
         promises.push(this.fetchWebEndpoint('fetchCurrencies', 'webExchangeGetCurrencyCurrencyChainInfo', true));
         //
@@ -1023,90 +1039,101 @@ export default class kucoin extends Exchange {
         //        "retry": false,
         //        "data": [
         //            {
-        //                "withdrawMinFee": "0.0005",
-        //                "chainName": "BTC",
-        //                "preDepositTipEnabled": "false",
-        //                "chain": "btc",
+        //                "status": "enabled",
+        //                "currency": "BTC",
         //                "isChainEnabled": "true",
-        //                "withdrawDisabledTip": "",
-        //                "walletPrecision": "8",
+        //                "chain": "btc",
+        //                "chainName": "BTC",
         //                "chainFullName": "Bitcoin",
-        //                "orgAddress": "",
+        //                "walletPrecision": "8",
         //                "isDepositEnabled": "true",
-        //                "withdrawMinSize": "0.001",
-        //                "depositDisabledTip": "",
-        //                "userAddressName": "",
-        //                "txUrl": "https://blockchain.info/tx/{txId}",
-        //                "preWithdrawTipEnabled": "false",
-        //                "withdrawFeeRate": "0",
-        //                "confirmationCount": "2",
-        //                "currency": "BTC",
         //                "depositMinSize": "0.00005",
+        //                "confirmationCount": "2",
         //                "isWithdrawEnabled": "true",
-        //                "preDepositTip": "",
+        //                "withdrawMinSize": "0.001",
+        //                "withdrawMinFee": "0.0005",
+        //                "withdrawFeeRate": "0",
+        //                "depositDisabledTip": "Wallet Maintenance",
+        //                "preDepositTipEnabled": "true",
+        //                "preDepositTip": "Do not transfer from ETH network directly",
+        //                "withdrawDisabledTip": "",
+        //                "preWithdrawTipEnabled": "false",
         //                "preWithdrawTip": "",
-        //                "status": "enabled"
+        //                "orgAddress": "",
+        //                "userAddressName": "Memo",
         //            },
         //        ]
         //    }
         //
         const responses = await Promise.all(promises);
-        const responseCurrencies = responses[0];
-        const responseChains = responses[1];
-        const data = this.safeValue(responseCurrencies, 'data', []);
-        const chainsData = this.safeValue(responseChains, 'data', []);
-        const currencyChains = this.groupBy(chainsData, 'currency');
+        const currenciesResponse = this.safeValue(responses, 0, {});
+        const currenciesData = this.safeValue(currenciesResponse, 'data', []);
+        const additionalResponse = this.safeValue(responses, 1, {});
+        const additionalData = this.safeValue(additionalResponse, 'data', []);
+        const additionalDataGrouped = this.groupBy(additionalData, 'currency');
         const result = {};
-        for (let i = 0; i < data.length; i++) {
-            const entry = data[i];
+        for (let i = 0; i < currenciesData.length; i++) {
+            const entry = currenciesData[i];
             const id = this.safeString(entry, 'currency');
             const name = this.safeString(entry, 'fullName');
             const code = this.safeCurrencyCode(id);
-            const isWithdrawEnabled = this.safeValue(entry, 'isWithdrawEnabled', false);
-            const isDepositEnabled = this.safeValue(entry, 'isDepositEnabled', false);
-            const fee = this.safeNumber(entry, 'withdrawalMinFee');
-            const active = (isWithdrawEnabled && isDepositEnabled);
+            let isWithdrawEnabled = undefined;
+            let isDepositEnabled = undefined;
             const networks = {};
-            const chains = this.safeValue(currencyChains, id, []);
+            const chains = this.safeValue(entry, 'chains', []);
+            const extraChainsData = this.indexBy(this.safeValue(additionalDataGrouped, id, []), 'chain');
+            const precision = this.parseNumber(this.parsePrecision(this.safeString(entry, 'precision')));
             for (let j = 0; j < chains.length; j++) {
                 const chain = chains[j];
                 const chainId = this.safeString(chain, 'chain');
-                const isChainEnabled = this.safeString(chain, 'isChainEnabled'); // better than 'status'
-                if (isChainEnabled === 'true') {
-                    const networkCode = this.networkIdToCode(chainId);
-                    const chainWithdrawEnabled = this.safeValue(chain, 'isWithdrawEnabled', false);
-                    const chainDepositEnabled = this.safeValue(chain, 'isDepositEnabled', false);
-                    networks[networkCode] = {
-                        'info': chain,
-                        'id': chainId,
-                        'name': this.safeString2(chain, 'chainFullName', 'chainName'),
-                        'code': networkCode,
-                        'active': chainWithdrawEnabled && chainDepositEnabled,
-                        'fee': this.safeNumber(chain, 'withdrawMinFee'),
-                        'precision': this.parseNumber(this.parsePrecision(this.safeString(chain, 'walletPrecision'))),
-                        'limits': {
-                            'withdraw': {
-                                'min': this.safeNumber(chain, 'withdrawMinSize'),
-                                'max': undefined,
-                            },
-                            'deposit': {
-                                'min': this.safeNumber(chain, 'depositMinSize'),
-                                'max': undefined,
-                            },
-                        },
-                    };
+                const networkCode = this.networkIdToCode(chainId);
+                const chainWithdrawEnabled = this.safeValue(chain, 'isWithdrawEnabled', false);
+                if (isWithdrawEnabled === undefined) {
+                    isWithdrawEnabled = chainWithdrawEnabled;
                 }
+                else {
+                    isWithdrawEnabled = isWithdrawEnabled || chainWithdrawEnabled;
+                }
+                const chainDepositEnabled = this.safeValue(chain, 'isDepositEnabled', false);
+                if (isDepositEnabled === undefined) {
+                    isDepositEnabled = chainDepositEnabled;
+                }
+                else {
+                    isDepositEnabled = isDepositEnabled || chainDepositEnabled;
+                }
+                const chainExtraData = this.safeValue(extraChainsData, chainId, {});
+                networks[networkCode] = {
+                    'info': chain,
+                    'id': chainId,
+                    'name': this.safeString(chain, 'chainName'),
+                    'code': networkCode,
+                    'active': chainWithdrawEnabled && chainDepositEnabled,
+                    'fee': this.safeNumber(chain, 'withdrawalMinFee'),
+                    'deposit': chainDepositEnabled,
+                    'withdraw': chainWithdrawEnabled,
+                    'precision': this.parseNumber(this.parsePrecision(this.safeString(chainExtraData, 'walletPrecision'))),
+                    'limits': {
+                        'withdraw': {
+                            'min': this.safeNumber(chain, 'withdrawalMinSize'),
+                            'max': undefined,
+                        },
+                        'deposit': {
+                            'min': this.safeNumber(chainExtraData, 'depositMinSize'),
+                            'max': undefined,
+                        },
+                    },
+                };
             }
             result[code] = {
                 'id': id,
                 'name': name,
                 'code': code,
-                'precision': this.parseNumber(this.parsePrecision(this.safeString(entry, 'precision'))),
+                'precision': precision,
                 'info': entry,
-                'active': active,
+                'active': (isDepositEnabled || isWithdrawEnabled),
                 'deposit': isDepositEnabled,
                 'withdraw': isWithdrawEnabled,
-                'fee': fee,
+                'fee': undefined,
                 'limits': this.limits,
                 'networks': networks,
             };

package/js/src/pro/krakenfutures.js

@@ -624,7 +624,7 @@ export default class krakenfutures extends krakenfuturesRest {
             symbols[symbol] = true;
             cachedOrders.append(parsed);
         }
-        if (this.orders.length > 0) {
+        if (this.orders.length) {
             client.resolve(this.orders, 'orders');
             const keys = Object.keys(symbols);
             for (let i = 0; i < keys.length; i++) {

package/js/src/pro/okx.js

@@ -98,15 +98,17 @@ export default class okx extends okxRest {
     }
     getUrl(channel, access = 'public') {
         // for context: https://www.okx.com/help-center/changes-to-v5-api-websocket-subscription-parameter-and-url
+        const isSandbox = this.options['sandboxMode'];
+        const sandboxSuffix = isSandbox ? '?brokerId=9999' : '';
         const isPublic = (access === 'public');
         const url = this.urls['api']['ws'];
         if ((channel.indexOf('candle') > -1) || (channel === 'orders-algo')) {
-            return url + '/business';
+            return url + '/business' + sandboxSuffix;
         }
         else if (isPublic) {
-            return url + '/public';
+            return url + '/public' + sandboxSuffix;
         }
-        return url + '/private';
+        return url + '/private' + sandboxSuffix;
     }
     async subscribeMultiple(access, channel, symbols = undefined, params = {}) {
         await this.loadMarkets();
@@ -1253,6 +1255,9 @@ export default class okx extends okxRest {
                 }
                 return false;
             }
+            else {
+                client.reject(e);
+            }
         }
         return message;
     }

package/js/src/pro/probit.js

@@ -518,11 +518,11 @@ export default class probit extends probitRest {
             this.handleTicker(client, message);
         }
         const trades = this.safeValue(message, 'recent_trades', []);
-        if (trades.length > 0) {
+        if (trades.length) {
             this.handleTrades(client, message);
         }
         const orderBook = this.safeValueN(message, ['order_books', 'order_books_l1', 'order_books_l2', 'order_books_l3', 'order_books_l4'], []);
-        if (orderBook.length > 0) {
+        if (orderBook.length) {
             this.handleOrderBook(client, message, orderBook);
         }
     }

package/js/src/upbit.js

@@ -6,7 +6,7 @@
 
 //  ---------------------------------------------------------------------------
 import Exchange from './abstract/upbit.js';
-import { ExchangeError, BadRequest, AuthenticationError, InvalidOrder, InsufficientFunds, OrderNotFound, PermissionDenied, AddressPending } from './base/errors.js';
+import { ExchangeError, BadRequest, AuthenticationError, InvalidOrder, InsufficientFunds, OrderNotFound, PermissionDenied, AddressPending, ArgumentsRequired } from './base/errors.js';
 import { Precise } from './base/Precise.js';
 import { TICK_SIZE } from './base/functions/number.js';
 import { sha512 } from './static_dependencies/noble-hashes/sha512.js';
@@ -1728,12 +1728,20 @@ export default class upbit extends Exchange {
         };
         let method = 'privatePostWithdraws';
         if (code !== 'KRW') {
+            // 2023-05-23 Change to required parameters for digital assets
+            const network = this.safeStringUpper2(params, 'network', 'net_type');
+            if (network === undefined) {
+                throw new ArgumentsRequired(this.id + ' withdraw() requires a network argument');
+            }
+            params = this.omit(params, ['network']);
+            request['net_type'] = network;
             method += 'Coin';
             request['currency'] = currency['id'];
             request['address'] = address;
             if (tag !== undefined) {
                 request['secondary_address'] = tag;
             }
+            params = this.omit(params, 'network');
         }
         else {
             method += 'Krw';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.0.80",
+  "version": "4.0.82",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 130+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",

package/skip-tests.json

@@ -201,6 +201,8 @@
         }
     },
     "bithumb": {
+        "skip": "fetchMarkets returning undefined",
+        "until": "2023-09-05",
         "skipMethods": {
             "fetchTickers": {
                 "quoteVolume": "quoteVolume >= baseVolume * low is failing",
@@ -511,7 +513,8 @@
             },
             "fetchTickers": {
                 "bid": "broken bid-ask",
-                "ask": "broken bid-ask"
+                "ask": "broken bid-ask",
+                "baseVolume": "negative value"
             }
         }
     },
@@ -915,7 +918,9 @@
         "skipWs": true,
         "skipMethods":{
             "fetchCurrencies": {
-                "networks": "not yet implemented"
+                "networks": "not yet implemented",
+                "withdraw": "not provided for some currencies",
+                "deposit": "not provided for some currencies"
             },
             "loadMarkets": {
                 "currencyIdAndCode": "messed"