ccxt 4.0.80 → 4.0.81

package/js/src/pro/okx.js

@@ -98,15 +98,17 @@ export default class okx extends okxRest {
     }
     getUrl(channel, access = 'public') {
         // for context: https://www.okx.com/help-center/changes-to-v5-api-websocket-subscription-parameter-and-url
+        const isSandbox = this.options['sandboxMode'];
+        const sandboxSuffix = isSandbox ? '?brokerId=9999' : '';
         const isPublic = (access === 'public');
         const url = this.urls['api']['ws'];
         if ((channel.indexOf('candle') > -1) || (channel === 'orders-algo')) {
-            return url + '/business';
+            return url + '/business' + sandboxSuffix;
         }
         else if (isPublic) {
-            return url + '/public';
+            return url + '/public' + sandboxSuffix;
         }
-        return url + '/private';
+        return url + '/private' + sandboxSuffix;
     }
     async subscribeMultiple(access, channel, symbols = undefined, params = {}) {
         await this.loadMarkets();
@@ -1253,6 +1255,9 @@ export default class okx extends okxRest {
                 }
                 return false;
             }
+            else {
+                client.reject(e);
+            }
         }
         return message;
     }

package/js/src/pro/probit.js

@@ -518,11 +518,11 @@ export default class probit extends probitRest {
             this.handleTicker(client, message);
         }
         const trades = this.safeValue(message, 'recent_trades', []);
-        if (trades.length > 0) {
+        if (trades.length) {
             this.handleTrades(client, message);
         }
         const orderBook = this.safeValueN(message, ['order_books', 'order_books_l1', 'order_books_l2', 'order_books_l3', 'order_books_l4'], []);
-        if (orderBook.length > 0) {
+        if (orderBook.length) {
             this.handleOrderBook(client, message, orderBook);
         }
     }

package/js/src/upbit.js

@@ -6,7 +6,7 @@
 
 //  ---------------------------------------------------------------------------
 import Exchange from './abstract/upbit.js';
-import { ExchangeError, BadRequest, AuthenticationError, InvalidOrder, InsufficientFunds, OrderNotFound, PermissionDenied, AddressPending } from './base/errors.js';
+import { ExchangeError, BadRequest, AuthenticationError, InvalidOrder, InsufficientFunds, OrderNotFound, PermissionDenied, AddressPending, ArgumentsRequired } from './base/errors.js';
 import { Precise } from './base/Precise.js';
 import { TICK_SIZE } from './base/functions/number.js';
 import { sha512 } from './static_dependencies/noble-hashes/sha512.js';
@@ -1728,12 +1728,20 @@ export default class upbit extends Exchange {
         };
         let method = 'privatePostWithdraws';
         if (code !== 'KRW') {
+            // 2023-05-23 Change to required parameters for digital assets
+            const network = this.safeStringUpper2(params, 'network', 'net_type');
+            if (network === undefined) {
+                throw new ArgumentsRequired(this.id + ' withdraw() requires a network argument');
+            }
+            params = this.omit(params, ['network']);
+            request['net_type'] = network;
             method += 'Coin';
             request['currency'] = currency['id'];
             request['address'] = address;
             if (tag !== undefined) {
                 request['secondary_address'] = tag;
             }
+            params = this.omit(params, 'network');
         }
         else {
             method += 'Krw';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.0.80",
+  "version": "4.0.81",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 130+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",

package/skip-tests.json

@@ -201,6 +201,8 @@
         }
     },
     "bithumb": {
+        "skip": "fetchMarkets returning undefined",
+        "until": "2023-09-05",
         "skipMethods": {
             "fetchTickers": {
                 "quoteVolume": "quoteVolume >= baseVolume * low is failing",
@@ -511,7 +513,8 @@
             },
             "fetchTickers": {
                 "bid": "broken bid-ask",
-                "ask": "broken bid-ask"
+                "ask": "broken bid-ask",
+                "baseVolume": "negative value"
             }
         }
     },
@@ -915,7 +918,9 @@
         "skipWs": true,
         "skipMethods":{
             "fetchCurrencies": {
-                "networks": "not yet implemented"
+                "networks": "not yet implemented",
+                "withdraw": "not provided for some currencies",
+                "deposit": "not provided for some currencies"
             },
             "loadMarkets": {
                 "currencyIdAndCode": "messed"