ccxt 4.0.101 → 4.0.103

package/js/src/pro/binance.js

@@ -505,8 +505,8 @@ export default class binance extends binanceRest {
         for (let i = 0; i < symbols.length; i++) {
             const symbol = symbols[i];
             const market = this.market(symbol);
-            const messageHash = market['lowercaseId'] + '@' + name;
-            subParams.push(messageHash);
+            const currentMessageHash = market['lowercaseId'] + '@' + name;
+            subParams.push(currentMessageHash);
         }
         const messageHash = 'multipleTrades::' + symbols.join(',');
         const query = this.omit(params, 'type');
@@ -824,10 +824,10 @@ export default class binance extends binanceRest {
         const hashes = [];
         for (let i = 0; i < symbolsAndTimeframes.length; i++) {
             const data = symbolsAndTimeframes[i];
-            const symbol = data[0];
-            const timeframe = data[1];
-            const interval = this.safeString(this.timeframes, timeframe, timeframe);
-            const market = this.market(symbol);
+            const symbolString = data[0];
+            const timeframeString = data[1];
+            const interval = this.safeString(this.timeframes, timeframeString, timeframeString);
+            const market = this.market(symbolString);
             let marketId = market['lowercaseId'];
             if (name === 'indexPriceKline') {
                 // weird behavior for index price kline we can't use the perp suffix
@@ -835,7 +835,7 @@ export default class binance extends binanceRest {
             }
             const topic = marketId + '@' + name + '_' + interval;
             subParams.push(topic);
-            hashes.push(symbol + '#' + timeframe);
+            hashes.push(symbolString + '#' + timeframeString);
         }
         const messageHash = 'multipleOHLCV::' + hashes.join(',');
         const url = this.urls['api']['ws'][type] + '/' + this.stream(type, messageHash);

package/js/src/pro/bybit.js

@@ -364,17 +364,17 @@ export default class bybit extends bybitRest {
         let firstSymbol = undefined;
         for (let i = 0; i < symbolsAndTimeframes.length; i++) {
             const data = symbolsAndTimeframes[i];
-            let symbol = this.safeString(data, 0);
-            const timeframe = this.safeString(data, 1);
-            const market = this.market(symbol);
-            symbol = market['symbol'];
+            let symbolString = this.safeString(data, 0);
+            const timeframeString = this.safeString(data, 1);
+            const market = this.market(symbolString);
+            symbolString = market['symbol'];
             if (i === 0) {
                 firstSymbol = market['symbol'];
             }
-            const timeframeId = this.safeString(this.timeframes, timeframe, timeframe);
+            const timeframeId = this.safeString(this.timeframes, timeframeString, timeframeString);
             const topic = 'kline.' + timeframeId + '.' + market['id'];
             topics.push(topic);
-            hashes.push(symbol + '#' + timeframe);
+            hashes.push(symbolString + '#' + timeframeString);
         }
         const messageHash = 'multipleOHLCV::' + hashes.join(',');
         const url = this.getUrlByMarketType(firstSymbol, false, params);
@@ -921,8 +921,8 @@ export default class bybit extends bybitRest {
         }
         const keys = Object.keys(symbols);
         for (let i = 0; i < keys.length; i++) {
-            const messageHash = 'myTrades:' + keys[i];
-            client.resolve(trades, messageHash);
+            const currentMessageHash = 'myTrades:' + keys[i];
+            client.resolve(trades, currentMessageHash);
         }
         // non-symbol specific
         const messageHash = 'myTrades';
@@ -1054,25 +1054,26 @@ export default class bybit extends bybitRest {
         const first = this.safeValue(rawOrders, 0, {});
         const category = this.safeString(first, 'category');
         const isSpot = category === 'spot';
-        let parser = undefined;
-        if (isSpot) {
-            parser = 'parseWsSpotOrder';
-        }
-        else {
-            parser = 'parseContractOrder';
+        if (!isSpot) {
             rawOrders = this.safeValue(rawOrders, 'result', rawOrders);
         }
         const symbols = {};
         for (let i = 0; i < rawOrders.length; i++) {
-            const parsed = this[parser](rawOrders[i]);
+            let parsed = undefined;
+            if (isSpot) {
+                parsed = this.parseWsSpotOrder(rawOrders[i]);
+            }
+            else {
+                parsed = this.parseOrder(rawOrders[i]);
+            }
             const symbol = parsed['symbol'];
             symbols[symbol] = true;
             orders.append(parsed);
         }
         const symbolsArray = Object.keys(symbols);
         for (let i = 0; i < symbolsArray.length; i++) {
-            const messageHash = 'orders:' + symbolsArray[i];
-            client.resolve(orders, messageHash);
+            const currentMessageHash = 'orders:' + symbolsArray[i];
+            client.resolve(orders, currentMessageHash);
         }
         const messageHash = 'orders';
         client.resolve(orders, messageHash);

package/js/src/pro/coinbasepro.js

@@ -526,11 +526,11 @@ export default class coinbasepro extends coinbaseproRest {
         //         reason: 'filled'
         //     }
         //
-        let orders = this.orders;
-        if (orders === undefined) {
+        let currentOrders = this.orders;
+        if (currentOrders === undefined) {
             const limit = this.safeInteger(this.options, 'ordersLimit', 1000);
-            orders = new ArrayCacheBySymbolById(limit);
-            this.orders = orders;
+            currentOrders = new ArrayCacheBySymbolById(limit);
+            this.orders = currentOrders;
         }
         const type = this.safeString(message, 'type');
         const marketId = this.safeString(message, 'product_id');
@@ -567,9 +567,9 @@ export default class coinbasepro extends coinbaseproRest {
                         let totalAmount = 0;
                         const trades = previousOrder['trades'];
                         for (let i = 0; i < trades.length; i++) {
-                            const trade = trades[i];
-                            totalCost = this.sum(totalCost, trade['cost']);
-                            totalAmount = this.sum(totalAmount, trade['amount']);
+                            const tradeEntry = trades[i];
+                            totalCost = this.sum(totalCost, tradeEntry['cost']);
+                            totalAmount = this.sum(totalAmount, tradeEntry['amount']);
                         }
                         if (totalAmount > 0) {
                             previousOrder['average'] = totalCost / totalAmount;
@@ -697,12 +697,12 @@ export default class coinbasepro extends coinbaseproRest {
             client.resolve(ticker, messageHash);
             const messageHashes = this.findMessageHashes(client, 'tickers::');
             for (let i = 0; i < messageHashes.length; i++) {
-                const messageHash = messageHashes[i];
-                const parts = messageHash.split('::');
+                const currentMessageHash = messageHashes[i];
+                const parts = currentMessageHash.split('::');
                 const symbolsString = parts[1];
                 const symbols = symbolsString.split(',');
                 if (this.inArray(symbol, symbols)) {
-                    client.resolve(ticker, messageHash);
+                    client.resolve(ticker, currentMessageHash);
                 }
             }
         }

package/js/src/pro/kucoin.js

@@ -238,15 +238,15 @@ export default class kucoin extends kucoinRest {
         client.resolve(ticker, 'tickers');
         const messageHashes = this.findMessageHashes(client, 'tickers::');
         for (let i = 0; i < messageHashes.length; i++) {
-            const messageHash = messageHashes[i];
-            const parts = messageHash.split('::');
+            const currentMessageHash = messageHashes[i];
+            const parts = currentMessageHash.split('::');
             const symbolsString = parts[1];
             const symbols = symbolsString.split(',');
             const tickers = this.filterByArray(this.tickers, 'symbol', symbols);
             const tickersSymbols = Object.keys(tickers);
             const numTickers = tickersSymbols.length;
             if (numTickers > 0) {
-                client.resolve(tickers, messageHash);
+                client.resolve(tickers, currentMessageHash);
             }
         }
     }

package/js/src/wavesexchange.js

@@ -1250,7 +1250,8 @@ export default class wavesexchange extends Exchange {
     toPrecision(amount, scale) {
         const amountString = this.numberToString(amount);
         const precise = new Precise(amountString);
-        precise.decimals = Precise.stringSub(precise.decimals, scale);
+        // precise.decimals should be integer
+        precise.decimals = this.parseToInt(Precise.stringSub(this.numberToString(precise.decimals), this.numberToString(scale)));
         precise.reduce();
         return precise;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "4.0.101",
+  "version": "4.0.103",
   "description": "A JavaScript / TypeScript / Python / C# / PHP cryptocurrency trading library with support for 130+ exchanges",
   "unpkg": "dist/ccxt.browser.js",
   "type": "module",

package/skip-tests.json

@@ -537,7 +537,7 @@
         }
     },
     "coinbasepro": {
-		"skipPhpAsync":true,
+        "skipPhpAsync": true,
         "skipMethods": {
             "fetchStatus": "request timeout",
             "fetchCurrencies": {
@@ -547,7 +547,7 @@
         }
     },
     "coinbaseprime": {
-		"skipPhpAsync":true,
+        "skipPhpAsync": true,
         "skipMethods": {
             "fetchStatus": "request timeout",
             "fetchCurrencies": {
@@ -780,7 +780,6 @@
         "skipWs": true
     },
     "huobi": {
-		"skipPhpAsync": true,
         "skipWs": true,
         "skipMethods": {
             "loadMarkets": {
@@ -1018,7 +1017,9 @@
         "skipMethods": {
             "fetchTickers": {
                 "quoteVolume": "quoteVolume >= baseVolume * low is failing",
-                "baseVolume": "quoteVolume >= baseVolume * low is failing"
+                "baseVolume": "quoteVolume >= baseVolume * low is failing",
+                "ask": "https://app.travis-ci.com/github/ccxt/ccxt/builds/266029139",
+                "bid": "https://app.travis-ci.com/github/ccxt/ccxt/builds/266029139"
             },
             "fetchTicker": {
                 "quoteVolume": "quoteVolume >= baseVolume * low is failing",
@@ -1036,9 +1037,7 @@
         }
     },
     "mexc": {
-	"skip": "OnMaintenance https://www.mexc.com/support/articles/17827791510263",
         "skipWs": true,
-        "skipPhpAsync": "Connection ended before receiving response...",
         "skipMethods": {
             "loadMarkets":{
                 "currencyIdAndCode": "messed"
@@ -1283,7 +1282,6 @@
         }
     },
 	"woo": {
-		"skipPhpAsync": true,
         "skipMethods":{
             "loadMarkets":{
                 "active": "undefined",

package/js/src/abstract/bkex.d.ts

@@ -1,61 +0,0 @@
-import { implicitReturnType } from '../base/types.js';
-import { Exchange as _Exchange } from '../base/Exchange.js';
-interface Exchange {
-    publicSpotGetCommonSymbols(params?: {}): Promise<implicitReturnType>;
-    publicSpotGetCommonCurrencys(params?: {}): Promise<implicitReturnType>;
-    publicSpotGetCommonTimestamp(params?: {}): Promise<implicitReturnType>;
-    publicSpotGetQKline(params?: {}): Promise<implicitReturnType>;
-    publicSpotGetQTickers(params?: {}): Promise<implicitReturnType>;
-    publicSpotGetQTickerPrice(params?: {}): Promise<implicitReturnType>;
-    publicSpotGetQDepth(params?: {}): Promise<implicitReturnType>;
-    publicSpotGetQDeals(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetMarketCandle(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetMarketDeals(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetMarketDepth(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetMarketFundingRate(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetMarketIndex(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetMarketRiskLimit(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetMarketSymbols(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetMarketTickerPrice(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetMarketTickers(params?: {}): Promise<implicitReturnType>;
-    publicSwapGetServerPing(params?: {}): Promise<implicitReturnType>;
-    privateSpotGetUApiInfo(params?: {}): Promise<implicitReturnType>;
-    privateSpotGetUAccountBalance(params?: {}): Promise<implicitReturnType>;
-    privateSpotGetUWalletAddress(params?: {}): Promise<implicitReturnType>;
-    privateSpotGetUWalletDepositRecord(params?: {}): Promise<implicitReturnType>;
-    privateSpotGetUWalletWithdrawRecord(params?: {}): Promise<implicitReturnType>;
-    privateSpotGetUOrderOpenOrders(params?: {}): Promise<implicitReturnType>;
-    privateSpotGetUOrderOpenOrderDetail(params?: {}): Promise<implicitReturnType>;
-    privateSpotGetUOrderHistoryOrders(params?: {}): Promise<implicitReturnType>;
-    privateSpotPostUAccountTransfer(params?: {}): Promise<implicitReturnType>;
-    privateSpotPostUWalletWithdraw(params?: {}): Promise<implicitReturnType>;
-    privateSpotPostUOrderCreate(params?: {}): Promise<implicitReturnType>;
-    privateSpotPostUOrderCancel(params?: {}): Promise<implicitReturnType>;
-    privateSpotPostUOrderBatchCreate(params?: {}): Promise<implicitReturnType>;
-    privateSpotPostUOrderBatchCancel(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetAccountBalance(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetAccountBalanceRecord(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetAccountOrder(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetAccountOrderForced(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetAccountPosition(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetEntrustFinished(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetEntrustUnFinish(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetOrderFinished(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetOrderFinishedInfo(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetOrderUnFinish(params?: {}): Promise<implicitReturnType>;
-    privateSwapGetPositionInfo(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostAccountSetLeverage(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostEntrustAdd(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostEntrustCancel(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostOrderBatchCancel(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostOrderBatchOpen(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostOrderCancel(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostOrderClose(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostOrderCloseAll(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostOrderOpen(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostPositionSetSpSl(params?: {}): Promise<implicitReturnType>;
-    privateSwapPostPositionUpdate(params?: {}): Promise<implicitReturnType>;
-}
-declare abstract class Exchange extends _Exchange {
-}
-export default Exchange;

package/js/src/abstract/bkex.js

@@ -1,11 +0,0 @@
-// ----------------------------------------------------------------------------
-
-// PLEASE DO NOT EDIT THIS FILE, IT IS GENERATED AND WILL BE OVERWRITTEN:
-// https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#how-to-contribute-code
-// EDIT THE CORRESPONDENT .ts FILE INSTEAD
-
-// -------------------------------------------------------------------------------
-import { Exchange as _Exchange } from '../base/Exchange.js';
-class Exchange extends _Exchange {
-}
-export default Exchange;