ccs-digitalmarketplace-frameworks 4.4.32 → 4.4.34

package/README.md

@@ -4,7 +4,7 @@ Digital Marketplace content
 [![npm version](https://badge.fury.io/js/ccs-digitalmarketplace-frameworks.svg)](https://badge.fury.io/js/ccs-digitalmarketplace-frameworks)
 
 YAML definitions of the Digital Marketplace’s procurement frameworks.
- 
+
 The content here is pulled in to the frontend applications to display forms, and is also used to generate the JSON
 schemas used by the API for validation (by running the `scripts/generate-validation-schemas.py` script).
 
@@ -35,7 +35,7 @@ Question keys
 * `type` type of the question input, used to find the related toolkit form template (required)
 * `name` short question name to use in summary tables instead of the full question. Also used to
   generate the URL slug for addressable questions. This field is a [TemplateField](https://github.com/alphagov/digitalmarketplace-content-loader/blob/474d9adce0f422700cbf2dfc8815a7503ab368bc/dmcontent/utils.py#L8).
-* `filter_label` for boolean questions, a text label to use for filtering services where the question was answered 'yes'. If not present `name` or `question` will be used instead.
+* `filter_label` for boolean questions, a text label to use for filtering services where the question was answered 'yes'. If not present, `name` or `question` will be used instead.
 * `slug` can be used to manually override the slug used for this question.
 * `empty_message` a message to display instead of "Answer required" if question wasn't answered
 * `hint` hint text to display after the question, eg advice about how to best format you answer. This field is a [TemplateField](https://github.com/alphagov/digitalmarketplace-content-loader/blob/474d9adce0f422700cbf2dfc8815a7503ab368bc/dmcontent/utils.py#L8).
@@ -53,7 +53,7 @@ Question keys
 * `validations` a list of validation errors related to the field. Each validation consists of:
     * `name` the error message key that should match the validation error returned by the API (required)
     * `message` text of the message that will be displayed by the frontend app (required)
-* `depends` describes the service conditions that must be met for question to be displayed. Right now, only used to list the
+* `depends` describes the service conditions that must be met for a question to be displayed. Right now, only used to list the
   lots the question applies to. Each depend rule consists of:
     * `"on"` service data key name to use for comparison (e.g. "lot" for lots)
     * `being` a list of acceptable values for the key. If service data key value matches one of the values in the `being` the
@@ -107,7 +107,7 @@ Manifest files define a tree-like structure for content.  A manifest is a list o
 Each section contains:
 
 * `name` name of the section (required). This field is a [TemplateField](https://github.com/alphagov/digitalmarketplace-content-loader/blob/474d9adce0f422700cbf2dfc8815a7503ab368bc/dmcontent/utils.py#L8).
-* `slug` can be used to manually override the slug used for this section. 
+* `slug` can be used to manually override the slug used for this section.
 * `editable` controls whether section allows updates for the questions, boolean value
 * `edit_questions` controls whether individual questions can be edited separately (only supported by `multiquestion` questions)
 * `removable` controls whether individual questions can be removed separately (only supported by `multiquestion` questions and is the same as `edit_questions` by default)
@@ -156,7 +156,7 @@ mapping from `<doc_type>_search_filters` based on this template.
 
 For each field (question) that needs to be used in (e.g. facet) filtering, there must be a corresponding
 `dmfilter_` property added to the `mappings` key. Note that if a question's `id` has been overridden (i.e. the
-`id` is no longer the same as the filename, then the _overridden_ `id` should be used here. (Compare with the manifest,
+`id` is no longer the same as the filename, so the _overridden_ `id` should be used here. (Compare with the manifest,
 where in all cases the filename should be used to specify the question.)
 
 For each field (question) that should have an aggregation available for it, there must similarly be a corresponding
@@ -184,7 +184,7 @@ Development
 A local checkout of the frameworks repo can be shared with locally-running services (i.e. frontend applications). There are two ways of doing this:
 
 1. From this repo, run `npm link`
-2. From each app, run `npm link ccs-digitalmarketplace-frameworks`. 
+2. From each app, run `npm link ccs-digitalmarketplace-frameworks`.
 3. You can then run `npx gulp frameworks` to automatically rebuild the framework content whenever a framework YML file changes. Restart the app in dmrunner to pick up changes.
 
 Or
@@ -245,6 +245,3 @@ of the [Open Government 3.0][ogl] licence.
 [mit]: LICENCE
 [copyright]: http://www.nationalarchives.gov.uk/information-management/re-using-public-sector-information/uk-government-licensing-framework/crown-copyright/
 [ogl]: http://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/
-
-
-

package/frameworks/digital-outcomes-and-specialists-7/questions/fvra/consortiumImmediateParentCompanyPublishedAccountsURL.yml

@@ -33,8 +33,8 @@ depends:
     being:
       - fvra_lot_2_only_fail
       - fvra_lot_2_only_pass
+      - fvra_lot_2_with_other_lots_fail
       - fvra_lot_2_with_other_lots_pass
-      - fvra_default_fail
 
 validations:
   - name: file_is_valid_format

package/frameworks/digital-outcomes-and-specialists-7/questions/fvra/immediateParentCompanyPublishedAccountsURL.yml

@@ -32,8 +32,8 @@ depends:
     being:
       - fvra_lot_2_only_fail
       - fvra_lot_2_only_pass
+      - fvra_lot_2_with_other_lots_fail
       - fvra_lot_2_with_other_lots_pass
-      - fvra_default_fail
   - "on": immediateParentCompany
     being:
       - true

package/frameworks/digital-outcomes-and-specialists-7/questions/services/technicalAbilityCertificateTwoURL.yml

@@ -1,5 +1,5 @@
 name: Technical ability certificate 2
-question: "Technical ability certificate 2 (optional)"
+question: Technical ability certificate 2
 
 type: upload
 optional: true

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccs-digitalmarketplace-frameworks",
-  "version": "4.4.32",
+  "version": "4.4.34",
   "description": "Data files for Digital Marketplace’s procurement frameworks",
   "repository": {
     "type": "git",