ccqa 1.45.0 → 1.46.0

package/dist/bin/ccqa.mjs

@@ -223,6 +223,7 @@ const AGENT_BROWSER_TARGET = "agent-browser";
 */
 const TestSpecSchema = z.object({
 	title: z.string().min(1),
+	disabled: z.boolean().optional(),
 	target: TargetIdSchema.optional(),
 	mode: SpecModeSchema.optional(),
 	session: SessionFieldSchema.optional(),
@@ -647,6 +648,21 @@ async function getTestScript(featureName, specName, cwd) {
 async function listAllSpecsWithSpecFile(cwd) {
 	return listAllSpecsFilteredBy(SPEC_FILE, cwd);
 }
+/**
+* The active suite — the tree minus the specs marked `disabled` — which is
+* what `ccqa run` expands "all specs" to. Kept separate from the enumeration
+* above because `serialGroups` and `actors` validate that a spec *name*
+* exists, and a disabled spec is still a name.
+*
+* A spec that will not read or parse stays in: unreadable is not the same as
+* asking to be skipped.
+*/
+async function listActiveSpecs(cwd) {
+	const all = await listAllSpecsWithSpecFile(cwd);
+	return (await Promise.all(all.map(async (ref) => {
+		return tryParseTestSpec(await tryReadSpecFile(ref.featureName, ref.specName, cwd))?.disabled === true ? null : ref;
+	}))).filter((ref) => ref !== null);
+}
 async function listAllSpecsFilteredBy(requiredFilename, cwd) {
 	const featuresDir = join(getCcqaDir(cwd), "features");
 	const featureDirs = await readdir(featuresDir).catch(() => []);
@@ -676,13 +692,7 @@ async function resolveSpecTargets(target, enumerateAll, cwd) {
 			specName
 		}];
 	}
-	return (await listSpecsForFeature(target, cwd)).map((specName) => ({
-		featureName: target,
-		specName
-	}));
-}
-async function listSpecsForFeature(featureName, cwd) {
-	return readdir(join(getFeatureDir(featureName, cwd), "test-cases")).catch(() => []);
+	return (await listActiveSpecs(cwd)).filter((ref) => ref.featureName === target);
 }
 /**
 * Lists every feature/spec dir under .ccqa/features/, regardless of whether
@@ -4968,6 +4978,7 @@ const PerspectiveSpecSchema = z.object({
 	steps: z.array(PerspectiveStepSchema).optional(),
 	status: PerspectiveStatusSchema,
 	changedAt: z.string().optional(),
+	disabled: z.boolean().optional(),
 	note: z.string().optional()
 }).strip();
 const PerspectiveFeatureSchema = z.object({
@@ -7167,6 +7178,7 @@ async function startBrowserCoverage(opts) {
 var Engine = class {
 	client;
 	connectFn;
+	/** Last known address of the browser; see `refreshWsUrl`. */
 	wsUrl;
 	reconnects = 0;
 	reconnectInFlight = false;
@@ -7285,6 +7297,22 @@ var Engine = class {
 		this.stopped = true;
 		this.clearTimer();
 	}
+	/**
+	* Answers why the address could not be refreshed, so the retry that follows
+	* says whether it is dialling a stale address or a dead browser. Told apart
+	* because one is a driver to fix and the other is a browser to wait for, and
+	* a silent stale address is the shape of the bug this exists to prevent.
+	*/
+	async refreshWsUrl() {
+		const ask = this.opts.currentCdpUrl;
+		if (ask === void 0) return void 0;
+		try {
+			this.wsUrl = await browserWebSocketUrl(await ask());
+			return;
+		} catch (error) {
+			return message(error);
+		}
+	}
 	async reconnect(initialReason) {
 		if (this.reconnectInFlight) return;
 		this.reconnectInFlight = true;
@@ -7300,11 +7328,12 @@ var Engine = class {
 				this.opts.warn(`browser coverage transport dropped (${reason}); reconnecting in ${delay}ms (${this.reconnects}/${MAX_RECONNECTS})`);
 				await new Promise((resolve) => setTimeout(resolve, delay));
 				if (this.stopped) return;
+				const stale = await this.refreshWsUrl();
 				let fresh;
 				try {
 					fresh = await this.connectFn(this.wsUrl);
 				} catch (error) {
-					reason = `reconnect failed: ${message(error)}`;
+					reason = stale ? `reconnect failed: ${message(error)} (address may be stale: ${stale})` : `reconnect failed: ${message(error)}`;
 					continue;
 				}
 				if (this.stopped) {
@@ -7319,6 +7348,7 @@ var Engine = class {
 					reason = `reconnect failed: ${message(error)}`;
 					continue;
 				}
+				this.reconnects = 0;
 				if (this.stopped) {
 					this.clearTimer();
 					fresh.close();
@@ -7749,9 +7779,10 @@ var CoverageSession = class CoverageSession {
 	* destinations, the roots — lives here, so the caller only supplies where
 	* the browser is.
 	*/
-	armBrowser(ref, cdpUrl, coverageDir) {
+	armBrowser(ref, browser, coverageDir) {
 		return startBrowserCoverage({
-			cdpUrl,
+			cdpUrl: browser.cdpUrl,
+			currentCdpUrl: browser.currentCdpUrl?.bind(browser),
 			specId: specIdFor(this.runId, ref),
 			origins: this.origins,
 			assetOrigins: this.assetOrigins,
@@ -8257,7 +8288,7 @@ async function runOneSpec$1(ref, opts, blocks) {
 			});
 			const acquired = browserHandle;
 			opts.teardown?.onFinalize(() => acquired.dispose());
-			browserEngine = await measurement.collector.armBrowser(ref, browserHandle.cdpUrl, coverageDir);
+			browserEngine = await measurement.collector.armBrowser(ref, browserHandle, coverageDir);
 			if (browserHandle.amendCommand) command = browserHandle.amendCommand(command);
 			Object.assign(childEnv, browserHandle.env);
 		} catch (err) {
@@ -12146,6 +12177,7 @@ async function loadSpecInventory(cwd) {
 		const content = await tryReadSpecFile(featureName, specName, cwd);
 		if (content === null) return null;
 		const spec = parseTestSpec(content, `${featureName}/${specName}/spec.yaml`);
+		if (spec.disabled) return null;
 		return {
 			featureName,
 			specName,
@@ -13884,6 +13916,37 @@ async function acquireAgentBrowserEndpoint(ctx) {
 		"about:blank"
 	]);
 	if (warm.status !== 0) throw new Error(`could not start the session's browser: ${warm.stderr || warm.stdout}`);
+	return {
+		cdpUrl: askCdpUrl(session),
+		currentCdpUrl: () => askCdpUrlSoon(session),
+		dispose: async () => {}
+	};
+}
+/**
+* The same question on a short leash. Its caller is racing its own backoff
+* between reconnect attempts, so an answer that arrives after the budget is
+* spent is worth less than no answer: `spawnAB` would sit through a 30s EAGAIN
+* retry and a 35s hard timeout, which is the whole reconnect window several
+* times over.
+*/
+const CDP_URL_TIMEOUT_MS = 2e3;
+async function askCdpUrlSoon(session) {
+	const { promisify } = await import("node:util");
+	const { execFile } = await import("node:child_process");
+	const { stdout } = await promisify(execFile)(resolveAgentBrowserBin$1(), [
+		"--session",
+		session,
+		"get",
+		"cdp-url"
+	], {
+		timeout: CDP_URL_TIMEOUT_MS,
+		encoding: "utf8"
+	});
+	const cdpUrl = stdout.trim().split("\n").pop()?.trim() ?? "";
+	if (!/^wss?:\/\//.test(cdpUrl)) throw new Error(`agent-browser answered no cdp-url for session ${session}`);
+	return cdpUrl;
+}
+function askCdpUrl(session) {
 	const answer = spawnAB([
 		"--session",
 		session,
@@ -13892,10 +13955,7 @@ async function acquireAgentBrowserEndpoint(ctx) {
 	]);
 	const cdpUrl = answer.stdout.trim().split("\n").pop()?.trim() ?? "";
 	if (answer.status !== 0 || !/^wss?:\/\//.test(cdpUrl)) throw new Error(`agent-browser did not answer \`get cdp-url\` for session ${session}: ${answer.stderr || answer.stdout}`);
-	return {
-		cdpUrl,
-		dispose: async () => {}
-	};
+	return cdpUrl;
 }
 //#endregion
 //#region src/diagnose/snapshot.ts
@@ -14279,7 +14339,7 @@ async function runOneSpec(args) {
 		browserEngine = await opts.coverage.armBrowser({
 			featureName,
 			specName
-		}, handle.cdpUrl, coverageDir);
+		}, handle, coverageDir);
 	} catch (err) {
 		coverageBroken = errMessage(err);
 		warn(`coverage: could not attach to the live browser (${coverageBroken})`);
@@ -17048,7 +17108,7 @@ async function executeRun(targets, opts) {
 		customPrompt,
 		triageUserPrompt
 	};
-	const enumerateAll = () => listAllSpecsWithSpecFile(cwd);
+	const enumerateAll = () => listActiveSpecs(cwd);
 	let specs = dedupeSpecs((await Promise.all((targets.length ? targets : [void 0]).map((t) => resolveSpecTargets(t, enumerateAll, cwd)))).flat());
 	if (filtering) {
 		const before = specs.length;
@@ -21080,13 +21140,15 @@ async function collectTargets(specPath, cwd) {
 			specName
 		}];
 	}
+	const active = new Set((await listActiveSpecs(cwd)).map(specKey));
 	const out = [];
 	for (const feature of tree) for (const spec of feature.specs) {
 		if (!spec.hasSpecFile) continue;
-		out.push({
+		const target = {
 			featureName: feature.featureName,
 			specName: spec.specName
-		});
+		};
+		if (active.has(specKey(target))) out.push(target);
 	}
 	return out;
 }
@@ -21398,7 +21460,7 @@ async function buildSkeleton(tree) {
 	const config = await loadProjectConfig(process.cwd()).catch(() => null);
 	const changedAt = await readSpecChangedAt(process.cwd());
 	return (await Promise.all(tree.map(async (feature) => {
-		const specs = await Promise.all(feature.specs.filter((s) => s.hasSpecFile).map(async (s) => {
+		const built = await Promise.all(feature.specs.filter((s) => s.hasSpecFile).map(async (s) => {
 			const specYaml = await tryReadSpecFile(feature.featureName, s.specName);
 			const meta = readSpecMeta(s.specName, specYaml);
 			const plugin = resolveSpecTarget(specYaml, config);
@@ -21410,12 +21472,13 @@ async function buildSkeleton(tree) {
 				summary: "",
 				...meta.steps.length > 0 ? { steps: meta.steps } : {},
 				status,
-				...lastEdit ? { changedAt: lastEdit } : {}
+				...lastEdit ? { changedAt: lastEdit } : {},
+				...meta.disabled ? { disabled: true } : {}
 			};
 		}));
 		return {
 			featureName: feature.featureName,
-			specs
+			specs: built
 		};
 	}))).filter((f) => f.specs.length > 0).map((f) => ({
 		featureName: f.featureName,
@@ -21478,13 +21541,19 @@ function withoutGeneratedAt(yamlText) {
 function noteKey(featureName, specName) {
 	return `${featureName}/${specName}`;
 }
-/** Lenient title/mode read from an already-loaded spec.yaml (null → defaults). */
+/**
+* Lenient read of an already-loaded spec.yaml. A file that is missing or will
+* not parse falls back to `defaults`, which reports the spec as enabled: a
+* spec nobody could read has not asked to be skipped.
+*/
 function readSpecMeta(specName, specYaml) {
-	if (specYaml === null) return {
+	const defaults = {
 		title: specName,
 		mode: DEFAULT_SPEC_MODE,
-		steps: []
+		steps: [],
+		disabled: false
 	};
+	if (specYaml === null) return defaults;
 	try {
 		const parsed = parse(specYaml);
 		const title = typeof parsed.title === "string" && parsed.title.length > 0 ? parsed.title : specName;
@@ -21492,14 +21561,11 @@ function readSpecMeta(specName, specYaml) {
 		return {
 			title,
 			mode: modeResult.success ? modeResult.data : DEFAULT_SPEC_MODE,
-			steps: transcribeSteps(parsed.steps)
+			steps: transcribeSteps(parsed.steps),
+			disabled: tryParseTestSpec(specYaml)?.disabled === true
 		};
 	} catch {
-		return {
-			title: specName,
-			mode: DEFAULT_SPEC_MODE,
-			steps: []
-		};
+		return defaults;
 	}
 }
 /**
@@ -23028,6 +23094,7 @@ function readSpecTargets(doc) {
 		for (const spec of specs) {
 			const specName = prop(spec, "specName");
 			if (typeof specName !== "string") continue;
+			if (prop(spec, "disabled") === true) continue;
 			const changedAt = prop(spec, "changedAt");
 			out.push({
 				key: `${featureName}/${specName}`,

package/dist/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccqa",
-  "version": "1.45.0",
+  "version": "1.46.0",
   "type": "module",
   "description": "Browser test recorder powered by Claude Code and agent-browser",
   "repository": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccqa",
-  "version": "1.45.0",
+  "version": "1.46.0",
   "type": "module",
   "description": "Browser test recorder powered by Claude Code and agent-browser",
   "repository": {