ccqa 1.44.0 → 1.45.1

package/dist/bin/ccqa.mjs

@@ -7167,6 +7167,7 @@ async function startBrowserCoverage(opts) {
 var Engine = class {
 	client;
 	connectFn;
+	/** Last known address of the browser; see `refreshWsUrl`. */
 	wsUrl;
 	reconnects = 0;
 	reconnectInFlight = false;
@@ -7285,6 +7286,22 @@ var Engine = class {
 		this.stopped = true;
 		this.clearTimer();
 	}
+	/**
+	* Answers why the address could not be refreshed, so the retry that follows
+	* says whether it is dialling a stale address or a dead browser. Told apart
+	* because one is a driver to fix and the other is a browser to wait for, and
+	* a silent stale address is the shape of the bug this exists to prevent.
+	*/
+	async refreshWsUrl() {
+		const ask = this.opts.currentCdpUrl;
+		if (ask === void 0) return void 0;
+		try {
+			this.wsUrl = await browserWebSocketUrl(await ask());
+			return;
+		} catch (error) {
+			return message(error);
+		}
+	}
 	async reconnect(initialReason) {
 		if (this.reconnectInFlight) return;
 		this.reconnectInFlight = true;
@@ -7300,11 +7317,12 @@ var Engine = class {
 				this.opts.warn(`browser coverage transport dropped (${reason}); reconnecting in ${delay}ms (${this.reconnects}/${MAX_RECONNECTS})`);
 				await new Promise((resolve) => setTimeout(resolve, delay));
 				if (this.stopped) return;
+				const stale = await this.refreshWsUrl();
 				let fresh;
 				try {
 					fresh = await this.connectFn(this.wsUrl);
 				} catch (error) {
-					reason = `reconnect failed: ${message(error)}`;
+					reason = stale ? `reconnect failed: ${message(error)} (address may be stale: ${stale})` : `reconnect failed: ${message(error)}`;
 					continue;
 				}
 				if (this.stopped) {
@@ -7319,6 +7337,7 @@ var Engine = class {
 					reason = `reconnect failed: ${message(error)}`;
 					continue;
 				}
+				this.reconnects = 0;
 				if (this.stopped) {
 					this.clearTimer();
 					fresh.close();
@@ -7749,9 +7768,10 @@ var CoverageSession = class CoverageSession {
 	* destinations, the roots — lives here, so the caller only supplies where
 	* the browser is.
 	*/
-	armBrowser(ref, cdpUrl, coverageDir) {
+	armBrowser(ref, browser, coverageDir) {
 		return startBrowserCoverage({
-			cdpUrl,
+			cdpUrl: browser.cdpUrl,
+			currentCdpUrl: browser.currentCdpUrl?.bind(browser),
 			specId: specIdFor(this.runId, ref),
 			origins: this.origins,
 			assetOrigins: this.assetOrigins,
@@ -8257,7 +8277,7 @@ async function runOneSpec$1(ref, opts, blocks) {
 			});
 			const acquired = browserHandle;
 			opts.teardown?.onFinalize(() => acquired.dispose());
-			browserEngine = await measurement.collector.armBrowser(ref, browserHandle.cdpUrl, coverageDir);
+			browserEngine = await measurement.collector.armBrowser(ref, browserHandle, coverageDir);
 			if (browserHandle.amendCommand) command = browserHandle.amendCommand(command);
 			Object.assign(childEnv, browserHandle.env);
 		} catch (err) {
@@ -12337,7 +12357,7 @@ var StreamResolution = class {
 	asOf = 0;
 	lastSeq = 0;
 	pushesDuringRun = 0;
-	/** `markers` needs to hold every marker event of the stream; pushes are ignored here. */
+	/** `markers` needs to hold every marker `runId` issued; other runs' markers and pushes are ignored. */
 	constructor(markers, runId) {
 		this.runId = runId;
 		const specIds = /* @__PURE__ */ new Set();
@@ -12460,16 +12480,22 @@ var StreamResolution = class {
 /**
 * Every run that opened a spec in this stream, most recently heard-from
 * first — recency by the arrival position of each run's latest spec-open,
-* the one order the hub's stamps establish.
+* the one order the hub's stamps establish. Fed one event at a time, so the
+* question can be asked of a stream too large to hold.
 */
-function listRunIds(events) {
-	const lastOpenIndex = /* @__PURE__ */ new Map();
-	events.forEach((event, index) => {
+var RunIdIndex = class {
+	/** Re-inserted on every `spec-open`, so insertion order is order of latest open. */
+	opened = /* @__PURE__ */ new Set();
+	accept(event) {
 		const body = event.body;
-		if ("kind" in body && body.kind === "spec-open") lastOpenIndex.set(body.runId, index);
-	});
-	return [...lastOpenIndex.entries()].sort((a, b) => b[1] - a[1]).map(([id]) => id);
-}
+		if (!("kind" in body) || body.kind !== "spec-open") return;
+		this.opened.delete(body.runId);
+		this.opened.add(body.runId);
+	}
+	newestFirst() {
+		return [...this.opened].reverse();
+	}
+};
 //#endregion
 //#region src/cli/session.ts
 const AB = resolveAgentBrowserBin$1();
@@ -13878,6 +13904,37 @@ async function acquireAgentBrowserEndpoint(ctx) {
 		"about:blank"
 	]);
 	if (warm.status !== 0) throw new Error(`could not start the session's browser: ${warm.stderr || warm.stdout}`);
+	return {
+		cdpUrl: askCdpUrl(session),
+		currentCdpUrl: () => askCdpUrlSoon(session),
+		dispose: async () => {}
+	};
+}
+/**
+* The same question on a short leash. Its caller is racing its own backoff
+* between reconnect attempts, so an answer that arrives after the budget is
+* spent is worth less than no answer: `spawnAB` would sit through a 30s EAGAIN
+* retry and a 35s hard timeout, which is the whole reconnect window several
+* times over.
+*/
+const CDP_URL_TIMEOUT_MS = 2e3;
+async function askCdpUrlSoon(session) {
+	const { promisify } = await import("node:util");
+	const { execFile } = await import("node:child_process");
+	const { stdout } = await promisify(execFile)(resolveAgentBrowserBin$1(), [
+		"--session",
+		session,
+		"get",
+		"cdp-url"
+	], {
+		timeout: CDP_URL_TIMEOUT_MS,
+		encoding: "utf8"
+	});
+	const cdpUrl = stdout.trim().split("\n").pop()?.trim() ?? "";
+	if (!/^wss?:\/\//.test(cdpUrl)) throw new Error(`agent-browser answered no cdp-url for session ${session}`);
+	return cdpUrl;
+}
+function askCdpUrl(session) {
 	const answer = spawnAB([
 		"--session",
 		session,
@@ -13886,10 +13943,7 @@ async function acquireAgentBrowserEndpoint(ctx) {
 	]);
 	const cdpUrl = answer.stdout.trim().split("\n").pop()?.trim() ?? "";
 	if (answer.status !== 0 || !/^wss?:\/\//.test(cdpUrl)) throw new Error(`agent-browser did not answer \`get cdp-url\` for session ${session}: ${answer.stderr || answer.stdout}`);
-	return {
-		cdpUrl,
-		dispose: async () => {}
-	};
+	return cdpUrl;
 }
 //#endregion
 //#region src/diagnose/snapshot.ts
@@ -14273,7 +14327,7 @@ async function runOneSpec(args) {
 		browserEngine = await opts.coverage.armBrowser({
 			featureName,
 			specName
-		}, handle.cdpUrl, coverageDir);
+		}, handle, coverageDir);
 	} catch (err) {
 		coverageBroken = errMessage(err);
 		warn(`coverage: could not attach to the live browser (${coverageBroken})`);
@@ -17128,7 +17182,8 @@ async function executeRun(targets, opts) {
 	const liveSpecs = withMode.filter((s) => s.mode === "live");
 	meta("modes", `${detSpecs.length} deterministic / ${liveSpecs.length} live`);
 	if (dispatch.external.length > 0) meta("external", dispatch.external.map((g) => `${g.targetId} ${g.specs.length}`).join(" / "));
-	const coverage = opts.coverage && forExecution ? await startCoverage(cwd, projectConfig.coverage, actors, dispatch, opts.teardown, coverageInbox, storedSourceMapReader(hubCtx, deployedSha), hubCtx !== null) : void 0;
+	const storedMaps = hubCtx !== null && deployedSha !== null ? createStoredSourceMaps(hubCtx, deployedSha) : void 0;
+	const coverage = opts.coverage && forExecution ? await startCoverage(cwd, projectConfig.coverage, actors, dispatch, opts.teardown, coverageInbox, storedMaps?.read, hubCtx !== null) : void 0;
 	if (liveSpecs.length === 0) {
 		const why = "it only applies to agent-browser 'mode: live' specs, and this run has none";
 		if (typeof opts.liveStepRetry === "number" && opts.liveStepRetry > 0) warn(`--live-step-retry is ignored: ${why}`);
@@ -17241,8 +17296,11 @@ async function executeRun(targets, opts) {
 	};
 	const live = await runLiveSpecs(liveSpecs, liveOpts);
 	let streamedEdges = {};
-	if (coverage && !coverage.streamsToHub) reportCoverageHealth(coverage, [...externalRows, ...live.reportResults]);
-	else if (coverage && hubCtx != null) streamedEdges = await reportStreamedCoverageHealth(coverage, hubCtx);
+	if (coverage && !coverage.streamsToHub) reportCoverageHealth(coverage, [...externalRows, ...live.reportResults], storedMaps);
+	else if (coverage && hubCtx != null) {
+		streamedEdges = await reportStreamedCoverageHealth(coverage, hubCtx);
+		storedMaps?.warnIfNothingAnswered();
+	}
 	let overallExitCode = det.exitCode !== 0 ? 1 : 0;
 	if (live.failedCount > 0) overallExitCode = 1;
 	if (externalRows.some((r) => r.status === "failed")) overallExitCode = 1;
@@ -17336,6 +17394,12 @@ async function executeRun(targets, opts) {
 		reportDir
 	};
 }
+/**
+* Starts the run's coverage measurement before any spec runs: the sink has to
+* be listening before the first request reaches the application, and the set
+* of spec ids it will accept is only known once dispatch has resolved. With
+* an `inbox`, nothing binds — the run streams its events to the hub instead.
+*/
 async function startCoverage(cwd, config, actors, dispatch, teardown, inbox, fetchStoredSourceMap, hubConfigured) {
 	if (config === void 0) throw new RunUsageError("--coverage needs a `coverage:` block in .ccqa/config.yaml whose `instrumentedOrigins` names the origins the spec cookie may be attached to");
 	let session;
@@ -17361,25 +17425,25 @@ async function startCoverage(cwd, config, actors, dispatch, teardown, inbox, fet
 	return session;
 }
 /**
-* Starts the run's coverage measurement before any spec runs: the sink has to
-* be listening before the first request reaches the application, and the set
-* of spec ids it will accept is only known once dispatch has resolved. With
-* an `inbox`, nothing binds — the run streams its events to the hub instead.
+* The maps a deploy pushed for one commit. One answer per asset for the run:
+* the commit is fixed, so a miss stays a miss, and every spec would otherwise
+* re-ask for the same scripts.
 */
-/**
-* Needs both a hub and the commit under test: without either there is nothing
-* to address a stored map by, and reading some other commit's maps would name
-* the wrong files. See `SourceMapStore`.
-*/
-function storedSourceMapReader(hubCtx, deployedSha) {
-	if (hubCtx === null || deployedSha === null) return void 0;
+function createStoredSourceMaps(hubCtx, deployedSha) {
 	const seen = /* @__PURE__ */ new Map();
-	return async (assetPath) => {
-		const cached = seen.get(assetPath);
-		if (cached !== void 0 || seen.has(assetPath)) return cached;
-		const map = await hubCtx.hub.getSourceMap(hubCtx.project, deployedSha, assetPath) ?? void 0;
-		seen.set(assetPath, map);
-		return map;
+	return {
+		read: async (assetPath) => {
+			const cached = seen.get(assetPath);
+			if (cached !== void 0 || seen.has(assetPath)) return cached;
+			const map = await hubCtx.hub.getSourceMap(hubCtx.project, deployedSha, assetPath) ?? void 0;
+			seen.set(assetPath, map);
+			return map;
+		},
+		warnIfNothingAnswered() {
+			const answered = [...seen.values()].some((map) => map !== void 0);
+			if (seen.size === 0 || answered) return;
+			warn(`coverage: no stored source map answered for any of the ${seen.size} script(s) this run asked about, under commit ${deployedSha.slice(0, 12)}. Either that deploy pushed none, or the hub's deploy log names a commit the environment is no longer serving`);
+		}
 	};
 }
 /**
@@ -17460,8 +17524,17 @@ async function upsertMeasuredEdges(hubCtx, specs) {
 		warn(`coverage: could not record measured edges on the hub (${errMessage(error)})`);
 	}
 }
+/**
+* Whether the browser half came back with nothing anywhere. `every` rather
+* than `some`: a run that resolved some chunks from the copies the server
+* served has no gap the stored maps were needed for, and warning there would
+* fire on every build that strips maps from a few chunks and not the rest.
+*/
+function noFrontendResolved(rows) {
+	return rows.every((row) => (row.coverage?.frontendFiles ?? 0) === 0);
+}
 /** Everything the measurement could not place; silence here reads as "never reached". */
-function reportCoverageHealth(coverage, rows) {
+function reportCoverageHealth(coverage, rows, storedMaps) {
 	if (!coverage.heardFromApplication()) warn("no instrumented application process reported — only the browser half was measured. The server needs ccqa-tools and CCQA_COVERAGE_ENDPOINT pointed at this run's sink");
 	if (rows.filter((row) => row.coverage !== void 0).length > 0 && coverage.heardFromApplication() && coverage.attributedSpecs() === 0) warn("instrumented application processes reported, but no spec was attributed to them — the spec cookie is not reaching the application, so every spec's server-side reach is zero for that reason rather than because the server ran nothing. Check coverage.instrumentedOrigins covers every origin the spec's requests go to, and that a server which is not node:http-based installs the middleware itself");
 	const boot = coverage.boot();
@@ -17475,6 +17548,7 @@ function reportCoverageHealth(coverage, rows) {
 	if (rejected > 0) warn(`${rejected} coverage push(es) named a spec id this run never issued — dropped`);
 	const malformed = coverage.malformedPushes();
 	if (malformed > 0) warn(`${malformed} coverage push(es) could not be read — the application's ccqa-tools and this CLI disagree on the wire format`);
+	if (noFrontendResolved(rows)) storedMaps?.warnIfNothingAnswered();
 }
 function buildLiveRunSummary(results) {
 	const sections = [];
@@ -23587,6 +23661,36 @@ function createResolveMemo(limit) {
 	};
 }
 /**
+* `runId`'s answer, in two more scans: one keeping its markers, one replaying
+* the stream through the resolver they seed. Both stop at `head`, where the
+* scan that chose the run stopped — the resolver's markers are frozen there,
+* so a later push would credit a spec it was never told had opened and count
+* as rejected: a fault in the read, reading as a fault in the run.
+*/
+/** A marker `runId` issued — what `StreamResolution` needs before it is fed the stream. */
+function isMarkerOf(event, runId) {
+	const body = event.body;
+	return "kind" in body && body.runId === runId;
+}
+async function resolveRun(config, key, project, runId, head, collected) {
+	async function scanToHead(visit) {
+		await scanStream(config, key, project, 0, (event) => {
+			if (event.seq <= head) visit(event);
+		});
+	}
+	let markers = collected;
+	if (markers === null) {
+		const found = [];
+		await scanToHead((event) => {
+			if (isMarkerOf(event, runId)) found.push(event);
+		});
+		markers = found;
+	}
+	const resolution = new StreamResolution(markers, runId);
+	await scanToHead((event) => resolution.accept(event));
+	return resolution.finish();
+}
+/**
 * GET /api/v1/coverage?project=[&runId=] — the stream, interpreted for one
 * run by the shared resolver (resolve-stream.ts); this handler only reads,
 * memoizes and serves. `runId` omitted means the run the stream most
@@ -23607,24 +23711,18 @@ function createResolveCoverageHandler(config) {
 			sendJson(ctx.res, 200, hit);
 			return;
 		}
-		const markers = [];
+		const runIndex = new RunIdIndex();
+		const named = runKey !== "" ? [] : null;
 		let seen = 0;
 		const first = await scanStream(config, key, project, 0, (event) => {
 			seen += 1;
-			if ("kind" in event.body) markers.push(event);
+			runIndex.accept(event);
+			if (named !== null && isMarkerOf(event, runKey)) named.push(event);
 		});
-		const runIds = listRunIds(markers).slice(0, RUN_IDS_LIMIT);
+		const runIds = runIndex.newestFirst().slice(0, RUN_IDS_LIMIT);
 		const runId = runKey !== "" ? runKey : runIds[0];
-		let resolved = null;
-		if (runId !== void 0 && seen > 0) {
-			const resolution = new StreamResolution(markers, runId);
-			await scanStream(config, key, project, 0, (event) => {
-				if (event.seq <= first.lastSeq) resolution.accept(event);
-			});
-			resolved = resolution.finish();
-		}
 		const answer = {
-			resolved,
+			resolved: runId !== void 0 && seen > 0 ? await resolveRun(config, key, project, runId, first.lastSeq, named) : null,
 			runIds
 		};
 		memo.put(project, runKey, first.lastSeq, answer);

package/dist/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccqa",
-  "version": "1.44.0",
+  "version": "1.45.1",
   "type": "module",
   "description": "Browser test recorder powered by Claude Code and agent-browser",
   "repository": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccqa",
-  "version": "1.44.0",
+  "version": "1.45.1",
   "type": "module",
   "description": "Browser test recorder powered by Claude Code and agent-browser",
   "repository": {